Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Fix test broken by 04ae0b0b5e594e0bb99c5cd608921745977bcdcd | Rafael Mendonça França | 2019-03-19 | 1 | -3/+4 |
| | | | | | This test was trying to set the exception_app in the wrapper proxy instead in the middleware itself. | ||||
* | Use frozen string literal in actionpack/ | Kir Shatrov | 2017-07-29 | 1 | -0/+2 |
| | |||||
* | Revert "Merge pull request #29540 from kirs/rubocop-frozen-string" | Matthew Draper | 2017-07-02 | 1 | -1/+0 |
| | | | | | This reverts commit 3420a14590c0e6915d8b6c242887f74adb4120f9, reversing changes made to afb66a5a598ce4ac74ad84b125a5abf046dcf5aa. | ||||
* | Enforce frozen string in Rubocop | Kir Shatrov | 2017-07-01 | 1 | -0/+1 |
| | |||||
* | normalizes indentation and whitespace across the project | Xavier Noria | 2016-08-06 | 1 | -3/+3 |
| | |||||
* | modernizes hash syntax in actionpack | Xavier Noria | 2016-08-06 | 1 | -2/+2 |
| | |||||
* | applies new string literal convention in actionpack/test | Xavier Noria | 2016-08-06 | 1 | -27/+27 |
| | | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default. | ||||
* | Fix failing tests for #19474 | Andrew White | 2015-03-23 | 1 | -2/+2 |
| | |||||
* | Consistent usage of spaces in hashes across our codebase | Rafael Mendonça França | 2015-01-29 | 1 | -6/+6 |
| | |||||
* | Switch to kwargs in ActionController::TestCase and ActionDispatch::Integration | Kir Shatrov | 2015-01-29 | 1 | -6/+6 |
| | | | | | | | | Non-kwargs requests are deprecated now. Guides are updated as well. `post url, nil, nil, { a: 'b' }` doesn't make sense. `post url, params: { y: x }, session: { a: 'b' }` would be an explicit way to do the same | ||||
* | LOCALHOST definition should match any 127.0.0.0/8 address | Earl J St Sauver | 2014-07-18 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | The entire 127.0.0.0/8 range is assigned to the loopback address, not only 127.0.0.0/24. This patch allows ActionDispatch::Request::LOCALHOST to match any IPv4 127.0.0.0/8 loopback address. The only place that the #local? method was previously under test was in the show_expectations_test.rb file. I don't particularly like that that's implicitly where this code is under test, and I feel like I should move some of that testing code into the test/dispatch/request_test.rb file, but I wanted some feedback first. Credit goes to @sriedel for discovering the issue and adding the patch. | ||||
* | Fix that JSON and XML exception responses should give the HTTP error message ↵ | Jeremy Kemper | 2013-05-08 | 1 | -2/+2 |
| | | | | for their status, by default, not the message from the underlying exception | ||||
* | Fix typos in AP: "overriden" => "overridden" | Carlos Antonio da Silva | 2013-03-30 | 1 | -8/+8 |
| | |||||
* | update documentation and code to use _action callbacks | Francesco Rodriguez | 2012-12-07 | 1 | -1/+1 |
| | |||||
* | Add ensure block to make sure the state is properly restored | Carlos Antonio da Silva | 2012-11-04 | 1 | -1/+1 |
| | |||||
* | Failsafe exception returns text/plain. | Steve Klabnik | 2012-10-01 | 1 | -0/+16 |
| | | | | | | | It's best to just return text/plain when something has gone terribly wrong. Fixes #5660. | ||||
* | This consider_all_requests_local doesn't make sense | Santiago Pastorino | 2012-06-12 | 1 | -18/+0 |
| | | | | | This middleware is only for Public Exceptions. This follows bd8c0b8a | ||||
* | Return proper format on exceptions | Santiago Pastorino | 2012-06-11 | 1 | -0/+43 |
| | |||||
* | Show detailed exceptions no longer returns true if the request is local in ↵ | José Valim | 2011-12-16 | 1 | -1/+5 |
| | | | | production. | ||||
* | Extract the rendering of public exceptions pages into a Rack app. | José Valim | 2011-12-16 | 1 | -1/+1 |
| | |||||
* | Fix diagnostics page for routing errors. | José Valim | 2011-12-15 | 1 | -3/+10 |
| | |||||
* | Split ShowExceptions responsibilities in two middlewares. | José Valim | 2011-12-01 | 1 | -0/+1 |
| | |||||
* | Warnings removed. (ambiguous first argument) | kennyj | 2011-11-24 | 1 | -3/+3 |
| | |||||
* | move show_detailed_exceptions? to Rescue module | lest | 2011-11-22 | 1 | -2/+2 |
| | |||||
* | refactor show exceptions tests | lest | 2011-11-22 | 1 | -0/+59 |