Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | adding a test for #6459 | Aaron Patterson | 2012-06-14 | 1 | -0/+10 | |
| | ||||||
* | Merge pull request #2549 from trek/RoutingErrorForMissingControllers | Aaron Patterson | 2012-05-21 | 1 | -0/+10 | |
|\ | | | | | When a route references a missing controller, raise ActionController::RoutingError with clearer message | |||||
| * | When a route references a missing controller, raise ↵ | Trek Glowacki | 2011-08-16 | 1 | -0/+10 | |
| | | | | | | | | ActionController::RoutingError with a clearer message | |||||
* | | Force given path to http methods in mapper to skip canonical action checking | Carlos Antonio da Silva | 2012-05-04 | 1 | -2/+2 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This fixes the following scenario: resources :contacts do post 'new', action: 'new', on: :collection, as: :new end Where the /new path is not generated because it's considered a canonical action, part of the normal resource actions: new_contacts POST /contacts(.:format) contacts#new Fixes #2999 | |||||
* | | ActionPack: remove tests for hash_for_* methods | Bogdan Gusiev | 2012-05-02 | 1 | -18/+0 | |
| | | ||||||
* | | Remove default match without specified method | Jose and Yehuda | 2012-04-24 | 1 | -168/+168 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In the current router DSL, using the +match+ DSL method will match all verbs for the path to the specified endpoint. In the vast majority of cases, people are currently using +match+ when they actually mean +get+. This introduces security implications. This commit disallows calling +match+ without an HTTP verb constraint by default. To explicitly match all verbs, this commit also adds a :via => :all option to +match+. Closes #5964 | |||||
* | | Route root helper shortcut | Brian Cardarella | 2012-03-03 | 1 | -0/+9 | |
| | | | | | | | | Allow the root route helper to accept just a string | |||||
* | | Optimize url helpers. | Sergey Nartimov + José Valim | 2012-03-02 | 1 | -3/+3 | |
| | | ||||||
* | | Adding tests for non-optional glob parameters | Andrew White | 2012-02-26 | 1 | -2/+27 | |
| | | ||||||
* | | Add config.default_method_for_update to support PATCH | David Lee | 2012-02-22 | 1 | -1/+14 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PATCH is the correct HTML verb to map to the #update action. The semantics for PATCH allows for partial updates, whereas PUT requires a complete replacement. Changes: * adds config.default_method_for_update you can set to :patch * optionally use PATCH instead of PUT in resource routes and forms * adds the #patch verb to routes to detect PATCH requests * adds #patch? to Request * changes documentation and comments to indicate support for PATCH This change maintains complete backwards compatibility by keeping :put as the default for config.default_method_for_update. | |||||
* | | adding tests to document behavior for #4817 | Aaron Patterson | 2012-02-14 | 1 | -0/+26 | |
| | | ||||||
* | | Cleaning Route generation tests | Thiago Pradi | 2012-02-12 | 1 | -30/+0 | |
| | | ||||||
* | | Merge pull request #3775 from karevn/master | Aaron Patterson | 2012-01-24 | 1 | -1/+14 | |
|\ \ | | | | | | | Please pull my changes - they fix a rare problem with tests framework | |||||
| * | | Fix: when using subdomains and constraints, request params were not passed ↵ | karevn | 2011-11-28 | 1 | -1/+14 | |
| |/ | | | | | | | to constraints callback | |||||
* | | Added custom regexps to ASTs that have literal nodes on either side of | Aaron Patterson | 2012-01-23 | 1 | -0/+62 | |
| | | | | | | | | symbol nodes. Fixes #4585 | |||||
* | | moved the `get` testing method to a module | Aaron Patterson | 2012-01-23 | 1 | -11/+2 | |
| | | ||||||
* | | Remove rescue_action from compatibility module and tests | Carlos Antonio da Silva | 2012-01-17 | 1 | -1/+0 | |
| | | ||||||
* | | AP tests should inherit from AS::TestCase | Aaron Patterson | 2012-01-05 | 1 | -2/+2 | |
| | | ||||||
* | | remove checks for encodings availability | Sergey Nartimov | 2011-12-25 | 1 | -1/+1 | |
| | | ||||||
* | | adding an integration test for splat regexp substitutions. fixes #4138 | Aaron Patterson | 2011-12-22 | 1 | -0/+13 | |
| | | ||||||
* | | Adding an integration test. Fixes #4136 | Aaron Patterson | 2011-12-22 | 1 | -0/+9 | |
| | | ||||||
* | | rack bodies should be a list | Aaron Patterson | 2011-12-22 | 1 | -7/+7 | |
| | | ||||||
* | | refactoring routing tests | Aaron Patterson | 2011-12-22 | 1 | -34/+19 | |
| | | ||||||
* | | adding integration test for journey #7 | Aaron Patterson | 2011-12-21 | 1 | -0/+22 | |
| | | ||||||
* | | caches should not be global, so no need to clear in the teardown | Aaron Patterson | 2011-12-21 | 1 | -4/+0 | |
| | | ||||||
* | | adding tests for #4029 | Aaron Patterson | 2011-12-19 | 1 | -0/+51 | |
| | | ||||||
* | | Named Routes shouldn't override existing ones (currently route recognition ↵ | Andy Jeffries | 2011-12-05 | 1 | -2/+2 | |
| | | | | | | | | goes with the earliest match, named routes use the latest match) | |||||
* | | fix method redefined warnings in tests | lest | 2011-11-30 | 1 | -6/+0 | |
|/ | ||||||
* | moving test_generate to an integration test with one assert per test | Aaron Patterson | 2011-08-12 | 1 | -108/+0 | |
| | ||||||
* | remove extra require for 'active_support/dependencies' as it is required in ↵ | Vishnu Atrai | 2011-07-31 | 1 | -1/+0 | |
| | | | | abstract_unit.rb | |||||
* | raise an error if the old router draw method is used, along with a message ↵ | Josh Kalderimis | 2011-05-03 | 1 | -0/+6 | |
| | | | | advising them to either upgrade their routes or add rails_legacy_mapper to their Gemfile | |||||
* | Action Pack typos. | R.T. Lechow | 2011-03-05 | 1 | -1/+1 | |
| | ||||||
* | cleaning up some warnings on 1.9.3 | Aaron Patterson | 2011-02-07 | 1 | -2/+2 | |
| | ||||||
* | The redirect routing method now allows for a hash of options which only ↵ | Josh Kalderimis | 2010-11-30 | 1 | -284/+297 | |
| | | | | changes the relevant parts of the url, or an object which responds to call can be supplied so common redirect rules can be easily reused. This commit includes a change where url generation from parts has been moved to AD::Http::URL as a class method. | |||||
* | Revert "Quick fix for not escaping []s (not ideal)" | Santiago Pastorino | 2010-11-18 | 1 | -3/+3 | |
| | | | | | | | | | According to http://www.ietf.org/rfc/rfc2616.txt and http://tools.ietf.org/rfc/rfc3986.txt [ and ] are reserved characters and should be escaped using "%" HEX HEX This reverts commit 856d2fd874d72dd9f83204affff4edfef3308361 and 1ee9b40b18a0bed5bb10a0785f7e2730bac983f6.. | |||||
* | Anchors should be allowed on constraints that are not on path segments | Carl Lerche | 2010-11-16 | 1 | -0/+8 | |
| | ||||||
* | Remove deprecated stuff in ActionController | Carlos Antonio da Silva | 2010-09-26 | 1 | -7/+7 | |
| | | | | | | This removes all deprecated classes in ActionController related to Routing, Abstract Request/Response and Integration/IntegrationTest. All tests and docs were changed to ActionDispatch instead of ActionController. | |||||
* | Remove a few tests from old router that do not make sense with the new one. | José Valim | 2010-09-05 | 1 | -16/+0 | |
| | ||||||
* | Deleted test with extended regexp - it fails with no reason, probably ↵ | Piotr Sarnacki | 2010-09-05 | 1 | -21/+0 | |
| | | | | rack-mount is doing something weird with that regexp | |||||
* | Fixed 2 broken tests for router. | Łukasz Strzałkowski | 2010-09-05 | 1 | -3/+3 | |
| | | | | They were broken after rebase/merge | |||||
* | Removed tests for setting default value of *path in route | Łukasz Strzałkowski | 2010-09-05 | 1 | -25/+0 | |
| | | | | If we want to have this - we have to change Rack::Mount source | |||||
* | Made test_generate pass | Łukasz Strzałkowski | 2010-09-05 | 1 | -9/+1 | |
| | | | | I've removed assertions with @routes.generate(:use_route => ...). I'm not 100% sure if not supporting :use_route in new router is intentional or it should rather be supported and backported from 2.3.x. | |||||
* | If it's unused there's no reason to keep it commented. It will always remain ↵ | Łukasz Strzałkowski | 2010-09-05 | 1 | -11/+0 | |
| | | | | in git history, so removing it. | |||||
* | Removed rest of errors and failures in routing_test.rb. Almost all squashed, ↵ | Łukasz Strzałkowski | 2010-09-05 | 1 | -92/+79 | |
| | | | | only few left | |||||
* | Test for recognizing routes with http method set | Łukasz Strzałkowski | 2010-09-05 | 1 | -1/+40 | |
| | ||||||
* | Fixed about half of broken tests in routing_test | Łukasz Strzałkowski | 2010-09-05 | 1 | -125/+82 | |
| | ||||||
* | Removed deprecated RouteSet API, still many tests fail | Piotr Sarnacki | 2010-09-05 | 1 | -348/+327 | |
| | ||||||
* | Revert "Setup explicit requires for files with exceptions. Removed them from ↵ | José Valim | 2010-09-02 | 1 | -1/+0 | |
| | | | | | | | | autoloading." Booting a new Rails application does not work after this commit [#5359 state:open] This reverts commit 38a421b34d0b414564e919f67d339fac067a56e6. | |||||
* | Setup explicit requires for files with exceptions. Removed them from ↵ | Łukasz Strzałkowski | 2010-09-02 | 1 | -0/+1 | |
| | | | | | | autoloading. Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Support routing constraints in functional tests | Andrew White | 2010-08-20 | 1 | -1/+1 | |
| | | | | | | | | | | Extend assert_recognizes and assert_generates to support passing full urls as the path argument. This allows testing of routing constraints such as subdomain and host within functional tests. [#5005 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> |