aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/test/controller/request
Commit message (Collapse)AuthorAgeFilesLines
* Use frozen string literal in actionpack/Kir Shatrov2017-07-291-0/+2
|
* Revert "Merge pull request #29540 from kirs/rubocop-frozen-string"Matthew Draper2017-07-021-1/+0
| | | | | This reverts commit 3420a14590c0e6915d8b6c242887f74adb4120f9, reversing changes made to afb66a5a598ce4ac74ad84b125a5abf046dcf5aa.
* Enforce frozen string in RubocopKir Shatrov2017-07-011-0/+1
|
* :warning: "Use assert_nil if expecting nil. This will fail in MT6."Akira Matsuda2017-01-181-8/+12
| | | | | | These are followups for 307065f959f2b34bdad16487bae906eb3bfeaf28, but TBH I'm personally not very much confortable with this style. Maybe we could override assert_equal in our test_helper not to warn?
* assert_equal takes expectation firstAkira Matsuda2016-12-261-2/+2
|
* "Use assert_nil if expecting nil. This will fail in minitest 6."Akira Matsuda2016-12-251-1/+1
|
* Fixed CONTENT_LENGTH header in ActionController::TestRequestArtem Rashev2016-11-151-0/+10
| | | | | | | | | | | | | CONENT_LENGTH setted by string length, which is equal to number of characters in string but StringIO.length is byte sequence and when payload contains non-ASCII characters, stream's length will be different. That's why real byte length should be used for CONTENT_LENGTH header. Add unit test for CONTENT_LENGTH header fix It just passes non-ascii symbols as parameters and verifies that "CONTENT_LENGTH" header has content bytes count as value.
* Do not mutate AC::TestRequest::DEFAULT_OPTIONSKir Shatrov2016-09-101-0/+5
|
* applies remaining conventions across the projectXavier Noria2016-08-061-2/+0
|
* applies new string literal convention in actionpack/testXavier Noria2016-08-061-2/+2
| | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default.
* let the superclass build the request and responseAaron Patterson2015-07-081-5/+1
| | | | | We should leverage the request / response objects that the superclass has already allocated for us.
* Use request.session.id instead of request.session_options[:id]Brian John2015-03-121-8/+0
| | | | | | | | | As of the upgrade to Rack 1.5, request.session_options[:id] is no longer populated. Reflect this change in the tests by using request.session.id instead. Related change in Rack: https://github.com/rack/rack/commit/83a270d6
* cleaning up some warnings on 1.9.3Aaron Patterson2011-02-071-2/+1
|
* Inherit TestSession from Session::AbstractStore and add indifferent access ↵Joshua Peek2009-04-261-11/+12
| | | | to Session::AbstractStore.
* Bring abstract_controller up to date with rails/masterCarl Lerche & Yehuda Katz2009-04-131-0/+35
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Resolved all the conflicts since 2.3.0 -> HEAD. Following is a list of commits that could not be applied cleanly or are obviated with the abstract_controller refactor. They all need to be revisited to ensure that fixes made in 2.3 do not reappear in 3.0: 2259ecf368e6a6715966f69216e3ee86bf1a82a7 AR not available * This will be reimplemented with ActionORM or equivalent 06182ea02e92afad579998aa80144588e8865ac3 implicitly rendering a js response should not use the default layout [#1844 state:resolved] * This will be handled generically 893e9eb99504705419ad6edac14d00e71cef5f12 Improve view rendering performance in development mode and reinstate template recompiling in production [#1909 state:resolved] * We will need to reimplement rails-dev-boost on top of the refactor; the changes here are very implementation specific and cannot be cleanly applied. The following commits are implicated: 199e750d46c04970b5e7684998d09405648ecbd4 3942cb406e1d5db0ac00e03153809cc8dc4cc4db f8ea9f85d4f1e3e6f3b5d895bef6b013aa4b0690 e3b166aab37ddc2fbab030b146eb61713b91bf55 ae9f258e03c9fd5088da12c1c6cd216cc89a01f7 44423126c6f6133a1d9cf1d0832b527e8711d40f 0cb020b4d6d838025859bd60fb8151c8e21b8e84 workaround for picking layouts based on wrong view_paths [#1974 state:resolved] * The specifics of this commit no longer apply. Since it is a two-line commit, we will reimplement this change. 8c5cc66a831aadb159f3daaffa4208064c30af0e make action_controller/layouts pick templates from the current instance's view_paths instead of the class view_paths [#1974 state:resolved] * This does not apply at all. It should be trivial to apply the feature to the reimplemented ActionController::Base. 87e8b162463f13bd50d27398f020769460a770e3 fix HTML fallback for explicit templates [#2052 state:resolved] * There were a number of patches related to this that simply compounded each other. Basically none of them apply cleanly, and the underlying issue needs to be revisited. After discussing the underlying problem with Koz, we will defer these fixes for further discussion.
| * added tests for session options being defaulted correctly to rack defaults ↵Kenny Ortmann2009-04-071-0/+35
| | | | | | | | | | | | [#2403 state:resolved] Signed-off-by: Joshua Peek <josh@joshpeek.com>
| * Update rack to fix multipart uploads with an empty file [#1945 state:resolved]Joshua Peek2009-03-131-1/+1
| |
| * Remove ancient tests for CGI parsing bugJoshua Peek2009-01-311-30/+0
| |
| * Removed Prototype specific Safari 2 AJAX hack.Joshua Peek2009-01-311-6/+0
| | | | | | | | The normal null character stripper is still there.
* | Move dispatch related tests into test/dispatchJoshua Peek2009-01-285-696/+0
| |
* | Move HTTP libs and middleware into ActionDispatch componentJoshua Peek2009-01-272-2/+2
|/
* Allow empty files to be uploadedJoshua Peek2009-01-201-2/+10
|
* Don't let empty Tempfiles come through as uploaded files [#1785 state:resolved]Mislav Marohnić2009-01-201-0/+7
| | | | Signed-off-by: Joshua Peek <josh@joshpeek.com>
* Build query string and POST params parser on top of Rack::Request. Also ↵Joshua Peek2009-01-171-3/+3
| | | | switch our multipart parser to use Racks. Moved XML, JSON, and YAML parsers into ActionController::ParamsParser middleware [#1661 state:resolved]
* Add test coverage for fixing Safari 2 trailing null characterJoshua Peek2009-01-171-0/+12
|
* Update multipart tests to expose (another) bug in Rack's multipart parserJoshua Peek2009-01-132-2/+2
|
* Add RewindableInput wrapper to fix issues with middleware that impolitely ↵Joshua Peek2009-01-132-2/+80
| | | | eat up non-rewindable input
* Explicitly read as binary in multipart_body for Windows [#1065 state:resolved]Bryan Ash2009-01-131-7/+7
| | | | Signed-off-by: Joshua Peek <josh@joshpeek.com>
* Refactor request urlencoded params parsing testsJoshua Peek2009-01-101-0/+171
|
* Moved query string parsing tests into the request tests folderJoshua Peek2009-01-101-0/+120
|
* Refactor request multipart params parsing testsJoshua Peek2009-01-101-0/+167
|
* Refactor request xml params parsing testsJoshua Peek2009-01-091-0/+88
|
* Refactor request json params parsing testsJoshua Peek2009-01-091-0/+45
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-30 00:15:15 +0000