Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Use the Ruby 1.8 hash syntax | Rafael Mendonça França | 2012-10-06 | 1 | -1/+1 |
| | |||||
* | Merge pull request #7848 from senny/3415_assert_template_has_nil_variable | Rafael Mendonça França | 2012-10-06 | 1 | -0/+11 |
| | | | | | | can't pass :locals to #assert_template without a view test case (#3415) Conflicts: actionpack/CHANGELOG.md | ||||
* | html_escape should escape single quotes | Santiago Pastorino | 2012-08-02 | 1 | -2/+2 |
| | | | | | | | | | | | | https://www.owasp.org/index.php/XSS_%28Cross_Site_Scripting%29_Prevention_Cheat_Sheet#RULE_.231_-_HTML_Escape_Before_Inserting_Untrusted_Data_into_HTML_Element_Content Closes #7215 Conflicts: actionpack/test/template/erb_util_test.rb actionpack/test/template/form_tag_helper_test.rb actionpack/test/template/text_helper_test.rb actionpack/test/template/url_helper_test.rb activesupport/lib/active_support/core_ext/string/output_safety.rb | ||||
* | Added test for case when view doesn't have logger method when using ↵ | Dmitry Vorotilin | 2012-06-16 | 1 | -0/+17 |
| | | | | ActionController::Metal controller. | ||||
* | Add failing test re #3436 which demonstrates content_type is not respected ↵ | Kunal Shah | 2012-05-07 | 1 | -0/+21 |
| | | | | when using the :head method/shortcut | ||||
* | Set proper rendered_format when doing render :inline | Santiago Pastorino | 2012-03-28 | 1 | -0/+1 |
| | | | | Closes #5632 | ||||
* | If partial is rendered in controller, grab format from template | Piotr Sarnacki | 2012-03-27 | 1 | -0/+13 |
| | | | | | | | | | Previously `rendered_format` was set only based on mime types passed in Accept header, which was wrong if first type from Accept was different than rendered partial. The fix is to simply move setting rendered_format to the place where template is available and grab format from the template. If it fails we can fallback to formats passed by Accept header. | ||||
* | Add missing test for #5308 | Piotr Sarnacki | 2012-03-17 | 1 | -0/+13 |
| | |||||
* | Fix #5440 - multiple render_to_string breaks partials formats | Piotr Sarnacki | 2012-03-17 | 1 | -0/+26 |
| | | | | | | | | | This fixes situation where rendering template to string sets `rendered_format` to the format rendered there. This is ok to have consistent formats rendered in partials, but it breaks on next renders if format is explicitly set or on last render where default format does not necessarily need to be the format of first rendered template. | ||||
* | Fix #5238, rendered_format is not set when template is not rendered | Piotr Sarnacki | 2012-03-02 | 1 | -2/+6 |
| | |||||
* | Deprecate AC::UnknownError and AC::DoubleRenderError | Carlos Antonio da Silva | 2012-01-17 | 1 | -5/+5 |
| | | | | | Use the constants AbstractController::ActionNotFound and AbstractController::DoubleRenderError respectively instead. | ||||
* | Add some deprecations for logic being removed in 4.0 | Carlos Antonio da Silva | 2012-01-17 | 1 | -1/+1 |
| | |||||
* | remove warnings about @variable_for_layout | lest | 2011-12-20 | 1 | -5/+6 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Revert "Added ActiveRecord::Base#last_modified to work with the new ↵ | David Heinemeier Hansson | 2011-12-01 | 1 | -2/+2 |
| | | | | | | | | fresh_when/stale? conditional get methods from Action Pack" Needless indirection with no added value. This reverts commit 535853e83b9092078035a5abb2aa242fba815c05. | ||||
* | Added ActiveRecord::Base#last_modified to work with the new ↵ | David Heinemeier Hansson | 2011-12-01 | 1 | -2/+2 |
| | | | | fresh_when/stale? conditional get methods from Action Pack | ||||
* | Allow fresh_when/stale? to take a record instead of an options hash [DHH] | David Heinemeier Hansson | 2011-12-01 | 1 | -0/+46 |
| | |||||
* | Deprecate passing the template handler in the template name. | José Valim | 2011-09-22 | 1 | -16/+12 |
| | | | | | | For example, calling hello.erb is now deprecated. Since Rails 3.0 passing the handler had no effect whatsover. This commit simply deprecates such cases so we can clean up the code in later releases. | ||||
* | Get rid of update_details in favor of passing details to find_template. | José Valim | 2011-09-22 | 1 | -1/+3 |
| | |||||
* | * is not allowed in windows file names. Closes #2574 #2847 | Santiago Pastorino | 2011-09-04 | 1 | -1/+1 |
| | |||||
* | Properly escape glob characters. | Aaron Patterson | 2011-08-16 | 1 | -0/+14 |
| | |||||
* | - added ActionView::PartialRenderer#merge_path_into_partial(path, partial) | Gaston Ramos | 2011-07-24 | 1 | -1/+1 |
| | | | | fix issues/1951 | ||||
* | - added test case for issue: | Gaston Ramos | 2011-07-24 | 1 | -0/+14 |
| | | | | | https://github.com/rails/rails/issues/1951 Namespaced model partial_path is wrong in namespaced controllers | ||||
* | removed deprecated methods, and related tests, from ActionPack | Josh Kalderimis | 2011-05-24 | 1 | -6/+1 |
| | |||||
* | removes support for render :update | Xavier Noria | 2011-04-13 | 1 | -9/+0 |
| | |||||
* | Ensure render is case sensitive even on systems with case-insensitive ↵ | José Valim | 2011-02-08 | 1 | -0/+10 |
| | | | | | | filesystems. This fixes CVE-2011-0449 | ||||
* | Move ETag and ConditionalGet logic from AD::Response to the middleware stack. | José Valim | 2010-10-03 | 1 | -118/+0 |
| | |||||
* | Redefine duplicated test name. | Emilio Tagua | 2010-09-28 | 1 | -1/+1 |
| | |||||
* | Remove more warnings by initializing variables in test. | Emilio Tagua | 2010-09-28 | 1 | -0/+6 |
| | |||||
* | Remove more warnings: no need to define attr_accessor if already exists. ↵ | Emilio Tagua | 2010-09-28 | 1 | -0/+1 |
| | | | | Initialize ivar. | ||||
* | Fix header capitalization by explicitly upcasing first letter of every word, ↵ | Maxim Chernyak | 2010-09-18 | 1 | -0/+11 |
| | | | | and avoiding capitalize. [#5636 state:resolved] | ||||
* | Removed deprecated RouteSet API, still many tests fail | Piotr Sarnacki | 2010-09-05 | 1 | -1/+1 |
| | |||||
* | code gardening: we have assert_(nil|blank|present), more concise, with ↵ | Xavier Noria | 2010-08-17 | 1 | -6/+6 |
| | | | | better default failure messages - let's use them | ||||
* | Deletes trailing whitespaces (over text files only find * -type f -exec sed ↵ | Santiago Pastorino | 2010-08-14 | 1 | -2/+2 |
| | | | | 's/[ \t]*$//' -i {} \;) | ||||
* | Make sure a namespaced <%= render form %> still renders the _form partial ↵ | Jan De Poorter | 2010-06-20 | 1 | -0/+11 |
| | | | | | | [#4784 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | edit pass: the names of Rails components have a space, ie, "Active Record", ↵ | Xavier Noria | 2010-06-14 | 1 | -1/+1 |
| | | | | not "ActiveRecord" | ||||
* | Revert "Moved encoding work in progress to a feature branch." | wycats | 2010-05-17 | 1 | -2/+2 |
| | | | | This reverts commit ade756fe42423033bae8e5aea8f58782f7a6c517. | ||||
* | Moved encoding work in progress to a feature branch. | Jeremy Kemper | 2010-05-16 | 1 | -2/+2 |
| | | | | This reverts commits af0d1a88157942c6e6398dbf73891cff1e152405 and 64d109e3539ad600f58536d3ecabd2f87b67fd1c. | ||||
* | Significantly improved internal encoding heuristics and support. | wycats | 2010-05-16 | 1 | -2/+2 |
| | | | | | | | | | | | | | | | | | | | | | | | | | * Default Encoding.default_internal to UTF-8 * Eliminated the use of file-wide magic comments to coerce code evaluated inside the file * Read templates as BINARY, use default_external or template-wide magic comments inside the Template to set the initial encoding * This means that template handlers in Ruby 1.9 will receive Strings encoded in default_internal (UTF-8 by default) * Create a better Exception for encoding issues, and use it when the template source has bytes that are not compatible with the specified encoding * Allow template handlers to opt-into handling BINARY. If they do so, they need to do some of their own manual encoding work * Added a "Configuration Gotchas" section to the intro Rails Guide instructing users to use UTF-8 for everything * Use config.encoding= in Ruby 1.8, and raise if a value that is an invalid $KCODE value is used Also: * Fixed a few tests that were assert() rather than assert_equal() and were caught by Minitest requiring a String for the message * Fixed a test where an assert_select was misformed, also caught by Minitest being more restrictive * Fixed a test where a Rack response was returning a String rather than an Enumerable | ||||
* | Fixed 1 failure and 2 errors in ActionPack testsuite [#4613 state:commited] | rohit | 2010-05-16 | 1 | -2/+2 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | partial counters with :as [#2804 state:resolved] | Jeff Kreeftmeijer | 2010-05-15 | 1 | -0/+9 |
| | | | | Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | Make render :partial, :layout consistent between AC and AV | Carlhuda | 2010-03-18 | 1 | -11/+1 |
| | |||||
* | All tests pass without memoizing view_context | Carlhuda | 2010-03-18 | 1 | -1/+7 |
| | |||||
* | Modify assert_template to use notifications. Also, remove ↵ | Carlhuda | 2010-03-17 | 1 | -3/+3 |
| | | | | ActionController::Base#template since it is no longer needed. | ||||
* | Ensure controller filters are executed before stuff starts to happen. | José Valim | 2010-03-13 | 1 | -0/+14 |
| | |||||
* | Clean LookupContext API. | José Valim | 2010-03-08 | 1 | -3/+3 |
| | |||||
* | Fix render :file => "#{Rails.root}/public/404.html", :status => :not_found. ↵ | Yehuda Katz | 2010-02-23 | 1 | -0/+9 |
| | | | | Closes #8994 | ||||
* | Make Railties tests green again. | José Valim | 2010-02-17 | 1 | -1/+1 |
| | |||||
* | Ensure render :text => resource first tries to invoke :to_text on it | José Valim | 2010-02-16 | 1 | -0/+9 |
| | |||||
* | Remove ActionView inline logging to ActiveSupport::Notifications and create ↵ | José Valim | 2009-12-26 | 1 | -31/+1 |
| | | | | ActionController::Base#log_event, so everything can be logged within one listener. Also expose log_process_action as a hook for different modules to include their own information during the action processing. This allow ActiveRecord to hook and any other ORM. Finally, this commit changes 'Processing' and 'Rendering' in logs to 'Processed' and 'Rendered' because at the point it's logged, everying already happened. | ||||
* | AD::StatusCodes support is now part of rack | Joshua Peek | 2009-12-22 | 1 | -2/+2 |
| |