Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | code gardening: we have assert_(nil|blank|present), more concise, with ↵ | Xavier Noria | 2010-08-17 | 1 | -6/+6 |
| | | | | better default failure messages - let's use them | ||||
* | Deletes trailing whitespaces (over text files only find * -type f -exec sed ↵ | Santiago Pastorino | 2010-08-14 | 1 | -2/+2 |
| | | | | 's/[ \t]*$//' -i {} \;) | ||||
* | Make sure a namespaced <%= render form %> still renders the _form partial ↵ | Jan De Poorter | 2010-06-20 | 1 | -0/+11 |
| | | | | | | [#4784 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | edit pass: the names of Rails components have a space, ie, "Active Record", ↵ | Xavier Noria | 2010-06-14 | 1 | -1/+1 |
| | | | | not "ActiveRecord" | ||||
* | Revert "Moved encoding work in progress to a feature branch." | wycats | 2010-05-17 | 1 | -2/+2 |
| | | | | This reverts commit ade756fe42423033bae8e5aea8f58782f7a6c517. | ||||
* | Moved encoding work in progress to a feature branch. | Jeremy Kemper | 2010-05-16 | 1 | -2/+2 |
| | | | | This reverts commits af0d1a88157942c6e6398dbf73891cff1e152405 and 64d109e3539ad600f58536d3ecabd2f87b67fd1c. | ||||
* | Significantly improved internal encoding heuristics and support. | wycats | 2010-05-16 | 1 | -2/+2 |
| | | | | | | | | | | | | | | | | | | | | | | | | | * Default Encoding.default_internal to UTF-8 * Eliminated the use of file-wide magic comments to coerce code evaluated inside the file * Read templates as BINARY, use default_external or template-wide magic comments inside the Template to set the initial encoding * This means that template handlers in Ruby 1.9 will receive Strings encoded in default_internal (UTF-8 by default) * Create a better Exception for encoding issues, and use it when the template source has bytes that are not compatible with the specified encoding * Allow template handlers to opt-into handling BINARY. If they do so, they need to do some of their own manual encoding work * Added a "Configuration Gotchas" section to the intro Rails Guide instructing users to use UTF-8 for everything * Use config.encoding= in Ruby 1.8, and raise if a value that is an invalid $KCODE value is used Also: * Fixed a few tests that were assert() rather than assert_equal() and were caught by Minitest requiring a String for the message * Fixed a test where an assert_select was misformed, also caught by Minitest being more restrictive * Fixed a test where a Rack response was returning a String rather than an Enumerable | ||||
* | Fixed 1 failure and 2 errors in ActionPack testsuite [#4613 state:commited] | rohit | 2010-05-16 | 1 | -2/+2 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | partial counters with :as [#2804 state:resolved] | Jeff Kreeftmeijer | 2010-05-15 | 1 | -0/+9 |
| | | | | Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | Make render :partial, :layout consistent between AC and AV | Carlhuda | 2010-03-18 | 1 | -11/+1 |
| | |||||
* | All tests pass without memoizing view_context | Carlhuda | 2010-03-18 | 1 | -1/+7 |
| | |||||
* | Modify assert_template to use notifications. Also, remove ↵ | Carlhuda | 2010-03-17 | 1 | -3/+3 |
| | | | | ActionController::Base#template since it is no longer needed. | ||||
* | Ensure controller filters are executed before stuff starts to happen. | José Valim | 2010-03-13 | 1 | -0/+14 |
| | |||||
* | Clean LookupContext API. | José Valim | 2010-03-08 | 1 | -3/+3 |
| | |||||
* | Fix render :file => "#{Rails.root}/public/404.html", :status => :not_found. ↵ | Yehuda Katz | 2010-02-23 | 1 | -0/+9 |
| | | | | Closes #8994 | ||||
* | Make Railties tests green again. | José Valim | 2010-02-17 | 1 | -1/+1 |
| | |||||
* | Ensure render :text => resource first tries to invoke :to_text on it | José Valim | 2010-02-16 | 1 | -0/+9 |
| | |||||
* | Remove ActionView inline logging to ActiveSupport::Notifications and create ↵ | José Valim | 2009-12-26 | 1 | -31/+1 |
| | | | | ActionController::Base#log_event, so everything can be logged within one listener. Also expose log_process_action as a hook for different modules to include their own information during the action processing. This allow ActiveRecord to hook and any other ORM. Finally, this commit changes 'Processing' and 'Rendering' in logs to 'Processed' and 'Rendered' because at the point it's logged, everying already happened. | ||||
* | AD::StatusCodes support is now part of rack | Joshua Peek | 2009-12-22 | 1 | -2/+2 |
| | |||||
* | Use new routing dsl in tests | Joshua Peek | 2009-12-08 | 1 | -15/+15 |
| | |||||
* | Ensure Cache-Control max-age is an integer | Jeremy Kemper | 2009-12-02 | 1 | -1/+1 |
| | |||||
* | Ruby 1.9: resolve constant lookup issues | Jeremy Kemper | 2009-11-04 | 1 | -1/+1 |
| | |||||
* | Fixes expires_now and cleans things up a bit | Yehuda Katz | 2009-10-26 | 1 | -0/+10 |
| | |||||
* | Switch to on-by-default XSS escaping for rails. | Michael Koziarski | 2009-10-08 | 1 | -1/+1 |
| | | | | | | | | | | | | This consists of: * String#html_safe! a method to mark a string as 'safe' * ActionView::SafeBuffer a string subclass which escapes anything unsafe which is concatenated to it * Calls to String#html_safe! throughout the rails helpers * a 'raw' helper which lets you concatenate trusted HTML from non-safety-aware sources (e.g. presantized strings in the DB) * New ERB implementation based on erubis which uses a SafeBuffer instead of a String Hat tip to Django for the inspiration. | ||||
* | Cleanup route reloading in tests. Prefer with_routing over using ↵ | Joshua Peek | 2009-08-16 | 1 | -8/+10 |
| | | | | ActionController::Routing::Routes directly | ||||
* | More cleanup of ActionView and reduction in need for blocks in some cases: | Yehuda Katz | 2009-08-15 | 1 | -9/+0 |
| | | | | | | | | * only one of partial_name or :as will be available as a local * `object` is removed * Simplify _layout_for in most cases. * Remove <% render :partial do |args| %> * <% render :partial do %> still works fine | ||||
* | Clean up partial object some more; replace passing around a block to a ↵ | Yehuda Katz | 2009-08-09 | 1 | -1/+0 |
| | | | | single block ivar | ||||
* | Add destroyed? to ActiveRecord, include tests for polymorphic urls for ↵ | José Valim | 2009-08-07 | 1 | -5/+7 |
| | | | | destroyed objects and refactor mime responds tests and documentation. | ||||
* | Add nagivational behavior to respond_with. | José Valim | 2009-08-07 | 1 | -0/+15 |
| | |||||
* | Replace _render_template_with_layout with _render_template since the layout ↵ | Yehuda Katz | 2009-08-07 | 1 | -1/+2 |
| | | | | is optional | ||||
* | Update cache_control to be a Hash of options that is used to build the header. | Yehuda Katz | 2009-08-02 | 1 | -1/+1 |
| | | | | * Significantly simplifies setting and modifying cache control in other areas | ||||
* | Remove deprecated implicit ivar assignment | Joshua Peek | 2009-06-25 | 1 | -7/+0 |
| | |||||
* | Finish making pending tests pass | Yehuda Katz + Carl Lerche | 2009-06-17 | 1 | -7/+7 |
| | |||||
* | Modify render_test's determine_layout to match RJS | Yehuda Katz + Carl Lerche | 2009-05-22 | 1 | -3/+1 |
| | |||||
* | Cleaning up more render tests | Yehuda Katz + Carl Lerche | 2009-05-14 | 1 | -0/+5 |
| | |||||
* | Ported over render :file tests. | Yehuda Katz + Carl Lerche | 2009-05-13 | 1 | -320/+14 |
| | |||||
* | Implemented redirects and partial rendering in new base. | Yehuda Katz + Carl Lerche | 2009-05-12 | 1 | -2/+2 |
| | |||||
* | Merge branch 'master' into wip_abstract_controller | Yehuda Katz + Carl Lerche | 2009-05-11 | 1 | -5/+5 |
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Conflicts: actionpack/lib/action_controller/abstract/callbacks.rb actionpack/lib/action_controller/abstract/renderer.rb actionpack/lib/action_controller/base/base.rb actionpack/lib/action_controller/dispatch/dispatcher.rb actionpack/lib/action_controller/routing/route_set.rb actionpack/lib/action_controller/testing/process.rb actionpack/test/abstract_controller/layouts_test.rb actionpack/test/controller/filters_test.rb actionpack/test/controller/helper_test.rb actionpack/test/controller/render_test.rb actionpack/test/new_base/test_helper.rb | ||||
| * | Functional test runner finalizes response just like the integration test ↵ | Joshua Peek | 2009-05-02 | 1 | -11/+11 |
| | | | | | | | | | | runner. In both runners, the @response object will now behave the same. Some functional tests will need to be updated if they are relying on preprocessed data on the response. | ||||
* | | Aliased AbstractController::ActionNotFound to ActionController::UnknownAction | Yehuda Katz + Carl Lerche | 2009-05-11 | 1 | -2/+3 |
| | | |||||
* | | Ported ConditionalGet to new Base | Yehuda Katz + Carl Lerche | 2009-05-11 | 1 | -4/+4 |
| | | |||||
* | | Starting to get new_base to run on old tests | Yehuda Katz + Carl Lerche | 2009-05-01 | 1 | -1/+1 |
| | | |||||
* | | Committing the last changes before we start trying to get the old tests to ↵ | Yehuda Katz + Carl Lerche | 2009-05-01 | 1 | -1/+10 |
| | | | | | | | | pass on the new base | ||||
* | | Ported over the concept of public instance methods on controller child ↵ | Yehuda Katz + Carl Lerche | 2009-05-01 | 1 | -0/+7 |
| | | | | | | | | classes as callable action methods | ||||
* | | Ported over render :template tests | Yehuda Katz + Carl Lerche | 2009-05-01 | 1 | -0/+19 |
| | | |||||
* | | Finished implementing render :text in Base2 | Yehuda Katz + Carl Lerche | 2009-05-01 | 1 | -0/+17 |
| | | |||||
* | | Renamed the new_base tests | Yehuda Katz + Carl Lerche | 2009-05-01 | 1 | -0/+2 |
| | | |||||
* | | OMG, a lot of work | Yehuda Katz + Carl Lerche | 2009-05-01 | 1 | -0/+3 |
|/ | |||||
* | Fix render :json => nil [#2589 state:resolved] | Jeremy Kemper | 2009-04-30 | 1 | -0/+10 |
| | |||||
* | Refactor ActionView::Template | Yehuda Katz + Carl Lerche | 2009-04-27 | 1 | -3/+3 |
| | | | | | | | | ActionView::Template is now completely independent from template storage, which allows different back ends such as the database. ActionView::Template's only responsibility is to take in the template source (passed in from ActionView::Path), compile it, and render it. |