rails.git - Mirror of official rails repo with custom fixes.

	Commit message (Collapse)	Author	Age	Files	Lines
*	Use assert_predicate and assert_not_predicate	Daniel Colson	2018-01-25	1	-3/+3
\|
*	Use frozen string literal in actionpack/	Kir Shatrov	2017-07-29	1	-0/+2
\|
*	Revert "Merge pull request #29540 from kirs/rubocop-frozen-string"	Matthew Draper	2017-07-02	1	-1/+0
\| \| \| \| \|	This reverts commit 3420a14590c0e6915d8b6c242887f74adb4120f9, reversing changes made to afb66a5a598ce4ac74ad84b125a5abf046dcf5aa.
*	Enforce frozen string in Rubocop	Kir Shatrov	2017-07-01	1	-0/+1
\|
*	ActionController::Parameters#deep_dup (#26567)	Pavel Evstigneev	2016-10-11	1	-0/+22
\| \| \| \| \| \| \| \| \| \| \|	* ActionController::Parameters#deep_dup * Tests for ActionController::Parameters#deep_dup * Fix test for ActionController::Parameters#deep_dup * More tests for ActionController::Parameters#deep_dup [Rafael Mendonça França + Pavel Evstigneev]
*	Add three new rubocop rules	Rafael Mendonça França	2016-08-16	1	-1/+1
\| \| \| \| \| \| \| \|	Style/SpaceBeforeBlockBraces Style/SpaceInsideBlockBraces Style/SpaceInsideHashLiteralBraces Fix all violations in the repository.
*	applies new string literal convention in actionpack/test	Xavier Noria	2016-08-06	1	-6/+6
\| \| \| \| \|	The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default.
*	Remove duplicate test and fix a typo in the test	Prathamesh Sonpatki	2016-07-12	1	-1/+1
\| \| \| \| \|	- Tests for dup'ing params was separately added in a separate file in https://github.com/rails/rails/pull/25735.
*	Trust `Object#dup` in `ActionController::Parameters`, using ↵	Tim Rogers	2016-07-08	1	-1/+19
\| \| \| \| \| \|	`#initialize_copy` to manually duplicate the underlying parameters hash It looks like `ActionController::Parameters#dup` is leftover from when the class inherited from `Hash`. We can just trust `#dup`, which already copies the `@permitted` instance variable (confirmed by tests). We still define a `#initialize_copy` to make `@parameters` a copy that can be mutated without affecting the original instance.
*	Changes to a dupped `ActionController::Parameters` mutate the original	Tim Rogers	2016-07-07	1	-0/+25
	When `ActionController::Parameters` is duplicated with `#dup`, it doesn't create a duplicate of the instance variables (e.g. `@parameters`) but rather maintains the reference (see <http://ruby-doc.org/core-2.3.1/Object.html>). Given that the parameters object is often manipulated as if it were a hash (e.g. with `#delete` and similar methods), this leads to unexpected behaviour, like the following: ``` params = ActionController::Parameters.new(foo: "bar") duplicated_params = params.dup duplicated_params.delete(:foo) params == duplicated_params ``` This fixes the bug by defining a private `#initialize_copy` method, used internally by `#dup`, which makes a copy of `@parameters`.