Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Fix `ActionController::Parameters#each_value` and add changelog entry to ↵ | Bogdan | 2018-10-15 | 1 | -2/+6 |
| | | | | | | | | | | | | | this method (#34210) * Fix `ActionController::Parameters#each_value` `each_value` should yield with "value" of the params instead of "value" as an array. Related to #33979 * Add changelog entry about `ActionController::Parameters#each_value`. Follow up #33979 | ||||
* | Added ActionController::Parameters.each_value method | Lukas Zapletal | 2018-09-27 | 1 | -0/+18 |
| | |||||
* | Convert hashes into parameters (#33076) | Kevin Sjöberg | 2018-06-19 | 1 | -0/+21 |
| | | | | | | | | | | | | * Convert hashes into parameters Ensure `ActionController::Parameters#transform_values` and `ActionController::Parameters#transform_values!` converts hashes into parameters. * fixup! Convert hashes into parameters [Rafael Mendonça França + Kevin Sjöberg] | ||||
* | Make mutating params#dig mutate underlying params | Vince DeVendra | 2018-03-24 | 1 | -0/+8 |
| | | | | | | | | | | | When #dig was called on a params object and return either a Hash or an Array, and that value was subsquently mutated, it would not modify the containing params object. That means that the behavior of `params.dig(:a, :b)[:c] = 1` did not match either `params[:a][:b][:c] = 1` nor `hash.dig(:a, :b)[:c] = 1`. Similarly to `ActionController::Parameters#[]`, use `#convert_hashes_to_parameters` to pre-convert values and insert them in the receiving params object prior to returning them. | ||||
* | Rails 6 requires Ruby 2.4.1+ | Jeremy Daer | 2018-02-17 | 1 | -1/+0 |
| | | | | | | Skipping over 2.4.0 to sidestep the `"symbol_from_string".to_sym.dup` bug. References #32028 | ||||
* | Rails 6 requires Ruby 2.3+ | Jeremy Daer | 2018-02-17 | 1 | -16/+9 |
| | |||||
* | Use assert_empty and assert_not_empty | Daniel Colson | 2018-01-25 | 1 | -2/+2 |
| | |||||
* | Use assert_predicate and assert_not_predicate | Daniel Colson | 2018-01-25 | 1 | -28/+28 |
| | |||||
* | Change refute to assert_not | Daniel Colson | 2018-01-25 | 1 | -6/+6 |
| | |||||
* | Use respond_to test helpers | Daniel Colson | 2018-01-25 | 1 | -1/+1 |
| | |||||
* | Yield array from AC::Parameters#each for block with one arg | Dominic Cleal | 2017-12-06 | 1 | -0/+16 |
| | | | | Matches Hash#each behaviour as used in Rails 4. | ||||
* | Use frozen string literal in actionpack/ | Kir Shatrov | 2017-07-29 | 1 | -0/+2 |
| | |||||
* | Revert "Merge pull request #29540 from kirs/rubocop-frozen-string" | Matthew Draper | 2017-07-02 | 1 | -1/+0 |
| | | | | | This reverts commit 3420a14590c0e6915d8b6c242887f74adb4120f9, reversing changes made to afb66a5a598ce4ac74ad84b125a5abf046dcf5aa. | ||||
* | Merge pull request #29540 from kirs/rubocop-frozen-string | Matthew Draper | 2017-07-02 | 1 | -0/+1 |
|\ | | | | | | | Enforce frozen string in Rubocop | ||||
| * | Enforce frozen string in Rubocop | Kir Shatrov | 2017-07-01 | 1 | -0/+1 |
| | | |||||
* | | Fallback Parameters#to_s to Hash#to_s | Kir Shatrov | 2017-06-30 | 1 | -0/+5 |
|/ | | | Fixes https://github.com/rails/rails/issues/29617 | ||||
* | Fix test that was asserting the wrong thing | Rafael Mendonça França | 2017-03-21 | 1 | -1/+1 |
| | |||||
* | Tests for delegated public methods on AC::Parameters | T.J. Schuck | 2017-03-07 | 1 | -0/+63 |
| | |||||
* | Remove deprecated comparing support with `ActionController::Parameters` | Rafael Mendonça França | 2016-10-10 | 1 | -8/+0 |
| | |||||
* | Add three new rubocop rules | Rafael Mendonça França | 2016-08-16 | 1 | -1/+1 |
| | | | | | | | | Style/SpaceBeforeBlockBraces Style/SpaceInsideBlockBraces Style/SpaceInsideHashLiteralBraces Fix all violations in the repository. | ||||
* | applies new string literal convention in actionpack/test | Xavier Noria | 2016-08-06 | 1 | -9/+9 |
| | | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default. | ||||
* | Add `ActionController::Parameters#dig` | Sean Griffin | 2016-03-09 | 1 | -0/+20 |
| | | | | | | This method will only be added when used with Ruby 2.3.0 or greater. This method has the same behavior as `Hash#dig`, except it will convert hashes to `ActionController::Parameters`, similar to `#[]` and `#fetch`. | ||||
* | Show permitted flag in the output of AC::Parameters#inspect | Prathamesh Sonpatki | 2016-02-24 | 1 | -3/+13 |
| | | | | - Fixes #23822. | ||||
* | Deprecate AC::Parameters#== with a Hash | Benjamin Quorning | 2016-02-19 | 1 | -2/+4 |
| | |||||
* | Fix AC::Parameters#== with other AC::Parameters | Benjamin Quorning | 2016-02-19 | 1 | -0/+33 |
| | | | | Creating a protected getter method for `@parameters`. | ||||
* | Tests for AC::Parameters#== | Benjamin Quorning | 2016-02-19 | 1 | -0/+6 |
| | |||||
* | Implement ActionController::Parameters#inspect | Benjamin Quorning | 2016-02-17 | 1 | -0/+9 |
| | | | | Now that AC::Parameters is no longer a Hash, it shouldn't look like a hash. | ||||
* | Fix `ActionController::Parameters#==` bug | Jon Moss | 2016-01-21 | 1 | -0/+6 |
| | | | | See bug #21032. | ||||
* | AC::Parameters#at_json: restore Rails 4.2’s value | claudiob | 2016-01-12 | 1 | -0/+6 |
| | | | | | | Fixes #23026 See discussion at #23026 | ||||
* | Fix failing test on several methods on Parameter | Prem Sichanugrist | 2014-08-18 | 1 | -0/+9 |
| | | | | | | | * `each` * `each_pair` * `delete` * `select!` | ||||
* | Seperate Parameters accessors and mutators tests | Prem Sichanugrist | 2014-08-18 | 1 | -0/+116 |