Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Remove default match without specified method | Jose and Yehuda | 2012-04-24 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | In the current router DSL, using the +match+ DSL method will match all verbs for the path to the specified endpoint. In the vast majority of cases, people are currently using +match+ when they actually mean +get+. This introduces security implications. This commit disallows calling +match+ without an HTTP verb constraint by default. To explicitly match all verbs, this commit also adds a :via => :all option to +match+. Closes #5964 | ||||
* | Add test case for #5307 | Carlos Antonio da Silva | 2012-03-07 | 1 | -2/+6 |
| | |||||
* | Failing test for mime responder respond_with using a block. | Mario Visic | 2012-03-05 | 1 | -0/+36 |
| | |||||
* | Add config.default_method_for_update to support PATCH | David Lee | 2012-02-22 | 1 | -0/+35 |
| | | | | | | | | | | | | | | | | PATCH is the correct HTML verb to map to the #update action. The semantics for PATCH allows for partial updates, whereas PUT requires a complete replacement. Changes: * adds config.default_method_for_update you can set to :patch * optionally use PATCH instead of PUT in resource routes and forms * adds the #patch verb to routes to detect PATCH requests * adds #patch? to Request * changes documentation and comments to indicate support for PATCH This change maintains complete backwards compatibility by keeping :put as the default for config.default_method_for_update. | ||||
* | Fix override API response bug in respond_with | Prem Sichanugrist | 2012-02-03 | 1 | -0/+25 |
| | | | | | | | | | | Default responder was only using the given respond block when user requested for HTML format, or JSON/XML format with valid resource. This fix the responder so that it will use the given block regardless of the validity of the resource. Note that in this case you'll have to check for object's validity by yourself in the controller. Fixes #4796 | ||||
* | Remove rescue_action from compatibility module and tests | Carlos Antonio da Silva | 2012-01-17 | 1 | -5/+1 |
| | |||||
* | Responders now return 204 No Content for API requests without a response ↵ | José Valim | 2011-10-26 | 1 | -10/+10 |
| | | | | body (as in the new scaffold) | ||||
* | ActionPack test fix for RBX | Arun Agrawal | 2011-10-24 | 1 | -1/+3 |
| | |||||
* | Support symbol and string actions in AC#respond_to options | Alexey Vakhov | 2011-10-11 | 1 | -1/+1 |
| | |||||
* | JSON responder should return errors with :error root | Denis Odorcic | 2011-10-10 | 1 | -0/+26 |
| | |||||
* | provide a more explicit message when using url_for with nil | Damien Mathieu | 2011-07-02 | 1 | -0/+7 |
| | | | This fixes the problem of having a non-explicit message when the :location option is not provided in respond_with. | ||||
* | Make sure respond_with with :js tries to render a template in all cases | José Valim | 2011-06-30 | 1 | -6/+15 |
| | |||||
* | don't raise an exception if the format isn't recognized | dmathieu | 2011-05-26 | 1 | -0/+6 |
| | | | | Fixed while traveling to heuruko | ||||
* | Remove `#among?` from Active Support | Prem Sichanugrist | 2011-04-13 | 1 | -1/+1 |
| | | | | | | After a long list of discussion about the performance problem from using varargs and the reason that we can't find a great pair for it, it would be best to remove support for it for now. It will come back if we can find a good pair for it. For now, Bon Voyage, `#among?`. | ||||
* | removes the RJS template handler | Xavier Noria | 2011-04-13 | 1 | -28/+1 |
| | |||||
* | Change Object#either? to Object#among? -- thanks to @jamesarosen for the ↵ | David Heinemeier Hansson | 2011-04-12 | 1 | -1/+1 |
| | | | | suggestion! | ||||
* | Using Object#in? and Object#either? in various places | Prem Sichanugrist | 2011-04-11 | 1 | -1/+2 |
| | | | | There're a lot of places in Rails source code which make a lot of sense to switching to Object#in? or Object#either? instead of using [].include?. | ||||
* | pass respond_with options to controller render when using a template for api ↵ | Josh Kalderimis | 2011-03-31 | 1 | -0/+19 |
| | | | | | | navigation Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | only try to display an api template in responders if the request is a get or ↵ | Josh Kalderimis | 2011-03-31 | 1 | -0/+21 |
| | | | | | | there are no errors Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | when using respond_with with an invalid resource and custom options, the ↵ | Josh Kalderimis | 2011-03-31 | 1 | -0/+17 |
| | | | | | | default response status and error messages should be returned Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | fixing wrong test | Aaron Patterson | 2011-01-17 | 1 | -1/+1 |
| | |||||
* | A bunch of cleanup on the inherited template patch | wycats | 2010-12-26 | 1 | -1/+1 |
| | |||||
* | Fix tests on 1.9.2. | José Valim | 2010-11-28 | 1 | -7/+9 |
| | |||||
* | If a user wants json output then try best to render json output. In such ↵ | Neeraj Singh | 2010-11-24 | 1 | -0/+18 |
| | | | | | | | | cases prefer kind_of(String) over respond_to?(to_str) [#5841 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | clean up test by using unregister method | Neeraj Singh | 2010-11-25 | 1 | -12/+6 |
| | |||||
* | Remove the not needed setup and teardown | Neeraj Singh | 2010-11-25 | 1 | -3/+0 |
| | |||||
* | move the mime registration code to setup so that | Neeraj Singh | 2010-11-22 | 1 | -2/+19 |
| | | | | | | | | | | | | | | | it could be cleaned up on teardown. Currently the test code test/controller/mime_responds_test.rb impacts test/dispatch/mime_type_test.rb. dispatch/mime_type_test.rb runs independently fine but when run as part of rake breaks because of new mime types registered in controller/mime_responds_test.rb Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | do not assume that there is no space between | Neeraj Singh | 2010-11-22 | 1 | -0/+4 |
| | | | | | | leading */* and comma Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | failing test for #6022 | Neeraj Singh | 2010-11-22 | 1 | -0/+34 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | current code ignores http header "Accept" if it | Neeraj Singh | 2010-11-22 | 1 | -0/+6 |
| | | | | | | | | | | | has ....,*/* . It is possible to a device to send request such that */* appear at the beginning of the "Accept" header. This patch ensures that "Accept" header is ignored for such cases too. Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Correctly handle the case of an API response that returns a hash by treating ↵ | Chris Eppstein | 2010-11-06 | 1 | -0/+16 |
| | | | | a single hash argument as the resource instead of as options. | ||||
* | Return a valid empty JSON on successful PUT and DELETE requests. [#5199 ↵ | Szymon Nowak | 2010-10-12 | 1 | -0/+19 |
| | | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Use parentheses when using assert_match followed by a regexp to avoid warnings. | Emilio Tagua | 2010-09-27 | 1 | -2/+2 |
| | |||||
* | Removed deprecated RouteSet API, still many tests fail | Piotr Sarnacki | 2010-09-05 | 1 | -1/+1 |
| | |||||
* | Deletes trailing whitespaces (over text files only find * -type f -exec sed ↵ | Santiago Pastorino | 2010-08-14 | 1 | -5/+5 |
| | | | | 's/[ \t]*$//' -i {} \;) | ||||
* | Adds tests for content negotiation change introduced in dc5300adb6d46252c26e | Patrik Stenmark | 2010-07-04 | 1 | -0/+20 |
| | | | | Signed-off-by: wycats <wycats@gmail.com> | ||||
* | Fix a bug where responders were not working properly on method override. | José Valim | 2010-05-24 | 1 | -0/+13 |
| | |||||
* | Added missing require | Santiago Pastorino | 2010-04-16 | 1 | -0/+1 |
| | |||||
* | Fixed a bunch of tests that failed in 1.9 because they assumed that a Rack ↵ | wycats | 2010-03-19 | 1 | -1/+1 |
| | | | | response was a String. | ||||
* | ActionController::Base.use_accept_header is not actually used anymore, so ↵ | Carl Lerche | 2010-03-03 | 1 | -4/+0 |
| | | | | let's deprecate it. | ||||
* | Require persisted? in ActiveModel::Lint and remove new_record? and ↵ | José Valim | 2010-02-21 | 1 | -2/+2 |
| | | | | destroyed? methods. ActionPack does not care if the resource is new or if it was destroyed, it cares only if it's persisted somewhere or not. | ||||
* | Improve missing template error messages a little bit. | José Valim | 2010-01-31 | 1 | -1/+1 |
| | |||||
* | Raise an error if respond_with is invoked and no format is declared. | José Valim | 2010-01-10 | 1 | -68/+62 |
| | |||||
* | Merge branch 'master' of github.com:rails/rails | Yehuda Katz | 2009-12-10 | 1 | -3/+5 |
|\ | |||||
| * | Use new routing dsl in tests | Joshua Peek | 2009-12-08 | 1 | -3/+5 |
| | | |||||
* | | Responder redirects to resource if destroy fails. | José Valim | 2009-12-07 | 1 | -8/+34 |
|/ | | | | Signed-off-by: Yehuda Katz <wycats@Yehuda-Katz.local> | ||||
* | Allow ActionController::Responder to have a common entry point for all formats. | José Valim | 2009-12-01 | 1 | -0/+17 |
| | | | | Signed-off-by: Yehuda Katz <wycats@Yehuda-Katz.local> | ||||
* | Split mime responder into smaller chunks and allow action to be configured. | José Valim | 2009-11-13 | 1 | -1/+21 |
| | | | | Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | Unify class_inheritable_accessor and extlib_inheritable_accessor and allow ↵ | José Valim | 2009-10-17 | 1 | -0/+8 |
| | | | | responder to be set in the class level. | ||||
* | Use with_routing helper in tests instead of modifying global route set | Joshua Peek | 2009-10-03 | 1 | -67/+83 |
| |