aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/test/controller/layout_test.rb
Commit message (Collapse)AuthorAgeFilesLines
* force response body to be read in assert_templateSergey Nartimov2012-03-051-0/+13
|
* Fix bug in assert_template when using only `:layout` optionPrem Sichanugrist2011-12-061-1/+1
| | | | | | | | | | Currently if you're do this: assert_template :layout => "foo" Regardless of what layout you were using, the test will always pass. This was broken since the introduction of :layout option in [d9375f3f]. We have a lot of test cases in actionpack/test/controller/layout_test.rb that use this feature. This will make sure that those test cases are not true negative.
* Deprecate passing the template handler in the template name.José Valim2011-09-221-2/+2
| | | | | | For example, calling hello.erb is now deprecated. Since Rails 3.0 passing the handler had no effect whatsover. This commit simply deprecates such cases so we can clean up the code in later releases.
* Deprecate old template handler API. Remove old handlers.José Valim2010-10-101-9/+9
|
* Config is deprecated on 1.8.8 and 1.9.3 use RbConfigSantiago Pastorino2010-08-231-1/+1
|
* Deletes trailing whitespaces (over text files only find * -type f -exec sed ↵Santiago Pastorino2010-08-141-2/+2
| | | | 's/[ \t]*$//' -i {} \;)
* move FixtureResolver to a file that is accessible outside Rails' own testsDavid Chelimsky2010-05-021-2/+0
| | | | | | [#4522 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* Use Config::CONFIG['host_os'] instead of RUBY_PLATFORM [#4477 state:resolved]Anil Wadghule2010-04-261-1/+2
| | | | Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* Use correct RUBY_PLATFORM regex for Windows env [#4385 state:resolved]Anil Wadghule2010-04-131-1/+1
| | | | Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* Modify assert_template to use notifications. Also, remove ↵Carlhuda2010-03-171-8/+8
| | | | ActionController::Base#template since it is no longer needed.
* Reorganize autoloads:Carlhuda2009-12-021-1/+1
| | | | | | | | | | | | | | | | | | | | | * A new module (ActiveSupport::Autoload) is provide that extends autoloading with new behavior. * All autoloads in modules that have extended ActiveSupport::Autoload will be eagerly required in threadsafe environments * Autoloads can optionally leave off the path if the path is the same as full_constant_name.underscore * It is possible to specify that a group of autoloads live under an additional path. For instance, all of ActionDispatch's middlewares are ActionDispatch::MiddlewareName, but they live under "action_dispatch/middlewares/middleware_name" * It is possible to specify that a group of autoloads are all found at the same path. For instance, a number of exceptions might all be declared there. * One consequence of this is that testing-related constants are not autoloaded. To get the testing helpers for a given component, require "component_name/test_case". For instance, "action_controller/test_case". * test_help.rb, which is automatically required by a Rails application's test helper, requires the test_case.rb for all active components, so this change will not be disruptive in existing or new applications.
* Fixing pending tests and fixed some formats / partial rendering semanticsYehuda Katz + Carl Lerche2009-06-171-19/+3
|
* More _write_layout_method removalYehuda Katz + Carl Lerche2009-06-151-9/+0
|
* Move fake controllers and models to a common load pathJeremy Kemper2009-05-221-1/+1
|
* Get controller/layout_test.rb running on new base except for ↵Yehuda Katz + Carl Lerche2009-05-221-7/+10
| | | | ActionController::Base.exempt_from_layout which is going to be deprecated.
* Implemented layout conditions in new baseYehuda Katz + Carl Lerche2009-05-211-9/+17
|
* Extract ActionController rescue templates into Rescue and ShowExceptions ↵Joshua Peek2009-05-021-2/+1
| | | | | middleware. This commit breaks all exception catching plugins like ExceptionNotifier. These plugins should be rewritten as middleware instead overriding Controller#rescue_action_in_public.
* Deprecate template, session, assigns, and layout accessors on response ↵Joshua Peek2009-04-281-12/+12
| | | | object. Instead access them through the controller instance. This mainly affects functional test assertions.
* Refactor ActionView::TemplateYehuda Katz + Carl Lerche2009-04-271-11/+13
| | | | | | | | ActionView::Template is now completely independent from template storage, which allows different back ends such as the database. ActionView::Template's only responsibility is to take in the template source (passed in from ActionView::Path), compile it, and render it.
* Bring abstract_controller up to date with rails/masterCarl Lerche & Yehuda Katz2009-04-131-0/+25
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Resolved all the conflicts since 2.3.0 -> HEAD. Following is a list of commits that could not be applied cleanly or are obviated with the abstract_controller refactor. They all need to be revisited to ensure that fixes made in 2.3 do not reappear in 3.0: 2259ecf368e6a6715966f69216e3ee86bf1a82a7 AR not available * This will be reimplemented with ActionORM or equivalent 06182ea02e92afad579998aa80144588e8865ac3 implicitly rendering a js response should not use the default layout [#1844 state:resolved] * This will be handled generically 893e9eb99504705419ad6edac14d00e71cef5f12 Improve view rendering performance in development mode and reinstate template recompiling in production [#1909 state:resolved] * We will need to reimplement rails-dev-boost on top of the refactor; the changes here are very implementation specific and cannot be cleanly applied. The following commits are implicated: 199e750d46c04970b5e7684998d09405648ecbd4 3942cb406e1d5db0ac00e03153809cc8dc4cc4db f8ea9f85d4f1e3e6f3b5d895bef6b013aa4b0690 e3b166aab37ddc2fbab030b146eb61713b91bf55 ae9f258e03c9fd5088da12c1c6cd216cc89a01f7 44423126c6f6133a1d9cf1d0832b527e8711d40f 0cb020b4d6d838025859bd60fb8151c8e21b8e84 workaround for picking layouts based on wrong view_paths [#1974 state:resolved] * The specifics of this commit no longer apply. Since it is a two-line commit, we will reimplement this change. 8c5cc66a831aadb159f3daaffa4208064c30af0e make action_controller/layouts pick templates from the current instance's view_paths instead of the class view_paths [#1974 state:resolved] * This does not apply at all. It should be trivial to apply the feature to the reimplemented ActionController::Base. 87e8b162463f13bd50d27398f020769460a770e3 fix HTML fallback for explicit templates [#2052 state:resolved] * There were a number of patches related to this that simply compounded each other. Basically none of them apply cleanly, and the underlying issue needs to be revisited. After discussing the underlying problem with Koz, we will defer these fixes for further discussion.
| * Fix layouts with absolute paths [#2134 state:resolved]thedarkone2009-03-051-1/+11
| | | | | | | | Signed-off-by: Joshua Peek <josh@joshpeek.com>
| * make action_controller/layouts pick templates from the current instance's ↵Sven Fuchs2009-02-201-0/+14
| | | | | | | | | | | | view_paths instead of the class view_paths [#1974 state:resolved] Signed-off-by: Joshua Peek <josh@joshpeek.com>
* | Temporarily modifies setup to call super directly. This can support more ↵Yehuda Katz and Carl Lerche2009-04-081-0/+1
| | | | | | | | T::U runners.
* | Begin unifying the interface between ActionController and ActionViewYehuda Katz2009-01-221-3/+35
|/
* Use instance_eval instead of adding an accessor to the classJeremy Kemper2009-01-071-2/+1
|
* Fix ActionPack build on Windows: we really should not test anything ↵Yaroslav Markin2008-12-271-10/+12
| | | | | | regarding symlinks on Windows. Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
* Reinstate "Super lazy load view paths in development mode (no indexing or ↵Joshua Peek2008-11-281-7/+7
| | | | caching at all). Switch layout finders to use view path api to take advantage of cache." as it killed dev mode reloading."
* Revert "Super lazy load view paths in development mode (no indexing or ↵David Heinemeier Hansson2008-11-271-7/+7
| | | | | | caching at all). Switch layout finders to use view path api to take advantage of cache." as it killed dev mode reloading. This reverts commit 4d910b033379727e5e7355590c50c72fc75e56db.
* Super lazy load view paths in development mode (no indexing or caching at ↵Joshua Peek2008-11-261-7/+7
| | | | all). Switch layout finders to use view path api to take advantage of cache.
* Move controller assertions from base TestCase to AC:: and AV::TestCaseJeremy Kemper2008-11-071-28/+5
|
* Moved layout exemption logic into the viewJoshua Peek2008-08-311-49/+0
|
* pass yielded arguments to block for ActionView::Base#render with :layout ↵Ryan Bates2008-08-171-10/+9
| | | | | | [#847 state:resolved] Signed-off-by: Joshua Peek <josh@joshpeek.com>
* Removed lagacy TemplateHandler#render API. Left in a legacy TemplateHandler ↵Joshua Peek2008-07-181-10/+2
| | | | and Compilable stub so plugins will not have to change anything.
* Refactor template preloading. New abstractions include Renderable mixins and ↵Joshua Peek2008-07-121-0/+1
| | | | a refactored Template class.
* Changed ActionView::TemplateHandler#render API method signature to ↵Joshua Peek2008-07-111-2/+2
| | | | render(template, local_assigns = {})
* Revert "Moved TemplateHandlers to Base"Joshua Peek2008-07-031-1/+1
| | | | | | | | | This reverts commit 42d215a925a228778e43f7040f03ad8f3eb5341c. Conflicts: actionpack/lib/action_view/inline_template.rb actionpack/lib/action_view/template.rb
* Moved TemplateHandlers to BaseJoshua Peek2008-07-031-1/+1
|
* Move missing template logic to ActionViewPratik Naik2008-04-191-1/+1
|
* Fix layouts in symlinked paths. Closes #9136 [court3nay, caio]Jeremy Kemper2008-03-281-0/+19
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@9120 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Moved template handlers related code from ActionView::Base to ↵Pratik Naik2008-03-051-1/+1
| | | | | | ActionView::Template git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8981 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Refactor partial rendering into a PartialTemplate class. [Pratik]Michael Koziarski2008-03-031-2/+2
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8976 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* * Pass around handler instances, not their classes [Koz]Michael Koziarski2008-01-111-1/+2
| | | | | | | | * Move compilation, rendering and 'compilable?' checks into the Handlers [Koz] * Remove delegate_* methods as the handler is now an instance [Koz] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8624 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* require abstract_unit directly since test is in load pathJeremy Kemper2008-01-051-1/+1
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8564 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Ruby 1.9 compat, consistent load pathsJeremy Kemper2007-10-021-8/+8
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7719 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Fixed that render template did not honor exempt_from_layout (closes #9698) ↵David Heinemeier Hansson2007-09-301-0/+18
| | | | | | [pezra] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7701 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Fix layout overriding response status. Closes #9476.Jeremy Kemper2007-09-081-0/+19
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7418 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Add some performance enhancements to ActionView.Rick Olson2007-05-151-0/+1
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6736 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Allow layouts with extension of .html.erb. Closes #8032 [Josh Knowles]Rick Olson2007-04-121-0/+10
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6516 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Added .erb and .builder as preferred aliases to the now deprecated .rhtml ↵David Heinemeier Hansson2007-02-201-0/+2
| | | | | | and .rxml extensions [Chad Fowler]. This is done to separate the renderer from the mime type. .erb templates are often used to render emails, atom, csv, whatever. So labeling them .rhtml doesn't make too much sense. The same goes for .rxml, which can be used to build everything from HTML to Atom to whatever. .rhtml and .rxml will continue to work until Rails 3.0, though. So this is a slow phasing out. All generators and examples will start using the new aliases, though. git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6178 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Allow Controllers to have multiple view_paths instead of a single ↵Rick Olson2007-02-041-5/+7
| | | | | | template_root. Closes #2754 [John Long] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6120 5ecf4fe2-1ee6-0310-87b1-e25e094e27de