Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Remove secret_token rack env and cookie upgrade code | Rafael Mendonça França | 2019-01-17 | 1 | -1/+4 |
| | | | | Now that secret_token was removed all this code is now dead. | ||||
* | Turn on performance based cops | Dillon Welch | 2018-07-23 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | Use attr_reader/attr_writer instead of methods method is 12% slower Use flat_map over map.flatten(1) flatten is 66% slower Use hash[]= instead of hash.merge! with single arguments merge! is 166% slower See https://github.com/rails/rails/pull/32337 for more conversation | ||||
* | Replace `assert !` with `assert_not` | Daniel Colson | 2018-04-19 | 1 | -1/+1 |
| | | | | | This autocorrects the violations after adding a custom cop in 3305c78dcd. | ||||
* | We should call methods with `.method_name` not `::method_name`. | utilum | 2018-02-22 | 1 | -4/+5 |
| | | | | | | Found several instances. Follow up on 63d530c5e68a8cf53603744789f53ccbc7ac1a0e | ||||
* | Use frozen string literal in actionpack/ | Kir Shatrov | 2017-07-29 | 1 | -0/+2 |
| | |||||
* | Revert "Merge pull request #29540 from kirs/rubocop-frozen-string" | Matthew Draper | 2017-07-02 | 1 | -1/+0 |
| | | | | | This reverts commit 3420a14590c0e6915d8b6c242887f74adb4120f9, reversing changes made to afb66a5a598ce4ac74ad84b125a5abf046dcf5aa. | ||||
* | Enforce frozen string in Rubocop | Kir Shatrov | 2017-07-01 | 1 | -0/+1 |
| | |||||
* | Add more rubocop rules about whitespaces | Rafael Mendonça França | 2016-10-29 | 1 | -2/+2 |
| | |||||
* | Add three new rubocop rules | Rafael Mendonça França | 2016-08-16 | 1 | -2/+2 |
| | | | | | | | | Style/SpaceBeforeBlockBraces Style/SpaceInsideBlockBraces Style/SpaceInsideHashLiteralBraces Fix all violations in the repository. | ||||
* | normalizes indentation and whitespace across the project | Xavier Noria | 2016-08-06 | 1 | -34/+34 |
| | |||||
* | modernizes hash syntax in actionpack | Xavier Noria | 2016-08-06 | 1 | -26/+26 |
| | |||||
* | applies new string literal convention in actionpack/test | Xavier Noria | 2016-08-06 | 1 | -60/+60 |
| | | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default. | ||||
* | Stop using deprecated `render :text` in test | Prem Sichanugrist | 2015-07-17 | 1 | -2/+2 |
| | | | | | | | | | This will silence deprecation warnings. Most of the test can be changed from `render :text` to render `:plain` or `render :body` right away. However, there are some tests that needed to be fixed by hand as they actually assert the default Content-Type returned from `render :body`. | ||||
* | Remove `assigns` and `assert_template`. | Guo Xiang Tan | 2015-05-30 | 1 | -10/+1 |
| | |||||
* | Typos. return -> returns. [ci skip] | Lauro Caetano | 2013-12-03 | 1 | -1/+1 |
| | |||||
* | Remove comments about removing LegacyKeyGenerator in 4.1 | Trevor Turk | 2013-04-03 | 1 | -1/+0 |
| | |||||
* | Rename DummyKeyGenerator -> LegacyKeyGenerator | Trevor Turk | 2013-04-02 | 1 | -2/+2 |
| | |||||
* | Digest auth should not 500 when given a basic header. | Brad Dunbar | 2013-03-18 | 1 | -0/+8 |
| | |||||
* | update documentation and code to use _action callbacks | Francesco Rodriguez | 2012-12-07 | 1 | -2/+2 |
| | |||||
* | Move ensure_secret_secure to DummyKeyGenerator | Santiago Pastorino | 2012-11-03 | 1 | -1/+1 |
| | |||||
* | Use derived keys everywhere, http_authentication was missing it | Santiago Pastorino | 2012-11-03 | 1 | -1/+3 |
| | |||||
* | Fix for digest authentication bug - issue #2301 in rails/rails | Arthur Smith | 2012-08-02 | 1 | -3/+4 |
| | |||||
* | Should use an argument in http_digest_authentication_test.rb | kennyj | 2012-03-17 | 1 | -1/+1 |
| | |||||
* | Fix http digest authentication with trailing '/' or '?' (fixes #4038 and #3228) | Piotr Sarnacki | 2011-12-21 | 1 | -5/+36 |
| | |||||
* | Added failing test to demonstrate digest authentication failure | Jarrod Carlson | 2011-12-20 | 1 | -0/+10 |
| | |||||
* | Rename config.cookie_secret to config.secret_token and pass it as ↵ | José Valim | 2010-04-05 | 1 | -3/+2 |
| | | | | configuration in request.env. This is another step forward removing global configuration. | ||||
* | Deprecated ActionController::Base.session_options= and ↵ | Carlhuda | 2010-03-04 | 1 | -2/+3 |
| | | | | ActionController::Base.session_store= in favor of a config.session_store method (which takes params) and a config.cookie_secret variable, which is used in various secret scenarios. The old AC::Base options will continue to work with deprecation warnings. | ||||
* | Tweak the semantic of various URL related methods of ActionDispatch::Request | Carlhuda | 2010-03-03 | 1 | -4/+6 |
| | |||||
* | Move session_store and session_options to the AC configuration object | Carlhuda | 2010-03-03 | 1 | -2/+3 |
| | |||||
* | Make http digest work with different server/browser combinations | José Valim | 2009-08-09 | 1 | -6/+29 |
| | | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | A test to show that http_authentication needs to fail authentication if the ↵ | nate | 2009-06-09 | 1 | -0/+14 |
| | | | | | | password procedure returns nil. Also includes a fix to validate_digest_response to fail validation if the password procedure returns nil. Signed-off-by: Michael Koziarski <michael@koziarski.com> | ||||
* | Add HTTP Authentication to the new base | Pratik Naik | 2009-05-22 | 1 | -4/+9 |
| | |||||
* | Ensure HTTP Digest auth uses appropriate HTTP method [#2490 state:resolved] ↵ | Pratik Naik | 2009-05-18 | 1 | -3/+20 |
| | | | | [Steve Madsen] | ||||
* | Inherit TestSession from Session::AbstractStore and add indifferent access ↵ | Joshua Peek | 2009-04-26 | 1 | -2/+0 |
| | | | | to Session::AbstractStore. | ||||
* | Support MD5 passwords for Digest auth and use session_options[:secret] in ↵ | Donald Parish | 2009-03-12 | 1 | -7/+46 |
| | | | | | | nonce [#2209 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | Fixed http digest authentication to use credentials URI passed from client. ↵ | Donald Parish | 2009-02-16 | 1 | -1/+10 |
| | | | | | | [#1848 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | Implement HTTP Digest authentication. [#1230 state:resolved] [Gregg Kellogg, ↵ | Gregg Kellogg | 2009-01-29 | 1 | -0/+130 |
| | | | | | | Pratik Naik] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | Revert "HTTP Digest authentication [#1230 state:resolved]" | Pratik Naik | 2009-01-13 | 1 | -73/+0 |
| | | | | | | | | | This reverts commit 45dee3842d68359a189fe7c0729359bd5a905ea4. Reasons : 1. The code is not working in it's current state 2. Should not be using exceptions for flow control | ||||
* | HTTP Digest authentication [#1230 state:resolved] | Joshua Peek | 2008-12-28 | 1 | -0/+73 |