Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | finish deprecating handling strings and symbols | Aaron Patterson | 2015-08-07 | 1 | -1/+1 |
| | | | | | since we only work with instances of classes, it greatly simplifies the `Middleware` implementation. | ||||
* | Remove `assigns` and `assert_template`. | Guo Xiang Tan | 2015-05-30 | 1 | -24/+25 |
| | |||||
* | Deprecate `:nothing` option for render method | Mehmet Emin İNAÇ | 2015-05-28 | 1 | -1/+1 |
| | | | | `head` method works similar to `render` method with `:nothing` option | ||||
* | Switch to kwargs in ActionController::TestCase and ActionDispatch::Integration | Kir Shatrov | 2015-01-29 | 1 | -7/+9 |
| | | | | | | | | Non-kwargs requests are deprecated now. Guides are updated as well. `post url, nil, nil, { a: 'b' }` doesn't make sense. `post url, params: { y: x }, session: { a: 'b' }` would be an explicit way to do the same | ||||
* | Remove unused `subclass_controller_with_flash_type_bar` var from flash test. | Vipul A M | 2014-04-07 | 1 | -2/+2 |
| | |||||
* | Fix setup of adding _flash_types test. | Guo Xiang Tan | 2014-04-06 | 1 | -6/+15 |
| | | | | | | | Adding flash types to a controller within any of the tests will result in a global state change of the controller under test. This patch will prevent state leaks and allow us to run the test in random order. | ||||
* | Fixed broken flash tests | Godfrey Chan | 2014-02-11 | 1 | -4/+4 |
| | |||||
* | Typo fixes [ci skip] | Akshay Vishnoi | 2013-11-30 | 1 | -2/+2 |
| | |||||
* | Custom flash should be defined only for the class that defines it and it's ↵ | Ricardo de Cillo | 2013-09-13 | 1 | -0/+12 |
| | | | | subclasses. | ||||
* | Remove comments about removing LegacyKeyGenerator in 4.1 | Trevor Turk | 2013-04-03 | 1 | -1/+0 |
| | |||||
* | Rename DummyKeyGenerator -> LegacyKeyGenerator | Trevor Turk | 2013-04-02 | 1 | -2/+2 |
| | |||||
* | use `_action` instead of `_filter` callbacks | Francesco Rodriguez | 2012-12-07 | 1 | -3/+3 |
| | |||||
* | Remove extra whitespace | Santiago Pastorino | 2012-11-15 | 1 | -1/+1 |
| | |||||
* | Sign cookies using key deriver | Santiago Pastorino | 2012-11-03 | 1 | -2/+4 |
| | |||||
* | Use "instance_accessor" for flash types class attribute | Carlos Antonio da Silva | 2012-07-07 | 1 | -1/+0 |
| | |||||
* | Added support add_flash_types | kennyj | 2012-07-07 | 1 | -0/+26 |
| | |||||
* | Remove unused code. | kennyj | 2012-07-07 | 1 | -4/+0 |
| | |||||
* | Remove default match without specified method | Jose and Yehuda | 2012-04-24 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | In the current router DSL, using the +match+ DSL method will match all verbs for the path to the specified endpoint. In the vast majority of cases, people are currently using +match+ when they actually mean +get+. This introduces security implications. This commit disallows calling +match+ without an HTTP verb constraint by default. To explicitly match all verbs, this commit also adds a :via => :all option to +match+. Closes #5964 | ||||
* | Remove rescue_action from compatibility module and tests | Carlos Antonio da Silva | 2012-01-17 | 1 | -4/+0 |
| | |||||
* | Get rid of the close checks since we cannot reliably close the session anyway. | José Valim | 2011-12-16 | 1 | -40/+0 |
| | |||||
* | Don't reuse a closed flash when using now | Florent Piteau | 2011-04-20 | 1 | -0/+8 |
| | |||||
* | Be sure to not store the closed flash in the session. | José Valim | 2011-04-19 | 1 | -1/+8 |
| | |||||
* | favor composition over inheritance, have FlashHash delegate to a Hash | Aaron Patterson | 2011-04-06 | 1 | -4/+4 |
| | |||||
* | raise if someone tries to modify the flash when it was already streamed back ↵ | Santiago Pastorino | 2011-04-05 | 1 | -0/+50 |
| | | | | to the client or converted to HTTP headers | ||||
* | Remove deprecated stuff in ActionController | Carlos Antonio da Silva | 2010-09-26 | 1 | -1/+1 |
| | | | | | | This removes all deprecated classes in ActionController related to Routing, Abstract Request/Response and Integration/IntegrationTest. All tests and docs were changed to ActionDispatch instead of ActionController. | ||||
* | Removed deprecated RouteSet API, still many tests fail | Piotr Sarnacki | 2010-09-05 | 1 | -1/+1 |
| | |||||
* | Just reading flash messages should not create a session if one does not ↵ | José Valim | 2010-06-25 | 1 | -3/+17 |
| | | | | exist yet. | ||||
* | Ruby 1.9.1 compat: constant lookup | Jeremy Kemper | 2010-06-11 | 1 | -1/+1 |
| | |||||
* | Simplify cookie_store by simply relying on cookies.signed. | José Valim | 2010-05-18 | 1 | -1/+10 |
| | |||||
* | Add tests for convenience methods #notice and #alert to flash.now [#4369 ↵ | Anil Wadghule | 2010-05-15 | 1 | -0/+20 |
| | | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Module lookup issue on flash_test using ruby 1.9 solved [#3716 status:resolved] | Sam Elliott and Santiago Pastorino | 2010-01-17 | 1 | -1/+1 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Move Flash into middleware | Joshua Peek | 2010-01-15 | 1 | -2/+40 |
| | |||||
* | reset_session needs to be a real method so flash can override it | Joshua Peek | 2009-12-21 | 1 | -12/+12 |
| | |||||
* | Added alert/notice from 2-3-stable and refactored redirect_to into just ↵ | David Heinemeier Hansson | 2009-12-17 | 1 | -1/+28 |
| | | | | living in Redirector [DHH] | ||||
* | The FlashHash and friends causes a lot of needless session storing, when we ↵ | Johan Sörensen | 2009-05-28 | 1 | -1/+6 |
| | | | | | | know for a fact that there's no content in the flash. By not storing the empty hash in the session we save a lot of communication with the various session backends, while still keeping the same interface to the flash. [#2703 state:resolved] Signed-off-by: Joshua Peek <josh@joshpeek.com> | ||||
* | ActionController::Flash::FlashHash.use now returns either the value ↵ | Niels Ganser | 2009-05-27 | 1 | -0/+15 |
| | | | | | | corresponding to the passed key or itself when no key is passed [#1792 state:resolved] Signed-off-by: Joshua Peek <josh@joshpeek.com> | ||||
* | Make ActionController::Flash work with new_base | Pratik Naik | 2009-05-21 | 1 | -24/+25 |
| | |||||
* | Deprecate template, session, assigns, and layout accessors on response ↵ | Joshua Peek | 2009-04-28 | 1 | -24/+24 |
| | | | | object. Instead access them through the controller instance. This mainly affects functional test assertions. | ||||
* | Include process methods in ActionController::TestCase only. No need to ↵ | Jeremy Kemper | 2009-01-07 | 1 | -6/+2 |
| | | | | alias_method_chain :process either. | ||||
* | Move missing template logic to ActionView | Pratik Naik | 2008-04-19 | 1 | -1/+1 |
| | |||||
* | require abstract_unit directly since test is in load path | Jeremy Kemper | 2008-01-05 | 1 | -1/+1 |
| | | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8564 5ecf4fe2-1ee6-0310-87b1-e25e094e27de | ||||
* | Remove unnecessary returns from builtin filters since render/return is now ↵ | Jeremy Kemper | 2007-10-24 | 1 | -1/+0 |
| | | | | | | sufficient. Closes #9952 [Josh Peek] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8009 5ecf4fe2-1ee6-0310-87b1-e25e094e27de | ||||
* | Removed ActionController::Base#keep_flash (use flash.keep instead) | David Heinemeier Hansson | 2007-09-09 | 1 | -2/+2 |
| | | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7428 5ecf4fe2-1ee6-0310-87b1-e25e094e27de | ||||
* | Sweep flash when filter chain is halted. Closes #6175. [Caio Chassot ↵ | Marcel Molina | 2007-05-06 | 1 | -0/+45 |
| | | | | | | <lists@v2studio.com>] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6670 5ecf4fe2-1ee6-0310-87b1-e25e094e27de | ||||
* | deprecated keep_flash test | Jeremy Kemper | 2006-09-04 | 1 | -2/+2 |
| | | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4972 5ecf4fe2-1ee6-0310-87b1-e25e094e27de | ||||
* | Fixed that you can still access the flash after the flash has been reset in ↵ | Rick Olson | 2006-07-22 | 1 | -0/+17 |
| | | | | | | reset_session. Closes #5584 [lmarlow@yahoo.com] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4617 5ecf4fe2-1ee6-0310-87b1-e25e094e27de | ||||
* | Modernize flash tests | David Heinemeier Hansson | 2006-02-12 | 1 | -41/+26 |
| | | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3583 5ecf4fe2-1ee6-0310-87b1-e25e094e27de | ||||
* | Silence deprecation warnings for keep_flash when running tests. | Marcel Molina | 2005-12-02 | 1 | -1/+1 |
| | | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3203 5ecf4fe2-1ee6-0310-87b1-e25e094e27de | ||||
* | Added a reader for flash.now, so it's possible to do stuff like ↵ | David Heinemeier Hansson | 2005-10-26 | 1 | -0/+6 |
| | | | | | | flash.now[:alert] ||= 'New if not set' (closes #2422) [Caio Chassot] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2747 5ecf4fe2-1ee6-0310-87b1-e25e094e27de | ||||
* | Improved performance of test app req/sec with ~10% refactoring the render ↵ | David Heinemeier Hansson | 2005-07-24 | 1 | -6/+6 |
| | | | | | | method #1823 [Stefan Kaes] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1915 5ecf4fe2-1ee6-0310-87b1-e25e094e27de |