Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Revert "Merge pull request #8017 from jcoglan/objectless_sessions" | Jon Leighton | 2012-11-09 | 1 | -21/+0 |
| | | | | | | | | | | | | This reverts commit 36376560fdd02f955ae3bf6b7792b784443660ad, reversing changes made to 3148ed9a4bb7efef30b846dc945d73ceebcc3f0f. Conflicts: actionpack/lib/action_dispatch/middleware/flash.rb Reason: it broke Sam's CI https://github.com/rails/rails/pull/8017#issuecomment-10210655 | ||||
* | Store FlashHashes in the session as plain hashes rather than custom objects ↵ | James Coglan | 2012-11-03 | 1 | -0/+21 |
| | | | | | | | | | | | | | | | | | | with unstable class names and instance variables. Refactor FlashHash to take values for its ivars in the constructor, to pretty up FlashHash.from_session_value. Remove stale comment on FlashHash: it is no longer Marshaled in the session so we can change its implementation. Remove blank lines I introduced in controller/test_case.rb. Unit tests for FlashHash#to_session_value. Put in a compatibility layer to accept FlashHash serializations from Rails 3.0+. Test that Rails 3.2 session flashes are correctly converted to the new format. Remove code path for processing Rails 3.0 FlashHashes since they can no longer deserialize. | ||||
* | mutations on the underlying hash should also mutate the discard set | Aaron Patterson | 2011-12-28 | 1 | -0/+19 |
| | |||||
* | mutations can't be done without the consent of our proxy object. This | Aaron Patterson | 2011-12-28 | 1 | -0/+62 |
| | | | | is one benefit of choosing composition over inheritance. | ||||
* | many args does not make sense with the current implementation because of how ↵ | Aaron Patterson | 2011-04-06 | 1 | -10/+0 |
| | | | | `use` works | ||||
* | getting the flash hash under test | Aaron Patterson | 2011-04-06 | 1 | -0/+100 |