Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Replace `assert !` with `assert_not` | Daniel Colson | 2018-04-19 | 1 | -2/+2 |
| | | | | | This autocorrects the violations after adding a custom cop in 3305c78dcd. | ||||
* | Use assert_empty and assert_not_empty | Daniel Colson | 2018-01-25 | 1 | -3/+3 |
| | |||||
* | Use assert_predicate and assert_not_predicate | Daniel Colson | 2018-01-25 | 1 | -3/+3 |
| | |||||
* | Use frozen string literal in actionpack/ | Kir Shatrov | 2017-07-29 | 1 | -0/+2 |
| | |||||
* | Revert "Merge pull request #29540 from kirs/rubocop-frozen-string" | Matthew Draper | 2017-07-02 | 1 | -1/+0 |
| | | | | | This reverts commit 3420a14590c0e6915d8b6c242887f74adb4120f9, reversing changes made to afb66a5a598ce4ac74ad84b125a5abf046dcf5aa. | ||||
* | Enforce frozen string in Rubocop | Kir Shatrov | 2017-07-01 | 1 | -0/+1 |
| | |||||
* | "Use assert_nil if expecting nil from ...:in `...'. This will fail in MT6." | Akira Matsuda | 2016-12-25 | 1 | -4/+4 |
| | |||||
* | Add more rubocop rules about whitespaces | Rafael Mendonça França | 2016-10-29 | 1 | -2/+2 |
| | |||||
* | Add three new rubocop rules | Rafael Mendonça França | 2016-08-16 | 1 | -14/+14 |
| | | | | | | | | Style/SpaceBeforeBlockBraces Style/SpaceInsideBlockBraces Style/SpaceInsideHashLiteralBraces Fix all violations in the repository. | ||||
* | remove redundant curlies from hash arguments | Xavier Noria | 2016-08-06 | 1 | -3/+3 |
| | |||||
* | applies new string literal convention in actionpack/test | Xavier Noria | 2016-08-06 | 1 | -72/+72 |
| | | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default. | ||||
* | Make flash messages cookie compatible with Rails 4 | Rafael Mendonça França | 2016-05-06 | 1 | -2/+2 |
| | | | | | | | | In #18721 we removed the discard key from the session hash used to flash messages and that broke compatibility with Rails 4 applications because they try to map in the discarded flash messages and it returns nil. Fixes #24726. | ||||
* | Migrate old flash behaviour | Samuel Cochran | 2015-01-30 | 1 | -6/+7 |
| | |||||
* | Discard from flash before persisting in session | Samuel Cochran | 2015-01-29 | 1 | -7/+9 |
| | |||||
* | Make FlashHash#key? work with symbol and string | Rafael Mendonça França | 2014-11-11 | 1 | -0/+9 |
| | | | | Closes #17586 | ||||
* | Convert FlashHash in a Hash with indifferent access | Guillermo Iguaran | 2014-02-11 | 1 | -0/+10 |
| | |||||
* | Store FlashHashes in the session as plain hashes rather than custom objects ↵ | James Coglan | 2012-11-09 | 1 | -0/+21 |
| | | | | | | | | | | | | | | | | | | | | with unstable class names and instance variables. Refactor FlashHash to take values for its ivars in the constructor, to pretty up FlashHash.from_session_value. Remove stale comment on FlashHash: it is no longer Marshaled in the session so we can change its implementation. Remove blank lines I introduced in controller/test_case.rb. Unit tests for FlashHash#to_session_value. Put in a compatibility layer to accept FlashHash serializations from Rails 3.0+. Test that Rails 3.2 session flashes are correctly converted to the new format. Remove code path for processing Rails 3.0 FlashHashes since they can no longer deserialize. Fix session['flash'] deletion condition: it will never be empty?, it will either be nil or a hash with 'discard' and 'flashes' keys. | ||||
* | mutations on the underlying hash should also mutate the discard set | Aaron Patterson | 2011-12-28 | 1 | -0/+19 |
| | |||||
* | mutations can't be done without the consent of our proxy object. This | Aaron Patterson | 2011-12-28 | 1 | -0/+62 |
| | | | | is one benefit of choosing composition over inheritance. | ||||
* | many args does not make sense with the current implementation because of how ↵ | Aaron Patterson | 2011-04-06 | 1 | -10/+0 |
| | | | | `use` works | ||||
* | getting the flash hash under test | Aaron Patterson | 2011-04-06 | 1 | -0/+100 |