aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/test/controller/filters_test.rb
Commit message (Collapse)AuthorAgeFilesLines
* Better test for ticket [#3914 state:resolved]Neeraj Singh2010-06-091-0/+11
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* cache_sweeper yields blank outputNeeraj Singh2010-06-081-0/+6
| | | | | | [#3914 state:open] Signed-off-by: José Valim <jose.valim@gmail.com>
* Use better assertion methods for testingNeeraj Singh2010-05-191-7/+7
| | | | | | [#4645 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* Modify assert_template to use notifications. Also, remove ↵Carlhuda2010-03-171-2/+2
| | | | ActionController::Base#template since it is no longer needed.
* deOMGifying Railties, Active Support, and Action PackMikel Lindsaar2010-01-311-3/+3
|
* Symbol#to_proc is not needed for Ruby >= 1.8.7Xavier Noria2009-11-091-1/+0
|
* Cleaning up more tests and code that needed to work in both old and new baseYehuda Katz + Carl Lerche2009-06-171-50/+18
|
* YAGNI Method references. DeprecatedYehuda Katz2009-06-021-4/+6
|
* Get all the callback tests to work on new baseYehuda Katz + Carl Lerche2009-06-011-22/+46
|
* Make sure tests pass action name to Controller.action()Pratik Naik2009-05-301-1/+1
|
* Added a compatibility layer to get legacy filter tests to pass on new baseYehuda Katz + Carl Lerche2009-05-271-5/+27
|
* Make Filter#filter work with around filtersPratik Naik2009-05-251-59/+54
|
* Cordon off missing filter methodsJeremy Kemper2009-05-221-0/+8
|
* Remove gratuitous filter_chain internal testing. Not part of the API and ↵Jeremy Kemper2009-05-221-25/+0
| | | | other tests are sufficient to catch regressions.
* Rescue hack was supposed to be removed. Some how it crept back in.Joshua Peek2009-05-171-1/+0
|
* Merge branch 'master' into wip_abstract_controllerYehuda Katz + Carl Lerche2009-05-111-0/+5
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | Conflicts: actionpack/lib/action_controller/abstract/callbacks.rb actionpack/lib/action_controller/abstract/renderer.rb actionpack/lib/action_controller/base/base.rb actionpack/lib/action_controller/dispatch/dispatcher.rb actionpack/lib/action_controller/routing/route_set.rb actionpack/lib/action_controller/testing/process.rb actionpack/test/abstract_controller/layouts_test.rb actionpack/test/controller/filters_test.rb actionpack/test/controller/helper_test.rb actionpack/test/controller/render_test.rb actionpack/test/new_base/test_helper.rb
| * Extract ActionController rescue templates into Rescue and ShowExceptions ↵Joshua Peek2009-05-021-0/+5
| | | | | | | | | | middleware. This commit breaks all exception catching plugins like ExceptionNotifier. These plugins should be rewritten as middleware instead overriding Controller#rescue_action_in_public.
| * Deprecate Controller.process interfaceJoshua Peek2009-05-021-1/+1
| |
* | Implement FooController.action(:name)Yehuda Katz2009-05-021-1/+2
|/ | | | | | * Rails actions are now Rack endpoints, and can be retrieved via FooController.action(name) and called with an env * Updated some tests that relied on the old internal #process/#call implementation
* Update some old tests to use AC TestProcessJoshua Peek2009-04-301-12/+13
|
* alias method chain process with testJoshua Peek2009-04-301-2/+2
|
* Deprecate template, session, assigns, and layout accessors on response ↵Joshua Peek2009-04-281-70/+107
| | | | object. Instead access them through the controller instance. This mainly affects functional test assertions.
* Include process methods in ActionController::TestCase only. No need to ↵Jeremy Kemper2009-01-071-2/+6
| | | | alias_method_chain :process either.
* Get rid of 'Object#send!'. It was originally added because it's in Ruby 1.9, ↵Jeremy Kemper2008-08-311-1/+1
| | | | | | | | | | but it has since been removed from 1.9. Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> Conflicts: actionpack/test/controller/layout_test.rb
* Move copying ivar logic from ActionController::Base to ActionView::BasePratik Naik2008-08-311-12/+12
|
* Fix regression from filter refactoring where re-adding a skipped filter ↵Rick Olson2008-03-231-0/+33
| | | | | | resulted in it being called twice. [rick] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@9080 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Refactor filters to use Active Support callbacks. Closes #11235.Jeremy Kemper2008-03-181-15/+10
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@9055 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Filter procs must take 1 or 2 arguments. Raise ArgumentError otherwise.Jeremy Kemper2008-01-071-7/+4
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8583 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* require abstract_unit directly since test is in load pathJeremy Kemper2008-01-051-1/+1
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8564 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Note that filters test crashes Ruby 1.9Jeremy Kemper2007-12-151-0/+1
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8408 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Changed before_filter halting to happen automatically on render or redirect ↵David Heinemeier Hansson2007-10-211-4/+6
| | | | | | but no longer on simply returning false [DHH] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7984 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Ruby 1.9 compat, consistent load pathsJeremy Kemper2007-10-021-1/+1
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7719 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Remove deprecated functionality from actionpack. Closes #8958 [lifofifo]Michael Koziarski2007-09-031-3/+3
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7403 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Fix errors with around_filters which do not yield, restore 1.1 behaviour ↵Michael Koziarski2007-07-111-7/+73
| | | | | | with after filters. Closes #8891 [skaes] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7177 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Rescuing in around_filters works as expected again [codahale, Stephan Kaes]. ↵Tobias Lütke2007-05-221-0/+35
| | | | | | Closes #8341 git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6810 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Bug fix for the filter implementationMichael Koziarski2007-05-061-0/+43
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6669 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Replace the current block/continuation filter chain handling by an ↵Rick Olson2007-05-021-26/+40
| | | | | | implementation based on a simple loop. #8226 [Stefan Kaes] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6649 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* make sure filters in subclasses with :only or :except conditions are treated ↵Jamis Buck2006-10-141-1/+13
| | | | | | like skip_filter calls git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5301 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* r5540@ks: jeremy | 2006-10-08 23:05:30 -0700Jeremy Kemper2006-10-091-1/+11
| | | | | | | | | | | #5949 r5541@ks: jeremy | 2006-10-08 23:07:08 -0700 Fix filter skipping in controller subclasses. r5557@ks: jeremy | 2006-10-08 23:11:24 -0700 Update changelog. Closes #5949, references #6297, references #6299. git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5268 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Fix bug that kept any before_filter except the first one from being able to ↵Rick Olson2006-09-271-0/+44
| | | | | | halt the before_filter chain. [Rick Olson] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5196 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Filters overhaul including meantime filter support for around filters. ↵Jeremy Kemper2006-09-221-15/+234
| | | | | | Closes #5949. git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5163 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Failed test for Marcel to ponderDavid Heinemeier Hansson2006-04-061-2/+10
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4178 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Honor skipping filters conditionally for only certain actions even when the ↵Marcel Molina2006-04-051-1/+22
| | | | | | parent class sets that filter to conditionally be executed only for the same actions. Closes #4522. git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4167 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Stopped the massive bleeding of concerns into ActionController::Base. Base ↵David Heinemeier Hansson2006-02-121-2/+2
| | | | | | no longer knows about flash, filters, or components. This may well have introduced some instability, please do test with apps, especially the ones using components. [DHH] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3580 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Major components cleanup and speedup. Closes #3527.Jeremy Kemper2006-02-091-4/+5
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3563 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Added :only and :except controls to skip_before/after_filter just like for ↵David Heinemeier Hansson2006-01-311-0/+28
| | | | | | when you add filters [DHH] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3504 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Added skip_before_filter/skip_after_filter for easier control of the filter ↵David Heinemeier Hansson2005-11-041-1/+2
| | | | | | chain in inheritance hierachies [DHH] Added short-hand to assert_tag so assert_tag :tag => "span" can be written as assert_tag "span" [DHH] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2873 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Improved performance of test app req/sec with ~10% refactoring the render ↵David Heinemeier Hansson2005-07-241-6/+6
| | | | | | method #1823 [Stefan Kaes] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1915 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Add test for dynamic dispatch based on action_name accessor.Jeremy Kemper2005-07-071-0/+21
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1757 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Added some unit tests #706David Heinemeier Hansson2005-02-231-0/+36
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@775 5ecf4fe2-1ee6-0310-87b1-e25e094e27de