Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | prevent the cache sweeper ignores NoMethodError | ayaya | 2012-03-29 | 1 | -0/+7 |
| | |||||
* | Remove unused global variable in controller filters test | Alexey Vakhov | 2012-02-23 | 1 | -2/+0 |
| | |||||
* | Move render_to_body logic to return a spaced string to AC::Rendering | Carlos Antonio da Silva | 2012-01-17 | 1 | -2/+0 |
| | | | | | | | | | | | This seems to be required only when calling render :partial with an empty collection from a controller. This call happens to return no content, letting the response body empty, which means to Rails that it should go on and try to find a template to render based on the current action name, thus failing hard. Although tests keep all green, we need to check a better way to fix this. | ||||
* | Remove rescue_action from compatibility module and tests | Carlos Antonio da Silva | 2012-01-17 | 1 | -12/+0 |
| | |||||
* | get rid of using instance_variable_names method from AS | Sergey Nartimov | 2012-01-07 | 1 | -1/+1 |
| | | | | | - instance_variables return symbols in 1.9 - there is instance_variable_defined? method | ||||
* | Tests only after filters in cache sweepers | Jeroen Jacobs | 2011-06-22 | 1 | -0/+5 |
| | |||||
* | Fix filter :only and :except with implicit actions | Andrew White | 2011-03-23 | 1 | -11/+16 |
| | | | | | | | The method_name argument is "default_render" for implicit actions so use the action_name attribute to determine which callbacks to run. [#5673 state:resolved] | ||||
* | Add a failing test case for an implicit action with a before filter. | Manfred Stienstra | 2011-03-23 | 1 | -0/+22 |
| | | | | Signed-off-by: Andrew White <andyw@pixeltrix.co.uk> | ||||
* | cleaning up some warnings on 1.9.3 | Aaron Patterson | 2011-02-07 | 1 | -5/+5 |
| | |||||
* | Make after_filter halt when before_filter renders or redirects [#5648 ↵ | Marcelo Giorgi | 2010-11-11 | 1 | -2/+79 |
| | | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | fixing a few test warnings | Aaron Patterson | 2010-10-04 | 1 | -2/+2 |
| | |||||
* | We can't assign @view_context_class here, define super() in test instead if ↵ | Emilio Tagua | 2010-09-29 | 1 | -0/+1 |
| | | | | we want to avoid warnings. | ||||
* | Remove more warnings on AP. | Emilio Tagua | 2010-09-28 | 1 | -1/+1 |
| | |||||
* | Remove deprecated stuff in ActionController | Carlos Antonio da Silva | 2010-09-26 | 1 | -1/+2 |
| | | | | | | This removes all deprecated classes in ActionController related to Routing, Abstract Request/Response and Integration/IntegrationTest. All tests and docs were changed to ActionDispatch instead of ActionController. | ||||
* | Deletes trailing whitespaces (over text files only find * -type f -exec sed ↵ | Santiago Pastorino | 2010-08-14 | 1 | -1/+1 |
| | | | | 's/[ \t]*$//' -i {} \;) | ||||
* | Better test for ticket [#3914 state:resolved] | Neeraj Singh | 2010-06-09 | 1 | -0/+11 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | cache_sweeper yields blank output | Neeraj Singh | 2010-06-08 | 1 | -0/+6 |
| | | | | | | [#3914 state:open] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Use better assertion methods for testing | Neeraj Singh | 2010-05-19 | 1 | -7/+7 |
| | | | | | | [#4645 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Modify assert_template to use notifications. Also, remove ↵ | Carlhuda | 2010-03-17 | 1 | -2/+2 |
| | | | | ActionController::Base#template since it is no longer needed. | ||||
* | deOMGifying Railties, Active Support, and Action Pack | Mikel Lindsaar | 2010-01-31 | 1 | -3/+3 |
| | |||||
* | Symbol#to_proc is not needed for Ruby >= 1.8.7 | Xavier Noria | 2009-11-09 | 1 | -1/+0 |
| | |||||
* | Cleaning up more tests and code that needed to work in both old and new base | Yehuda Katz + Carl Lerche | 2009-06-17 | 1 | -50/+18 |
| | |||||
* | YAGNI Method references. Deprecated | Yehuda Katz | 2009-06-02 | 1 | -4/+6 |
| | |||||
* | Get all the callback tests to work on new base | Yehuda Katz + Carl Lerche | 2009-06-01 | 1 | -22/+46 |
| | |||||
* | Make sure tests pass action name to Controller.action() | Pratik Naik | 2009-05-30 | 1 | -1/+1 |
| | |||||
* | Added a compatibility layer to get legacy filter tests to pass on new base | Yehuda Katz + Carl Lerche | 2009-05-27 | 1 | -5/+27 |
| | |||||
* | Make Filter#filter work with around filters | Pratik Naik | 2009-05-25 | 1 | -59/+54 |
| | |||||
* | Cordon off missing filter methods | Jeremy Kemper | 2009-05-22 | 1 | -0/+8 |
| | |||||
* | Remove gratuitous filter_chain internal testing. Not part of the API and ↵ | Jeremy Kemper | 2009-05-22 | 1 | -25/+0 |
| | | | | other tests are sufficient to catch regressions. | ||||
* | Rescue hack was supposed to be removed. Some how it crept back in. | Joshua Peek | 2009-05-17 | 1 | -1/+0 |
| | |||||
* | Merge branch 'master' into wip_abstract_controller | Yehuda Katz + Carl Lerche | 2009-05-11 | 1 | -0/+5 |
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Conflicts: actionpack/lib/action_controller/abstract/callbacks.rb actionpack/lib/action_controller/abstract/renderer.rb actionpack/lib/action_controller/base/base.rb actionpack/lib/action_controller/dispatch/dispatcher.rb actionpack/lib/action_controller/routing/route_set.rb actionpack/lib/action_controller/testing/process.rb actionpack/test/abstract_controller/layouts_test.rb actionpack/test/controller/filters_test.rb actionpack/test/controller/helper_test.rb actionpack/test/controller/render_test.rb actionpack/test/new_base/test_helper.rb | ||||
| * | Extract ActionController rescue templates into Rescue and ShowExceptions ↵ | Joshua Peek | 2009-05-02 | 1 | -0/+5 |
| | | | | | | | | | | middleware. This commit breaks all exception catching plugins like ExceptionNotifier. These plugins should be rewritten as middleware instead overriding Controller#rescue_action_in_public. | ||||
| * | Deprecate Controller.process interface | Joshua Peek | 2009-05-02 | 1 | -1/+1 |
| | | |||||
* | | Implement FooController.action(:name) | Yehuda Katz | 2009-05-02 | 1 | -1/+2 |
|/ | | | | | | * Rails actions are now Rack endpoints, and can be retrieved via FooController.action(name) and called with an env * Updated some tests that relied on the old internal #process/#call implementation | ||||
* | Update some old tests to use AC TestProcess | Joshua Peek | 2009-04-30 | 1 | -12/+13 |
| | |||||
* | alias method chain process with test | Joshua Peek | 2009-04-30 | 1 | -2/+2 |
| | |||||
* | Deprecate template, session, assigns, and layout accessors on response ↵ | Joshua Peek | 2009-04-28 | 1 | -70/+107 |
| | | | | object. Instead access them through the controller instance. This mainly affects functional test assertions. | ||||
* | Include process methods in ActionController::TestCase only. No need to ↵ | Jeremy Kemper | 2009-01-07 | 1 | -2/+6 |
| | | | | alias_method_chain :process either. | ||||
* | Get rid of 'Object#send!'. It was originally added because it's in Ruby 1.9, ↵ | Jeremy Kemper | 2008-08-31 | 1 | -1/+1 |
| | | | | | | | | | | but it has since been removed from 1.9. Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> Conflicts: actionpack/test/controller/layout_test.rb | ||||
* | Move copying ivar logic from ActionController::Base to ActionView::Base | Pratik Naik | 2008-08-31 | 1 | -12/+12 |
| | |||||
* | Fix regression from filter refactoring where re-adding a skipped filter ↵ | Rick Olson | 2008-03-23 | 1 | -0/+33 |
| | | | | | | resulted in it being called twice. [rick] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@9080 5ecf4fe2-1ee6-0310-87b1-e25e094e27de | ||||
* | Refactor filters to use Active Support callbacks. Closes #11235. | Jeremy Kemper | 2008-03-18 | 1 | -15/+10 |
| | | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@9055 5ecf4fe2-1ee6-0310-87b1-e25e094e27de | ||||
* | Filter procs must take 1 or 2 arguments. Raise ArgumentError otherwise. | Jeremy Kemper | 2008-01-07 | 1 | -7/+4 |
| | | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8583 5ecf4fe2-1ee6-0310-87b1-e25e094e27de | ||||
* | require abstract_unit directly since test is in load path | Jeremy Kemper | 2008-01-05 | 1 | -1/+1 |
| | | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8564 5ecf4fe2-1ee6-0310-87b1-e25e094e27de | ||||
* | Note that filters test crashes Ruby 1.9 | Jeremy Kemper | 2007-12-15 | 1 | -0/+1 |
| | | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8408 5ecf4fe2-1ee6-0310-87b1-e25e094e27de | ||||
* | Changed before_filter halting to happen automatically on render or redirect ↵ | David Heinemeier Hansson | 2007-10-21 | 1 | -4/+6 |
| | | | | | | but no longer on simply returning false [DHH] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7984 5ecf4fe2-1ee6-0310-87b1-e25e094e27de | ||||
* | Ruby 1.9 compat, consistent load paths | Jeremy Kemper | 2007-10-02 | 1 | -1/+1 |
| | | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7719 5ecf4fe2-1ee6-0310-87b1-e25e094e27de | ||||
* | Remove deprecated functionality from actionpack. Closes #8958 [lifofifo] | Michael Koziarski | 2007-09-03 | 1 | -3/+3 |
| | | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7403 5ecf4fe2-1ee6-0310-87b1-e25e094e27de | ||||
* | Fix errors with around_filters which do not yield, restore 1.1 behaviour ↵ | Michael Koziarski | 2007-07-11 | 1 | -7/+73 |
| | | | | | | with after filters. Closes #8891 [skaes] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7177 5ecf4fe2-1ee6-0310-87b1-e25e094e27de | ||||
* | Rescuing in around_filters works as expected again [codahale, Stephan Kaes]. ↵ | Tobias Lütke | 2007-05-22 | 1 | -0/+35 |
| | | | | | | Closes #8341 git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6810 5ecf4fe2-1ee6-0310-87b1-e25e094e27de |