aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/test/controller/filters_test.rb
Commit message (Collapse)AuthorAgeFilesLines
* Remove unnecessary begin..rescue..end, use only rescueAkira Matsuda2013-01-061-5/+3
|
* Remove observers and sweepersRafael Mendonça França2012-11-281-41/+0
| | | | | | | | They was extracted from a plugin. See https://github.com/rails/rails-observers [Rafael Mendonça França + Steve Klabnik]
* AS::Callbacks: deprecate monkey patch of object callbacksBogdan Gusiev2012-09-071-7/+7
|
* Clean up Sweeper controller accessor when an Error is raisedBrian John2012-07-201-0/+11
|
* AS::Callbacks: deprecate monkey patch codeBogdan Gusiev2012-06-261-0/+12
| | | | | Deprecate usage of filter object with #before and #after methods as around callback
* prevent the cache sweeper ignores NoMethodErrorayaya2012-03-291-0/+7
|
* Remove unused global variable in controller filters testAlexey Vakhov2012-02-231-2/+0
|
* Move render_to_body logic to return a spaced string to AC::RenderingCarlos Antonio da Silva2012-01-171-2/+0
| | | | | | | | | | | This seems to be required only when calling render :partial with an empty collection from a controller. This call happens to return no content, letting the response body empty, which means to Rails that it should go on and try to find a template to render based on the current action name, thus failing hard. Although tests keep all green, we need to check a better way to fix this.
* Remove rescue_action from compatibility module and testsCarlos Antonio da Silva2012-01-171-12/+0
|
* get rid of using instance_variable_names method from ASSergey Nartimov2012-01-071-1/+1
| | | | | - instance_variables return symbols in 1.9 - there is instance_variable_defined? method
* Tests only after filters in cache sweepersJeroen Jacobs2011-06-221-0/+5
|
* Fix filter :only and :except with implicit actionsAndrew White2011-03-231-11/+16
| | | | | | | The method_name argument is "default_render" for implicit actions so use the action_name attribute to determine which callbacks to run. [#5673 state:resolved]
* Add a failing test case for an implicit action with a before filter.Manfred Stienstra2011-03-231-0/+22
| | | | Signed-off-by: Andrew White <andyw@pixeltrix.co.uk>
* cleaning up some warnings on 1.9.3Aaron Patterson2011-02-071-5/+5
|
* Make after_filter halt when before_filter renders or redirects [#5648 ↵Marcelo Giorgi2010-11-111-2/+79
| | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* fixing a few test warningsAaron Patterson2010-10-041-2/+2
|
* We can't assign @view_context_class here, define super() in test instead if ↵Emilio Tagua2010-09-291-0/+1
| | | | we want to avoid warnings.
* Remove more warnings on AP.Emilio Tagua2010-09-281-1/+1
|
* Remove deprecated stuff in ActionControllerCarlos Antonio da Silva2010-09-261-1/+2
| | | | | | This removes all deprecated classes in ActionController related to Routing, Abstract Request/Response and Integration/IntegrationTest. All tests and docs were changed to ActionDispatch instead of ActionController.
* Deletes trailing whitespaces (over text files only find * -type f -exec sed ↵Santiago Pastorino2010-08-141-1/+1
| | | | 's/[ \t]*$//' -i {} \;)
* Better test for ticket [#3914 state:resolved]Neeraj Singh2010-06-091-0/+11
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* cache_sweeper yields blank outputNeeraj Singh2010-06-081-0/+6
| | | | | | [#3914 state:open] Signed-off-by: José Valim <jose.valim@gmail.com>
* Use better assertion methods for testingNeeraj Singh2010-05-191-7/+7
| | | | | | [#4645 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* Modify assert_template to use notifications. Also, remove ↵Carlhuda2010-03-171-2/+2
| | | | ActionController::Base#template since it is no longer needed.
* deOMGifying Railties, Active Support, and Action PackMikel Lindsaar2010-01-311-3/+3
|
* Symbol#to_proc is not needed for Ruby >= 1.8.7Xavier Noria2009-11-091-1/+0
|
* Cleaning up more tests and code that needed to work in both old and new baseYehuda Katz + Carl Lerche2009-06-171-50/+18
|
* YAGNI Method references. DeprecatedYehuda Katz2009-06-021-4/+6
|
* Get all the callback tests to work on new baseYehuda Katz + Carl Lerche2009-06-011-22/+46
|
* Make sure tests pass action name to Controller.action()Pratik Naik2009-05-301-1/+1
|
* Added a compatibility layer to get legacy filter tests to pass on new baseYehuda Katz + Carl Lerche2009-05-271-5/+27
|
* Make Filter#filter work with around filtersPratik Naik2009-05-251-59/+54
|
* Cordon off missing filter methodsJeremy Kemper2009-05-221-0/+8
|
* Remove gratuitous filter_chain internal testing. Not part of the API and ↵Jeremy Kemper2009-05-221-25/+0
| | | | other tests are sufficient to catch regressions.
* Rescue hack was supposed to be removed. Some how it crept back in.Joshua Peek2009-05-171-1/+0
|
* Merge branch 'master' into wip_abstract_controllerYehuda Katz + Carl Lerche2009-05-111-0/+5
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | Conflicts: actionpack/lib/action_controller/abstract/callbacks.rb actionpack/lib/action_controller/abstract/renderer.rb actionpack/lib/action_controller/base/base.rb actionpack/lib/action_controller/dispatch/dispatcher.rb actionpack/lib/action_controller/routing/route_set.rb actionpack/lib/action_controller/testing/process.rb actionpack/test/abstract_controller/layouts_test.rb actionpack/test/controller/filters_test.rb actionpack/test/controller/helper_test.rb actionpack/test/controller/render_test.rb actionpack/test/new_base/test_helper.rb
| * Extract ActionController rescue templates into Rescue and ShowExceptions ↵Joshua Peek2009-05-021-0/+5
| | | | | | | | | | middleware. This commit breaks all exception catching plugins like ExceptionNotifier. These plugins should be rewritten as middleware instead overriding Controller#rescue_action_in_public.
| * Deprecate Controller.process interfaceJoshua Peek2009-05-021-1/+1
| |
* | Implement FooController.action(:name)Yehuda Katz2009-05-021-1/+2
|/ | | | | | * Rails actions are now Rack endpoints, and can be retrieved via FooController.action(name) and called with an env * Updated some tests that relied on the old internal #process/#call implementation
* Update some old tests to use AC TestProcessJoshua Peek2009-04-301-12/+13
|
* alias method chain process with testJoshua Peek2009-04-301-2/+2
|
* Deprecate template, session, assigns, and layout accessors on response ↵Joshua Peek2009-04-281-70/+107
| | | | object. Instead access them through the controller instance. This mainly affects functional test assertions.
* Include process methods in ActionController::TestCase only. No need to ↵Jeremy Kemper2009-01-071-2/+6
| | | | alias_method_chain :process either.
* Get rid of 'Object#send!'. It was originally added because it's in Ruby 1.9, ↵Jeremy Kemper2008-08-311-1/+1
| | | | | | | | | | but it has since been removed from 1.9. Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> Conflicts: actionpack/test/controller/layout_test.rb
* Move copying ivar logic from ActionController::Base to ActionView::BasePratik Naik2008-08-311-12/+12
|
* Fix regression from filter refactoring where re-adding a skipped filter ↵Rick Olson2008-03-231-0/+33
| | | | | | resulted in it being called twice. [rick] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@9080 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Refactor filters to use Active Support callbacks. Closes #11235.Jeremy Kemper2008-03-181-15/+10
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@9055 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Filter procs must take 1 or 2 arguments. Raise ArgumentError otherwise.Jeremy Kemper2008-01-071-7/+4
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8583 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* require abstract_unit directly since test is in load pathJeremy Kemper2008-01-051-1/+1
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8564 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Note that filters test crashes Ruby 1.9Jeremy Kemper2007-12-151-0/+1
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8408 5ecf4fe2-1ee6-0310-87b1-e25e094e27de