aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/test/controller/caching_test.rb
Commit message (Collapse)AuthorAgeFilesLines
* Fixed a bunch of tests that failed in 1.9 because they assumed that a Rack ↵wycats2010-03-191-3/+6
| | | | response was a String.
* All tests pass without memoizing view_contextCarlhuda2010-03-181-2/+6
|
* Some more tweaks on <% %>.Carlhuda2010-03-161-4/+4
| | | | * The cache helper is now semantically "mark this region for caching" * As a result, <% x = cache do %> no longer works
* Break a window :/Jeremy Kemper2010-03-151-1/+1
|
* Add deprecation notices for <% %>.Carlhuda2010-03-151-13/+2
| | | | | | | | | | | | | | | | * The approach is to compile <% %> into a method call that checks whether the value returned from a block is a String. If it is, it concats to the buffer and prints a deprecation warning. * <%= %> uses exactly the same logic to compile the template, which first checks to see whether it's compiling a block. * This should have no impact on other uses of block in templates. For instance, in <% [1,2,3].each do |i| %><%= i %><% end %>, the call to each returns an Array, not a String, so the result is not concatenated * In two cases (#capture and #cache), a String can be returned that should *never* be concatenated. We have temporarily created a String subclass called NonConcattingString which behaves (and is serialized) identically to String, but is not concatenated by the code that handles deprecated <% %> block helpers. Once we remove support for <% %> block helpers, we can remove NonConcattingString.
* read_ and write_fragment cache preserve html safety yet cache strings onlyJeremy Kemper2010-03-141-0/+13
|
* skip_relative_url_root url_for option is deadJoshua Peek2010-03-091-1/+1
|
* RouteSet#rewrite => url_forJoshua Peek2010-03-091-2/+2
|
* Move AC::UrlRewriter onto route setJoshua Peek2010-03-091-3/+2
|
* Get rid of the instance-level URL rewriterwycats2010-03-091-1/+1
|
* Refactor cache_store to use ActionController configCarlhuda2010-03-041-7/+14
|
* ActionController::Base.use_accept_header is not actually used anymore, so ↵Carl Lerche2010-03-031-3/+0
| | | | let's deprecate it.
* Fix tests for the request refactorCarl Lerche2010-03-031-1/+2
|
* If IntegrationSession is initialized with an objects that responds to ↵Carlhuda2010-02-261-1/+0
| | | | #routes, automatically extend the URL helpers from the RouteSet onto it
* Rename named_url_helpers to url_helpers and url_helpers to url_forCarlhuda2010-02-261-1/+1
|
* Rename metaclass to singleton_classCarlhuda2010-02-251-1/+1
|
* Fix all of AP's tests with the non global routerCarlhuda2010-02-251-2/+4
|
* For performance reasons, you can no longer call html_safe! on Strings. ↵Yehuda Katz2010-01-311-2/+2
| | | | | | | | | | | | Instead, all Strings are always not html_safe?. Instead, you can get a SafeBuffer from a String by calling #html_safe, which will SafeBuffer.new(self). * Additionally, instead of doing concat("</form>".html_safe), you can do safe_concat("</form>"), which will skip both the flag set, and the flag check. * For the first pass, I converted virtually all #html_safe!s to #html_safe, and the tests pass. A further optimization would be to try to use #safe_concat as much as possible, reducing the performance impact if we know up front that a String is safe.
* Add subscriber for ActionPack and move all logging inside it.José Valim2010-01-131-14/+0
|
* Ensure no notification is on the queue before running notifications related ↵José Valim2010-01-031-0/+2
| | | | tests.
* Use namespaces in notifications.José Valim2010-01-031-8/+6
|
* Remove ActionView inline logging to ActiveSupport::Notifications and create ↵José Valim2009-12-261-1/+1
| | | | ActionController::Base#log_event, so everything can be logged within one listener. Also expose log_process_action as a hook for different modules to include their own information during the action processing. This allow ActiveRecord to hook and any other ORM. Finally, this commit changes 'Processing' and 'Rendering' in logs to 'Processed' and 'Rendered' because at the point it's logged, everying already happened.
* More test portingJoshua Peek2009-12-081-4/+3
|
* Fix caching test to ensure notifications are all deliveredJeremy Kemper2009-12-011-0/+1
|
* Notifications: extract central Notifier, cordon off the internal Fanout ↵Jeremy Kemper2009-11-281-1/+3
| | | | implementation, and segregate instrumentation concerns
* Caching refactoringYehuda Katz2009-10-291-2/+6
|
* Renamed Orchestra to Notifications once again [#3321 state:resolved]José Valim2009-10-151-1/+1
|
* Instrument cache store events only if required.José Valim2009-10-151-1/+1
|
* Update Orchestra instrumentations and move part of logging to Orchestra.José Valim2009-10-151-8/+1
|
* Revert "Rename Orchestra to Notifications [#3321 state:resolved]"José Valim2009-10-151-2/+2
| | | | This reverts commit 8cbf825425dc8ad3770881ea4e100b9023c69ce2.
* Merge branch 'arel'Jeremy Kemper2009-10-141-6/+10
|\
| * Clarify AR dependencyJeremy Kemper2009-10-141-6/+10
| |
* | Rename Orchestra to Notifications [#3321 state:resolved]Joshua Peek2009-10-141-2/+2
|/
* Use with_routing helper in tests instead of modifying global route setJoshua Peek2009-10-031-11/+11
|
* Fixes Sam Ruby tests suite.José Valim2009-09-211-3/+2
| | | | Signed-off-by: Yehuda Katz <wycats@gmail.com>
* Add Orchestra instrumentation to fragment and page caching.José Valim2009-09-201-3/+8
|
* Make sure caching test is using a generatable urlJoshua Peek2009-09-191-2/+2
|
* Cleanup route reloading in tests. Prefer with_routing over using ↵Joshua Peek2009-08-161-3/+0
| | | | ActionController::Routing::Routes directly
* More perf work:Yehuda Katz2009-08-111-1/+0
| | | | | | | | | | | | | | * Move #set_cookie and #delete_cookie inline to optimize. These optimizations should almost certainly be sent back upstream to Rack. The optimization involves using an ivar for cookies instead of indexing into the headers each time. * Was able to use a bare Hash for headers now that cookies have their own joining semantics (some code assumed that the raw cookies were an Array). * Cache blankness of body on body= * Improve expand_cache_key for Arrays of a single element (common in our case) * Use a simple layout condition check unless conditions are used * Cache visible actions * Lazily load the UrlRewriter * Make etag an ivar that is set on prepare!
* Deprecate router generation "best match" sortingJoshua Peek2009-08-091-1/+1
|
* Fixes "Cached fragment hit" written to log even if fragment is not cached ↵Yehuda Katz2009-08-081-0/+15
| | | | (Erik Andrejko) [#2917 state:resolved]
* Added responds_to to new base.Yehuda Katz + Carl Lerche2009-05-201-0/+2
|
* Extract ActionController rescue templates into Rescue and ShowExceptions ↵Joshua Peek2009-05-021-0/+3
| | | | | middleware. This commit breaks all exception catching plugins like ExceptionNotifier. These plugins should be rewritten as middleware instead overriding Controller#rescue_action_in_public.
* Switch functional tests to run through the rack interface instead of processJoshua Peek2009-05-021-1/+1
|
* Fix action-cached exception responses.John F. Douthat2009-04-301-0/+35
| | | | | | | | Methods raising ActiveRecord::RecordNotFound were returning 404 on first request and 200 OK with blank body on subsequent requests. [#2533 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* Start moving TestRequest and TestResponse into ActionDispatchJoshua Peek2009-04-301-1/+1
|
* Bring abstract_controller up to date with rails/masterCarl Lerche & Yehuda Katz2009-04-131-14/+24
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Resolved all the conflicts since 2.3.0 -> HEAD. Following is a list of commits that could not be applied cleanly or are obviated with the abstract_controller refactor. They all need to be revisited to ensure that fixes made in 2.3 do not reappear in 3.0: 2259ecf368e6a6715966f69216e3ee86bf1a82a7 AR not available * This will be reimplemented with ActionORM or equivalent 06182ea02e92afad579998aa80144588e8865ac3 implicitly rendering a js response should not use the default layout [#1844 state:resolved] * This will be handled generically 893e9eb99504705419ad6edac14d00e71cef5f12 Improve view rendering performance in development mode and reinstate template recompiling in production [#1909 state:resolved] * We will need to reimplement rails-dev-boost on top of the refactor; the changes here are very implementation specific and cannot be cleanly applied. The following commits are implicated: 199e750d46c04970b5e7684998d09405648ecbd4 3942cb406e1d5db0ac00e03153809cc8dc4cc4db f8ea9f85d4f1e3e6f3b5d895bef6b013aa4b0690 e3b166aab37ddc2fbab030b146eb61713b91bf55 ae9f258e03c9fd5088da12c1c6cd216cc89a01f7 44423126c6f6133a1d9cf1d0832b527e8711d40f 0cb020b4d6d838025859bd60fb8151c8e21b8e84 workaround for picking layouts based on wrong view_paths [#1974 state:resolved] * The specifics of this commit no longer apply. Since it is a two-line commit, we will reimplement this change. 8c5cc66a831aadb159f3daaffa4208064c30af0e make action_controller/layouts pick templates from the current instance's view_paths instead of the class view_paths [#1974 state:resolved] * This does not apply at all. It should be trivial to apply the feature to the reimplemented ActionController::Base. 87e8b162463f13bd50d27398f020769460a770e3 fix HTML fallback for explicit templates [#2052 state:resolved] * There were a number of patches related to this that simply compounded each other. Basically none of them apply cleanly, and the underlying issue needs to be revisited. After discussing the underlying problem with Koz, we will defer these fixes for further discussion.
| * Ensure correct content type is declared after cache hits on actions with ↵Mislav Marohnić2009-03-101-0/+14
| | | | | | | | | | | | string cache keys [#1585 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
| * Bump mocha requirement for Ruby 1.9 compat. Remove uses_mocha.Jeremy Kemper2009-02-031-14/+10
| |
* | Temporarily modifies setup to call super directly. This can support more ↵Yehuda Katz and Carl Lerche2009-04-081-0/+4
|/ | | | T::U runners.
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-09 04:46:45 +0000