Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Removed deprecated RouteSet API, still many tests fail | Piotr Sarnacki | 2010-09-05 | 1 | -2/+2 |
| | |||||
* | Fixed double output from cache in no caching mode | David Heinemeier Hansson | 2010-06-08 | 1 | -15/+0 |
| | |||||
* | ActionCachingTestController rescues from all exceptions. Making sure that ↵ | Neeraj Singh | 2010-04-29 | 1 | -0/+31 |
| | | | | | | all the tests check for valid response. [#4468 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Make perform_caching work again, with the tests passing and backward compatible | Santiago Pastorino and Carl Lerche | 2010-04-15 | 1 | -10/+10 |
| | |||||
* | Consistent routing language | Joshua Peek | 2010-03-30 | 1 | -3/+3 |
| | |||||
* | Fixed a bunch of tests that failed in 1.9 because they assumed that a Rack ↵ | wycats | 2010-03-19 | 1 | -3/+6 |
| | | | | response was a String. | ||||
* | All tests pass without memoizing view_context | Carlhuda | 2010-03-18 | 1 | -2/+6 |
| | |||||
* | Some more tweaks on <% %>. | Carlhuda | 2010-03-16 | 1 | -4/+4 |
| | | | | * The cache helper is now semantically "mark this region for caching" * As a result, <% x = cache do %> no longer works | ||||
* | Break a window :/ | Jeremy Kemper | 2010-03-15 | 1 | -1/+1 |
| | |||||
* | Add deprecation notices for <% %>. | Carlhuda | 2010-03-15 | 1 | -13/+2 |
| | | | | | | | | | | | | | | | | * The approach is to compile <% %> into a method call that checks whether the value returned from a block is a String. If it is, it concats to the buffer and prints a deprecation warning. * <%= %> uses exactly the same logic to compile the template, which first checks to see whether it's compiling a block. * This should have no impact on other uses of block in templates. For instance, in <% [1,2,3].each do |i| %><%= i %><% end %>, the call to each returns an Array, not a String, so the result is not concatenated * In two cases (#capture and #cache), a String can be returned that should *never* be concatenated. We have temporarily created a String subclass called NonConcattingString which behaves (and is serialized) identically to String, but is not concatenated by the code that handles deprecated <% %> block helpers. Once we remove support for <% %> block helpers, we can remove NonConcattingString. | ||||
* | read_ and write_fragment cache preserve html safety yet cache strings only | Jeremy Kemper | 2010-03-14 | 1 | -0/+13 |
| | |||||
* | skip_relative_url_root url_for option is dead | Joshua Peek | 2010-03-09 | 1 | -1/+1 |
| | |||||
* | RouteSet#rewrite => url_for | Joshua Peek | 2010-03-09 | 1 | -2/+2 |
| | |||||
* | Move AC::UrlRewriter onto route set | Joshua Peek | 2010-03-09 | 1 | -3/+2 |
| | |||||
* | Get rid of the instance-level URL rewriter | wycats | 2010-03-09 | 1 | -1/+1 |
| | |||||
* | Refactor cache_store to use ActionController config | Carlhuda | 2010-03-04 | 1 | -7/+14 |
| | |||||
* | ActionController::Base.use_accept_header is not actually used anymore, so ↵ | Carl Lerche | 2010-03-03 | 1 | -3/+0 |
| | | | | let's deprecate it. | ||||
* | Fix tests for the request refactor | Carl Lerche | 2010-03-03 | 1 | -1/+2 |
| | |||||
* | If IntegrationSession is initialized with an objects that responds to ↵ | Carlhuda | 2010-02-26 | 1 | -1/+0 |
| | | | | #routes, automatically extend the URL helpers from the RouteSet onto it | ||||
* | Rename named_url_helpers to url_helpers and url_helpers to url_for | Carlhuda | 2010-02-26 | 1 | -1/+1 |
| | |||||
* | Rename metaclass to singleton_class | Carlhuda | 2010-02-25 | 1 | -1/+1 |
| | |||||
* | Fix all of AP's tests with the non global router | Carlhuda | 2010-02-25 | 1 | -2/+4 |
| | |||||
* | For performance reasons, you can no longer call html_safe! on Strings. ↵ | Yehuda Katz | 2010-01-31 | 1 | -2/+2 |
| | | | | | | | | | | | | Instead, all Strings are always not html_safe?. Instead, you can get a SafeBuffer from a String by calling #html_safe, which will SafeBuffer.new(self). * Additionally, instead of doing concat("</form>".html_safe), you can do safe_concat("</form>"), which will skip both the flag set, and the flag check. * For the first pass, I converted virtually all #html_safe!s to #html_safe, and the tests pass. A further optimization would be to try to use #safe_concat as much as possible, reducing the performance impact if we know up front that a String is safe. | ||||
* | Add subscriber for ActionPack and move all logging inside it. | José Valim | 2010-01-13 | 1 | -14/+0 |
| | |||||
* | Ensure no notification is on the queue before running notifications related ↵ | José Valim | 2010-01-03 | 1 | -0/+2 |
| | | | | tests. | ||||
* | Use namespaces in notifications. | José Valim | 2010-01-03 | 1 | -8/+6 |
| | |||||
* | Remove ActionView inline logging to ActiveSupport::Notifications and create ↵ | José Valim | 2009-12-26 | 1 | -1/+1 |
| | | | | ActionController::Base#log_event, so everything can be logged within one listener. Also expose log_process_action as a hook for different modules to include their own information during the action processing. This allow ActiveRecord to hook and any other ORM. Finally, this commit changes 'Processing' and 'Rendering' in logs to 'Processed' and 'Rendered' because at the point it's logged, everying already happened. | ||||
* | More test porting | Joshua Peek | 2009-12-08 | 1 | -4/+3 |
| | |||||
* | Fix caching test to ensure notifications are all delivered | Jeremy Kemper | 2009-12-01 | 1 | -0/+1 |
| | |||||
* | Notifications: extract central Notifier, cordon off the internal Fanout ↵ | Jeremy Kemper | 2009-11-28 | 1 | -1/+3 |
| | | | | implementation, and segregate instrumentation concerns | ||||
* | Caching refactoring | Yehuda Katz | 2009-10-29 | 1 | -2/+6 |
| | |||||
* | Renamed Orchestra to Notifications once again [#3321 state:resolved] | José Valim | 2009-10-15 | 1 | -1/+1 |
| | |||||
* | Instrument cache store events only if required. | José Valim | 2009-10-15 | 1 | -1/+1 |
| | |||||
* | Update Orchestra instrumentations and move part of logging to Orchestra. | José Valim | 2009-10-15 | 1 | -8/+1 |
| | |||||
* | Revert "Rename Orchestra to Notifications [#3321 state:resolved]" | José Valim | 2009-10-15 | 1 | -2/+2 |
| | | | | This reverts commit 8cbf825425dc8ad3770881ea4e100b9023c69ce2. | ||||
* | Merge branch 'arel' | Jeremy Kemper | 2009-10-14 | 1 | -6/+10 |
|\ | |||||
| * | Clarify AR dependency | Jeremy Kemper | 2009-10-14 | 1 | -6/+10 |
| | | |||||
* | | Rename Orchestra to Notifications [#3321 state:resolved] | Joshua Peek | 2009-10-14 | 1 | -2/+2 |
|/ | |||||
* | Use with_routing helper in tests instead of modifying global route set | Joshua Peek | 2009-10-03 | 1 | -11/+11 |
| | |||||
* | Fixes Sam Ruby tests suite. | José Valim | 2009-09-21 | 1 | -3/+2 |
| | | | | Signed-off-by: Yehuda Katz <wycats@gmail.com> | ||||
* | Add Orchestra instrumentation to fragment and page caching. | José Valim | 2009-09-20 | 1 | -3/+8 |
| | |||||
* | Make sure caching test is using a generatable url | Joshua Peek | 2009-09-19 | 1 | -2/+2 |
| | |||||
* | Cleanup route reloading in tests. Prefer with_routing over using ↵ | Joshua Peek | 2009-08-16 | 1 | -3/+0 |
| | | | | ActionController::Routing::Routes directly | ||||
* | More perf work: | Yehuda Katz | 2009-08-11 | 1 | -1/+0 |
| | | | | | | | | | | | | | | * Move #set_cookie and #delete_cookie inline to optimize. These optimizations should almost certainly be sent back upstream to Rack. The optimization involves using an ivar for cookies instead of indexing into the headers each time. * Was able to use a bare Hash for headers now that cookies have their own joining semantics (some code assumed that the raw cookies were an Array). * Cache blankness of body on body= * Improve expand_cache_key for Arrays of a single element (common in our case) * Use a simple layout condition check unless conditions are used * Cache visible actions * Lazily load the UrlRewriter * Make etag an ivar that is set on prepare! | ||||
* | Deprecate router generation "best match" sorting | Joshua Peek | 2009-08-09 | 1 | -1/+1 |
| | |||||
* | Fixes "Cached fragment hit" written to log even if fragment is not cached ↵ | Yehuda Katz | 2009-08-08 | 1 | -0/+15 |
| | | | | (Erik Andrejko) [#2917 state:resolved] | ||||
* | Added responds_to to new base. | Yehuda Katz + Carl Lerche | 2009-05-20 | 1 | -0/+2 |
| | |||||
* | Extract ActionController rescue templates into Rescue and ShowExceptions ↵ | Joshua Peek | 2009-05-02 | 1 | -0/+3 |
| | | | | | middleware. This commit breaks all exception catching plugins like ExceptionNotifier. These plugins should be rewritten as middleware instead overriding Controller#rescue_action_in_public. | ||||
* | Switch functional tests to run through the rack interface instead of process | Joshua Peek | 2009-05-02 | 1 | -1/+1 |
| | |||||
* | Fix action-cached exception responses. | John F. Douthat | 2009-04-30 | 1 | -0/+35 |
| | | | | | | | | Methods raising ActiveRecord::RecordNotFound were returning 404 on first request and 200 OK with blank body on subsequent requests. [#2533 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> |