Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Remove default match without specified method | Jose and Yehuda | 2012-04-24 | 1 | -7/+7 |
| | | | | | | | | | | | | | | | | In the current router DSL, using the +match+ DSL method will match all verbs for the path to the specified endpoint. In the vast majority of cases, people are currently using +match+ when they actually mean +get+. This introduces security implications. This commit disallows calling +match+ without an HTTP verb constraint by default. To explicitly match all verbs, this commit also adds a :via => :all option to +match+. Closes #5964 | ||||
* | default_url_options does not receive one argument anymore | Rafael Mendonça França | 2012-04-08 | 1 | -1/+1 |
| | |||||
* | Remove ActionController::TestCase#rescue_action_in_public! | Piotr Sarnacki | 2012-03-15 | 1 | -5/+0 |
| | | | | | | This method has no effect since exception handling was moved to middlewares and ActionController tests do not use any middlewares. | ||||
* | @controller already includes url_helpers in with_routing method | Santiago Pastorino | 2012-03-10 | 1 | -1/+0 |
| | |||||
* | Optimize url helpers. | Sergey Nartimov + José Valim | 2012-03-02 | 1 | -4/+4 |
| | |||||
* | Added unit test to cover changes to RouteSet.url_for | Ryan McGeary | 2012-02-07 | 1 | -0/+16 |
| | | | | | | | | | ActionDispatch::Routing::RouteSet.url_for now handles passing params through to ActionDispatch::Http::Url.url_for Conflicts: actionpack/test/controller/base_test.rb | ||||
* | Do not deprecate performed. | José Valim | 2012-01-19 | 1 | -0/+6 |
| | |||||
* | Remove method missing handling when action is not found, use action missing ↵ | Carlos Antonio da Silva | 2012-01-17 | 1 | -45/+0 |
| | | | | | | | instead Do not create a method_missing method to handle not found actions, use the action_missing method provided by Rails instead. | ||||
* | Remove other old compatibility constants | Carlos Antonio da Silva | 2012-01-17 | 1 | -2/+2 |
| | |||||
* | AP tests should inherit from AS::TestCase | Aaron Patterson | 2012-01-05 | 1 | -1/+1 |
| | |||||
* | Moving to logger methods to ActiveSupport Logger | Karunakar (Ruby) | 2011-12-24 | 1 | -2/+2 |
| | |||||
* | Removed deprecated RouteSet API, still many tests fail | Piotr Sarnacki | 2010-09-05 | 1 | -1/+1 |
| | |||||
* | Remove deprecated support to <% form_for %> and several ↵ | José Valim | 2010-08-29 | 1 | -14/+0 |
| | | | | ActionController::Base methods. | ||||
* | Deletes trailing whitespaces (over text files only find * -type f -exec sed ↵ | Santiago Pastorino | 2010-08-14 | 1 | -6/+6 |
| | | | | 's/[ \t]*$//' -i {} \;) | ||||
* | Move Rails module to abstract_unit to make test in isolation work | Santiago Pastorino | 2010-06-28 | 1 | -3/+0 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Missing method error doesn't specify which controller it is missing from ↵ | Alan Harper | 2010-06-10 | 1 | -1/+10 |
| | | | | | | | | | [#4436 state:resolved] The error page shown when the method you are requesting on a controller doesn't specify which controller the method is missing from Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Tests method_missing to raise NameError. [#2522 state:resolved] | Rizwan Reza | 2010-03-27 | 1 | -0/+16 |
| | | | Signed-off-by: wycats <wycats@gmail.com> | ||||
* | Current url helpers become actions in controller. Added a failing test case ↵ | José Valim | 2010-03-22 | 1 | -6/+17 |
| | | | | for it. | ||||
* | Reinstate dom_id in controllers. | Justin Ko | 2010-03-09 | 1 | -0/+8 |
| | | | | | | | [#3040 state:committed] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | Reinstate default_url_options and remove url_options= writer | Jeremy Kemper | 2010-03-08 | 1 | -23/+19 |
| | |||||
* | Silence test deprecation warnings | Carlhuda | 2010-02-26 | 1 | -16/+55 |
| | |||||
* | Fix controller_path returnsing an empty string in Ruby 1.8.7 [#4036 ↵ | José Valim | 2010-02-26 | 1 | -0/+9 |
| | | | | status:resolved] | ||||
* | Continued effort to deglobalize the router | Carlhuda | 2010-02-25 | 1 | -0/+1 |
| | |||||
* | WIP: Remove the global router | Carlhuda | 2010-02-25 | 1 | -1/+3 |
| | |||||
* | Make filter parameters based on request, so they can be modified for ↵ | José Valim | 2010-01-21 | 1 | -2/+19 |
| | | | | anything in the middleware stack. | ||||
* | Ensure that segments in default_url_options also work with format specified. | José Valim | 2010-01-07 | 1 | -0/+8 |
| | |||||
* | From now on, parameters defined in default_url_options can be absent from ↵ | José Valim | 2010-01-07 | 1 | -43/+36 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | named routes. This allows the following setup to work: # app/controllers/application_controller.rb class ApplicationController def default_url_options(options=nil) { :locale => I18n.locale } end end # From your views and controllers: I18n.locale #=> :en users_url #=> "/en/users" users_url(:pl) #=> "/pl/users" user_url(1) #=> "/en/users/1" user_url(:pl, 1) #=> "/pl/users/1" user_url(1, :locale => :pl) #=> "/pl/users/1" If you provide all expected parameters, it still works as previously. But if any parameter is missing, it tries to assign all possible ones with the hash returned in default_url_options or the one passed straight to the named route method. Beware that default_url_options in ApplicationController is not shared with ActionMailer, so you are required to always give the locale in your email views. | ||||
* | Remove duplicated url_for code and move methods shared between ActionMailer ↵ | José Valim | 2010-01-07 | 1 | -1/+0 |
| | | | | and ActionController up to AbstractController. | ||||
* | Remove ActionView inline logging to ActiveSupport::Notifications and create ↵ | José Valim | 2009-12-26 | 1 | -7/+0 |
| | | | | ActionController::Base#log_event, so everything can be logged within one listener. Also expose log_process_action as a hook for different modules to include their own information during the action processing. This allow ActiveRecord to hook and any other ORM. Finally, this commit changes 'Processing' and 'Rendering' in logs to 'Processed' and 'Rendered' because at the point it's logged, everying already happened. | ||||
* | Use new routing dsl in tests | Joshua Peek | 2009-12-08 | 1 | -3/+3 |
| | |||||
* | Start rewriting some internal tests to use the new routing dsl | Joshua Peek | 2009-10-20 | 1 | -12/+12 |
| | |||||
* | Cleanup route reloading in tests. Prefer with_routing over using ↵ | Joshua Peek | 2009-08-16 | 1 | -17/+17 |
| | | | | ActionController::Routing::Routes directly | ||||
* | Cleaning up more tests and code that needed to work in both old and new base | Yehuda Katz + Carl Lerche | 2009-06-17 | 1 | -5/+1 |
| | |||||
* | Document and clean up HideActions and Http | Yehuda Katz + Carl Lerche | 2009-06-10 | 1 | -3/+8 |
| | |||||
* | Got new base to pass controller/base_test.rb, implemented method_missing ↵ | Yehuda Katz + Carl Lerche | 2009-05-14 | 1 | -1/+1 |
| | | | | action semantics in compatibility mode, and fixed a few action_missing bugs. | ||||
* | Cherry-pick core extensions | Jeremy Kemper | 2009-05-13 | 1 | -0/+1 |
| | |||||
* | Extract ActionController rescue templates into Rescue and ShowExceptions ↵ | Joshua Peek | 2009-05-02 | 1 | -5/+4 |
| | | | | | middleware. This commit breaks all exception catching plugins like ExceptionNotifier. These plugins should be rewritten as middleware instead overriding Controller#rescue_action_in_public. | ||||
* | Updated old AC::Base for small changes to AV | Yehuda Katz and Carl Lerche | 2009-04-08 | 1 | -0/+2 |
| | |||||
* | Include process methods in ActionController::TestCase only. No need to ↵ | Jeremy Kemper | 2009-01-09 | 1 | -12/+10 |
| | | | | alias_method_chain :process either. | ||||
* | Move controller assertions from base TestCase to AC:: and AV::TestCase | Jeremy Kemper | 2008-11-07 | 1 | -1/+1 |
| | |||||
* | Get rid of 'Object#send!'. It was originally added because it's in Ruby 1.9, ↵ | Jeremy Kemper | 2008-08-31 | 1 | -4/+4 |
| | | | | | | | | | | but it has since been removed from 1.9. Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> Conflicts: actionpack/test/controller/layout_test.rb | ||||
* | Use fully-qualified controller name when logging. [#600 state:resolved] | Ripta Pasay | 2008-07-17 | 1 | -0/+20 |
| | | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | Fix url_for with no arguments when default_url_options is not explicitly ↵ | Luke Redpath | 2008-06-17 | 1 | -1/+17 |
| | | | | | | defined. [#339 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | regression test for bug introduced in ↵ | rick | 2008-05-05 | 1 | -0/+13 |
| | | | | [6a6b4392c16c665eb713705f2b38e959a658eeef] [Ian White] [#22 state:resolved] | ||||
* | Allow ActionController::Base#default_url_options to have a default options ↵ | Cheah Chu Yeow | 2008-05-05 | 1 | -1/+1 |
| | | | | | | argument of nil. This fixes a bug introduced in [6a6b4392c16c665eb713705f2b38e959a658eeef] which was breaking routing in ActionController::UrlWriter. | ||||
* | Ensure that default_url_options, if defined, are used in named routes. | Cheah Chu Yeow | 2008-05-04 | 1 | -0/+34 |
| | | | | | | Signed-off-by: Michael Koziarski <michael@koziarski.com> [#22 state:resolved] | ||||
* | require abstract_unit directly since test is in load path | Jeremy Kemper | 2008-01-05 | 1 | -2/+1 |
| | | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8564 5ecf4fe2-1ee6-0310-87b1-e25e094e27de | ||||
* | Fixup mocha tests for 0.5.6. Closes #10602 [murphy, mikong] | Jeremy Kemper | 2007-12-29 | 1 | -1/+4 |
| | | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8508 5ecf4fe2-1ee6-0310-87b1-e25e094e27de | ||||
* | Ruby 1.9 compat, consistent load paths | Jeremy Kemper | 2007-10-02 | 1 | -4/+4 |
| | | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7719 5ecf4fe2-1ee6-0310-87b1-e25e094e27de | ||||
* | Mocha 0.4 mixes in more public instance methods, confusing controller ↵ | Jeremy Kemper | 2007-01-24 | 1 | -10/+8 |
| | | | | | | identification of action methods. Closes #7347. git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6030 5ecf4fe2-1ee6-0310-87b1-e25e094e27de |