Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Expectations first | Akira Matsuda | 2014-08-18 | 1 | -7/+7 |
| | |||||
* | Merge branch 'master' into loofah | Rafael Mendonça França | 2014-08-17 | 1 | -0/+23 |
|\ | | | | | | | | | Conflicts: actionpack/CHANGELOG.md | ||||
| * | Fix assert_template for files. | Guo Xiang Tan | 2014-08-14 | 1 | -0/+23 |
| | | | | | | | | | | The test was not failing for `assert_template file: nil` when a file has been rendered. | ||||
* | | Removed require's for html-scanner. | Timm | 2014-06-16 | 1 | -1/+0 |
| | | |||||
* | | Removed tag.rb since it has been deprecated. | Timm | 2014-06-15 | 1 | -5/+0 |
|/ | |||||
* | Prefer assert_raise instead of flunk + rescue to test for exceptions | Carlos Antonio da Silva | 2013-12-19 | 1 | -10/+6 |
| | | | | | | Change most tests to make use of assert_raise returning the raised exception rather than relying on a combination of flunk + rescue to check for exception types/messages. | ||||
* | Fix incorrect assert_redirected_to failure message | Derek Prior | 2013-09-19 | 1 | -0/+18 |
| | | | | | | | | | | | | | | | In some instances, `assert_redirected_to` assertion was returning an incorrect and misleading failure message when the assertion failed. This was due to a disconnect in how the assertion computes the redirect string for the failure message and how `redirect_to` computes the string that is actually used for redirection. I made the `_compute_redirect_to_loaction` method used by `redirect_to` public and call that from the method `assert_redirect_to` uses to calculate the URL. The reveals a new test failure due to the regex used by `_compute_redirect_to_location` allow `_` in the URL scheme. | ||||
* | Fix warnings | Carlos Antonio da Silva | 2013-03-07 | 1 | -2/+2 |
| | |||||
* | Allow use of assert_template with the :file option. | Justin Coyne | 2013-03-01 | 1 | -0/+35 |
| | | | | This worked in Rails 3.2, but was a regression in 4.0.0.beta1 | ||||
* | deprecate `assert_blank` and `assert_present`. | Yves Senn | 2013-01-05 | 1 | -1/+1 |
| | | | | | They don't add any benefits over `assert object.blank?` and `assert object.present?` | ||||
* | assert_template: validating option keys | Roberto Soares | 2012-11-25 | 1 | -0/+6 |
| | |||||
* | `assert_template` fails with empty string. | Roberto Soares | 2012-11-23 | 1 | -0/+7 |
| | |||||
* | `assert_template` fails with empty string when a template has been rendered | Roberto Soares | 2012-11-23 | 1 | -0/+7 |
| | | | | | | | | For instance, it prevents false positive in this case: file = nil get :index assert_template("#{file}") | ||||
* | `assert_template` no more passing with what ever string that matches. | Hugo Roque | 2012-09-29 | 1 | -0/+22 |
| | | | | | | | | | | | | | | | | | | | | | | | Given Im rendering an template `/layout/hello.html.erb`, assert_template was passing with any string that matches. This behavior allowed false passing like: assert_template "layout" assert_template "out/hello" Now the passing possibilities are: assert_template "layout/hello" assert_template "hello" fixing assert_template bug when template matches expected, but not ends with Cherry Pick Merge: Fixes issue #3849 assert_template false positive taking redundant test off prevening incorrect assert_template when rendering with repeated names in path updating CHANGELOG with bugfix: assert_template false passing | ||||
* | Move action_controller/vendor/html-scanner to action_view | Piotr Sarnacki | 2012-08-28 | 1 | -1/+1 |
| | | | | | | This is another step in moving Action View's dependencies in Action Pack to Action View itself. Also, HtmlScanner seems to be better suited for views rather than controllers. | ||||
* | Improve assert_template layout checking | Alexey Vakhov | 2012-05-04 | 1 | -0/+15 |
| | |||||
* | Fix assert_template :layout => nil assertion | Alexey Vakhov | 2012-05-04 | 1 | -0/+12 |
| | |||||
* | Fix assert_template assertion with :layout option | Alexey Vakhov | 2012-05-04 | 1 | -0/+10 |
| | |||||
* | Allows assert_redirected_to to accept a regular expression | Andy Lindeman | 2012-05-03 | 1 | -0/+4 |
| | |||||
* | Remove default match without specified method | Jose and Yehuda | 2012-04-24 | 1 | -10/+10 |
| | | | | | | | | | | | | | | | | In the current router DSL, using the +match+ DSL method will match all verbs for the path to the specified endpoint. In the vast majority of cases, people are currently using +match+ when they actually mean +get+. This introduces security implications. This commit disallows calling +match+ without an HTTP verb constraint by default. To explicitly match all verbs, this commit also adds a :via => :all option to +match+. Closes #5964 | ||||
* | Remove deprecation warning from test related to old process api | Carlos Antonio da Silva | 2012-01-06 | 1 | -1/+1 |
| | |||||
* | Revert "remove deprecated API" | Aaron Patterson | 2012-01-05 | 1 | -1/+1 |
| | | | | This reverts commit f53c247d10acbaacb0d61824cfce888c4b0520d2. | ||||
* | remove deprecated API | Aaron Patterson | 2012-01-05 | 1 | -1/+1 |
| | |||||
* | Clean up routes inclusion and add some comments for the next soul that ↵ | José Valim | 2012-01-03 | 1 | -14/+0 |
| | | | | decides to adventure on this code. | ||||
* | be explicit about where helpers are installed | Aaron Patterson | 2011-12-30 | 1 | -1/+1 |
| | |||||
* | warning removed "warning: instance variable @variable_for_layout not ↵ | Arun Agrawal | 2011-12-17 | 1 | -0/+1 |
| | | | | initialized" | ||||
* | Fix bug in assert_template when using only `:layout` option | Prem Sichanugrist | 2011-12-06 | 1 | -0/+16 |
| | | | | | | | | | | Currently if you're do this: assert_template :layout => "foo" Regardless of what layout you were using, the test will always pass. This was broken since the introduction of :layout option in [d9375f3f]. We have a lot of test cases in actionpack/test/controller/layout_test.rb that use this feature. This will make sure that those test cases are not true negative. | ||||
* | remove unused user_controller from test | Neeraj Singh | 2011-06-08 | 1 | -3/+0 |
| | |||||
* | fix warning during test execution | Neeraj Singh | 2010-11-17 | 1 | -1/+1 |
| | | | | | | [#5997 state:resolved] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | make sure we are only doing sanity checking against regular expressions | Aaron Patterson | 2010-11-15 | 1 | -0/+8 |
| | |||||
* | Reset assert_template instance variables between requests [#5832 state:resolved] | Andrew White | 2010-10-18 | 1 | -0/+8 |
| | |||||
* | _ is not a valid scheme name character, \w includes it and also is redundant ↵ | Emilio Tagua | 2010-09-29 | 1 | -0/+7 |
| | | | | | | with \d. 'The scheme name consists of a letter followed by any combination of letters, digits, and the plus ("+"), period ("."), or hyphen ("-") characters; and is terminated by a colon (":").' | ||||
* | Use instance_variable_defined? instead instance_variable_get in tests. | Emilio Tagua | 2010-09-28 | 1 | -2/+2 |
| | |||||
* | Use parentheses when using assert_match followed by a regexp to avoid warnings. | Emilio Tagua | 2010-09-27 | 1 | -1/+1 |
| | |||||
* | Cleanup Action Dispatch assertions tests | Carlos Antonio da Silva | 2010-09-06 | 1 | -108/+37 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Cleanup deprecations in Action Dispatch | Carlos Antonio da Silva | 2010-09-06 | 1 | -21/+6 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Removed deprecated RouteSet API, still many tests fail | Piotr Sarnacki | 2010-09-05 | 1 | -11/+8 |
| | |||||
* | Remove assert_valid. It was already deprecated on Rails 2.3. | José Valim | 2010-07-19 | 1 | -15/+0 |
| | |||||
* | move assert_template tests to their own test case [#4501 state:resolved] | David Chelimsky | 2010-05-03 | 1 | -41/+46 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Eliminate false positives when passing symbols to assert_template | David Chelimsky | 2010-05-03 | 1 | -4/+25 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Modify assert_template to use notifications. Also, remove ↵ | Carlhuda | 2010-03-17 | 1 | -3/+5 |
| | | | | ActionController::Base#template since it is no longer needed. | ||||
* | Remove unneeded AV::Base and AV::Template monkey-patches | Carlhuda | 2010-03-17 | 1 | -3/+2 |
| | |||||
* | No longer add missing leading / on path args to assert_redirected_to. ↵ | Jeremy Kemper | 2010-03-02 | 1 | -2/+4 |
| | | | | Deprecated in 2.3.6. | ||||
* | Remove implicit controller namespacing from new dsl | Joshua Peek | 2010-02-28 | 1 | -3/+6 |
| | |||||
* | WIP: Remove the global router | Carlhuda | 2010-02-25 | 1 | -3/+6 |
| | |||||
* | Use new routing dsl in tests | Joshua Peek | 2009-12-08 | 1 | -11/+11 |
| | |||||
* | Fix isolated running of ActionPackAssertionTest | Joshua Peek | 2009-09-06 | 1 | -0/+1 |
| | |||||
* | Track all AC base subclasses as possible controllers for internal testing | Joshua Peek | 2009-08-25 | 1 | -8/+0 |
| | |||||
* | Cleanup route reloading in tests. Prefer with_routing over using ↵ | Joshua Peek | 2009-08-16 | 1 | -6/+2 |
| | | | | ActionController::Routing::Routes directly | ||||
* | Fix pending test about content-type | Yehuda Katz + Carl Lerche | 2009-06-17 | 1 | -5/+19 |
| |