aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/test/abstract_unit.rb
Commit message (Collapse)AuthorAgeFilesLines
* mostly remove the ParamsParser middlewareAaron Patterson2015-09-181-1/+0
| | | | | This can still be added to the middleware stack, but is really not necessary. I'll follow up with a commit that deprecates the constant
* Remove mocha from ActionPack testsMarcin Olichwirowicz2015-09-051-1/+0
|
* provide a request and response to all controllersAaron Patterson2015-08-251-2/+6
| | | | | | | | | | Controllers should always have a request and response when responding. Since we make this The Rule(tm), then controllers don't need to be somewhere in limbo between "asking a response object for a rack response" or "I, myself contain a rack response". This duality leads to conditionals spread through the codebase that we can delete: * https://github.com/rails/rails/blob/85a78d9358aa728298cd020cdc842b55c16f9549/actionpack/lib/action_controller/metal.rb#L221-L223
* adding a direct dispatch method to controller classesAaron Patterson2015-08-251-8/+2
| | | | This saves a lambda and request allocation on each request.
* Merge pull request #21368 from rodzyn/remove_mochaKasper Timm Hansen2015-08-251-1/+7
|\ | | | | Get rid of mocha tests in actionpack - part 2
| * Get rid of mocha tests - part 2Marcin Olichwirowicz2015-08-251-1/+7
| |
* | Merge pull request #21345 from aditya-kapoor/trim-apRafael Mendonça França2015-08-251-2/+0
|\ \ | | | | | | Trim out least needed controllers from AP test suite
| * | Trim out unneeded controllers from AP test suiteAditya Kapoor2015-08-241-2/+0
| | |
* | | remove dead code :bomb:Aaron Patterson2015-08-241-2/+0
| | |
* | | subclass and delegate rather than mutating existing objectsAaron Patterson2015-08-241-12/+29
| | | | | | | | | | | | | | | If we subclass and augment the superclass, then we don't need to have setters for particular things on the superclass.
* | | temp files are no more requireGaurav Sharma2015-08-251-1/+0
| | | | | | | | | `:nail_care:`
* | | use a custom request class to determine the controller classAaron Patterson2015-08-241-23/+21
| |/ |/| | | | | | | | | controller class resolution has been moved to the request object, so we should override that method instead of relying on the RouteSet to generate the controller class.
* | Merge pull request #21321 from rodzyn/removing_mochaKasper Timm Hansen2015-08-241-0/+1
|\ \ | |/ |/| Get rid of mocha tests in actionpack - part 1
| * Get rid of mocha tests - part 1Marcin Olichwirowicz2015-08-241-0/+1
| |
* | Refactor to remove controller class from route to requesteileencodes2015-08-221-1/+1
|/ | | | | | | | | | This refactoring moves the controller class name that was on the route set to the request. The purpose of this refactoring is for changes we need to move controller tests to integration tests, mainly being able to access the controller on the request instead of having to go through the router. [Eileen M. Uchitelle & Aaron Patterson]
* Merge pull request #11352 from xaviershay/dispatcher-apiRafael Mendonça França2015-08-081-8/+4
|\ | | | | Allow a custom dispatcher to be provided to routing.
| * Allow a custom dispatcher to be provided to routing.Xavier Shay2015-08-071-8/+4
| |
* | Refactor to remove DrawOnce moduleeileencodes2015-08-081-27/+8
|/ | | | | | We were doing extra work that could be pushed off to Integration test and SharedRoutes. Creating an extra module isn't necessary when those are created by their respective classes.
* Using strings or symbols for middleware class names is deprecated.Aaron Patterson2015-08-071-7/+7
| | | | | | | | | | Convert things like this: middleware.use "Foo::Bar" to this: middleware.use Foo::Bar
* Add ActionController API functionalitySantiago Pastorino2015-06-111-0/+4
|
* Deprecate `:nothing` option for render methodMehmet Emin İNAÇ2015-05-281-1/+1
| | | | `head` method works similar to `render` method with `:nothing` option
* wrap "require 'drb/unix'" by bgin-end at test/abstract_unit.rbToshi MARUYAMA2015-04-091-1/+5
| | | | | | Related: #19617, #19187, #19533, #19689, #19675. 'drb/unix' does not exist on mingw.
* Revert "Merge pull request #19404 from dmathieu/remove_rack_env"Jeremy Kemper2015-03-201-1/+1
| | | | | | | Preserving RACK_ENV behavior. This reverts commit 7bdc7635b885e473f6a577264fd8efad1c02174f, reversing changes made to 45786be516e13d55a1fca9a4abaddd5781209103.
* don't fallback to RACK_ENV when RAILS_ENV is not presentDamien Mathieu2015-03-191-1/+1
|
* Run ActionPack test cases in random order.Guo Xiang Tan2015-03-061-5/+0
|
* Avoid parallelizing Action Pack's tests on RubiniusRobin Dupret2015-03-021-2/+2
| | | | | | | | | | Since the `ForkingExecutor` class seems to be pretty slow on Rubinius due to DRb (c.f. http://git.io/xIVg), let's avoid running tests with it on this platform. Also, the `parallelize_me!` call make the suite to output a bunch of errors due to rubinius/rubinius#2934 since there are thread-safety problems with autoloading.
* Removing old helper that was necessary for compatibility with Ruby 1.8.xThiago Pradi2015-02-221-13/+0
|
* Removing unused constants from abstract_unitThiago Pradi2015-02-221-2/+0
|
* Removing unused controller from abstract_unitThiago Pradi2015-02-221-16/+0
|
* Merge pull request #17862 from lucasmazza/lm-hide-actionRafael Mendonça França2014-12-021-1/+2
| | | | `_generate_paths_by_default` should always be private.
* Pass symbol as an argument instead of a blockErik Michaels-Ober2014-11-291-1/+1
|
* Remove session to allow `with_routing` to be called twice.Guo Xiang Tan2014-11-051-0/+1
| | | | Fixes: https://github.com/rails/rails/issues/16814
* Default to sorting user's test cases for nowGodfrey Chan2014-09-081-1/+1
| | | | | | | | | | | Goals: 1. Default to :random for newly generated applications 2. Default to :sorted for existing applications with a warning 3. Only show the warning once 4. Only show the warning if the app actually uses AS::TestCase Fixes #16769
* Leave all our tests as order_dependent! for nowMatthew Draper2014-09-021-0/+5
| | | | | | | | | We're seeing too many failures to believe otherwise. This reverts commits bc116a55ca3dd9f63a1f1ca7ade3623885adcc57, cbde413df3839e06dd14e3c220e9800af91e83ab, bf0a67931dd8e58f6f878b9510ae818ae1f29a3a, and 2440933fe2c27b27bcafcd9019717800db2641aa.
* Use system /tmp when testing actionpackAgis-2014-08-221-3/+1
| | | | | | | | | | | | | | https://github.com/rails/rails/commit/c64bff2c87ebf363703c63ecd4a96d56a1a78364 added support and enabled parallel execution of the actionpack tests. However it introduced https://github.com/rails/rails/commit/c64bff2c87ebf363703c63ecd4a96d56a1a78364 since one cannot connect to a socket file that's inside a Vagrant synced folder due to security restrictions, and DRb tries to. Also rename the temporary files to make it obvious that they're rails-related, since now they're placed outside the project's directory. Fixes https://github.com/rails/rails/commit/c64bff2c87ebf363703c63ecd4a96d56a1a78364
* UnexpectedErrors may reference exceptions that can't be dumpedAaron Patterson2014-08-131-0/+17
| | | | | | UnexpectedError exceptions wrap the original exception, and the original exception may contain a reference to something that can't be marshal dumped which will cause the process to die.
* AM, AP, AV, and AMo tests are already order_independent!Akira Matsuda2014-08-131-5/+0
|
* Nobody sucks so nobody should call this awful method nameRafael Mendonça França2014-08-121-1/+1
|
* users_dont_suck_but_only_we_suck_and_only_our_tests_are_order_dependent!Akira Matsuda2014-08-121-0/+5
| | | | | Calling ActiveSupport::TestCase.i_suck_and_my_tests_are_order_dependent! in AS::TestCase makes everyone's tests order dependent, which should never be done by the framework.
* Use PROCESS_COUNT to define the number of parallel executorsRafael Mendonça França2014-07-231-1/+1
|
* specify N=0 to prevent parallel tests (just run tests on the main process)Aaron Patterson2014-07-231-2/+6
|
* Merge branch 'rm-remove-mocha'Rafael Mendonça França2014-07-191-0/+2
|\ | | | | | | | | Conflicts: actionpack/test/abstract_unit.rb
| * Stop requiring mocha automaticallyRafael Mendonça França2014-07-191-0/+2
| | | | | | | | | | | | | | | | | | | | | | We are planning to remove mocha from our test suite because of performance problems. To make this possible we should stop require mocha on ActionSupport::TestCase. This should not affect applications since users still need to add mocha to Gemfile and this already load mocha. Added FIXME notes to place that still need mocha removal
* | reporting is only done in one thread, so we can safely remove the lockAaron Patterson2014-07-171-1/+1
| | | | | | | | (I think)
* | pass the test reporter by referenceAaron Patterson2014-07-171-1/+4
| | | | | | | | | | | | this prevents the array from being dumped as a DRbObject so we can reduce communication with the server. the reporter should always exist on the server side, so we don't have to worry about GC
* | do not restart the service, just stop itAaron Patterson2014-07-171-1/+0
| |
* | only parallelize on forking systemsAaron Patterson2014-07-171-1/+1
| |
* | [EXPERIMENTAL] run actionpack tests in parallelAaron Patterson2014-07-171-0/+57
| | | | | | | | | | only on forking systems though. Feel free to revert this if it causes problems.
* | pass the route name to define_url_helperAaron Patterson2014-07-171-1/+2
| | | | | | | | | | this allows us to avoid 2 hash allocations per named helper definition, also we can avoid a `merge` and `delete`.
* | Fix 1.9. uggghhhhhh get it together @tenderlove :bomb:Aaron Patterson2014-07-151-2/+2
| |