aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/test/abstract
Commit message (Collapse)AuthorAgeFilesLines
* Move abstract's controller tests to AVŁukasz Strzałkowski2013-08-2514-886/+0
| | | | The ones that were actually testing AV functionality and should belong in there
* Create AbstractController::Rendering interfaceŁukasz Strzałkowski2013-08-254-1/+5
| | | | This interface should be use when implementing renderers.
* Fix AP test suite after moving stuff to AVŁukasz Strzałkowski2013-08-254-6/+6
|
* add test-case to verify `error.path` when a helper was not found.Yves Senn2013-07-121-0/+5
| | | | | This verifies the code added with: https://github.com/rails/rails/commit/99c9d18601539c7e7e87f26bb047add1f93072af
* move `MissingHelperError` out of the `ClassMethods` module.Yves Senn2013-07-121-1/+1
|
* Remove accidentally committed vi .swp file.Marc Schütz2013-07-101-0/+0
|
* Show real LoadError on helpers requirePiotr Niełacny2013-07-102-0/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | When helper try to require missing file rails will throw exception about missing helper. # app/helpers/my_helper.rb require 'missing' module MyHelper end And when we try do load helper class ApplicationController helper :my end Rails will throw exception. This is wrong because there is a helper file. Missing helper file helpers/my_helper.rb Now when helper try to require non-existed file rails will throw proper exception. No such file to load -- missing
* Avoid leak into controller's action_methodsprintercu2013-04-181-0/+6
|
* Refactored to remove unused variableAnupam Choudhury2013-03-281-2/+2
|
* Merge pull request #8458 from ↵Rafael Mendonça França2013-03-271-0/+14
|\ | | | | | | | | | | | | | | | | lucisferre/improve-layout-override-fallback-behavior Provides standard layout lookup behavior for method and proc cases Conflicts: actionpack/CHANGELOG.md
| * Provides standard layout lookup behavior for method and proc casesChris Nicola2013-03-271-0/+14
| | | | | | | | | | | | | | When setting the layout either by referencing a method or supplying a Proc there is no way to fall back to the default lookup behavior if desired. This patch allows fallback to the layout lookup behavior when returning nil from the proc or method.
* | Changed 'args' to 'arguments' in test descriptionPrathamesh Sonpatki2013-03-242-2/+2
|/
* Fix setting expected value in translation testsCarlos Antonio da Silva2013-01-211-2/+2
| | | | It was being set to nil instead due to the wrong assignment.
* Removed ActionController::Base dependency from abstract controller ↵Jens Bissinger2013-01-201-41/+46
| | | | translation tests.
* Test abstract controller's localize method.Jens Bissinger2013-01-201-0/+6
|
* Remove unnecessary begin..rescue..end, use only rescueAkira Matsuda2013-01-062-11/+7
|
* add tests to aliased _filter callbacksFrancesco Rodriguez2012-12-071-0/+46
|
* use `_action` instead of `_filter` callbacksFrancesco Rodriguez2012-12-071-21/+19
|
* Rename all action callbacks from *_filter to *_actionDavid Heinemeier Hansson2012-12-071-5/+5
|
* add lazy look up in abstract controller's translate methodSergey Pchelincev2012-07-181-0/+13
|
* we raise a subclass of LoadError, so rescue thatAaron Patterson2012-06-141-1/+6
|
* Add a test case for layout nil.José Valim2012-03-281-1/+15
|
* use consistent explicit module inclusionLuke Gruber2012-03-163-6/+6
| | | | aid ease of understanding and readability for tests
* allow zero-arity proc for AbstrController::layoutLuke Gruber2012-03-151-0/+33
| | | | | proc without parameters can now be given to AbstractController::layout
* Add missing requireSantiago Pastorino2012-03-101-0/+1
|
* AbstractController.action_methods should return a SetSantiago Pastorino2012-03-101-1/+1
|
* Fix layout lookup for anonymous controllerAlexey Vakhov2012-02-281-0/+12
|
* AP tests should inherit from AS::TestCaseAaron Patterson2012-01-051-2/+2
|
* Remove deprecated layout lookup.José Valim2011-12-201-12/+3
|
* Deprecate implicit layout lookup in favor of inheriting the _layout config.José Valim2011-12-091-2/+2
|
* Allow layout fallback when using `layout` methodPrem Sichanugrist2011-12-061-1/+49
| | | | | | | | | | | | Rails will now use your default layout (such as "layouts/application") when you specify a layout with `:only` and `:except` condition, and those conditions fail. For example, consider this snippet: class CarsController layout 'single_car', :only => :show end Rails will use 'layouts/single_car' when a request comes in `:show` action, and use 'layouts/application' (or 'layouts/cars', if exists) when a request comes in for any other actions.
* Deprecate passing the template handler in the template name.José Valim2011-09-221-3/+3
| | | | | | For example, calling hello.erb is now deprecated. Since Rails 3.0 passing the handler had no effect whatsover. This commit simply deprecates such cases so we can clean up the code in later releases.
* Merge pull request #1644 from smartinez87/warnsSantiago Pastorino2011-06-101-1/+1
|\ | | | | Remove unused variable causing warning in 1.9.3
| * Remove unused variable causing warning in 1.9.3Sebastian Martinez2011-06-101-1/+1
| |
* | class WithSymbolReturningString is not used anywhere in the test.Neeraj Singh2011-06-081-12/+0
|/ | | | | | | | | | | Secondly it seemed from the method that the intent was to test a case where layout was declared in a symbol and the method named mention in layout returns nil. That case is already covered with class class WithSymbolReturningNil . Also the case of SymbolReturningString is covered with the class WithSymbol.
* Make test meaningfulNeeraj Singh2011-06-081-1/+1
| | | | | | | | | | If before_filter list was being called mistakenly then the test should fail. However test will not fail because second filter is assigning new values to @list. To truly test that first before_filter is not called when it should not be called then @list should not assigned value unconditionally. This patch will make the test fail if first filter is called.
* Merge pull request #1549 from neerajdotname/rename_to_method_for_actionJosé Valim2011-06-081-2/+2
|\ | | | | test name should reflect the name of the method
| * test name should reflect the name of the methodNeeraj Singh2011-06-081-2/+2
| | | | | | | | that is actually being called
* | remove unused class from testNeeraj Singh2011-06-081-6/+0
|/
* removing usesless variable assignmentsAaron Patterson2011-01-181-14/+14
|
* process_action accepts multiple args, even with Callbacks.Nick Sutterer2010-12-291-0/+21
|
* #948 template_inheritanceartemave2010-12-262-9/+9
|
* Avoid (@_var ||= nil) pattern by using initialize methods and ensuring ↵José Valim2010-09-291-1/+1
| | | | everyone calls super as expected.
* Fix more warnings by defining variables and using instance_variable_defined? ↵Emilio Tagua2010-09-281-2/+4
| | | | instead instance_variable_get.
* Add clear_helpers as a way to clean up all helpers added to this controller, ↵José Valim2010-08-261-2/+19
| | | | maintaing just the helper with the same name as the controller.
* Deletes trailing whitespaces (over text files only find * -type f -exec sed ↵Santiago Pastorino2010-08-143-54/+54
| | | | 's/[ \t]*$//' -i {} \;)
* Reload action_methods in AbstractController after defining new method.Piotr Sarnacki2010-08-041-0/+14
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* Fix setting helpers_path to a string or pathnameJeremy Kemper2010-07-071-1/+1
|
* Ensure overwritten callbacks conditions in controllers work [#4761 ↵José Valim2010-06-221-2/+12
| | | | state:resolved] [#3913 state:resolved]
* Use assert_respond_to because it has better error messagingNeeraj Singh2010-05-181-4/+4
| | | | | | [#4628 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-17 16:43:54 +0000