aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/test/abstract/callbacks_test.rb
Commit message (Collapse)AuthorAgeFilesLines
* Replace `assert !` with `assert_not`Daniel Colson2018-04-191-2/+2
| | | | | This autocorrects the violations after adding a custom cop in 3305c78dcd.
* Make actionpack frozen string friendlyKir Shatrov2017-07-241-1/+3
|
* Revert "Merge pull request #29540 from kirs/rubocop-frozen-string"Matthew Draper2017-07-021-1/+0
| | | | | This reverts commit 3420a14590c0e6915d8b6c242887f74adb4120f9, reversing changes made to afb66a5a598ce4ac74ad84b125a5abf046dcf5aa.
* Enforce frozen string in RubocopKir Shatrov2017-07-011-0/+1
|
* Remove deprecated methods related to controller filtersRafael Mendonça França2016-10-091-48/+0
| | | | | | | | | | `skip_action_callback`, `skip_filter`, `before_filter`, `prepend_before_filter`, `skip_before_filter`, `append_before_filter`, `around_filter` `prepend_around_filter`, `skip_around_filter`, `append_around_filter`, `after_filter`, `prepend_after_filter`, `skip_after_filter` and `append_after_filter`.
* applies remaining conventions across the projectXavier Noria2016-08-061-1/+0
|
* normalizes indentation and whitespace across the projectXavier Noria2016-08-061-16/+16
|
* modernizes hash syntax in actionpackXavier Noria2016-08-061-3/+3
|
* applies new string literal convention in actionpack/testXavier Noria2016-08-061-1/+1
| | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default.
* Revert "ActionController::Base#process() now only takes an action name"Aaron Patterson2015-10-291-0/+20
| | | | This reverts commit 9f93a5efbba3e1cbf0bfa700a17ec8d1ef60d7c6.
* ActionController::Base#process() now only takes an action nameAaron Patterson2015-10-291-20/+0
| | | | | | rather than an action name and *args. The *args were not being used in regular applications outside tests. This causes a backwards compatibility issue, but reduces array allocations for most users.
* Deprecate all *_filter callbacks in favor of *_action callbacksAbdelkader Boudih2015-01-081-3/+5
|
* Partially revert deprecation of *_filterRafael Mendonça França2014-06-031-5/+3
| | | | | | | | | | | We are going to deprecate only on Rails 5 to make easier plugin maintainers support different Rails versions. Right now we are only discouraging their usage. This reverts commit 6c5f43bab8206747a8591435b2aa0ff7051ad3de. Conflicts: actionpack/CHANGELOG.md
* Deprecate all *_filter callbacks in favor of *_action callbacksRafael Mendonça França2014-05-271-3/+5
| | | | | This is the continuation of the work started at 9d62e04838f01f5589fa50b0baa480d60c815e2c
* Changed 'args' to 'arguments' in test descriptionPrathamesh Sonpatki2013-03-241-1/+1
|
* add tests to aliased _filter callbacksFrancesco Rodriguez2012-12-071-0/+46
|
* use `_action` instead of `_filter` callbacksFrancesco Rodriguez2012-12-071-21/+19
|
* Rename all action callbacks from *_filter to *_actionDavid Heinemeier Hansson2012-12-071-5/+5
|
* Make test meaningfulNeeraj Singh2011-06-081-1/+1
| | | | | | | | | | If before_filter list was being called mistakenly then the test should fail. However test will not fail because second filter is assigning new values to @list. To truly test that first before_filter is not called when it should not be called then @list should not assigned value unconditionally. This patch will make the test fail if first filter is called.
* removing usesless variable assignmentsAaron Patterson2011-01-181-14/+14
|
* process_action accepts multiple args, even with Callbacks.Nick Sutterer2010-12-291-0/+21
|
* Fix more warnings by defining variables and using instance_variable_defined? ↵Emilio Tagua2010-09-281-2/+4
| | | | instead instance_variable_get.
* Deletes trailing whitespaces (over text files only find * -type f -exec sed ↵Santiago Pastorino2010-08-141-46/+46
| | | | 's/[ \t]*$//' -i {} \;)
* Ensure overwritten callbacks conditions in controllers work [#4761 ↵José Valim2010-06-221-2/+12
| | | | state:resolved] [#3913 state:resolved]
* Follow short name convention for test folder and just call it "abstract"Joshua Peek2009-09-191-0/+238