Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Replace `assert !` with `assert_not` | Daniel Colson | 2018-04-19 | 1 | -2/+2 |
| | | | | | This autocorrects the violations after adding a custom cop in 3305c78dcd. | ||||
* | Make actionpack frozen string friendly | Kir Shatrov | 2017-07-24 | 1 | -1/+3 |
| | |||||
* | Revert "Merge pull request #29540 from kirs/rubocop-frozen-string" | Matthew Draper | 2017-07-02 | 1 | -1/+0 |
| | | | | | This reverts commit 3420a14590c0e6915d8b6c242887f74adb4120f9, reversing changes made to afb66a5a598ce4ac74ad84b125a5abf046dcf5aa. | ||||
* | Enforce frozen string in Rubocop | Kir Shatrov | 2017-07-01 | 1 | -0/+1 |
| | |||||
* | Remove deprecated methods related to controller filters | Rafael Mendonça França | 2016-10-09 | 1 | -48/+0 |
| | | | | | | | | | | `skip_action_callback`, `skip_filter`, `before_filter`, `prepend_before_filter`, `skip_before_filter`, `append_before_filter`, `around_filter` `prepend_around_filter`, `skip_around_filter`, `append_around_filter`, `after_filter`, `prepend_after_filter`, `skip_after_filter` and `append_after_filter`. | ||||
* | applies remaining conventions across the project | Xavier Noria | 2016-08-06 | 1 | -1/+0 |
| | |||||
* | normalizes indentation and whitespace across the project | Xavier Noria | 2016-08-06 | 1 | -16/+16 |
| | |||||
* | modernizes hash syntax in actionpack | Xavier Noria | 2016-08-06 | 1 | -3/+3 |
| | |||||
* | applies new string literal convention in actionpack/test | Xavier Noria | 2016-08-06 | 1 | -1/+1 |
| | | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default. | ||||
* | Revert "ActionController::Base#process() now only takes an action name" | Aaron Patterson | 2015-10-29 | 1 | -0/+20 |
| | | | | This reverts commit 9f93a5efbba3e1cbf0bfa700a17ec8d1ef60d7c6. | ||||
* | ActionController::Base#process() now only takes an action name | Aaron Patterson | 2015-10-29 | 1 | -20/+0 |
| | | | | | | rather than an action name and *args. The *args were not being used in regular applications outside tests. This causes a backwards compatibility issue, but reduces array allocations for most users. | ||||
* | Deprecate all *_filter callbacks in favor of *_action callbacks | Abdelkader Boudih | 2015-01-08 | 1 | -3/+5 |
| | |||||
* | Partially revert deprecation of *_filter | Rafael Mendonça França | 2014-06-03 | 1 | -5/+3 |
| | | | | | | | | | | | We are going to deprecate only on Rails 5 to make easier plugin maintainers support different Rails versions. Right now we are only discouraging their usage. This reverts commit 6c5f43bab8206747a8591435b2aa0ff7051ad3de. Conflicts: actionpack/CHANGELOG.md | ||||
* | Deprecate all *_filter callbacks in favor of *_action callbacks | Rafael Mendonça França | 2014-05-27 | 1 | -3/+5 |
| | | | | | This is the continuation of the work started at 9d62e04838f01f5589fa50b0baa480d60c815e2c | ||||
* | Changed 'args' to 'arguments' in test description | Prathamesh Sonpatki | 2013-03-24 | 1 | -1/+1 |
| | |||||
* | add tests to aliased _filter callbacks | Francesco Rodriguez | 2012-12-07 | 1 | -0/+46 |
| | |||||
* | use `_action` instead of `_filter` callbacks | Francesco Rodriguez | 2012-12-07 | 1 | -21/+19 |
| | |||||
* | Rename all action callbacks from *_filter to *_action | David Heinemeier Hansson | 2012-12-07 | 1 | -5/+5 |
| | |||||
* | Make test meaningful | Neeraj Singh | 2011-06-08 | 1 | -1/+1 |
| | | | | | | | | | | If before_filter list was being called mistakenly then the test should fail. However test will not fail because second filter is assigning new values to @list. To truly test that first before_filter is not called when it should not be called then @list should not assigned value unconditionally. This patch will make the test fail if first filter is called. | ||||
* | removing usesless variable assignments | Aaron Patterson | 2011-01-18 | 1 | -14/+14 |
| | |||||
* | process_action accepts multiple args, even with Callbacks. | Nick Sutterer | 2010-12-29 | 1 | -0/+21 |
| | |||||
* | Fix more warnings by defining variables and using instance_variable_defined? ↵ | Emilio Tagua | 2010-09-28 | 1 | -2/+4 |
| | | | | instead instance_variable_get. | ||||
* | Deletes trailing whitespaces (over text files only find * -type f -exec sed ↵ | Santiago Pastorino | 2010-08-14 | 1 | -46/+46 |
| | | | | 's/[ \t]*$//' -i {} \;) | ||||
* | Ensure overwritten callbacks conditions in controllers work [#4761 ↵ | José Valim | 2010-06-22 | 1 | -2/+12 |
| | | | | state:resolved] [#3913 state:resolved] | ||||
* | Follow short name convention for test folder and just call it "abstract" | Joshua Peek | 2009-09-19 | 1 | -0/+238 |