Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Merge pull request #13897 from gmalette/nested-parameter-filtering-2 | Arthur Nogueira Neves | 2015-07-06 | 1 | -7/+17 |
|\ | | | | | Allow filtering params based on parent keys | ||||
| * | Allow filtering params based on parent keys | Guillaume Malette | 2015-06-22 | 1 | -7/+17 |
| | | | | | | | | | | | | | | | | | | | | Add the possibility to only filter parameters based on their full path instead of relying on the immediate key. config.filter_parameters += ['credit_card.code'] { 'credit_card' => { 'code' => '[FILTERED]' }, 'source' => { 'code' => '<%= puts 5 %>' } } | ||||
* | | Refactor cookie_jar to decouple it from request object | eileencodes | 2015-07-05 | 1 | -7/+3 |
| | | | | | | | | | | | | This change decouples `cookie_jar` allocation from the request object. We need this for moving controller tests to integration tests so we can access the `cookie_jar` object separately. | ||||
* | | [ci skip] Don't use TrueClass, FalseClass in docs | claudiob | 2015-07-02 | 1 | -6/+0 |
| | | | | | | | | | | | | | | | | | | This sort of documentation style comes from 2009, probably due to the merging of merb (see https://github.com/rails/rails/commit/38b608ecab2441cd0c4e75bc08bdf57fcf85dd71#diff-017d9bc9b1d2bdae199b938d72c15488R120). Rails follows Ruby's convention to define which values are "truthy" or "falsey", so there is no need to specify that the returned value must strictly be a TrueClass or FalseClass. /cc @fxn | ||||
* | | [ci skip] Improve the url_for documentation | Roque Pinel | 2015-07-01 | 1 | -3/+19 |
| | | | | | | | | | | | | | | | | | | Clarify the `url_for` usage in mailers. Re-add the documentation about `url_for` and Route's path parameters, first introduced by 5c4f1859970d06228a0b67cad6d4486c1526ef2a. This was reported on #15097 and until it is decided to deprecate it or not, I believe the documentation should exist. | ||||
* | | Merge pull request #20276 from davetron5000/revert-head-on-no-template | Kasper Timm Hansen | 2015-06-27 | 1 | -2/+17 |
|\ \ | | | | | | | Allow default_render to take a block to customize behavior when there's no template | ||||
| * | | Override default_render's behavior with a block | Dave Copeland | 2015-06-20 | 1 | -2/+17 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In 0de4a23 the behavior when there is a missing template was changed to not raise an error, but instead head :no_content. This is a breaking change and some gems rely on this happening. To allow gems and other code to work around this, allow `default_render` to take a block which, if provided, will execute the contents of that block instead of doing the `head :no_content`. | ||||
* | | | Merge pull request #20664 from vngrs/remove_mistaken_end_from_doc | Claudio B. | 2015-06-22 | 1 | -1/+1 |
|\ \ \ | | | | | | | | | Remove mistaken end from controller_path doc [ci skip] | ||||
| * | | | Remove mistaken end from controller_path doc [ci skip] | Mehmet Emin İNAÇ | 2015-06-22 | 1 | -1/+1 |
| | |/ | |/| | |||||
* | | | Merge pull request #19431 from hmarr/head-routing | Rafael Mendonça França | 2015-06-22 | 1 | -1/+2 |
|\ \ \ | |/ / |/| | | Respect routing precedence for HEAD requests | ||||
| * | | Respect routing precedence for HEAD requests | Harry Marr | 2015-03-20 | 1 | -1/+2 |
| | | | | | | | | | | | | | | | | | | | | | Fixes the issue described in #18764 - prevents Rack middleware from swallowing up HEAD requests that should have been matched by a higher-precedence `get` route, but still allows Rack middleware to respond to HEAD requests. | ||||
* | | | Merge pull request #20659 from ↵ | Yves Senn | 2015-06-22 | 1 | -2/+4 |
|\ \ \ | | | | | | | | | | | | | | | | | | | | | vngrs/strong_parameters_unpermitted_parameters_wrong_doc_fix Fix the documentation about ActionController::UnpermittedParameters [ci skip] | ||||
| * | | | Fix the documentation about ActionController::UnpermittedParameters [ci skip] | Mehmet Emin İNAÇ | 2015-06-22 | 1 | -2/+4 |
|/ / / | |||||
* | / | Fix the documentation about ActionController::ParameterMissing [ci skip] | Mehmet Emin İNAÇ | 2015-06-22 | 1 | -5/+5 |
| |/ |/| | |||||
* | | Revert "Merge pull request #20584 from arthurnn/fix_url" | Arthur Neves | 2015-06-17 | 1 | -8/+4 |
| | | | | | | | | | | | | | | | | This reverts commit 0b3397872582f2cf1bc6960960a6393f477c55e6, reversing changes made to 56d52e3749180e6c1dcf7166adbad967470aa78b. As pointed out on the PR, this will hide development mistakes too, which is not ideal. | ||||
* | | Merge pull request #20584 from arthurnn/fix_url | Arthur Nogueira Neves | 2015-06-16 | 1 | -4/+8 |
|\ \ | | | | | | | Catch InvalidURIError on bad paths on redirect. | ||||
| * | | Catch InvalidURIError on bad paths on redirect. | Arthur Neves | 2015-06-16 | 1 | -4/+8 |
| | | | | | | | | | | | | | | | Handle URI::InvalidURIError errors on the redirect route method, so it wont raise a 500 if a bad path is given. | ||||
* | | | Fix the comment about attr_reader of headers [ci skip] | Mehmet Emin İNAÇ | 2015-06-16 | 1 | -1/+1 |
|/ / | |||||
* | | remove `header=` on the response object. | Aaron Patterson | 2015-06-15 | 2 | -13/+14 |
| | | | | | | | | | | | | People should be free to mutate the header object, but not to set a new header object. That header object may be specific to the webserver, and we need to hide it's internals. | ||||
* | | set the default charset in response initialize | Aaron Patterson | 2015-06-15 | 1 | -4/+12 |
| | | | | | | | | | | this way we don't have to mutate the instance (as much) when writing a rack response | ||||
* | | Deprecate passing hash as first parameter into ActionController::Head | Mehmet Emin İNAÇ | 2015-06-15 | 1 | -2/+12 |
| | | |||||
* | | A few documentation edits [ci skip] | Robin Dupret | 2015-06-15 | 2 | -10/+12 |
| | | |||||
* | | Merge pull request #20559 from mtsmfm/fix-header-modification-by-ssl | Guillermo Iguaran | 2015-06-14 | 1 | -1/+1 |
|\ \ | | | | | | | ActionDispatch::SSL should keep original header's behavior | ||||
| * | | ActionDispatch::SSL should keep original header's behavior | Fumiaki MATSUSHIMA | 2015-06-14 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | | | `ActionDispatch::SSL` changes headers to `Hash`. So some headers will be broken if there are some middlewares on ActionDispatch::SSL and if it uses `Rack::Utils::HeaderHash`. | ||||
* | | | Merge pull request #20558 from prathamesh-sonpatki/missing-header-word | Kasper Timm Hansen | 2015-06-14 | 1 | -1/+1 |
|\ \ \ | |/ / |/| | | Add missing "header" word in documentation of Token#authentication_request [ci skip] | ||||
| * | | Add missing "header" word in documentation of Token#authentication_request ↵ | Prathamesh Sonpatki | 2015-06-14 | 1 | -1/+1 |
| | | | | | | | | | | | | [ci skip] | ||||
* | | | don't hold a reference to `env` in the options object | Aaron Patterson | 2015-06-13 | 1 | -13/+11 |
| | | | | | | | | | | | | | | | I want to decouple Rails from the rack ENV as much as possible. We should try to keep as few references to the env as possible | ||||
* | | | Handle param-parsing errors from Rack in ExceptionWrapper | Grey Baker | 2015-06-12 | 1 | -1/+3 |
|/ / | |||||
* | | Update RDoc for ActionController::TestCase for kwargs. | Victor Costan | 2015-06-12 | 1 | -1/+1 |
| | | |||||
* | | Merge pull request #20522 from colby-swandale/doc-update | Sean Griffin | 2015-06-11 | 1 | -1/+1 |
|\ \ | | | | | | | fixed sring to be string in ActiveRecord::Base params documentation [ci skip] | ||||
| * | | fixed sring to be string in ActiveRecord::Base params documentation | Colby Swandale | 2015-06-12 | 1 | -1/+1 |
| | | | |||||
* | | | Mention that doing nothing in Rails API controllers returns 204 | Santiago Pastorino | 2015-06-11 | 1 | -1/+1 |
| | | | |||||
* | | | Return 204 if render is not called in API controllers | Jorge Bejar | 2015-06-11 | 4 | -6/+16 |
| | | | |||||
* | | | Include ParamsWrapper in AC::API | Jorge Bejar | 2015-06-11 | 1 | -1/+5 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | ParamsWrapper was initially removed from API controllers according to the following discusision: https://github.com/rails-api/rails-api/issues/33 However, we're including it again so Rails API devs can decide whether to enable or disable it. | ||||
* | | | Fix MimeResponds example in AC::API documentation | Santiago Pastorino | 2015-06-11 | 1 | -3/+5 |
| | | | |||||
* | | | Revert changes related with api apps in RouteWrapper | Jorge Bejar | 2015-06-11 | 1 | -11/+1 |
| | | | | | | | | | | | | | | | See the following commit to have context about this change: https://github.com/rails/rails/commit/757a2bc3e3e52a5d9418656928db993db42b741b | ||||
* | | | Do not say that Api Controllers are faster than regular ones in docs | Jorge Bejar | 2015-06-11 | 1 | -4/+4 |
| | | | |||||
* | | | Remove Compatibility module since we don't remember why it was added :smile: | Jorge Bejar | 2015-06-11 | 2 | -20/+0 |
| | | | |||||
* | | | Routes resources avoid :new and :edit endpoints if api_only is enabled | Jorge Bejar | 2015-06-11 | 2 | -12/+35 |
| | | | |||||
* | | | Refactor internal? to query internal_controller? and internal_asset? methods | Santiago Pastorino | 2015-06-11 | 1 | -1/+11 |
| | | | |||||
* | | | Remove Unneeded ApiPublicExceptions middleware, PublicExceptions already ↵ | Santiago Pastorino | 2015-06-11 | 2 | -47/+0 |
| | | | | | | | | | | | | does the work | ||||
* | | | Remove api_rendering is not needed | Santiago Pastorino | 2015-06-11 | 3 | -19/+1 |
| | | | |||||
* | | | Adhere to Rails convention for private indentation | Santiago Pastorino | 2015-06-11 | 1 | -21/+20 |
| | | | |||||
* | | | Add ApiPublicException middleware | Santiago Pastorino | 2015-06-11 | 2 | -0/+48 |
| | | | |||||
* | | | Add ActionController API functionality | Santiago Pastorino | 2015-06-11 | 3 | -0/+176 |
| | | | |||||
* | | | Merge pull request #20519 from colby-swandale/doc-update | Zachary Scott | 2015-06-11 | 1 | -3/+3 |
|\| | | | | | | | | better clarity of params source in ActionController::Base documentation | ||||
| * | | better clarity of params source in ActionController::Base documentation [ci ↵ | Colby Swandale | 2015-06-11 | 1 | -3/+3 |
| | | | | | | | | | | | | skip] | ||||
* | | | Change the `index` arg of `ActionDispatch::Static#new` to a kwarg | Yuki Nishijima | 2015-06-11 | 1 | -4/+3 |
|/ / | |||||
* | | remove unused code | Aaron Patterson | 2015-06-08 | 1 | -2/+2 |
| | | |||||
* | | we only care about methods that the request object responds to | Aaron Patterson | 2015-06-08 | 1 | -2/+1 |
| | | | | | | | | | | matches? should only deal with methods on the request object, so lets just filter out anything that the request object doesn't respond to |