aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/lib
Commit message (Collapse)AuthorAgeFilesLines
* Refactor grep call to remove .eachCarlos Antonio da Silva2013-01-201-1/+1
| | | | Grep already yields the matching keys to the given block.
* Use 1.9 hash style in docs/comments [ci skip]Carlos Antonio da Silva2013-01-201-3/+3
|
* Removing warning: shadowing outer local variable Arun Agrawal2013-01-201-3/+3
|
* strong parameters filters permitted scalarsXavier Noria2013-01-201-22/+92
|
* Merge pull request #8978 from chrismcg/remove_i18n_symbol_dependencyAaron Patterson2013-01-191-0/+1
|\ | | | | Remove i18n symbol dependency
| * Don't change the original i18n dataChris McGrath2013-01-171-1/+1
| |
| * Remove i18n symbol dependencyChris McGrath2013-01-171-0/+1
| | | | | | | | | | | | | | | | | | date.order is the only key in rails i18n that is required to be a symbol. This patch allows for symbols or strings which means: * No requirement for symbol type in .yml files. A future YAML.safe_load wouldn't need to load symbols * Rails could actually use json rather than yml as the backend
* | Restore and adapt the implementation reverted atRafael Mendonça França2013-01-192-29/+58
| | | | | | | | | | | | https://github.com/rails/rails/commit/cc1c3c5be061e7572018f734e5239750ab449e3f Now instead of raise, we log by default in development and test
* | Added ability to raise or log on unpermitted params.Thomas Drake-Brockman2013-01-202-6/+34
| |
* | Merge pull request #8977 from Soylent/masterAaron Patterson2013-01-181-1/+1
|\ \ | | | | | | Resovled issue rails#7774
| * | Fix ActionDispatch::Request#formats when HTTP_ACCEPT header is empty stringKonstantin Papkovskiy2013-01-171-1/+1
| | |
* | | Fix syntax error :grin:Guillermo Iguaran2013-01-181-1/+1
| | |
* | | Remove "Application" section title from routesschneems2013-01-181-6/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | This PR standardizes the output of the HTML and console based routes to not include the title for "Application Routes" those that are defined by the application. Instead only routes defined in engines get any special treatment. Based on this conversation: https://github.com/rails/rails/commit/af5c0fd85fce1adb311083dd1ecf96432ee8caa3#commitcomment-2458823 ATP actionpack /cc @carlosantoniodasilva
* | | Revert "Merge pull request #8989 from robertomiranda/use-rails-4-find-by"Guillermo Iguaran2013-01-183-4/+4
| | | | | | | | | | | | | | | This reverts commit 637a7d9d357a0f3f725b0548282ca8c5e7d4af4a, reversing changes made to 5937bd02dee112646469848d7fe8a8bfcef5b4c1.
* | | User Rails 4 find_byrobertomiranda2013-01-183-4/+4
|/ /
* / Remove useless || operationCarlos Antonio da Silva2013-01-171-2/+1
|/
* Deprecate direct calls to AC::RecordIdentifier.dom_id and dom_classCarlos Antonio da Silva2013-01-161-5/+17
| | | | Also add some generic tests to ensure they're properly deprecated.
* Fix date_select :selected option so you can pass it nilColin Burn-Murdoch2013-01-161-1/+1
|
* Merge pull request #8958 from balexand/strong_parameters_exception_handlingRafael Mendonça França2013-01-152-7/+2
|\ | | | | Strong parameters exception handling
| * strong parameters exception handlingBrian Alexander2013-01-152-7/+2
| |
* | Remove header bloat introduced by BestStandardsSupport middlewareEdward Anderson2013-01-151-1/+3
|/ | | | The same headers were being duplicated on every request.
* Change the behavior of route defaultsAndrew White2013-01-153-6/+16
| | | | | | | | | | | | | | | | | | | This commit changes route defaults so that explicit defaults are no longer required where the key is not part of the path. For example: resources :posts, bucket_type: 'posts' will be required whenever constructing the url from a hash such as a functional test or using url_for directly. However using the explicit form alters the behavior so it's not required: resources :projects, defaults: { bucket_type: 'projects' } This changes existing behavior slightly in that any routes which only differ in their defaults will match the first route rather than the closest match. Closes #8814
* Add support for other types of routing constraintsAndrew White2013-01-153-113/+174
| | | | | | | | | | | | | | This now allows the use of arrays like this: get '/foo/:action', to: 'foo', constraints: { subdomain: %w[www admin] } or constraints where the request method returns an Fixnum like this: get '/foo', to: 'foo#index', constraints: { port: 8080 } Note that this only applies to constraints on the request - path constraints still need to be specified as Regexps as the various constraints are compiled into a single Regexp.
* Ensure port is set when passed via the process methodAndrew White2013-01-151-1/+1
|
* Raise correct exception now Journey is integrated.Andrew White2013-01-152-5/+8
| | | | | | | Now that Journey has been integrated into ActionDispatch we can raise the exception ActionController::UrlGenerationError directly rather than raising the internal Journey::Router::RoutingError and then have ActionDispatch::Routing::RouteSet#generate re-raise the exception.
* Revert "log at debug level what line caused the redirect_to"Carlos Antonio da Silva2013-01-151-1/+0
| | | | | | | | This reverts commit 3fa00070047b5d019d39e691598ee2890283d052. Reason: This message is usually not accurate and annoying: Redirected by ~/.rbenv/versions/1.9.3-p327-perf/lib/ruby/1.9.1/logger.rb:371:in `add'`
* Merge pull request #8938 from colinbm/date_select_valueSteve Klabnik2013-01-142-1/+6
|\ | | | | Rename :value to :selected for date_select, and add missing tests/docs
| * Rename :value option to :selected, in line with other select helpersColin Burn-Murdoch2013-01-142-1/+6
| | | | | | | | | | Add tests for time & datetime. Add documentation.
* | Revert benchmark helper regression. Use a #capture within a #benchmarkJeremy Kemper2013-01-142-15/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | block. Breaks benchmark calls that return non-String values otherwise. Revert "add benchmark helper that works in erb" This reverts commit 904e544cc8f5846de7c31827bb5556c6a238c0de. Conflicts: actionpack/lib/action_view/helpers.rb actionpack/lib/action_view/helpers/benchmark_helper.rb actionpack/test/template/benchmark_helper_test.rb
* | Merge pull request #8916 from josemota/collection-with-blockRafael Mendonça França2013-01-131-4/+4
|\ \ | |/ |/| | | | | Collection radio buttons and collection check boxes through FormBuilder render the provided block. Closes #8897
| * Collection radio buttons and collection check boxes through FormBuilder renderJosé Mota2013-01-121-4/+4
| | | | | | | | | | | | | | | | the provided block. In the case of having a form_for method being called, the block for each collection would not be passed and thus the result expected was always the same. This patch passes the block to the original method like it would be assumed.
* | Allow value to be set on date_selectColin Burn-Murdoch2013-01-131-1/+1
|/
* Fix regression introduced in pull request 8812Sam Ruby2013-01-111-1/+2
| | | | See https://github.com/rails/rails/pull/8812#commitcomment-2416514
* Merge pull request #8882 from goshakkk/clearer-conditionalCarlos Antonio da Silva2013-01-111-3/+3
|\ | | | | Clearer conditional in constraint match check
| * clearer conditional in constraint match checkGosha Arinich2013-01-101-3/+3
| |
* | Merge pull request #8623 from virusman/form_helpers_collectionproxy_fixJon Leighton2013-01-111-1/+1
|\ \ | | | | | | Fixed nested fields bug when called with AssociationProxy
| * | Test nested fields with AssociationProxy mockup & fix AssociationProxy ↵virusman2012-12-271-1/+1
| | | | | | | | | | | | support in form helper
* | | Fix json params parsing regression for non-object JSON content.Dylan Smith2013-01-111-2/+2
| |/ |/| | | | | Fixes #8845.
* | Merge pull request #8876 from senny/extract_performance_testsGuillermo Iguaran2013-01-104-15/+0
|\ \ | | | | | | Extract ActionDispatch::PerformanceTest
| * | extract PerformanceTest into rails-performance_tests gemYves Senn2013-01-104-15/+0
| | |
* | | Merge pull request #8821 from jamis/masterRafael Mendonça França2013-01-101-5/+1
|\ \ \ | |/ / |/| | | | | | | | | | | | | | Evaluate view_cache_dependencies at the instance level Conflicts: actionpack/lib/action_controller/caching.rb
| * | evaluate the dependency blocks at the instance level, not class levelJamis Buck2013-01-081-5/+1
| | |
* | | Remove redundant double quotation markszires2013-01-101-1/+1
| | |
* | | adding missing requiresAaron Patterson2013-01-092-0/+9
| | |
* | | Fix typo in deprecation warningNathaniel Jones2013-01-091-1/+1
| | |
* | | Merge pull request #8824 from mjtko/fix/cookie-store-inheritanceSantiago Pastorino2013-01-082-5/+26
|\ \ \ | | | | | | | | Modify CookieStore middleware inheritance to avoid subclassing Rack::Session::Cookie [Fix for #7372]
| * | | Revert cb3181e - no longer required.Mark J. Titorenko2013-01-081-2/+0
| | | |
| * | | Fix CookieStore middleware inheritance hierarchy s.t. it inherits from ↵Mark J. Titorenko2013-01-081-3/+26
| | | | | | | | | | | | | | | | Rack::Session::Abstract::ID rather than Rack::Session::Cookie.
* | | | Fix warning: & interpreted as argument prefixCarlos Antonio da Silva2013-01-081-1/+1
| | | |
* | | | remove yaml as a param parser :burn:Aaron Patterson2013-01-081-2/+0
| | | | | | | | | | | | | | | | | | | | If you revert this commit, I will hunt you down, I will make you regret ever terrible thing you've ever done, I will make you suffer.
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-09 08:06:29 +0000