aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/lib
Commit message (Collapse)AuthorAgeFilesLines
...
* | | Merge pull request #9221 from thenickcox/image_alt_attributeCarlos Antonio da Silva2013-02-111-3/+17
|\ \ \ | | | | | | | | Improve img alt attribute for screen readers
| * | | Improve img alt attribute for screen readersthenickcox2013-02-091-3/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently, the img_alt method in ActionView keeps underscores in the alt attribute. Because underscores are pronounced in Apple's VoiceOver Utility, this has serious implications for accessibility. This patch makes underscored or hyphenated file names (both common in projects) read more naturally in screen readers by replacing them with spaces. See method documentation for details. Added documentation to image_alt method
* | | | the `:controller` option for routes can contain numbers. closes #9231.Yves Senn2013-02-091-1/+1
| | | |
* | | | Add missing require to APCarlos Antonio da Silva2013-02-081-0/+1
| | | |
* | | | Fix #9168 Initialize NullCookieJar with all options needed for KeyGeneratorAndrey Chernih2013-02-082-5/+9
|/ / /
* | | ruby constant syntax is not supported as routing `:controller` option.Yves Senn2013-02-061-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The current implementation only works correctly if you supply the `:controller` with directory notation (eg. `:controller => 'admin/posts'`). The ruby constant notation (eg. `:controller => 'Admin::Posts`) leads to unexpected problems with `url_for`. This patch prints a warning for every non supported `:controller` option. I also added documentation how to work with namespaced controllers. The warning links to that documentation in the rails guide.
* | | partials inside directory work with `assert_template`Yves Senn2013-02-042-2/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | previously when a partial was placed inside a directory (eg. '/dir/_partial'), `assert_template` did not replace the '_' prefix when looking through rendered tempaltes, which resulted in an error. I modified it to replace both, the leading '_' and the last '_' after a '/'.
* | | descriptive `assert_template` error when partial wasn't renderedYves Senn2013-02-042-0/+7
| |/ |/| | | | | | | | | | | When `assert_template` is used with the :locals option, and the partial was not rendered, a method_missing error was raised. This changes first checks, if the partial actually was rendered and raises a descriptive error.
* | Missing require hash/keysAkira Matsuda2013-02-012-0/+3
| |
* | Missing or unneeded require extract_optionsAkira Matsuda2013-02-018-1/+8
| |
* | Use \A in RegexpsEgor Homakov2013-02-011-1/+1
| | | | | | | | | | So, if there is redirect_to params[:q] i can send ?q=javascript:asdf()%0A/localpath Or something more nasty, so please use \A
* | remove dead codeAaron Patterson2013-01-301-4/+1
| |
* | change parameter name for positional argsAaron Patterson2013-01-301-2/+1
| |
* | nodoc the helper classes, cache stuff for optimized helperAaron Patterson2013-01-301-13/+17
| |
* | cache path parts in the instanceAaron Patterson2013-01-301-2/+3
| |
* | stop evaling a string every timeAaron Patterson2013-01-301-4/+4
| |
* | moving helper classes outside the private blockAaron Patterson2013-01-301-90/+88
| |
* | pushing specialization down to the optimized classAaron Patterson2013-01-301-23/+25
| |
* | use polymorphism to remove conditionalAaron Patterson2013-01-301-35/+27
| |
* | move conditionals to instanceAaron Patterson2013-01-301-6/+16
| |
* | pull stuff out of the caller and hide in the instanceAaron Patterson2013-01-301-4/+3
| |
* | moving more stuff on to the instanceAaron Patterson2013-01-301-18/+18
| |
* | move optimize_helper? to the helper instanceAaron Patterson2013-01-301-9/+12
| |
* | moving more stuff to the instanceAaron Patterson2013-01-301-6/+6
| |
* | moving some stuff to the initializerAaron Patterson2013-01-301-14/+38
| |
* | moved more evald codeAaron Patterson2013-01-301-8/+7
| |
* | factored out some of the dynamic codeAaron Patterson2013-01-301-19/+31
| |
* | Fix `content_tag_for` with array html option.Semyon Perepelitsa2013-01-311-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It would embed array as string instead of joining it like `content_tag` does: content_tag(:td, class: ["foo", "bar"]){} #=> '<td class="foo bar"></td>' Before: content_tag_for(:td, item, class: ["foo", "bar"]){} #=> '<td class="item [&quot;foo&quot;, &quot;bar&quot;]" id="item_1"></td>' After: content_tag_for(:td, item, class: ["foo", "bar"]){} #=> '<td class="item foo bar" id="item_1"></td>'
* | Add 'X-UA-Compatible' => 'chrome=1' to default headersGuillermo Iguaran2013-01-291-1/+2
| |
* | Remove BestStandardsSupport middlewareGuillermo Iguaran2013-01-293-32/+0
| |
* | Merge pull request #9096 from tricknotes/fix-code-commentRafael Mendonça França2013-01-281-4/+4
|\ \ | | | | | | Fix code comment
| * | Fix JavaScript syntax in code comment [ci skip]Ryunosuke SATO2013-01-291-4/+4
| | |
* | | Make current_url? work with a HEAD methodMichiel Sikkes2013-01-281-1/+1
| | | | | | | | | | | | | | | | | | ActionDispatch::Head was removed in favor of Rack::Head. But Rack::Head does not convert GET requests to HEAD requests so we need to do checking for HEAD requests ourselves.
* | | Remove caching_allowed? from ActionController::CachingMichiel Sikkes2013-01-281-4/+0
|/ / | | | | | | | | Where is this used? No other code references to this method and it isn't being tested anywhere. No tests fail when commented out.
* | Merge pull request #9032 from firmhouse/head-breaks-csrfSantiago Pastorino2013-01-281-2/+2
|\ \ | | | | | | Make HEAD work / convert to GET once more
| * | Added request.head? to forgery protection codeMichiel Sikkes2013-01-221-2/+2
| | |
* | | Use Encoding::UTF_8 constant :do_not_litter:Akira Matsuda2013-01-284-5/+5
| | |
* | | Use already defined Encoding constants rather than creating one-trip StringsAkira Matsuda2013-01-282-2/+2
| | |
* | | add fetch to CookieJarAaron Patterson2013-01-271-0/+4
| | |
* | | Merge remote-tracking branch 'docrails/master'Xavier Noria2013-01-266-4/+98
|\ \ \ | | | | | | | | | | | | | | | | | | | | Conflicts: actionpack/lib/action_view/helpers/form_options_helper.rb guides/code/getting_started/app/controllers/comments_controller.rb
| * | | generic pass before merging docrailsXavier Noria2013-01-264-422/+62
| | | |
| * | | :scissors: "raise" duplicationAkira Matsuda2013-01-261-2/+1
| | | |
| * | | Review #translate docs [ci skip]Carlos Antonio da Silva2013-01-201-8/+7
| | | |
| * | | Add documentation for abstract controller #translate and #localize method.Jens Bissinger2013-01-201-0/+10
| | | |
| * | | Add documentation to ActionDispatch::ResponseMatthew Stopa2013-01-201-0/+7
| | | |
| * | | fix broken examples format in image_tag helper [ci skip]Francesco Rodriguez2013-01-181-0/+2
| | | |
| * | | repeating documentation for option form helpersThiago Pinto2013-01-171-0/+286
| | | |
| * | | repeating documentation for date and time form helpersThiago Pinto2013-01-171-0/+148
| | | |
| * | | Fix typo introduced in 0004ca3aCarlos Antonio da Silva2013-01-161-1/+1
| | | | | | | | | | | | | | | | [ci skip]
| * | | More documentation for ActionDispatch::ResponseMatthew Stopa2013-01-161-1/+3
| | | | | | | | | | | | | | | | [ci skip]
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-09 08:26:01 +0000