aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/lib
Commit message (Collapse)AuthorAgeFilesLines
* Fix system testing failureRyuta Kamizono2019-01-301-8/+11
| | | | https://travis-ci.org/rails/rails/jobs/486155626#L1317-L1335
* Rename methods and update docsEileen Uchitelle2019-01-293-19/+23
| | | | | | | | | | | | | | This is a minor update to the named methods for the following: - s/desired_capabilities/capabilities - s/driver_options/capabilities Since they are all the same thing we should keep the name the same throughout the feature. Updated docs to match / be a little bit clearer Also updated the Gemfile for selenium-webdriver.
* driver_option -> driver_optionsEdouard CHIN2019-01-292-7/+7
|
* Implement a way to add browser capabilities:Edouard CHIN2019-01-293-10/+40
| | | | | | | | | | | | | | | | | | * There is currently no way to define specific browser capabilities since our SystemTest driver override the `option` key [Ref](https://github.com/rails/rails/blob/a07d0680787ced3c04b362fa7a238c918211ac70/actionpack/lib/action_dispatch/system_testing/driver.rb#L35) This option key is used internally by selenium to add custom capabilities on the browser. Depending on the Browser, some option are allowed to be passed inside a hash, the driver takes care of setting whatever you passed on the driver option. An example [here](https://github.com/rails/rails/blob/a07d0680787ced3c04b362fa7a238c918211ac70/actionpack/lib/action_dispatch/system_testing/driver.rb#L35) where you are allowed to pass args such as `--no-sandbox` etc However this behavior was only meant for backward compatibility and as you can see it's deprecated. The non-deprecated behavior is to create a `<Driver>::Option` object containing all the capabilities we want. This is what we [currently do](https://github.com/rails/rails/blob/a07d0680787ced3c04b362fa7a238c918211ac70/actionpack/lib/action_dispatch/system_testing/browser.rb#L34-L36) when chrome or firefox are in headless mode. This PR allows to pass a block when calling `driven_by`, the block will be pased a `<Driver>::Option` instance. You can modify this object the way you want by adding any capabilities. The option object will be then passed to selenium. ```ruby driven_by :selenium, using: :chrome do |driver_option| driver_option.add_argument('--no-sandbox') driver_option.add_emulation(device: 'iphone 4') end ```
* Merge pull request #35030 from ↵Rafael França2019-01-282-2/+2
|\ | | | | | | | | alkesh26/actionpack-long-string-indentation-and-typo-fix Actionpack typo fixes.
| * Typo fixes action pack.alkesh262019-01-262-2/+2
| |
* | Fixed a bug where the debug view does not show the error page properlyYuki Nishijima2019-01-242-11/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There are two cases where the debug view does not show the error details properly: * When the cause is mapped to an HTTP status code the last exception is unexpectedly uwrapped * When the last error is thrown from a view template the debug view is not using the `rescues/template_error.html.erb` to generate the view Both the cases could be fixed by not unwrapping the exception. The only case where the exception should be unwrapped is when the last error is an `ActionView::Template::Error` object. In this case the HTTP status code is determined based on the cause. There are actually more wrapper exceptions that are intentionally thrown. However, there is a consistent pattern of setting the original message and original backtrace to the wrapper exception implemented, so the debug view will not lose the information about what went wrong eariler.
* | Merge pull request #34994 from schuetzm/host-authorization-only-in-developmentRafael França2019-01-242-4/+4
|\ \ | |/ |/| Recommend adding the requested domain to hosts whitelist only in deve…
| * Recommend adding the requested domain to hosts whitelist only in developmentMarc Schütz2019-01-232-4/+4
| |
* | Merge pull request #35018 from gmcgibbon/revert_redirect_to_allow_other_hostRafael França2019-01-222-29/+7
|\ \ | | | | | | Revert ensure external redirects are explicitly allowed
| * | Revert ensure external redirects are explicitly allowedGannon McGibbon2019-01-222-29/+7
| |/
* | Merge pull request #34952 from rails/template-stuffAaron Patterson2019-01-223-4/+11
|\ \ | |/ |/| Template Handler Refactoring
| * Only cache the view_context_class in one placeAaron Patterson2019-01-181-1/+8
| | | | | | | | | | | | | | This patch removes the instance writer of view_context_class. Subclasses may override it, but it doesn't need to be written. This also eliminates the need to cache the return value of the class level `view_context_class` method.
| * Remove args from `default_render`Aaron Patterson2019-01-172-3/+3
| | | | | | | | It's always called with 0 params, so just remove the parameter
* | Preparing for 6.0.0.beta1 releaseRafael Mendonça França2019-01-181-1/+1
| |
* | Remove secret_token rack env and cookie upgrade codeRafael Mendonça França2019-01-172-39/+1
| | | | | | | | Now that secret_token was removed all this code is now dead.
* | Remove deprecated `fragment_cache_key` helper in favor of ↵Rafael Mendonça França2019-01-171-19/+0
| | | | | | | | `combined_fragment_cache_key`
* | Remove deprecated methods in ActionDispatch::TestResponseRafael Mendonça França2019-01-171-27/+0
| | | | | | | | | | `#success?`, `missing?` and `error?` were deprecated in Rails 5.2 in favor of `#successful?`, `not_found?` and `server_error?`.
* | Update the promisse that ActionController::TestCase will be extractedRafael Mendonça França2019-01-171-1/+1
| | | | | | | | | | | | | | | | We are past 5.1 and it was not extrated yet, so while we still have plans they will not be realized on 6.0, so it is better to not set expectations of which release will exclude it just yet. [ci skip]
* | Ensure external redirects are explicitly allowedGannon McGibbon2019-01-173-17/+39
| | | | | | | | Add `fallback_location` and `allow_other_host` options to `redirect_to`.
* | Merge pull request #34944 from dasch/patch-7Rafael França2019-01-161-0/+8
|\ \ | | | | | | Document that `format.any` can match all formats
| * | Document that `format.any` can match all formatsDaniel Schierbeck2019-01-161-0/+8
| |/ | | | | I had to dig around the code to discover this, since I had a use case for the behavior.
* / Revert "Don't handle params option in a special way in url_for helper"Rafael Mendonça França2019-01-162-0/+5
|/ | | | | | | | | | | This reverts commit e385e4678fc64be6e176c3bdac6641db9fe48d85. While this option was undocumented it exists to make possible to pass parameters to the route helpers that are reserved like `:domain`. While `url_for(domain: 'foo.com')` would generate a URL in the `foo.com` domain `url_for(params: { domain: 'foo.com' })` would generate a URL with `?domain=foo.com`.
* Merge pull request #34894 from hahmed/tames-params-wrapper-errorsKasper Timm Hansen2019-01-091-16/+17
|\ | | | | Capture parsing errors only for ActionController::ParamsWrapper#process_actions
| * Capture parsing errors for ActionController::ParamsWrapper#process_actionHaroon Ahmed2019-01-081-16/+17
| |
* | Allow using combine the Cache-Control `public` and `no-cache` headersyuuji.yaginuma2019-01-071-4/+6
|/ | | | | | | | | | | | | | | | | Since #30367, if `no-cache` includes Cache-Control headers, special keys like `public`, `must-revalidate` are ignored. But in my understanding, `public` still need in case of want to cache authenticated pages. The authenticated pages to be cacheable, but still authenticated for every user, need to specify the `Cache-Control: public, no-cache`. For keys other than `public`, I did not know the case where it was necessary to use it in combination with `no-cache`, so I fixed that can be used only for `public`. Ref: https://www.mnot.net/cache_docs/#CACHE-CONTROL Fixes #34780.
* Remove mention about `Test::Unit::TestCase` [ci skip]bogdanvlviv2019-01-021-3/+0
| | | | | | We've switched from `Test::Unit::TestCase` to `ActiveSupport::TestCase` since Rails 2.3. See https://edgeguides.rubyonrails.org/2_3_release_notes.html#other-railties-changes
* Bump license years for 2019Arun Agrawal2018-12-312-2/+2
|
* Import Action MailboxGeorge Claghorn2018-12-251-12/+11
|
* Enable `Style/RedundantBegin` cop to avoid newly adding redundant begin blockRyuta Kamizono2018-12-215-29/+19
| | | | | | | | | | Currently we sometimes find a redundant begin block in code review (e.g. https://github.com/rails/rails/pull/33604#discussion_r209784205). I'd like to enable `Style/RedundantBegin` cop to avoid that, since rescue/else/ensure are allowed inside do/end blocks in Ruby 2.5 (https://bugs.ruby-lang.org/issues/12906), so we'd probably meets with that situation than before.
* Module#{define_method,alias_method,undef_method,remove_method} become public ↵Ryuta Kamizono2018-12-211-4/+4
| | | | | | since Ruby 2.5 https://bugs.ruby-lang.org/issues/14133
* Use native `Array#append`, `Array#prepend`, `Hash#transform_keys`, and ↵Ryuta Kamizono2018-12-202-4/+0
| | | | | | | | | | `Hash#transform_keys!` Since Rails 6 requires Ruby 2.5. https://github.com/ruby/ruby/blob/ruby_2_5/NEWS Follow up #34754.
* Allow nil params on controller HTTP test methodsr7kamura2018-12-181-2/+2
|
* Merge branch 'master' into host-authorizationEileen M. Uchitelle2018-12-171-6/+5
|\
| * Allow using parsed_body in ActionController::TestCaseTobias Bühlmann2018-12-161-6/+5
| | | | | | | | | | | | | | | | | | | | | | | | … by switching the initialzation of an appropriate response parser in `ActionDispatch::TestResponse` from eagerly to lazily. By doing so, the response parser can be correctly set for `ActionController::TestCase`, which doesn't include the content type header in the constructor but only sets it at a later time. Fixes #34676.
* | Introduce a guard against DNS rebinding attacksGenadi Samokovarov2018-12-156-41/+171
|/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The ActionDispatch::HostAuthorization is a new middleware that prevent against DNS rebinding and other Host header attacks. By default it is included only in the development environment with the following configuration: Rails.application.config.hosts = [ IPAddr.new("0.0.0.0/0"), # All IPv4 addresses. IPAddr.new("::/0"), # All IPv6 addresses. "localhost" # The localhost reserved domain. ] In other environments, `Rails.application.config.hosts` is empty and no Host header checks will be done. If you want to guard against header attacks on production, you have to manually permit the allowed hosts with: Rails.application.config.hosts << "product.com" The host of a request is checked against the hosts entries with the case operator (#===), which lets hosts support entries of type RegExp, Proc and IPAddr to name a few. Here is an example with a regexp. # Allow requests from subdomains like `www.product.com` and # `beta1.product.com`. Rails.application.config.hosts << /.*\.product\.com/ A special case is supported that allows you to permit all sub-domains: # Allow requests from subdomains like `www.product.com` and # `beta1.product.com`. Rails.application.config.hosts << ".product.com"
* Upgrade Rubocop to 0.61.1 and fix offensesVinicius Stock2018-12-101-79/+79
|
* Expand metaprogramming for Symbol, Slash and Dot.Alberto Almagro2018-12-071-6/+7
| | | | | | | | | | | | | | This first started with moving type method inside `ActionDispatch::Journey::Nodes::Symbol`. `AD::Journey::Nodes::Symbol#type` was generated dynamically with an `each` block. While this is OK for classes like `AD::Journey::Nodes::Slash` or `AD::Journey::Nodes::Dot` which don't have further implementation, all other classes containing more logic have this method defined in their class body. This patch does the same in this case. On code review process @kamipo suggested to fully expand over metaprogramming for Slash and Dot classes, a topic on which I agree with him.
* colorize the unpermitted params log messageblahed2018-12-031-1/+1
|
* Remove unnecessary variable routeAlberto Almagro2018-12-021-11/+2
| | | | | The variable `route` was only allocated to hold an object that was immediately returned. This patch removes that variable.
* Merge pull request #34554 from sj26/group-exception-logsRafael França2018-11-281-5/+8
|\ | | | | Log exceptions atomically
| * Avoid extra array allocationsSamuel Cochran2018-11-291-2/+2
| |
| * Log exceptions atomicallySamuel Cochran2018-11-281-5/+8
| | | | | | | | | | | | When distributed over multiple logger calls the lines can become intermixed with other log statements. Combining them into a single logger call makes sure they always get logged together.
* | Add autoload hook for AbstractController::ActionNotFoundRafael Mendonça França2018-11-281-0/+1
|/ | | | | | | | | The error can be reproduced with require "bundler/setup" require "action_controller" AbstractController::ActionNotFound
* Raise an error on root route naming conflicts.Gannon McGibbon2018-11-201-4/+2
| | | | | Raises an ArgumentError when multiple root routes are defined in the same context instead of assigning nil names to subsequent roots.
* Merge pull request #20865 from colavitam/only-except-behaviorRafael Mendonça França2018-11-191-2/+8
|\ | | | | | | :only and :except are now chained for routing resource(s)
| * :only and :except are now chained for routing resource(s)Michael Colavita2015-07-131-3/+9
| | | | | | | | | | | | | | | | | | | | | | Allow chaining the :only and :except options for routing resource(s). Previously, the following yielded routes for both show and destroy: resource :account, :only => [:show, :destroy], :except => :destroy This now yields only the show action. This chaining can be useful for passing optional :except options to code that makes use of the :only option (e.g. for a gem with its own routing methods).
* | Remove unused `Journey::Router::RoutingError`yuuji.yaginuma2018-11-181-3/+0
| | | | | | | | `Journey::Router::RoutingError` is no longer used since db06d128262b49c8b02e153cf95eb46f4eff364b.
* | Allow rescue from parameter parse errorsGannon McGibbon2018-11-135-8/+25
| | | | | | | | [Gannon McGibbon + Josh Cheek]
* | Reset sessions on failed system test screenshotMaxim Perepelitsa2018-11-131-2/+5
| | | | | | | | | | Reset Capybara sessions if `take_failed_screenshot` raise exception in system test `after_teardown`.
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-16 11:30:25 +0000