Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Add more rubocop rules about whitespaces | Rafael Mendonça França | 2016-10-29 | 34 | -58/+58 |
| | |||||
* | Support plain loggers in DebugExceptions | Genadi Samokovarov | 2016-10-28 | 1 | -1/+3 |
| | | | | | | | | | | | | | | I have been seeing people setting `Logger` instances for `config.logger` and it blowing up on `rails/web-console` usage. Now, I doubt many folks are manually setting `ActionView::Base.logger`, but given that `DebugExceptions` is running in a pretty fragile environment already, having it crash (and being silent) in those cases can be pretty tricky to trace down. I'm proposing we verify whether the `ActionView::Base.logger` supports silencing before we try to do it, to save us the headache of tracing it down. | ||||
* | Fix :stopdoc: to :startdoc: [ci skip] | Ryuta Kamizono | 2016-10-28 | 1 | -1/+1 |
| | |||||
* | removes requires already present in active_support/rails | Xavier Noria | 2016-10-27 | 2 | -3/+0 |
| | |||||
* | let Regexp#match? be globally available | Xavier Noria | 2016-10-27 | 1 | -1/+0 |
| | | | | | | Regexp#match? should be considered to be part of the Ruby core library. We are emulating it for < 2.4, but not having to require the extension is part of the illusion of the emulation. | ||||
* | remove unused `RedirectBackError` class | yuuji.yaginuma | 2016-10-27 | 1 | -8/+0 |
| | | | | Follow up to 333bfd896e87862cece95deb1ef88132d5f54ba8 | ||||
* | Remove all Journey constant from public API | Rafael Mendonça França | 2016-10-26 | 5 | -7/+17 |
| | | | | | | There were never public API only there by mistake. [ci skip] | ||||
* | HSTS subdomains is now true, so let's fix documentation [ci skip] (#26870) | प्रथमेश Sonpatki | 2016-10-23 | 1 | -1/+1 |
| | | | - Followup of fda5afeb | ||||
* | Revert "Undefine assings in IntegrationTest" | Rafael Mendonça França | 2016-10-21 | 1 | -2/+0 |
| | | | | | | This reverts commit 5dde413e1d14c42eb87071db20d075a7b962cb01. Reason: The gem defines it so we don't need to remove | ||||
* | /s/integrations/integration [ci skip] (#26801) | प्रथमेश Sonpatki | 2016-10-16 | 1 | -1/+1 |
| | |||||
* | Merge pull request #26786 from codeodor/patch-1 | Eileen M. Uchitelle | 2016-10-15 | 1 | -1/+3 |
|\ | | | | | Allow any key in Renderer environment hash | ||||
| * | Allow any key in Renderer environment hash | Sammy Larbi | 2016-10-15 | 1 | -1/+3 |
| | | | | | | | | | | | | When rendering arbitrary templates, it is helpful to not overwrite `env` keys with nil if they don't match any found in the `RACK_KEY_TRANSLATION` This allows the developer to set the environment to exactly what is needed for rendering. | ||||
* | | Copy-edit the documentation | Rafael Mendonça França | 2016-10-15 | 1 | -4/+4 |
| | | | | | | | | [ci skip] | ||||
* | | Make `process` a non-private method and update documentation. | Zach Aysan | 2016-10-15 | 1 | -98/+100 |
|/ | |||||
* | ActionController::Parameters#deep_dup (#26567) | Pavel Evstigneev | 2016-10-11 | 1 | -0/+7 |
| | | | | | | | | | | | * ActionController::Parameters#deep_dup * Tests for ActionController::Parameters#deep_dup * Fix test for ActionController::Parameters#deep_dup * More tests for ActionController::Parameters#deep_dup [Rafael Mendonça França + Pavel Evstigneev] | ||||
* | Add missing @, fix indents. [ci skip] | bogdanvlviv | 2016-10-10 | 1 | -6/+6 |
| | |||||
* | Remove deprecated support to non-keyword arguments in ↵ | Rafael Mendonça França | 2016-10-10 | 1 | -42/+11 |
| | | | | | | `ActionDispatch::IntegrationTest`, `#process`, `#get`, `#post`, `#patch`, `#put`, `#delete`, and `#head`. | ||||
* | Remove deprecated `ActionDispatch::IntegrationTest#*_via_redirect`. | Rafael Mendonça França | 2016-10-10 | 1 | -53/+0 |
| | |||||
* | Remove deprecated `ActionDispatch::IntegrationTest#xml_http_request` | Rafael Mendonça França | 2016-10-10 | 1 | -32/+0 |
| | |||||
* | Remove deprecated support for passing `:path` and route path as stings in ↵ | Rafael Mendonça França | 2016-10-10 | 1 | -12/+1 |
| | | | | `ActionDispatch::Routing::Mapper#match` | ||||
* | Remove deprecated support passing path as `nil` in ↵ | Rafael Mendonça França | 2016-10-10 | 1 | -5/+1 |
| | | | | `ActionDispatch::Routing::Mapper#match` | ||||
* | Remove deprecated `cache_control` argument from ↵ | Rafael Mendonça França | 2016-10-10 | 1 | -8/+1 |
| | | | | `ActionDispatch::Static#initialize` | ||||
* | Remove deprecated support to passing strings to the middleware stack | Rafael Mendonça França | 2016-10-10 | 2 | -21/+2 |
| | |||||
* | Remove deprecated code in ssl middleware | Rafael Mendonça França | 2016-10-10 | 1 | -21/+3 |
| | |||||
* | Remove deprecated code in ActionDispatch::Session::SessionRestoreError | Rafael Mendonça França | 2016-10-10 | 1 | -11/+1 |
| | |||||
* | Deprecated ActionDispatch::ParamsParser::ParamsParser | Rafael Mendonça França | 2016-10-10 | 5 | -34/+27 |
| | | | | | | ActionDispatch::ParamsParser class was removed in favor of ActionDispatch::Http::Parameters so it is better to move the error constant to the new class. | ||||
* | Remove deprecated ActionDispatch::ParamsParser | Rafael Mendonça França | 2016-10-10 | 1 | -12/+1 |
| | |||||
* | Remove deprecated code in ActionDispatch::ParamsParser::ParseError | Rafael Mendonça França | 2016-10-10 | 1 | -17/+1 |
| | |||||
* | Remove deprecated access to mime types through constants | Rafael Mendonça França | 2016-10-10 | 1 | -26/+0 |
| | |||||
* | Remove deprecated support to non-keyword arguments #process | Rafael Mendonça França | 2016-10-10 | 1 | -70/+16 |
| | |||||
* | Remove deprecated `xml_http_request` and `xhr` methods | Rafael Mendonça França | 2016-10-10 | 1 | -15/+0 |
| | |||||
* | Remove deprecated methods in ActionController::Parameters | Rafael Mendonça França | 2016-10-10 | 1 | -20/+0 |
| | |||||
* | Remove deprecated comparing support with `ActionController::Parameters` | Rafael Mendonça França | 2016-10-10 | 1 | -9/+0 |
| | |||||
* | Remove deprecated support to :text in render | Rafael Mendonça França | 2016-10-10 | 1 | -12/+1 |
| | |||||
* | Remove deprecated support to :nothing in render | Rafael Mendonça França | 2016-10-09 | 1 | -5/+0 |
| | |||||
* | Remove deprecated support to `:back` in `redirect_to` | Rafael Mendonça França | 2016-10-09 | 1 | -8/+0 |
| | |||||
* | Remove deprecated support for status option in head | Rafael Mendonça França | 2016-10-09 | 1 | -7/+1 |
| | |||||
* | Remove deprecation at ActionController::BadRequest | Rafael Mendonça França | 2016-10-09 | 1 | -11/+1 |
| | |||||
* | Remove deprecated methods related to controller filters | Rafael Mendonça França | 2016-10-09 | 1 | -39/+0 |
| | | | | | | | | | | `skip_action_callback`, `skip_filter`, `before_filter`, `prepend_before_filter`, `skip_before_filter`, `append_before_filter`, `around_filter` `prepend_around_filter`, `skip_around_filter`, `append_around_filter`, `after_filter`, `prepend_after_filter`, `skip_after_filter` and `append_after_filter`. | ||||
* | Undefine assings in IntegrationTest | Rafael Mendonça França | 2016-10-07 | 1 | -0/+2 |
| | | | | | assigns assert the state of a controller instance what should not be done in an integration test. | ||||
* | [ci-skip] Swap method and its alias, format doc | Andrey Molchanov | 2016-10-04 | 1 | -3/+4 |
| | |||||
* | Show an "unmatched constraints" error for mismatching and present params | Chris Carter | 2016-10-03 | 2 | -2/+6 |
| | | | | | | | | | | | | Currently a misleading "missing required keys" error is thrown when a param fails to match the constraints of a particular route. This commit ensures that these params are recognised as unmatching rather than missing. Note: this means that a different error message will be provided between optimized and non-optimized path helpers, due to the fact that the former does not check constraints when matching routes. Fixes #26470. | ||||
* | Remove obsolete comment about class-level respond_to | Andrew White | 2016-10-01 | 1 | -2/+0 |
| | | | | | | The class-level respond_to was extracted in ee77770 to responders gem [ci skip] | ||||
* | Merge pull request #26573 from kirs/action-controller-as-format | Rafael França | 2016-09-27 | 1 | -4/+4 |
|\ | | | | | Make :as option also set request format (AC::TestCase) | ||||
| * | Make :as option also set request format (AC::TestCase) | Kir Shatrov | 2016-09-21 | 1 | -4/+4 |
| | | | | | | | | | | | | | | | | right now you'd have to specify both :as and :format: ``` post :create, params: { foo: "bar" } as: :json, format: :json ``` | ||||
* | | Only search fixture_path for files that can't be found directly | Matthew Draper | 2016-09-24 | 1 | -1/+2 |
| | | | | | | | | | | | | | | | | | | | | When passed an already-valid file name, prepending the path is likely to create problems. This is particularly relevant for #26384, which adds fixture_path handling to test classes that previously didn't have it: any existing caller must have been manually locating the file, and we don't want to break them. | ||||
* | | Merge pull request #26589 from kirs/ad-test-request-method | Arthur Nogueira Neves | 2016-09-22 | 1 | -1/+1 |
|\ \ | | | | | | | Fix memoization bug on ActionDispatch::TestRequest#request_method= | ||||
| * | | Fix memoization bug on ActionDispatch::TestRequest#request_method= | Kir Shatrov | 2016-09-22 | 1 | -1/+1 |
| |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | TestRequest have been overrriding request_method setter since 2009, but the actual implementation in Request (not TestRequest) has been changed since that. Now it's also using @request_method instance variable to keep the state. The override in TestRequest have not been calling `super`, which caused a bug that after accessing #requst_method the value was memoized and then we've never been able to change it anymore: ``` req = ActionDispatch::TestRequest.create puts "was: #{req.request_method}" # memoized here req.request_method = "POST" puts "became: #{req.request_method}" ``` output: ``` was: GET became: GET ``` Since the whole purpose of overriding the setter in TestRequest is to upcase it, I'm changing it to `super(method.to_s.upcase)` | ||||
* | | Merge pull request #26498 from FriedSock/correct-render-text-deprecation-message | Rafael França | 2016-09-14 | 1 | -1/+1 |
|\ \ | | | | | | | Correct `render text:` deprecation message | ||||
| * | | Correct `render text:` deprecation message | Jack Bracewell | 2016-09-14 | 1 | -1/+1 |
| | | | | | | | | | The default Content-Type is `text/html`, not `text/plain`. |