aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/lib
Commit message (Collapse)AuthorAgeFilesLines
* Fix collection_radio_buttons with the option `:checked` with value ofRafael Mendonça França2012-12-261-1/+2
| | | | `false`
* Merge pull request #8598 from NARKOZ/refactor-highlightSantiago Pastorino2012-12-261-2/+2
|\ | | | | refactor highlight method: return fast if text or phrases are blank
| * fetch highlighter option only when neededNihad Abbasov2012-12-241-2/+2
| |
* | We need to check explictly that env['action_dispatch.show_exceptions']Rafael Mendonça França2012-12-261-1/+1
| | | | | | | | | | | | is false. If it is nil we can't raise the exception
* | more descriptive return parametersHrvoje Šimić2012-12-261-4/+3
|/
* "warning: ambiguous first argument; put parentheses or even spaces"Akira Matsuda2012-12-241-1/+1
|
* Merge pull request #8085 from acapilleri/format_never_nilGuillermo Iguaran2012-12-221-1/+12
|\ | | | | if format is unknown NullMimeTypeObject is returned
| * return Mime::NullType if format is unknownAngelo Capilleri2012-12-221-1/+12
| | | | | | | | | | | | | | | | | | | | If a request has an unknown format, the methods html?, xml?, json? ...etc not raise an Exception. This patch add a class Mime::NullType, that is returned when request.format is unknown and it responds false to the methods that ends with '?' and true to 'nil?'. It refers to #7837, this issue is considered a improvement not a bug.
* | Merge pull request #8586 from balexand/cache_digests_regexRafael Mendonça França2012-12-211-1/+1
|\ \ | |/ |/| Digestor explicit dependency should not contain trailing whitespace
| * Digestor explicit dependency should not contain trailing whitespaceBrian Alexander2012-12-211-1/+1
| | | | | | | | test for rails/rails#8586
* | Merge pull request #7312 from krainboltgreene/http-token-parser-bugSteve Klabnik2012-12-211-11/+27
|\ \ | |/ |/| Http token parser bug
| * Refactoring the token_and_options method to fix bugsKurtis Rainbolt-Greene2012-12-151-11/+27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Adding a test for the equal trun bug Adding a test for the after equal trunc bug Adding a test for the slash bug Adding a test for the slash quote bug Adding a helper method for creating a sample request object with token Writing a method to create params array from raw params Writing a method to rewrite param values in the params Writing a method to get the token params from an authorization value Refactoring the token_and_options method to fix bugs Removing unnessecary test A constant for this shared regex seemed appropriate Wanting to split up this logic Adding small documentation pieces
* | Merge branch 'master' of github.com:lifo/docrailsVijay Dev2012-12-212-1/+6
|\ \
| * | Revert "Fix incorrect adjustment 4c41e87e3ae548c44810b66437b2f0f6e73b2106"Vijay Dev2012-12-211-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | This reverts commit e1f8ec59f2cc83f052b15233147aa2d6d8114a4d. Reason: seems bad styling [ci skip]
| * | Fix incorrect adjustment 4c41e87e3ae548c44810b66437b2f0f6e73b2106kei2012-12-201-1/+1
| | |
| * | Fix documentation stylekei2012-12-201-1/+1
| | |
| * | Add script_name option description and example for #url_for optionsIvan Vanyak2012-12-171-0/+5
| |/
* | Fix indentation issuing warningCarlos Antonio da Silva2012-12-201-1/+1
| |
* | update AD::Journey to follow Rails coding conventionsFrancesco Rodriguez2012-12-2016-437/+439
| |
* | :nodoc: Journey because is not part of the public API [ci skip]Francesco Rodriguez2012-12-1920-78/+75
| |
* | remove code for Ruby 1.8.x supportFrancesco Rodriguez2012-12-191-7/+2
| |
* | Remove the actual extension file as well [ci skip]Andrew White2012-12-191-11/+0
| |
* | Remove obsolete Hash extension needed for Ruby 1.8.x supportAndrew White2012-12-191-1/+0
| | | | | | | | [ci skip]
* | Integrate Journey into Action DispatchAndrew White2012-12-1928-1/+2340
| | | | | | | | | | | | | | | | Move the Journey code underneath the ActionDispatch namespace so that we don't pollute the global namespace with names that may be used for models. Fixes rails/journey#49.
* | Remove obfuscation support from mail_to helperNick Reed2012-12-181-54/+12
| | | | | | | | | | | | Removes support for :encode, :replace_at, and :replace_dot options from the mail_to helper. Support for these options has been extracted to the 'actionview-encoded_mail_to' gem.
* | Minor js review [ci skip]Carlos Antonio da Silva2012-12-181-7/+7
| | | | | | | | Remove/add ; where necessary, fix indentation.
* | handle protocol option in stylesheet_link_tag and javascript_include_tagVasiliy Ermolovich2012-12-181-2/+6
| | | | | | | | closes #8388
* | Format routes as html on debug pageschneems2012-12-174-2/+76
| | | | | | | | | | | | | | | | | | When someone gets a routing exception, the routes are rendered (starting in Rails 4.0). This PR brings parity between the html routes in the `rails/info/routes` path and when rendered from an exception. This is the continuation of #8521 which brought html formatted routes. In addition to bringing parity to the two views, we're keeping our views DRY by rendering off of the same partials. In this case Railties depends on partials provided by ActionDispatch. I'm open to alternative implementations. Ideally both views will use the same code so any improvements or updates to it will be reproduced on both. <hr /> ![](http://f.cl.ly/items/3O1D0K1v0j0i343O3T3T/Screen%20Shot%202012-12-17%20at%203.07.20%20PM.png)
* | Make conditional_layout? private and update documentationAndrew White2012-12-171-15/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The conditional_layout? method is not for public use and doesn't actually do what the documentation suggested it does. It's actually used to determine whether or not to use the explicit layout definition defined in a controller or use the implicit layout definition. Also documentation was added for the action_has_layout? method which acts as a master switch for disabling the layout for the current action. This method was added so that action caching didn't depend on accessing layout internals but is also used by third-parties, most notably the [Hobo][1] application. [1]: https://github.com/hobo/hobo
* | Merge pull request #8529 from schneems/schneems/debug-exceptions-extend-pathSteve Klabnik2012-12-161-1/+1
|\ \ | |/ |/| DebugExceptions `File.join` => `File.expand_path`
| * DebugExceptions `File.join` => `File.expand_path`schneems2012-12-161-1/+1
| |
* | Merge branch 'master' of github.com:lifo/docrailsVijay Dev2012-12-151-0/+412
|\ \ | | | | | | | | | | | | | | | Conflicts: actionpack/lib/action_view/helpers/form_helper.rb railties/lib/rails/info_controller.rb
| * | repeating documentation for form helpersThiago Pinto2012-12-091-18/+406
| | |
* | | Revert "Merge pull request #8499 from schneems/schneems/html-route-inspector"Steve Klabnik2012-12-141-24/+7
| | | | | | | | | | | | | | | | | | | | | This reverts commit ae68fc3864e99ab43c18fd12577744e1583f6b64, reversing changes made to 0262a18c7b0ab6f60fee842b3007388f9ffeb0fa. See here: https://github.com/rails/rails/pull/8499#issuecomment-11356417
* | | remove a cache we do not needAaron Patterson2012-12-141-5/+1
| | |
* | | Merge pull request #8510 from thedarkone/thread_safety_improvementsAaron Patterson2012-12-146-63/+48
|\ \ \ | | | | | | | | Thread safety improvements
| * | | Replace some global Hash usages with the new thread safe cache.thedarkone2012-12-146-63/+48
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Summary of the changes: * Add thread_safe gem. * Use thread safe cache for digestor caching. * Replace manual synchronization with ThreadSafe::Cache in Relation::Delegation. * Replace @attribute_method_matchers_cache Hash with ThreadSafe::Cache. * Use TS::Cache to avoid the synchronisation overhead on listener retrieval. * Replace synchronisation with TS::Cache usage. * Use a preallocated array for performance/memory reasons. * Update the controllers cache to the new AS::Dependencies::ClassCache API. The original @controllers cache no longer makes much sense after @tenderlove's changes in 7b6bfe84f3 and f345e2380c. * Use TS::Cache in the connection pool to avoid locking overhead. * Use TS::Cache in ConnectionHandler.
* | | | Improve the documentation of cache_if and cache_unlessRafael Mendonça França2012-12-141-4/+7
| | | |
* | | | Merge pull request #8497 from acapilleri/conditional_cacheRafael Mendonça França2012-12-141-12/+24
|\ \ \ \ | | | | | | | | | | | | | | | Removed :if / :unless conditions to fragment cache in favour of *cache_i...
| * | | | Removed :if and :unless from fragment cache option in favour ofAngelo capilleri2012-12-141-12/+24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | cache_if(condition, option, &block) and cache_unless(condition, option, &block). In the PR #8371 was introduced conditional options :if and :unless in the cache method. Example: <%= cache @model, if: some_condition(@model) do %> ... <%end%> This is a good feature but *cache_if* and and *cache_unless* are more concise and close to the standard of rails view helpers (ex: link_to_if and link_to_unless). Example: <%= cache_if condition, @model do %> ... <%end%>
* | | | | Clear url helper methods when routes are reloadedAndrew White2012-12-141-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | | Remove all the old url helper methods when clear! is called on the route set because it's possible that some routes have been removed.
* | | | | Revert "Clear url helpers when reloading routes"Andrew White2012-12-141-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This doesn't actually remove old url helper methods as they are defined in a different module. This reverts commit 96bcef947bf713b7d9fc88f26dff69f568111262. Conflicts: actionpack/CHANGELOG.md
* | | | | Add missing require.Rafael Mendonça França2012-12-133-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | I was trying to use those files without Rails and that require was missing.
* | | | | Merge pull request #8499 from schneems/schneems/html-route-inspectorSteve Klabnik2012-12-131-7/+24
|\ \ \ \ \ | | | | | | | | | | | | Output routes in :html format
| * | | | | Output routes in :html formatschneems2012-12-121-7/+24
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | By formatting routes for different media (txt/html) we can apply optimizations based on the format. We can include meta-data in the HTML to allow a rich experience while rendering and viewing the routes. This PR shows route helpers as they are used with the `_path` extension, it also has a javascript toggle on the top to switch to `_url`. This way the developer can see the exact named route helper they can use instead of having to modify a base. This is one example of an optimization that could be applied. Eventually we can link out to guides for the different columns to better explain what helper, HTTP Verb, Path, and Controller#action indicate. We could even add a route search box that could allow developers to input a given route and see all of the routes that match it. These are stand alone features and should be delivered separately.
* | | | | Bring back helpers_path attr accessorCarlos Antonio da Silva2012-12-131-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | This is apparently used by the railtie to setup the app helpers paths correctly between initializers. I'll need to check it further.
* | | | | Refactor helpers code in Action Pack a bitCarlos Antonio da Silva2012-12-133-8/+6
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Avoid calling class_eval when not needed * Remove helpers_path attr accessor, it's defined as a class attribute a few lines later * Avoid creating extra arrays when finding helpers, use flat_map and sort! * Remove not required refer variable when redirecting :back
* | | | Remove deprecation message from Action PackCarlos Antonio da Silva2012-12-111-1/+1
| | | | | | | | | | | | | | | | | | | | Related to the deprecation of Time.utc_time in favor of Time.utc, in 48583f8bf74d1cefefea3cd6591bd546a9eaff6c.
* | | | Remove not used variable warnings from AM and ACCarlos Antonio da Silva2012-12-111-1/+1
| | | |
* | | | Fix rewinding in ActionDispatch::Request#raw_postMatt Venables2012-12-111-2/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If env['RAW_POST_DATA'] is nil, #raw_post will attempt to set it to the result of #body (which will return env['rack.input'] if env['RAW_POST_DATA'] is nil). #raw_post will then attempt to rewind the result of another call to #body. Since env['RAW_POST_DATA'] has already been set, the result of #body is not env['rack.input'] anymore. This causes env['rack.input'] to never be rewound.
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-16 05:25:25 +0000