| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
| |
If embedding auth_token in remote forms is off and we
pass a value for auth_token it should respect it.
|
|
|
|
|
|
|
| |
Changed default value for `config.action_view.embed_authenticity_token_in_remote_forms`
to `false`. This change breaks remote forms that need to work also without javascript,
so if you need such behavior, you can either set it to `true` or explicitly pass
`:authenticity_token => true` in form options
|
|
|
|
|
|
|
|
|
|
|
|
| |
There is a regression introduced in 16ee611fa, which breaks
remote forms that should also work without javascript. This commit
introduces config option that allows to configure this behavior
defaulting to the old behavior (ie. include authenticity token
in remote forms by default)
Conflicts:
actionpack/CHANGELOG.md
|
|\
| |
| | |
Fix label_tag to merge the options hash with the object hash
|
| |
| |
| |
| |
| |
| | |
hash.
Closes #2492 and #5615
|
| |
| |
| |
| |
| |
| |
| |
| | |
doesn't call for label.
objectify_options method should be applied to the proper options arg.
See explanation and example of the bug - https://github.com/kryzhovnik/rails_field_error_proc_bug_example
|
|\ \
| | |
| | | |
Don't break Haml with textarea newline fix. (master)
|
| | |
| | |
| | |
| | |
| | |
| | | |
See issue #393, issue #4000, issue #5190, and issue #5191. Adds a newline after the textarea opening tag based on @codykrieger's original patch so that we don't cause regressions in Haml-using apps. The regression caused textarea tags to add newlines to the field unintentionally (each update/save added an extra newline.)
Also fix 6 more tests that didn't yet have the newline expectation.
|
|/ /
| |
| |
| |
| | |
if you want to read the file you may need to ask if there is something
to read from
|
|\ \
| |/
|/| |
|
| | |
|
| | |
|
| |
| |
| |
| | |
It is in response for confusion in issue #5301
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Previously `rendered_format` was set only based on mime types
passed in Accept header, which was wrong if first type from
Accept was different than rendered partial. The fix is to simply
move setting rendered_format to the place where template
is available and grab format from the template. If it fails
we can fallback to formats passed by Accept header.
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
When someone accidentally passes a string to sanitize like:
sanitize("<span>foo</span>", :tags => "b")
there is no indication that it's the wrong way and span
will not be removed.
|
| | |
|
|\ \
| | |
| | | |
Properly deprecate the block argument in AV FormBuilder
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Commit 56089ca986c767763f29159c8de0aa1ebabfd4d2 introduced a backward
incompatible change by changing the method signature of the FormBuilder.
This brings back the same method signature warning in case someone gives
a block to the builder.
More info: https://github.com/rails/rails/commit/56089ca986c767763f29159c8de0aa1ebabfd4d2#commitcomment-1116166
|
| | | |
|
|\ \ \
| | | |
| | | | |
use content_tag in button_to helper
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
By default, resources routes are created with :resource/:id. A model
defining to_param can make prettier urls by using something more
readable than an integer ID, but since the route picks it up as :id you
wind up with awkward User.find_by_username(params[:id]) calls.
By overriding the key to be used in @request.params you can be more
obvious in your intent.
|
|\ \ \ \
| | | | |
| | | | | |
ActionController caching small String#split optimization
|
| | |_|/
| |/| | |
|
|/ / /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Reason: This commit changes code that was committed some year
and a half ago. The original code is an ordinary predicate
that delegates straight to a boolean operator with no further
unnecessaru adorments, as clearly explained in #5329.
This change also may confuse users who may now believe they can
rely now on singletons, while predicates in Rails rely on
standard Ruby semantics for boolean values and guarantee no
singletons whatsover.
This reverts commit 6349791d5aaf652631b29f1371701fc2985fda83.
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
Conflicts:
guides/source/ruby_on_rails_guides_guidelines.textile
|
| | | | |
|
| | | | |
|
|\ \ \ \
| |_|_|/
|/| | | |
Remove code duplication
|
| | | | |
|
|/ / /
| | |
| | |
| | | |
headers (and its causing problems for Strong Parameters attempt of wrapping request.parameters because it will change in testing)
|
| | |
| | |
| | |
| | | |
keyword
|
| | | |
|
|\ \ \
| |/ /
|/| | |
Fixes issue #5222: DateTimeSelector builds invalid dates on leap days
|
| | |
| | |
| | |
| | | |
discarding both day and month.
|
|\ \ \
| |/ /
|/| | |
|
| | | |
|
| | | |
|
| |\ \ |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| |/ /
|/| | |
|
| | | |
|
| | | |
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
Conflicts:
railties/guides/source/getting_started.textile
|
| | | | |
|