Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | | | | | | Never treat action or controller as unpermitted params | David Heinemeier Hansson | 2013-01-08 | 1 | -6/+15 | |
| | | | | | | ||||||
* | | | | | | Eliminate Rack::File headers deprecation warning | Sam Ruby | 2013-01-08 | 1 | -1/+1 | |
|/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | See http://intertwingly.net/projects/AWDwR4/checkdepot/section-6.1.html rake test produces: "Rack::File headers parameter replaces cache_control after Rack 1.5." Despite what the message says, it appears that the hearders parameter change will be effective as of Rack 1.5: https://github.com/rack/rack/blob/rack-1.4/lib/rack/file.rb#L24 https://github.com/rack/rack/blob/master/lib/rack/file.rb#L24 | |||||
* | | / / | Do not generate local vars for partials without object or collection | Carlos Antonio da Silva | 2013-01-08 | 1 | -1/+1 | |
| |_|/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously rendering a partial without giving :object or :collection would generate a local variable with the partial name by default. This was noticed due to warnings in Ruby 2.0 of not used variables, which turned out to be the generation of not used variables inside partials that do not contain objects related to them. | |||||
* | | | | Avoid Rack security warning no secret provided | Santiago Pastorino | 2013-01-08 | 1 | -0/+2 | |
| |/ / |/| | | | | | | | | This avoids "SECURITY WARNING: No secret option provided to Rack::Session::Cookie." | |||||
* | | | improve StrongParameters documentation [ci skip] | Francesco Rodriguez | 2013-01-07 | 1 | -8/+7 | |
| | | | ||||||
* | | | access `@path` and `@routes` via reader methods in journey | Gosha Arinich | 2013-01-07 | 2 | -3/+3 | |
| | | | ||||||
* | | | refactor ShowExceptions' #call to use def-rescue instead of begin-rescue | Gosha Arinich | 2013-01-07 | 1 | -7/+4 | |
| | | | ||||||
* | | | remove begin-rescue in favor of def-rescue | Gosha Arinich | 2013-01-07 | 1 | -10/+9 | |
| | | | ||||||
* | | | Fix operators precedence issue | Rafael Mendonça França | 2013-01-06 | 1 | -1/+1 | |
| | | | ||||||
* | | | Merge pull request #8787 from tank-bohr/master | Rafael Mendonça França | 2013-01-06 | 1 | -2/+2 | |
|\ \ \ | | | | | | | | | masgn and response variable | |||||
| * | | | return multiple assingment and response variable | tank-bohr | 2013-01-07 | 1 | -2/+2 | |
| | | | | ||||||
* | | | | Merge pull request #8785 from goshakkk/refactor-debug-exceptions | Rafael Mendonça França | 2013-01-06 | 1 | -2/+1 | |
|\ \ \ \ | |/ / / |/| | | | Refactor DebugExceptions | |||||
| * | | | refactor DebugExceptions by combining two conditionals into one | Gosha Arinich | 2013-01-07 | 1 | -2/+1 | |
| | | | | ||||||
* | | | | Reduce number of Strings a bit | Akira Matsuda | 2013-01-07 | 2 | -4/+4 | |
| | | | | ||||||
* | | | | Namespace HashWithIndifferentAccess | Akira Matsuda | 2013-01-07 | 3 | -3/+3 | |
|/ / / | ||||||
* | | | Merge pull request #8783 from goshakkk/refactor-journey-routes | Rafael Mendonça França | 2013-01-06 | 1 | -12/+11 | |
|\ \ \ | | | | | | | | | Refactor Journey::Routes | |||||
| * | | | refactor Journey::Routes | Gosha Arinich | 2013-01-07 | 1 | -12/+11 | |
| | | | | | | | | | | | | | | | | | | | | * prefer do-end for multiline blocks * prefer or-equals over returns with checks | |||||
* | | | | fix for rbx | tank-bohr | 2013-01-07 | 1 | -2/+2 | |
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | Rubinius returns a boolean after such assingment response = (_, headers, body = @app.call(env)) see https://github.com/rubinius/rubinius/issues/2117 get rid of a local variable | |||||
* | | | Needless requires | Akira Matsuda | 2013-01-06 | 1 | -4/+0 | |
| | | | ||||||
* | | | Missing requires | Akira Matsuda | 2013-01-06 | 1 | -0/+1 | |
| | | | ||||||
* | | | These are already required through AS/rails | Akira Matsuda | 2013-01-06 | 5 | -6/+0 | |
| | | | | | | | | | | | | | | | | | | | | | * core_ext/object/blank * concern * core_ext/class/attribute * deprecation | |||||
* | | | Rename route_wrapper partial layout to table | Carlos Antonio da Silva | 2013-01-06 | 2 | -1/+1 | |
| | | | | | | | | | | | | | | | | | | It is used by the table formatter only, and it's already inside a routes directory that namespaces it properly, so calling it just "table" seems simpler. | |||||
* | | | Move table routes formatter class to the inspector and rename it | Carlos Antonio da Silva | 2013-01-06 | 3 | -19/+19 | |
| | | | | | | | | | | | | | | | | | | | | | It feels more consistent to have this class called "HtmlTableFormatter", and to have it here with the routes inspector and console formatter, since it's used for both routing error exceptions and the rails info page. | |||||
* | | | Merge pull request #8777 from goshakkk/delegate-class | Andrew White | 2013-01-06 | 2 | -2/+2 | |
|\ \ \ | | | | | | | | | Delegate to :class rather than 'self.class' | |||||
| * | | | delegate to :class rather than 'self.class' | Gosha Arinich | 2013-01-06 | 2 | -2/+2 | |
| | | | | ||||||
* | | | | Refactor the logic that checks whether or not to emit the hidden id field | Carlos Antonio da Silva | 2013-01-06 | 1 | -7/+6 | |
| | | | | | | | | | | | | | | | | | | | | By checking for object.persisted? first, we avoid the hash lookups for new objects. | |||||
* | | | | Move the hidden :id field logic to where it belongs to | Carlos Antonio da Silva | 2013-01-06 | 1 | -6/+9 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When dealing with nested forms, Rails automatically generates a hidden field with the id value of the current object being generated by fields_for. This logic was inside the method that's available from the template object, but we just need it when really dealing with nested attributes, so moving the code to here makes more sense. | |||||
* | | | | Eliminate the usage of parent_builder option from form_for | Carlos Antonio da Silva | 2013-01-06 | 1 | -19/+15 | |
| | | | | | | | | | | | | | | | | Just use it internally from fields_for until we come up with a better solution. | |||||
* | | | | Do not call fields_for from form_for, to avoid instantiating two builders | Carlos Antonio da Silva | 2013-01-06 | 1 | -5/+5 | |
| | | | | ||||||
* | | | | Refactor to not call path.ast twice | Carlos Antonio da Silva | 2013-01-06 | 1 | -2/+3 | |
| | | | | ||||||
* | | | | refactor Route#ast to use or-equals and block, instead of return with a cond | Gosha Arinich | 2013-01-06 | 1 | -5/+4 | |
| | | | | ||||||
* | | | | Remove unnecessary begin..rescue..end, use only rescue | Akira Matsuda | 2013-01-06 | 2 | -13/+9 | |
|/ / / | ||||||
* | | | Fix documentation to content_tag_for [ci skip] | Rafael Mendonça França | 2013-01-05 | 1 | -2/+2 | |
| | | | ||||||
* | | | Merge pull request #8766 from jcoglan/session_token_docs | Andrew White | 2013-01-05 | 1 | -7/+4 | |
|\ \ \ | | | | | | | | | | | | | | | | | Remove suggestion that Procs can be used as session secrets. [ci skip] | |||||
| * | | | Remove suggestion that Procs can be used as session secrets. | James Coglan | 2013-01-05 | 1 | -7/+4 | |
| | | | | ||||||
* | | | | Remove warning, remove not used variable, and make methods private | Carlos Antonio da Silva | 2013-01-05 | 1 | -3/+5 | |
|/ / / | | | | | | | | | | Warning: "shadowing outer local variable - routes". | |||||
* | | | Close container div tag in routing error page | Carlos Antonio da Silva | 2013-01-05 | 1 | -9/+11 | |
| | | | ||||||
* | | | Move style to head to make routes page valid html5 | Carlos Antonio da Silva | 2013-01-05 | 2 | -4/+6 | |
| | | | ||||||
* | | | display mountable engine routes on RoutingError. | Yves Senn | 2013-01-05 | 2 | -8/+23 | |
| | | | ||||||
* | | | split formatting concerns from RoutesInspector | Yves Senn | 2013-01-05 | 1 | -20/+42 | |
| | | | ||||||
* | | | Wrong copy and paste :bomb: | Rafael Mendonça França | 2013-01-05 | 1 | -1/+1 | |
| | | | | | | | | | | | | [ci skip] | |||||
* | | | Add documentation to raise_on_unpermitted_parameters option | Rafael Mendonça França | 2013-01-05 | 1 | -2/+17 | |
| | | | | | | | | | | | | [ci skip] | |||||
* | | | Rename the configuration to raise_on_unpermitted_parameters | Rafael Mendonça França | 2013-01-05 | 2 | -11/+13 | |
| | | | | | | | | | | | | Also changed the exception to UnpermittedParameters | |||||
* | | | Ensure that raise_on_unexpected_params configuration will work | Rafael Mendonça França | 2013-01-05 | 1 | -9/+7 | |
| | | | ||||||
* | | | Merge pull request #8752 from thomasfedb/master | Rafael Mendonça França | 2013-01-05 | 2 | -6/+31 | |
|\ \ \ | | | | | | | | | Exception on unexpected params when enabled. | |||||
| * | | | Allow developers to enable raising of exception when unexpected params are ↵ | Thomas Drake-Brockman | 2013-01-05 | 2 | -6/+31 | |
| | | | | | | | | | | | | | | | | provided. | |||||
* | | | | Allow use of durations for ActionDispatch::SSL configuration | Andrew White | 2013-01-04 | 1 | -1/+1 | |
| | | | | ||||||
* | | | | Remove unnecessary `ERB::Util::h` | Ryunosuke SATO | 2013-01-05 | 7 | -17/+17 | |
| | | | | | | | | | | | | | | | | It is automatically applied when strings is unsafe for html. | |||||
* | | | | Suppress warning about IO#lines in Ruby 2.0 | Ryunosuke SATO | 2013-01-04 | 1 | -1/+1 | |
|/ / / | | | | | | | | | | actionpack/lib/action_dispatch/middleware/exception_wrapper.rb:99: IO#lines is deprecated; use #each_line instead | |||||
* | | | Merge pull request #8723 from goshakkk/refactor-error-page | Guillermo Iguaran | 2013-01-03 | 3 | -5/+27 | |
|\ \ \ | | | | | | | | | Move error page js into script tag |