Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | | Move ETag and ConditionalGet logic from AD::Response to the middleware stack. | José Valim | 2010-10-03 | 2 | -22/+2 | |
| | | ||||||
* | | Rely on Rack::Session stores API for more compatibility across the Ruby world. | José Valim | 2010-10-03 | 5 | -329/+81 | |
| | | ||||||
* | | PERF: Hash[] + map is faster than this silly inject, and var[1..-1] is ↵ | Santiago Pastorino | 2010-10-03 | 1 | -3/+3 | |
| | | | | | | | | faster than var.sub('@', '') | |||||
* | | Rename _assigns to view_assigns in AV::TC | David Chelimsky | 2010-10-03 | 1 | -9/+21 | |
| | | | | | | | | | | | | | | | | | | - also add tests - also deprecate _assigns [#5751 state:resolved] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | |||||
* | | Fixing search_field to remove object attribute from options hash [#5730 ↵ | Aditya Sanghi | 2010-10-02 | 1 | -1/+1 | |
| | | | | | | | | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | | Revert "Perf: refactor _assign method to avoid inject and defining unneeded ↵ | José Valim | 2010-10-02 | 1 | -1/+5 | |
| | | | | | | | | | | | | | | | | local var." _assigns must return a hash. This reverts commit e66c1cee86aba1c81152f3d0872313e65cec85a9. | |||||
* | | removing AS::Testing::Default in favor of just undefing default_test | Aaron Patterson | 2010-10-01 | 1 | -2/+1 | |
| | | ||||||
* | | Revert "removing crazy finalizer code until there is proof that we need it" | José Valim | 2010-09-30 | 1 | -0/+11 | |
| | | | | | | | | This reverts commit a40e3c1a9604ab3737ad2465c8f6a6db0fe0cc78. | |||||
* | | Properly reload routes defined in class definition | Piotr Sarnacki | 2010-09-30 | 1 | -0/+1 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Sometimes it's easier to define routes inside Engine or Application class definition (e.g. one file applications). The problem with such case is that if there is a plugin that has config/routes.rb file, it will trigger routes reload on application. Since routes definition for application is not in config/routes.rb file routes_reloader will fail to reload application's routes properly. With this commit you can pass routes definition as a block to routes method, which will allow to properly reload it: class MyApp::Application < Rails::Application routes do resources :users end end | |||||
* | | Allow mounting engines at '/' | Piotr Sarnacki | 2010-09-30 | 1 | -1/+1 | |
| | | | | | | | | | | Without that commit script_name always become '/', which results in paths like //posts/1 instead of /posts/1 | |||||
* | | Use .find here as it is simpler and faster. | José Valim | 2010-09-30 | 1 | -1/+1 | |
| | | ||||||
* | | avoid creating a block if possible | Aaron Patterson | 2010-09-29 | 1 | -2/+2 | |
| | | ||||||
* | | fixing regexp warnings | Aaron Patterson | 2010-09-29 | 1 | -1/+1 | |
| | | ||||||
* | | tag value can be false, so nil? check is necessary | Aaron Patterson | 2010-09-29 | 1 | -1/+1 | |
| | | ||||||
* | | another case of extra nil? check | Neeraj Singh | 2010-09-30 | 1 | -1/+1 | |
| | | ||||||
* | | no need to check for nil? | Neeraj Singh | 2010-09-30 | 1 | -2/+2 | |
| | | ||||||
* | | no need to check for nil? | Neeraj Singh | 2010-09-30 | 1 | -1/+1 | |
| | | ||||||
* | | no need of nil check | Neeraj Singh | 2010-09-30 | 1 | -1/+1 | |
| | | ||||||
* | | removing crazy finalizer code until there is proof that we need it | Aaron Patterson | 2010-09-29 | 1 | -9/+0 | |
| | | ||||||
* | | removing useless code | Aaron Patterson | 2010-09-29 | 1 | -1/+0 | |
| | | ||||||
* | | dry up method checking in the request object | Aaron Patterson | 2010-09-29 | 1 | -10/+9 | |
| | | ||||||
* | | reduce function calls on Array | Aaron Patterson | 2010-09-29 | 1 | -3/+2 | |
| | | ||||||
* | | removing more lolinject | Aaron Patterson | 2010-09-29 | 1 | -8/+7 | |
| | | ||||||
* | | removing lollerject | Aaron Patterson | 2010-09-29 | 1 | -1/+1 | |
| | | ||||||
* | | oops, missed a uniq | Aaron Patterson | 2010-09-29 | 1 | -1/+1 | |
| | | ||||||
* | | dry up action_methods | Aaron Patterson | 2010-09-29 | 1 | -4/+4 | |
| | | ||||||
* | | Merge remote branch 'miloops/warnings' | José Valim | 2010-09-29 | 2 | -7/+3 | |
|\ \ | |/ |/| | ||||||
| * | We can't assign @view_context_class here, define super() in test instead if ↵ | Emilio Tagua | 2010-09-29 | 1 | -1/+1 | |
| | | | | | | | | we want to avoid warnings. | |||||
| * | _ is not a valid scheme name character, \w includes it and also is redundant ↵ | Emilio Tagua | 2010-09-29 | 1 | -1/+1 | |
| | | | | | | | | | | | | with \d. 'The scheme name consists of a letter followed by any combination of letters, digits, and the plus ("+"), period ("."), or hyphen ("-") characters; and is terminated by a colon (":").' | |||||
| * | Remove redundant conditional. | Emilio Tagua | 2010-09-29 | 1 | -5/+1 | |
| | | ||||||
| * | Don't try to interpolate string if there's no interpolation point at all. | Emilio Tagua | 2010-09-29 | 1 | -1/+1 | |
| | | ||||||
| * | Initialize @view_context_class and cache view_context_class value. | Emilio Tagua | 2010-09-29 | 1 | -1/+1 | |
| | | ||||||
* | | no need to call e.class | Aaron Patterson | 2010-09-29 | 1 | -1/+1 | |
| | | ||||||
* | | Fix a small typo (ht: masterkain) | José Valim | 2010-09-29 | 1 | -1/+1 | |
|/ | ||||||
* | Ensure that named routes do not overwrite previously defined routes. | José Valim | 2010-09-29 | 1 | -10/+13 | |
| | ||||||
* | Fix an error on 1.8.7. | José Valim | 2010-09-29 | 1 | -1/+1 | |
| | ||||||
* | @_etag is not used anywhere. | José Valim | 2010-09-29 | 1 | -2/+0 | |
| | ||||||
* | Avoid (@_var ||= nil) pattern by using initialize methods and ensuring ↵ | José Valim | 2010-09-29 | 9 | -33/+41 | |
| | | | | everyone calls super as expected. | |||||
* | Merge remote branch 'miloops/warnings' | José Valim | 2010-09-29 | 17 | -23/+39 | |
|\ | ||||||
| * | Define @_layout if it is not defined. | Emilio Tagua | 2010-09-28 | 1 | -0/+1 | |
| | | ||||||
| * | Initialize @path. | Emilio Tagua | 2010-09-28 | 1 | -0/+1 | |
| | | ||||||
| * | Remove more warnings on AP. | Emilio Tagua | 2010-09-28 | 2 | -3/+4 | |
| | | ||||||
| * | Remove more warnings: no need to define attr_accessor if already exists. ↵ | Emilio Tagua | 2010-09-28 | 1 | -3/+5 | |
| | | | | | | | | Initialize ivar. | |||||
| * | Use redefine_method instead define_method, it may be already defined. | Emilio Tagua | 2010-09-28 | 1 | -1/+1 | |
| | | ||||||
| * | Remove method if exists, avoid calling Array#first so many times. | Emilio Tagua | 2010-09-28 | 1 | -3/+5 | |
| | | ||||||
| * | Remove more warnings on variables. | Emilio Tagua | 2010-09-28 | 1 | -0/+1 | |
| | | ||||||
| * | Initialize @compiled_at if it is not. | Emilio Tagua | 2010-09-28 | 1 | -0/+1 | |
| | | ||||||
| * | Remove warings from rescues: don't define more than once debug_hash method ↵ | Emilio Tagua | 2010-09-28 | 1 | -2/+2 | |
| | | | | | | | | and ask if @response if defined. | |||||
| * | Remove remaining warnings on _trace by adding parenthesis to gsub arguments. | Emilio Tagua | 2010-09-28 | 1 | -3/+3 | |
| | | ||||||
| * | Use parenthesis to avoid ambiguous first argument warning. | Emilio Tagua | 2010-09-28 | 1 | -1/+1 | |
| | |