Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
| * | We seem to have removed the URL helpers from ActionView subclasses... | wycats | 2010-03-18 | 3 | -0/+8 | |
| | | ||||||
| * | Each controller class has it's own view context subclass. This removes the ↵ | Carlhuda | 2010-03-18 | 5 | -50/+29 | |
| | | | | | | | | need for ActionView::Base.for_controller | |||||
| * | Return a valid Rack response from bare ActionController::Metal | Carlhuda | 2010-03-18 | 2 | -14/+8 | |
| | | ||||||
| * | Make render :partial, :layout consistent between AC and AV | Carlhuda | 2010-03-18 | 1 | -6/+0 | |
| | | ||||||
| * | All tests pass without memoizing view_context | Carlhuda | 2010-03-18 | 6 | -29/+37 | |
| | | ||||||
| * | Remove caching's dependency on view_context. Also, make it so that the ↵ | Carlhuda | 2010-03-18 | 2 | -14/+26 | |
| | | | | | | | | layout is always rendered the same way (so that layout dependencies on the action actually being rendered aren't masked on the first render) | |||||
| * | Make action_has_layout? non-private | Carlhuda | 2010-03-18 | 1 | -4/+4 | |
| | | ||||||
| * | @layout is a confusing name... use @cache_layout | Carlhuda | 2010-03-18 | 1 | -3/+3 | |
| | | ||||||
| * | Sending the partial as info is no longer required. | José Valim | 2010-03-18 | 1 | -3/+3 | |
| | | ||||||
| * | Use Array.wrap not Array() | Jeremy Kemper | 2010-03-17 | 1 | -1/+2 | |
| | | ||||||
| * | Deleting and setting a cookie in the same request was broken | Mathias Biilmann Christensen | 2010-03-17 | 1 | -0/+1 | |
| | | | | | | | | | | | | | | | | Made sure to remove a cookie from @deleted_cookies when set [#4211 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | |||||
| * | Get modules back into integration tests | Carlhuda | 2010-03-17 | 2 | -1/+3 | |
| | | ||||||
| * | Fix for missing dependency in ActionDispatch::Integration | Mathias Biilmann Christensen | 2010-03-17 | 1 | -0/+1 | |
| | | | | | | | | | | | | | | | | | | | | | | When running cucumber features from a new rails 3 app requiring 'cucumber/rails/world' would raise: uninitialized constant ActionDispatch::Integration::Session::Test (NameError) Fixed by requiring 'test/unit/assertions' in action_dispatch/integration Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | |||||
| * | Modify assert_template to use notifications. Also, remove ↵ | Carlhuda | 2010-03-17 | 6 | -15/+32 | |
| | | | | | | | | ActionController::Base#template since it is no longer needed. | |||||
| * | Mark bang instrumentations as something that you shuold not be listening to. | José Valim | 2010-03-17 | 2 | -10/+5 | |
| | | ||||||
| * | Ensure json is loaded before using responders. | José Valim | 2010-03-17 | 2 | -1/+2 | |
| | | ||||||
| * | Remove unneeded AV::Base and AV::Template monkey-patches | Carlhuda | 2010-03-17 | 2 | -21/+1 | |
| | | ||||||
| * | Modify assert_template to use instrumentation | Carlhuda | 2010-03-17 | 4 | -54/+89 | |
| | | ||||||
| * | Install url helpers on module instance so they can be accessed | Joshua Peek | 2010-03-17 | 1 | -5/+13 | |
| | | | | | | | | globally | |||||
| * | Remove some 1.9 warnings (resulting in some fixed bugs). Remaining AM ↵ | wycats | 2010-03-17 | 7 | -9/+6 | |
| | | | | | | | | warnings are in dependencies. | |||||
| * | Eliminate warnings for AM on 1.8 | wycats | 2010-03-16 | 5 | -7/+12 | |
| | | ||||||
| * | Another missing require | wycats | 2010-03-16 | 1 | -0/+1 | |
| | | ||||||
| * | link_to_function is here to stay | Joshua Peek | 2010-03-16 | 2 | -33/+87 | |
| | | ||||||
| * | Fix missing require | wycats | 2010-03-16 | 1 | -0/+1 | |
| | | ||||||
| * | Make sure options[:anchor] is correct in shorthand cases | wycats | 2010-03-16 | 1 | -2/+5 | |
| | | ||||||
| * | scope_key_by_partial fix for Ruby 1.9 when there's virtual_path [#4202 ↵ | Santiago Pastorino | 2010-03-16 | 1 | -2/+3 | |
| | | | | | | | | | | | | state:resolved] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | |||||
| * | Do not always include the named URL helpers into AC::Base and AV::Base. | Carl Lerche | 2010-03-16 | 5 | -4/+29 | |
| | | ||||||
| * | Make RouteSet#finalize! a NOOP if it's been called already. Call finalize! ↵ | Carl Lerche | 2010-03-16 | 1 | -0/+5 | |
| | | | | | | | | the first time call() and url_for() are called if the RouteSet has not been finalized yet. | |||||
| * | Fix rendering of HTML partials inside JS templates [#4197 status:resolved] | José Valim | 2010-03-16 | 2 | -3/+16 | |
| | | ||||||
| * | translation method of TranslationHelper module returns always SafeBuffer ↵ | Santiago Pastorino | 2010-03-16 | 1 | -1/+1 | |
| | | | | | | | | | | | | [#4194 status:resolved] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | |||||
| * | Some more tweaks on <% %>. | Carlhuda | 2010-03-16 | 3 | -4/+4 | |
| | | | | | | | | * The cache helper is now semantically "mark this region for caching" * As a result, <% x = cache do %> no longer works | |||||
| * | Change array entries to safe doesn't worth then the array is joined as a ↵ | Santiago Pastorino | 2010-03-16 | 1 | -1/+1 | |
| | | | | | | | | | | | | string losing the safe property of his entries [#4134 status:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
| * | RJS may cache an array | Jeremy Kemper | 2010-03-15 | 1 | -1/+1 | |
| | | ||||||
| * | Fix link_to with block | Jeremy Kemper | 2010-03-15 | 1 | -1/+1 | |
| | | ||||||
| * | link_to_remote -> link_to :remote => true | Jeremy Kemper | 2010-03-15 | 1 | -1/+1 | |
| | | ||||||
| * | Integration test url options should account for :protocol not just https? | Jeremy Kemper | 2010-03-15 | 1 | -8/+2 | |
| | | ||||||
| * | Move more normalization up to the lookup context, so it does not have to ↵ | José Valim | 2010-03-16 | 2 | -29/+31 | |
| | | | | | | | | repeat in every resolver. | |||||
| * | Revert "Reinstate old default_url_options method signature" | Jeremy Kemper | 2010-03-15 | 1 | -1/+1 | |
| | | | | | | | | This reverts commit 5913dd478150710fc0b72a0568f68e13c958d6bc. | |||||
| * | Reinstate old default_url_options method signature | Jeremy Kemper | 2010-03-15 | 1 | -1/+1 | |
| | | ||||||
| * | Add deprecation notices for <% %>. | Carlhuda | 2010-03-15 | 8 | -74/+53 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * The approach is to compile <% %> into a method call that checks whether the value returned from a block is a String. If it is, it concats to the buffer and prints a deprecation warning. * <%= %> uses exactly the same logic to compile the template, which first checks to see whether it's compiling a block. * This should have no impact on other uses of block in templates. For instance, in <% [1,2,3].each do |i| %><%= i %><% end %>, the call to each returns an Array, not a String, so the result is not concatenated * In two cases (#capture and #cache), a String can be returned that should *never* be concatenated. We have temporarily created a String subclass called NonConcattingString which behaves (and is serialized) identically to String, but is not concatenated by the code that handles deprecated <% %> block helpers. Once we remove support for <% %> block helpers, we can remove NonConcattingString. | |||||
* | | Updated ActionController::Base.asset_host example | retr0h | 2010-03-25 | 1 | -2/+2 | |
| | | | | | | | | | | | | | | | | The example provided contrived. It is not useful when wanting to use 1-based asset hosts (since it would generate a random asset host for the same asset). Signed-off-by: Rizwan Reza <rizwanreza@gmail.com> | |||||
* | | Merge remote branch 'mainstream/master' | Pratik Naik | 2010-03-15 | 24 | -124/+119 | |
|\| | ||||||
| * | with_output_buffer cannot assume there's an output_buffer | Xavier Noria | 2010-03-15 | 1 | -1/+1 | |
| | | | | | | | | | | | | [#4182 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | |||||
| * | to_str works here | Jeremy Kemper | 2010-03-15 | 1 | -1/+1 | |
| | | ||||||
| * | Don't force singularization of singleton resource names, e.g. /preferences ↵ | Andrew White | 2010-03-15 | 1 | -8/+8 | |
| | | | | | | | | | | | | [#4089 state:resolved] Signed-off-by: Joshua Peek <josh@joshpeek.com> | |||||
| * | read_ and write_fragment cache preserve html safety yet cache strings only | Jeremy Kemper | 2010-03-14 | 1 | -6/+6 | |
| | | ||||||
| * | Making escaped things more readable | Santiago Pastorino | 2010-03-14 | 3 | -3/+3 | |
| | | ||||||
| * | Optimize DetailsKey generation. | José Valim | 2010-03-14 | 1 | -4/+5 | |
| | | ||||||
| * | Ensure controller filters are executed before stuff starts to happen. | José Valim | 2010-03-13 | 2 | -3/+7 | |
| | | ||||||
| * | Remove formats setters from render template, speeding up partial and ↵ | José Valim | 2010-03-13 | 1 | -2/+1 | |
| | | | | | | | | collection renderings. |