aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/lib
Commit message (Collapse)AuthorAgeFilesLines
...
| * | | | | Kept overridden root method and removed original methodPrathamesh Sonpatki2016-01-071-21/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - The root method is defined and documented in Base module and decorated in Resources module. - The documentation in Base module actually talks about method signature of decorated method from Resources module. - Argument handling was moved to decorated method in https://github.com/rails/rails/commit/977455cc2efb94f40b4c0d46d1842be198ed7c4c to handle options such as :as with directly passed path parameter. - To avoid the confusion, removed original root method from Base module and only kept overridden version in Resources module. - References - https://github.com/rails/rails/pull/12208 & https://github.com/rails/rails/pull/12208#issuecomment-24350897.
* | | | | | Allow AC::Parameters as an argument to url_helpersPrathamesh Sonpatki2016-01-071-2/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Earlier only Hash was allowed as params argument to url_helpers. - Now ActionController::Parameters instances will also be allowed. - If the params are not secured then it will raise an ArgumentError to indicate that constructing URLs with non-secure params is not recommended. - Fixes #22832.
* | | | | | Merge pull request #22275 from mastahyeti/per-form-csrfRafael França2016-01-061-11/+54
|\ \ \ \ \ \ | | | | | | | | | | | | | | Per-form CSRF tokens
| * | | | | | add option for per-form CSRF tokensBen Toews2016-01-041-11/+54
| | | | | | |
* | | | | | | Merge pull request #22906 from bf4/rendering_exceptionsRafael França2016-01-041-64/+73
|\ \ \ \ \ \ \ | |/ / / / / / |/| | | | | | Add ActionController:Renderers test
| * | | | | | Group related methods togetherBenjamin Fleischer2016-01-031-67/+67
| | | | | | |
| * | | | | | Add ActionController:Renderers testBenjamin Fleischer2016-01-031-0/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | To complement actionpack/test/controller/metal/renderers_test.rb
* | | | | | | Replace x.times.map{} with Array.new(x){}Viktar Basharymau2016-01-021-1/+1
|/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The former is slightly more readable, performant and has fewer method calls. ```ruby Benchmark.ips do |x| x.report('times.map') { 5.times.map{} } x.report('Array.new') { Array.new(5){} } x.compare! end __END__ Calculating ------------------------------------- times.map 21.188k i/100ms Array.new 30.449k i/100ms ------------------------------------------------- times.map 311.613k (± 3.5%) i/s - 1.568M Array.new 590.374k (± 1.2%) i/s - 2.954M Comparison: Array.new: 590373.6 i/s times.map: 311612.8 i/s - 1.89x slower ```
* | | | | | Merge pull request #22519 from bf4/test_use_renderersRafael França2015-12-311-0/+34
|\ \ \ \ \ \ | |_|/ / / / |/| | | | | Add tests for ActionController::Renderers::use_renderers
| * | | | | Test ActionController::Renderers::use_renderersBenjamin Fleischer2015-12-311-0/+34
| | | | | |
* | | | | | Update copyright notices to 2016 [ci skip]Rashmi Yadav2015-12-312-2/+2
|/ / / / /
* | | | | Merge pull request #22850 from prathamesh-sonpatki/fix_ac_params_unsafe_h_2Kasper Timm Hansen2015-12-311-6/+6
|\ \ \ \ \ | | | | | | | | | | | | Fix AC::Parameters#to_unsafe_h to return all unfiltered values
| * | | | | Fix AC::Parameters#to_unsafe_h to return all unfiltered valuesPrathamesh Sonpatki2015-12-311-6/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - AC::Parameters#convert_parameters_to_hashes should return filtered or unfiltered values based on whether it is called from `to_h` or `to_unsafe_h` instead of always defaulting to `to_h`. - Fixes #22841
* | | | | | Merge pull request #22826 from timrogers/actiondispatch-ssl-configRafael França2015-12-311-8/+12
|\ \ \ \ \ \ | |_|_|_|/ / |/| | | | | Configurable redirect and secure cookies for ActionDispatch::SSL
| * | | | | Flexible configuration for ActionDispatch::SSLTim Rogers2015-12-291-8/+12
| | |_|_|/ | |/| | |
* | | | | Avoid `Time.parse` for static dateRafaël Blais Masson2015-12-301-1/+1
| |/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Benchmark.ips do |x| x.report('Time.parse') { Time.parse('2011-01-01') } x.report('Time.new') { Time.new(2011, 1, 1) } end Calculating ------------------------------------- Time.parse 6.640k i/100ms Time.new 15.082k i/100ms ------------------------------------------------- Time.parse 71.915k (± 3.1%) i/s - 365.200k Time.new 167.645k (± 3.3%) i/s - 844.592k
* | | | Merge pull request #22830 from jcoyne/parameters_includeRichard Schneeman2015-12-291-1/+1
|\ \ \ \ | | | | | | | | | | Add AC::Parameters#include?
| * | | | Add AC::Parameters#include?Justin Coyne2015-12-291-1/+1
| |/ / / | | | | | | | | | | | | Fixes #22818
* | | | Format from Accept headers have higher precedence than path extension formatJorge Bejar2015-12-291-2/+2
| | | |
* | | | Rely on default Mime format when MimeNegotiation#format_from_path_extension ↵Jorge Bejar2015-12-291-3/+3
|/ / / | | | | | | | | | | | | | | | is not a valid type Closes #22747
* | | Improve RDoc documentation of ActionDispatch::SSLTim Rogers2015-12-241-12/+14
| | |
* | | Add #== back to ActionDispatch::MiddlewareStack::MiddlewareJon Moss2015-12-211-0/+9
| | | | | | | | | | | | | | | This was causing bug #22738 to occur. Also added extra tests to make sure everything is A-OK.
* | | Remember the parameter hash we returnMatthew Draper2015-12-221-1/+1
| | | | | | | | | | | | Callers expect to be able to manipulate it.
* | | Merge branch 'master' of github.com:rails/docrailsVijay Dev2015-12-202-3/+3
|\ \ \ | |_|/ |/| |
| * | Add missing punctuation mark [ci skip]Gaurav Sharma2015-11-182-3/+3
| | |
* | | Change `alpha` to `beta1` to prep for release of Rails 5eileencodes2015-12-181-1/+1
| | | | | | | | | | | | :tada: :beers:
* | | Merge pull request #20797 from byroot/prevent-url-for-ac-parametersRafael França2015-12-182-2/+4
|\ \ \ | | | | | | | | Prevent ActionController::Parameters in url_for
| * | | Prevent ActionController::Parameters from being passed to url_for directlyJean Boussier2015-12-152-2/+4
| | | |
* | | | Refer to rails command instead of rake in a bunch of placesDavid Heinemeier Hansson2015-12-182-2/+2
| | | | | | | | | | | | | | | | Still more to do. Please assist!
* | | | Document when fallback_location is used [ci-skip]Derek Prior2015-12-171-2/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If you're not familiar with how the `Referer` header works, you likely won't understand why you need to provide a fallback or under what circumstances it would be used. Hopefully this clarifies things a bit.
* | | | Only dup Ruby's Hash and Array.Kasper Timm Hansen2015-12-171-2/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When calling `to_h` on an `ActionController::Parameters` instance it would `deep_dup` its internal parameters. This inadvertently called `dup` on a passed Active Record model which would create new models. Fix by only dupping Ruby's Arrays and Hashes.
* | | | Deprecate `redirect_to :back`Derek Prior2015-12-161-10/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Applications that use `redirect_to :back` can be forced to 500 by clients that do not send the HTTP `Referer` (sic) header. `redirect_back` requires the user to consider this possibility up front and avoids this trivially-caused application error.
* | | | Add `redirect_back` for safer referrer redirectsDerek Prior2015-12-161-0/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `redirect_to :back` is a somewhat common pattern in Rails apps, but it is not completely safe. There are a number of circumstances where HTTP referrer information is not available on the request. This happens often with bot traffic and occasionally to user traffic depending on browser security settings. When there is no referrer available on the request, `redirect_to :back` will raise `ActionController::RedirectBackError`, usually resulting in an application error. `redirect_back` takes a required `fallback_location` keyword argument that specifies the redirect when the referrer information is not available. This prevents 500 errors caused by `ActionController::RedirectBackError`.
* | | | Merge pull request #22598 from yui-knk/deprecate_string_callbackRafael França2015-12-161-1/+2
|\ \ \ \ | | | | | | | | | | Deprecate passing string to define callback.
| * | | | Deprecate passing string to define callback.yui-knk2015-12-161-1/+2
| |/ / /
* | | | Merge pull request #14212 from tylerhunt/fix-token-regexSean Griffin2015-12-151-1/+1
|\ \ \ \ | | | | | | | | | | | | | | | Handle tab in token authentication header.
| * | | | Handle tab in token authentication header.Tyler Hunt2014-02-261-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The HTTP spec allows for LWS to precede the header content, which could include multiple SP and HT characters. Update the regex used to match the Token authorization header to account for this, instead of matching on a single SP. See http://www.w3.org/Protocols/rfc2616/rfc2616-sec2.html and http://www.w3.org/Protocols/rfc2616/rfc2616-sec4.html for the relevant parts of the specification.
* | | | | Remove warning of shadowing variableRafael Mendonça França2015-12-151-1/+1
| | | | |
* | | | | Add fragment_cache_key macro for controller-wide fragment cache key prefixesSam Stephenson2015-12-141-3/+42
| | | | |
* | | | | Remove ActionView::Helpers::CacheHelper#fragment_cache_keySam Stephenson2015-12-141-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Introduced in e56c63542780fe2fb804636a875f95cae08ab3f4, `CacheHelper#fragment_cache_key` is a duplicate of `ActionController::Caching::Fragments#fragment_cache_key`. We now require the view to provide this method on its own (as with `view_cache_dependencies`); `ActionController::Caching::Fragments` exports its version as a `helper_method`.
* | | | | Merge pull request #22564 from maximeg/legit_name_errorsSean Griffin2015-12-141-2/+4
|\ \ \ \ \ | | | | | | | | | | | | Don't catch all NameError to reraise as ActionController::RoutingError
| * | | | | Don't catch all NameError to reraise as ActionController::RoutingError #22368Maxime Garcia2015-12-121-2/+4
| | | | | |
* | | | | | Make Parameters#to_h and #to_unsafe_h return HWIAPrem Sichanugrist2015-12-141-5/+7
| |_|/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | This makes these two methods to be more inline with the previous behavior of Parameters as Parameters used to be inherited from HWIA. Fixes #21391
* | | | | Remove ActionController::TestCase from documentationeileencodes2015-12-122-1/+5
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In Rails 5.1 `ActionController::TestCase` will be moved out of Rails into it's own gem. Please use `ActionDispatch::IntegrationTest` going foward. Because this will be moved to a gem I used `# :stopdoc:` instead of deleting the documentation. This will remove it from the Rails documentation but still leave the method documented for when we move it to a gem. Guides have been updated to use the routing structure used in Integration and all test examples have been updated to inherit from `ActionDispatch::IntegrationTest` instead of `ActionController::TestCase. Fixes #22496
* | | | Show redirect response code in assert_response messagesJon Atack2015-12-111-10/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Follow-up to PR #19977, which helpfully added the redirection path to the error message of assert_response if response is a redirection, but which removed the response code, obscuring the type of redirect. This PR: - brings back the response code in the error message, - updates the tests so the new messages can be tested, - and adds test cases for the change.
* | | | Merge pull request #22514 from ↵Rafael França2015-12-111-1/+1
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | prathamesh-sonpatki/use-assert-over-assert-predicate Use assert over assert_predicate in assert_response
| * | | | Use assert over assert_predicate in assert_responsePrathamesh Sonpatki2015-12-061-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - `assert_predicate` appends its own error message at the end of message generated by `assert_response` and because of that the error message displays the whole `response` object. - For eg. Expected response to be a <success>, but was a redirect to <http://test.host/posts>. Expected #<ActionDispatch::TestResponse:0x007fb1cc1cf6f8....(lambda)>}>> to be successful?. - Complete message can be found here - https://gist.github.com/prathamesh-sonpatki/055afb74b66108e71ded#file-gistfile1-txt-L19. - After this change the message from `assert_predicate` won't be displayed and only message generated by `assert_response` will be shown as follows: Expected response to be a <success>, but was a redirect to <http://test.host/posts>
* | | | | Merge pull request #20831 from jmbejar/rails-api-json-error-responseSantiago Pastorino2015-12-092-33/+81
|\ \ \ \ \ | | | | | | | | | | | | Rails API: Ability to return error responses in json format also in development
| * | | | | Avoid calling AD::MimeNegotiation#format_from_path_extension method twiceJorge Bejar2015-12-091-2/+2
| | | | | |
| * | | | | Avoid warning because of the mime typeJorge Bejar2015-12-091-1/+1
| | | | | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-10-30 19:06:05 +0000