aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/lib
Commit message (Collapse)AuthorAgeFilesLines
* Use Array Difference to calculate the zones array, instead of iteratingCarlos Antonio da Silva2013-02-211-2/+2
| | | | It's faster, and doesn't force us to dup the timezones array.
* Rack::Test::UploadedFile is a permitted scalarFabio Kreusch2013-02-211-3/+4
|
* Revert "Merge pull request #4803 from lucascaton/master"Santiago Pastorino2013-02-201-2/+2
| | | | | | | | | | | | | | | This reverts commit bb842e8d2111e50b21a14b8bd6d89371a4b9cd68, reversing changes made to 40c287c7983c20c498f6a8a2ea49e9a6455347f7. This was causing issues in one of our apps we just upgraded. ActionController::RoutingError: No route matches [GET] "/images/favicon.ico" favicon_link_tag now returns '/images/favicon.ico' and in 3.2 returned '/favicon.ico' Browsers by default look for favicon.ico in the root directory Conflicts: actionpack/CHANGELOG.md actionpack/lib/action_view/helpers/asset_tag_helper.rb
* Remove XML Parser from ActionDispatchPrem Sichanugrist2013-02-201-23/+3
| | | | | If you want an ability to parse XML parameters, please install `actionpack-xml_parser` gem.
* Fix time_zone_options_for_select to not mutate TimeZones arrayBrian McManus2013-02-191-1/+1
| | | | | | | | | | Previous implementation of time_zone_options_for_select did not dup the ActiveSupport::TimeZone.all array. When :priority_zones were provided the method would reject! the zones from the memoized TimeZones array thus affecting future requests to the server. Essentially whatever zones were specified as :priority_zones would show up for the first request but then disappear from the time zone options on future requests.
* InvalidMessage is in ActiveSupport::MessageEncryptor namespaceSantiago Pastorino2013-02-191-1/+1
| | | | Closes #9302
* Add missing require to routes inspectorCarlos Antonio da Silva2013-02-191-0/+1
|
* Require AS deps in ActionDispatch::Http::URLMiha Filej2013-02-191-0/+3
| | | | Allows us to use url_for and friends in isolation.
* Duck typing is hard. Add header to HtmlTableFormatter.Steve Klabnik2013-02-181-0/+4
| | | | | | | Somehow I missed this method, which was then throwing an error when viewing routes as HTML. Make @rubys happy: ✔
* editorial tweaksXavier Noria2013-02-191-3/+6
|
* use strip_heredoc to keep indentation consistent.Steve Klabnik2013-02-181-12/+12
| | | | Thanks @sikachu. :heart:
* Add message when you have no routes defined.Steve Klabnik2013-02-181-0/+25
| | | | | | Print a message in both `rake routes` and at GET "/rails/info/routes" that lets you know you have no routes defined, as well as linking to the Rails Guide on the topic.
* Add headings to rake routes tableSteve Klabnik2013-02-181-3/+19
|
* Gist URLs are now namespacedAkira Matsuda2013-02-181-1/+1
| | | | see: https://github.com/blog/1406-namespaced-gists
* Return false on toggle on error pagesBartlomiej Kozal2013-02-172-6/+7
|
* Merge pull request #9307 from wangjohn/remove_unneeded_md5_digestXavier Noria2013-02-161-1/+0
|\ | | | | Removed an old require of an MD5 digest which is no longer used.
| * Removed an old require of an MD5 digest which is no longer used.wangjohn2013-02-151-1/+0
| |
* | Merge branch 'master' of github.com:lifo/docrailsVijay Dev2013-02-153-4/+4
|\ \ | |/ |/| | | | | Conflicts: guides/source/upgrading_ruby_on_rails.md
| * Correct bullet content line wrappingTim "Roger" Harvey2013-02-121-1/+1
| | | | | | | | | | | | The `:prefix` bullet content was not properly wrapping, dropping to the following line because the additional content was not indented properly. With this change, it will now display properly the way `:discard_type` does.
| * Fix typo.Carson McDonald2013-02-111-1/+1
| | | | | | | | [ci skip]
| * Fixing the examples for button_toMarc Baumbach2013-02-061-2/+2
| | | | | | The examples do not generate the output they intend to due to not explicitly declaring the hash separations. This causes it to be treated as one parameter instead of the intended two parameters.
* | Merge pull request #8704 from senny/remove_regexp_global_from_url_forAaron Patterson2013-02-141-2/+6
|\ \ | | | | | | replace regexp global in #url_for
| * | replace regexp global in #url_forYves Senn2013-01-161-2/+6
| | |
* | | Avoid to_sym callsSantiago Pastorino2013-02-131-1/+1
| | |
* | | Improve changelog entry from #9221 [ci skip]Carlos Antonio da Silva2013-02-111-3/+3
| | |
* | | Merge pull request #9221 from thenickcox/image_alt_attributeCarlos Antonio da Silva2013-02-111-3/+17
|\ \ \ | | | | | | | | Improve img alt attribute for screen readers
| * | | Improve img alt attribute for screen readersthenickcox2013-02-091-3/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently, the img_alt method in ActionView keeps underscores in the alt attribute. Because underscores are pronounced in Apple's VoiceOver Utility, this has serious implications for accessibility. This patch makes underscored or hyphenated file names (both common in projects) read more naturally in screen readers by replacing them with spaces. See method documentation for details. Added documentation to image_alt method
* | | | the `:controller` option for routes can contain numbers. closes #9231.Yves Senn2013-02-091-1/+1
| | | |
* | | | Add missing require to APCarlos Antonio da Silva2013-02-081-0/+1
| | | |
* | | | Fix #9168 Initialize NullCookieJar with all options needed for KeyGeneratorAndrey Chernih2013-02-082-5/+9
|/ / /
* | | ruby constant syntax is not supported as routing `:controller` option.Yves Senn2013-02-061-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The current implementation only works correctly if you supply the `:controller` with directory notation (eg. `:controller => 'admin/posts'`). The ruby constant notation (eg. `:controller => 'Admin::Posts`) leads to unexpected problems with `url_for`. This patch prints a warning for every non supported `:controller` option. I also added documentation how to work with namespaced controllers. The warning links to that documentation in the rails guide.
* | | partials inside directory work with `assert_template`Yves Senn2013-02-042-2/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | previously when a partial was placed inside a directory (eg. '/dir/_partial'), `assert_template` did not replace the '_' prefix when looking through rendered tempaltes, which resulted in an error. I modified it to replace both, the leading '_' and the last '_' after a '/'.
* | | descriptive `assert_template` error when partial wasn't renderedYves Senn2013-02-042-0/+7
| |/ |/| | | | | | | | | | | When `assert_template` is used with the :locals option, and the partial was not rendered, a method_missing error was raised. This changes first checks, if the partial actually was rendered and raises a descriptive error.
* | Missing require hash/keysAkira Matsuda2013-02-012-0/+3
| |
* | Missing or unneeded require extract_optionsAkira Matsuda2013-02-018-1/+8
| |
* | Use \A in RegexpsEgor Homakov2013-02-011-1/+1
| | | | | | | | | | So, if there is redirect_to params[:q] i can send ?q=javascript:asdf()%0A/localpath Or something more nasty, so please use \A
* | remove dead codeAaron Patterson2013-01-301-4/+1
| |
* | change parameter name for positional argsAaron Patterson2013-01-301-2/+1
| |
* | nodoc the helper classes, cache stuff for optimized helperAaron Patterson2013-01-301-13/+17
| |
* | cache path parts in the instanceAaron Patterson2013-01-301-2/+3
| |
* | stop evaling a string every timeAaron Patterson2013-01-301-4/+4
| |
* | moving helper classes outside the private blockAaron Patterson2013-01-301-90/+88
| |
* | pushing specialization down to the optimized classAaron Patterson2013-01-301-23/+25
| |
* | use polymorphism to remove conditionalAaron Patterson2013-01-301-35/+27
| |
* | move conditionals to instanceAaron Patterson2013-01-301-6/+16
| |
* | pull stuff out of the caller and hide in the instanceAaron Patterson2013-01-301-4/+3
| |
* | moving more stuff on to the instanceAaron Patterson2013-01-301-18/+18
| |
* | move optimize_helper? to the helper instanceAaron Patterson2013-01-301-9/+12
| |
* | moving more stuff to the instanceAaron Patterson2013-01-301-6/+6
| |
* | moving some stuff to the initializerAaron Patterson2013-01-301-14/+38
| |
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-06 09:28:37 +0000