aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/lib
Commit message (Collapse)AuthorAgeFilesLines
* Escape the message of an exception in debug_exceptions to avoid bad renderingAdrien Siami2013-08-215-5/+5
|
* Use each_with_objectSantiago Pastorino2013-08-191-4/+2
|
* Organize normalize_encoding_params' conditionals a bit better and use a case ↵Santiago Pastorino2013-08-191-15/+18
| | | | | | statement for it Refactor of the work done in #11891
* Merge pull request #11891 from robertomiranda/remove_upload_moduleSantiago Pastorino2013-08-193-14/+2
|\ | | | | Normalize file parameters in same place as other parameters (ActionDispatch::Http::Parameters#normalize_encode_params)
| * Normalize file parameters in same place as other parameters ↵robertomiranda2013-08-143-14/+2
| | | | | | | | (ActionDispatch::Http::Parameters#normalize_encode_params)
* | Merge pull request #11443 from wangjohn/sse_reloader_classSantiago Pastorino2013-08-191-0/+74
|\ \ | | | | | | SSE class for ActionController::Live
| * | Creating an SSE class to be used with ActionController::Live.wangjohn2013-07-301-0/+74
| | |
* | | Fail informatively in #respond_with when no appropriate #api_behavior ↵Ben Woosley2013-08-172-0/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | renderer is available. Currently if a user calls #respond_with(csvable), but has not csv renderer available, Responder will just run through the default render behavior twice, raising ActionView::MissingTemplate both times. This changes ActionController::Metal::Responder#api_behavior to check in advance whether there is a renderer available, and raise ActionController::MissingRenderer if not.
* | | Merge branch 'master' of github.com:rails/docrailsVijay Dev2013-08-172-14/+12
|\ \ \ | |_|/ |/| | | | | | | | | | | | | | | | | Conflicts: actionview/README.rdoc activerecord/lib/active_record/migration.rb guides/source/development_dependencies_install.md guides/source/getting_started.md
| * | Revert "Merge branch 'master' of github.com:rails/docrails"Vijay Dev2013-08-172-14/+12
| |/ | | | | | | | | | | | | This reverts commit 70d6e16fbad75b89dd1798ed697e7732b8606fa3, reversing changes made to ea4db3bc078fb3093ecdddffdf4f2f4ff3e1e8f9. Seems to be a code merge done by mistake.
* | Execute conditional procs on controller filters only for current action.Nicholas Jakobsen2013-08-101-1/+1
| | | | | | | | | | | | :only and :except options for controller filters are now added before :if and :unless. This prevents running :if and :unless procs when not on the specified. Closes #11786.
* | Added data for permit array into scalar valueRahul P. Chaudhari2013-08-051-0/+1
| |
* | Pass assert_dom_equal message arg to underlying assertionRyan McGeary2013-08-041-4/+4
| | | | | | | | | | #assert_dom_equal and #assert_dom_not_equal both take a "failure" message argument, but this argument was not utilized.
* | fix a gramatical mistakeRajeev N Bharshetty2013-08-021-1/+1
| |
* | Improve documentation for controller how to get included helpers [ci skip]Paul Nikitochkin2013-07-301-1/+1
|/ | | | Closes #11671
* Refactor handling of action normalizationMax Shytikov2013-07-261-11/+13
| | | | | | Reference: Bloody mess internals http://gusiev.com/slides/rails_contribution/static/#40
* Typo fixAnkit Gupta2013-07-251-1/+1
| | | | | [skip ci] Fixing the typo which is formed a not required link. Check here http://api.rubyonrails.org/classes/ActionController/Base.html under paramters section keeping it under tt tag
* Allow overriding of all headers from passed environment hashAndrew White2013-07-251-5/+5
| | | | | | | Allow REMOTE_ADDR, HTTP_HOST and HTTP_USER_AGENT to be overridden from the environment passed into `ActionDispatch::TestRequest.new`. Fixes #11590
* Removed random dot in code sample [ci skip]Max Vasiliev2013-07-221-1/+1
|
* Clear named routes when routes.rb is reloadedAndrew White2013-07-211-0/+1
| | | | | | | | Fix an issue where Journey was failing to clear the named routes hash when the routes were reloaded and since it doesn't overwrite existing routes then if a route changed but wasn't renamed it kept the old definition. This was being masked by the optimised url helpers so it only became apparent when passing an options hash to the url helper.
* Refactor to reduce number of loopsAndrew White2013-07-171-15/+25
| | | | | | Only build the missing_keys array once we have detected that there actually are missing keys by moving the check to be part of the block that performs the path substitution.
* Fix failing test missed for the past year :(Andrew White2013-07-171-2/+17
| | | | | | | | | When optimized path helpers were re-introduced in d7014bc the test added in a328f2f broke but no-one noticed because it wasn't being run by the test suite. Fix the test by checking for nil values or empty strings after the args have been parameterized.
* Skip Rack applications and redirects when generating urlsAndrew White2013-07-162-1/+17
| | | | | | | | | | When generating an unnamed url (i.e. using `url_for` with an options hash) we should skip anything other than standard Rails routes otherwise it will match the first mounted application or redirect and generate a url with query parameters rather than raising an error if the options hash doesn't match any defined routes. Fixes #8018
* move `MissingHelperError` out of the `ClassMethods` module.Yves Senn2013-07-121-15/+18
|
* Add documentation for add_flash_types [ci skip]Robin Dupret2013-07-101-0/+17
| | | | | Document a little bit the ActionController::Flash::add_flash_types class method.
* Show real LoadError on helpers requirePiotr Niełacny2013-07-101-1/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | When helper try to require missing file rails will throw exception about missing helper. # app/helpers/my_helper.rb require 'missing' module MyHelper end And when we try do load helper class ApplicationController helper :my end Rails will throw exception. This is wrong because there is a helper file. Missing helper file helpers/my_helper.rb Now when helper try to require non-existed file rails will throw proper exception. No such file to load -- missing
* Merge pull request #11351 from jetthoughts/cleanup_requestRafael Mendonça França2013-07-091-1/+1
|\ | | | | Use content_length method instead of ENV['CONTENT_LENGTH'].to_i
| * Use helper method to get ENV['CONTENT_LENGTH']Paul Nikitochkin2013-07-081-1/+1
| |
* | Use Request#raw_post instead Request#bodyPaul Nikitochkin2013-07-081-1/+1
|/ | | | | | | | In order to get raw_post to be not empty after ParamsParser#parse_formatted_parameters, added rewinding of body stream input on parsing json params. Closes #11345
* Space is not required for Set-Cookie headerYamagishi Kazutoshi2013-07-051-1/+1
|
* remove useless `env.merge!(env)` from ActionDispatch::IntegrationTest`Yves Senn2013-07-041-2/+0
|
* Missing closing + in documentation [ci skip]Edho Arief2013-07-041-1/+1
|
* Remove deprecated Rails application fallback for integration testingCarlos Antonio da Silva2013-07-021-4/+0
| | | | Set ActionDispatch.test_app instead.
* Remove deprecated constants autoloadCarlos Antonio da Silva2013-07-021-3/+0
| | | | | These constants were removed in 4b97ce5eb16cc20207516387fba98bf577e2e281, but I forgot to remove the autoload calls :sparkles:.
* use extract_options!Neeraj Singh2013-07-021-1/+1
|
* Remove `page_cache_extension` deprecated methodFrancesco Rodriguez2013-07-011-10/+0
|
* Remove deprecated constants from Action ControllerCarlos Antonio da Silva2013-07-012-12/+0
| | | | | | | | | | ActionController::AbstractRequest => ActionDispatch::Request ActionController::Request => ActionDispatch::Request ActionController::AbstractResponse => ActionDispatch::Response ActionController::Response => ActionDispatch::Response ActionController::Routing => ActionDispatch::Routing ActionController::Integration => ActionDispatch::Integration ActionController::IntegrationTest => ActionDispatch::IntegrationTest
* store a symbol directly inside DISPATCH_CACHE for extra roflscaleCharlie Somerville2013-06-301-1/+1
|
* writing the new body can cause the response to be committed and theAaron Patterson2013-06-281-1/+3
| | | | | | | | request thread to return up the stack before the instance variable is assigned. Synchronize so that the ivar is assigned before the other thread can activate. fixes #10984
* Re-remove deprecated API.kennyj2013-06-281-12/+0
|
* Merge pull request #11000 from sbeckeriv/accept_headerCarlos Antonio da Silva2013-06-251-1/+1
|\ | | | | | | Fix undefined method `ref' for nil:NilClass for bad accept headers
| * Fix undefined method `ref' for nil:NilClass for bad accept headersStephen Becker IV2013-06-191-1/+1
| |
* | Fix shorthand routes where controller and action are in the scopeAndrew White2013-06-251-2/+10
| | | | | | | | | | | | | | | | | | Merge `:action` from routing scope and assign endpoint if both `:controller` and `:action` are present. The endpoint assignment only occurs if there is no `:to` present in the options hash so should only affect routes using the shorthand syntax (i.e. endpoint is inferred from the the path). Fixes #9856
* | Merge pull request #11069 from ykzts/actiondispatch-ssl-secure-flag-igonore-caseGuillermo Iguaran2013-06-241-1/+1
|\ \ | | | | | | Flag cookies as secure with ignore case in ActionDispatch::SSL
| * | Flag cookies as secure with ignore case in ActionDispatch::SSLYamagishi Kazutoshi2013-06-241-1/+1
| | |
* | | ActionDispatch:SSL: don't include STS header in non-https responsesGeoff Buesing2013-06-231-2/+1
|/ /
* | Don't remove trailing slash from PATH_INFO for mounted appsPiotr Sarnacki2013-06-211-1/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously when app was mounted as following: class Foo def call(env) [200, {}, [env['PATH_INFO']]] end end RackMountRailsBug::Application.routes.draw do mount RackTest.new => "/foo" end trailing slash was removed from PATH_INFO. For example requesting GET /foo/bar/ on routes defined above would result in a response containing "/foo/bar" instead of "/foo/bar/". This commit fixes the issue. (closes #3215)
* | Move actionpack/lib/action_view* into actionview/libPiotr Sarnacki2013-06-2096-14646/+0
| |
* | Fix name of nested attributes option include_idEric Hankins2013-06-191-2/+2
| | | | | | The option to disable including a hidden ID field on a `fields_for` nested association was incorrectly documented as `hidden_field_id` instead of `include_id`
* | Remove duplicate letter 'a'. [ci skip]Uģis Ozols2013-06-191-1/+1
| |
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-02 20:42:34 +0000