aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/lib
Commit message (Collapse)AuthorAgeFilesLines
* Properly initialize variables inside the initialize method.José Valim2010-09-271-3/+8
|
* Define @_routes inside method, makes more sense and will be initialized when ↵Emilio Tagua2010-09-272-2/+1
| | | | | | called anywhere. Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* Remove more warnings shadowing outer local variable.Emilio Tagua2010-09-273-8/+8
| | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* Remove warning "URI.unescape is obsolete" from actionpack.Emilio Tagua2010-09-276-13/+16
| | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* Do not cache the script name outcome.José Valim2010-09-271-9/+11
|
* Merge remote branch 'miloops/warnings'José Valim2010-09-2718-51/+87
|\ | | | | | | | | Conflicts: actionpack/lib/action_controller/metal/url_for.rb
| * _routes must be inside @controller conditional.Emilio Tagua2010-09-271-1/+1
| |
| * Initialize @_routes if not defined yet, avoiding more warnings.Emilio Tagua2010-09-271-0/+1
| |
| * Refactor method to avoid warnings and not run unnecessary code.Emilio Tagua2010-09-271-11/+11
| |
| * Avoid uninitialized variable warning.Emilio Tagua2010-09-271-1/+1
| |
| * Initialize @_request and @_response.Emilio Tagua2010-09-271-1/+3
| |
| * Remove method previous method if already defined.Emilio Tagua2010-09-271-0/+1
| |
| * Define @emitted_hidden_id if it doesn't exists and reuse it if it does.Emilio Tagua2010-09-271-1/+1
| |
| * Avoid uninitialized variable warning.Emilio Tagua2010-09-271-0/+1
| |
| * Initialize @cookies.Emilio Tagua2010-09-271-0/+1
| |
| * Remove more warnings shadowing outer local variable.Emilio Tagua2010-09-273-8/+8
| |
| * Don't shadow outer local variables.Emilio Tagua2010-09-272-5/+5
| |
| * Avoid uninitialized variable warning, reuse @integration_session.Emilio Tagua2010-09-271-8/+14
| |
| * Ask is @controller is defined to avoid warning.Emilio Tagua2010-09-271-1/+1
| |
| * Initialize @_routes if it doesn't exists.Emilio Tagua2010-09-271-0/+1
| |
| * Remove warning "too many arguments for format string" when interpolating ↵Emilio Tagua2010-09-271-1/+1
| | | | | | | | with empty hash.
| * Initialize @_etag.Emilio Tagua2010-09-271-0/+1
| |
| * Initialize @as before plural method is called.Emilio Tagua2010-09-271-0/+1
| |
| * Remove old method before redefining it.Emilio Tagua2010-09-271-0/+2
| |
| * Remove warning "URI.unescape is obsolete" from actionpack.Emilio Tagua2010-09-275-14/+34
| |
* | Call it compile_methods! and do the same on AM.José Valim2010-09-271-2/+2
| |
* | Assume compute_asset_host returns reasonable values.thedarkone2010-09-271-1/+1
| |
* | Convert unless/else into if/else.thedarkone2010-09-271-4/+4
| |
* | Performance: refactor convert_options_to_data_attributes.thedarkone2010-09-271-10/+14
| |
* | Remove dead code.thedarkone2010-09-271-2/+2
| |
* | Clean up url_for.thedarkone2010-09-271-3/+1
| |
* | Hash#empty? is faster than Enumerable#any? when used on a Hash.thedarkone2010-09-271-1/+1
| |
* | Do a single string interpolation.thedarkone2010-09-271-1/+1
| |
* | Simple .empty? test will do fine here (rails_asset_id returns nice strings).thedarkone2010-09-271-1/+1
| |
* | options[:action] is very likely to be nil.thedarkone2010-09-271-1/+1
| |
* | Cache 2 of Request's commonly called methods.thedarkone2010-09-271-2/+2
| |
* | Cache url_options on a per-request basis.thedarkone2010-09-271-9/+11
| |
* | No need to create a separate lambda for each call.thedarkone2010-09-271-15/+14
| |
* | Make asset extension rewriting faster.thedarkone2010-09-271-5/+11
| |
* | Optimize relative_url_root rewriting code.thedarkone2010-09-271-3/+5
| |
* | Compile ActionController::Base.config's methods to avoid method_missing ↵thedarkone2010-09-272-2/+11
|/ | | | overhead.
* Fix the precedence issue hereSantiago Pastorino2010-09-261-1/+1
|
* Not need to do this double ternarySantiago Pastorino2010-09-261-1/+1
|
* port is appended twice to HTTP_HOST when host already has the portSantiago Pastorino2010-09-261-3/+3
|
* Partial revert of #d650b71 'Remove deprecated stuff in ActionController'Carlos Antonio da Silva2010-09-264-0/+11
| | | | | This brings back the deprecated modules from ActionController, because they didn't have any deprecation warning.
* We don't need to check if the format exists to generate the url, it already ↵Carlos Antonio da Silva2010-09-261-8/+7
| | | | does it internally
* More cleanup on form helpersCarlos Antonio da Silva2010-09-261-11/+12
|
* Remove last tests with deprecated form_for and cleanup form_for helperCarlos Antonio da Silva2010-09-261-4/+2
| | | | | | | This cleans up the last bits of deprecation stuff from form_for helper. However there is still a bug when using :as => foo[], with index. The classes and ids are being generated using [], such as foo[]_edit. This bug already existed but it was not detected before.
* Select tags with array options are deprecated, removingCarlos Antonio da Silva2010-09-261-4/+0
|
* Refactor form_for helperCarlos Antonio da Silva2010-09-261-21/+11
|