Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | | do not mutate parameters, let the caller do mutations | Aaron Patterson | 2014-05-21 | 2 | -4/+6 | |
| | | ||||||
* | | push the formatter up to the Route object | Aaron Patterson | 2014-05-21 | 2 | -4/+4 | |
| | | ||||||
* | | Merge pull request #15221 from laurelfan/doc-fix-redirecting | Arthur Nogueira Neves | 2014-05-21 | 1 | -4/+8 | |
|\ \ | | | | | | | fix formatting and text for ActionController::Redirecting doc | |||||
| * | | fix formatting and text for ActionController::Redirecting doc | Laurel Fan | 2014-05-21 | 1 | -4/+8 | |
| | | | ||||||
* | | | Merge pull request #15213 from tgxworld/remove_redundant_code | Rafael Mendonça França | 2014-05-20 | 1 | -3/+2 | |
|\ \ \ | |/ / |/| | | Remove redundant code. | |||||
| * | | Remove redundant code. | Guo Xiang Tan | 2014-05-20 | 1 | -3/+2 | |
| | | | ||||||
* | | | we don't use this parameter for anything, so rm | Aaron Patterson | 2014-05-20 | 2 | -2/+2 | |
| | | | ||||||
* | | | fewer string allocations per url_for | Aaron Patterson | 2014-05-20 | 1 | -7/+5 | |
| | | | ||||||
* | | | mutate the path string to avoid object allocations | Aaron Patterson | 2014-05-20 | 1 | -4/+4 | |
| | | | ||||||
* | | | push only_path conditional up | Aaron Patterson | 2014-05-20 | 1 | -18/+19 | |
| | | | ||||||
* | | | push arg checking up | Aaron Patterson | 2014-05-20 | 1 | -4/+4 | |
| | | | ||||||
* | | | fewer method calls and string garbage when there is no user/password | Aaron Patterson | 2014-05-20 | 1 | -9/+5 | |
| | | | ||||||
* | | | fewer hash allocations when calling url_for | Aaron Patterson | 2014-05-20 | 1 | -9/+12 | |
| | | | ||||||
* | | | fix variable names, only pass hashes to the positional args method | Aaron Patterson | 2014-05-20 | 1 | -8/+10 | |
| | | | ||||||
* | | | Merge pull request #11346 from tomykaira/fix_10257 | Rafael Mendonça França | 2014-05-20 | 1 | -2/+14 | |
|\ \ \ | | | | | | | | | Check authentication scheme in Basic auth | |||||
| * | | | Run login_procedure only when the auth_scheme is valid | tomykaira | 2013-07-08 | 1 | -7/+14 | |
| | | | | ||||||
| * | | | Check authentication scheme in Basic auth | tomykaira | 2013-07-07 | 1 | -1/+6 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `authenticate_with_http_basic` and its families should check the authentication schema is "Basic". Different schema, such as OAuth2 Bearer should be rejected by basic auth, but it was passing as the test shows. This fixes #10257. | |||||
* | | | | remove dead code | Aaron Patterson | 2014-05-20 | 1 | -57/+0 | |
| | | | | ||||||
* | | | | cache the formatter on the path object | Aaron Patterson | 2014-05-20 | 2 | -2/+6 | |
| | | | | ||||||
* | | | | translate AST to a formatter before url generation | Aaron Patterson | 2014-05-20 | 2 | -1/+72 | |
| | | | | ||||||
* | | | | prepopulate the dispatch cache so we don't need the ThreadSafe cache. | Aaron Patterson | 2014-05-20 | 1 | -7/+9 | |
| | | | | ||||||
* | | | | make the each visitor top-down left-right | Aaron Patterson | 2014-05-20 | 1 | -1/+1 | |
| | | | | ||||||
* | | | | Merge pull request #15178 from zuhao/refactor_actionpack_respond_with_test | Yves Senn | 2014-05-20 | 1 | -0/+16 | |
|\ \ \ \ | | | | | | | | | | | Deregister csv renderer after test to prevent leak. | |||||
| * | | | | Add ActionController::Renderers.remove. | Zuhao Wan | 2014-05-20 | 1 | -0/+16 | |
| | |/ / | |/| | | ||||||
* | | | | make the AST go from left to right, rather than right to left | Aaron Patterson | 2014-05-19 | 2 | -45/+48 | |
| | | | | ||||||
* | | | | fix escaping in generation | Aaron Patterson | 2014-05-19 | 1 | -1/+7 | |
| | | | | ||||||
* | | | | Revert "Rewrite journey routes formatter for performance" | Aaron Patterson | 2014-05-19 | 1 | -28/+23 | |
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 5c224de9e110763ec7a0f01f5b604bcf81f40bfb. Conflicts: actionpack/lib/action_dispatch/journey/visitors.rb 5c224de9e110763ec7a0f01f5b604bcf81f40bfb introduced a bug in the formatter. This commit includes a regression test. | |||||
* | | | fixed a typo [ci skip] | Aida | 2014-05-17 | 1 | -1/+1 | |
| | | | ||||||
* | | | fixes stack level too deep exception on action named 'status' returning ↵ | Christiaan Van den Poel | 2014-05-15 | 4 | -2/+9 | |
| | | | | | | | | | | | | 'head :ok' | |||||
* | | | Add RFC4791 MKCALENDAR method | kasper | 2014-05-15 | 1 | -1/+3 | |
| | | | ||||||
* | | | Only path requirements are relevant to optimized urls | Andrew White | 2014-05-15 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | The bit of URL generation that is optimized is the generation of the path so things like :host, :port, etc. are irrelevant. | |||||
* | | | Add missing requires for require 'action_dispatch/routing' | Andrew White | 2014-05-15 | 2 | -0/+3 | |
| | | | ||||||
* | | | Merge pull request #14137 from dasch/better-fragment-cache-instrumentation | Rafael Mendonça França | 2014-05-14 | 1 | -1/+7 | |
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | Add controller and action name to the fragment caching instrumentation payload Conflicts: actionpack/CHANGELOG.md | |||||
| * | | | Add controller and action name to the instrumentation payload | Daniel Schierbeck | 2014-05-10 | 1 | -1/+7 | |
| | | | | ||||||
* | | | | Merge pull request #15070 from ayamomiji/sse-patch | Aaron Patterson | 2014-05-14 | 1 | -1/+2 | |
|\ \ \ \ | | | | | | | | | | | Add multiple lines message support for SSE module | |||||
| * | | | | Add multiple lines message support for SSE module | ayaya | 2014-05-12 | 1 | -1/+2 | |
| | | | | | ||||||
* | | | | | _recall should be set to a hash or not set | Aaron Patterson | 2014-05-13 | 1 | -2/+2 | |
| | | | | | | | | | | | | | | | | | | | | Then we can avoid nil checks | |||||
* | | | | | we never call url_for with a block, so rm | Aaron Patterson | 2014-05-13 | 1 | -1/+0 | |
| | | | | | ||||||
* | | | | | drop || test for cases that do not need it | Aaron Patterson | 2014-05-13 | 2 | -4/+6 | |
| | | | | | ||||||
* | | | | | no need to check for presence, script names can be blank | Aaron Patterson | 2014-05-13 | 1 | -2/+2 | |
| | | | | | ||||||
* | | | | | extend with a module then use define_method | Aaron Patterson | 2014-05-13 | 1 | -7/+4 | |
| | | | | | | | | | | | | | | | | | | | | no need for redefine_method | |||||
* | | | | | this method should always have a parameter passed to it, so remove the default | Aaron Patterson | 2014-05-13 | 1 | -1/+1 | |
| | | | | | ||||||
* | | | | | options should always be passed to url_for | Aaron Patterson | 2014-05-13 | 1 | -2/+2 | |
| | | | | | ||||||
* | | | | | calls with :host should still use the optimized path | Aaron Patterson | 2014-05-13 | 1 | -2/+2 | |
| | | | | | ||||||
* | | | | | use fewer method calls to determine the url_for options | Aaron Patterson | 2014-05-13 | 1 | -5/+4 | |
| | | | | | ||||||
* | | | | | just merge instead of dup and merge | Aaron Patterson | 2014-05-13 | 1 | -2/+1 | |
| | | | | | ||||||
* | | | | | the :only_path option is applied by the time the helper is called | Aaron Patterson | 2014-05-13 | 1 | -4/+1 | |
| | | | | | ||||||
* | | | | | options already have symbolized keys, so we can avoid this call | Aaron Patterson | 2014-05-13 | 1 | -1/+1 | |
| | | | | | ||||||
* | | | | | Get rid of unused method | Carlos Antonio da Silva | 2014-05-13 | 1 | -11/+0 | |
| | | | | | | | | | | | | | | | | | | | | It's usage has been removed in 325c9d5e5235db4b5210d9db6c863835d1ac7eed. | |||||
* | | | | | Simplify merge call on polymorphic helpers | Carlos Antonio da Silva | 2014-05-13 | 1 | -2/+2 | |
| | | | | |