| Commit message (Collapse) | Author | Age | Files | Lines |
|\
| |
| | |
Recommend adding the requested domain to hosts whitelist only in deve…
|
| | |
|
|\ \
| | |
| | | |
Revert ensure external redirects are explicitly allowed
|
| |/ |
|
|\ \
| |/
|/| |
Template Handler Refactoring
|
| |
| |
| |
| |
| |
| |
| | |
This patch removes the instance writer of view_context_class.
Subclasses may override it, but it doesn't need to be written. This
also eliminates the need to cache the return value of the class level
`view_context_class` method.
|
| |
| |
| |
| | |
It's always called with 0 params, so just remove the parameter
|
| | |
|
| |
| |
| |
| | |
Now that secret_token was removed all this code is now dead.
|
| |
| |
| |
| | |
`combined_fragment_cache_key`
|
| |
| |
| |
| |
| | |
`#success?`, `missing?` and `error?` were deprecated in Rails 5.2 in favor of
`#successful?`, `not_found?` and `server_error?`.
|
| |
| |
| |
| |
| |
| |
| |
| | |
We are past 5.1 and it was not extrated yet, so while we still have
plans they will not be realized on 6.0, so it is better to not set
expectations of which release will exclude it just yet.
[ci skip]
|
| |
| |
| |
| | |
Add `fallback_location` and `allow_other_host` options to `redirect_to`.
|
|\ \
| | |
| | | |
Document that `format.any` can match all formats
|
| |/
| |
| | |
I had to dig around the code to discover this, since I had a use case for the behavior.
|
|/
|
|
|
|
|
|
|
|
|
| |
This reverts commit e385e4678fc64be6e176c3bdac6641db9fe48d85.
While this option was undocumented it exists to make possible to pass
parameters to the route helpers that are reserved like `:domain`.
While `url_for(domain: 'foo.com')` would generate a URL in the `foo.com`
domain `url_for(params: { domain: 'foo.com' })` would generate a URL
with `?domain=foo.com`.
|
|\
| |
| | |
Capture parsing errors only for ActionController::ParamsWrapper#process_actions
|
| | |
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since #30367, if `no-cache` includes Cache-Control headers, special keys
like `public`, `must-revalidate` are ignored.
But in my understanding, `public` still need in case of want to cache
authenticated pages.
The authenticated pages to be cacheable, but still authenticated for
every user, need to specify the `Cache-Control: public, no-cache`.
For keys other than `public`, I did not know the case where it was
necessary to use it in combination with `no-cache`, so I fixed that can
be used only for `public`.
Ref: https://www.mnot.net/cache_docs/#CACHE-CONTROL
Fixes #34780.
|
|
|
|
|
|
| |
We've switched from `Test::Unit::TestCase` to `ActiveSupport::TestCase`
since Rails 2.3.
See https://edgeguides.rubyonrails.org/2_3_release_notes.html#other-railties-changes
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
| |
Currently we sometimes find a redundant begin block in code review
(e.g. https://github.com/rails/rails/pull/33604#discussion_r209784205).
I'd like to enable `Style/RedundantBegin` cop to avoid that, since
rescue/else/ensure are allowed inside do/end blocks in Ruby 2.5
(https://bugs.ruby-lang.org/issues/12906), so we'd probably meets with
that situation than before.
|
|
|
|
|
|
| |
since Ruby 2.5
https://bugs.ruby-lang.org/issues/14133
|
|
|
|
|
|
|
|
|
|
| |
`Hash#transform_keys!`
Since Rails 6 requires Ruby 2.5.
https://github.com/ruby/ruby/blob/ruby_2_5/NEWS
Follow up #34754.
|
| |
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
… by switching the initialzation of an appropriate response parser
in `ActionDispatch::TestResponse` from eagerly to lazily.
By doing so, the response parser can be correctly set for
`ActionController::TestCase`, which doesn't include
the content type header in the constructor but only sets it at
a later time.
Fixes #34676.
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The ActionDispatch::HostAuthorization is a new middleware that prevent
against DNS rebinding and other Host header attacks. By default it is
included only in the development environment with the following
configuration:
Rails.application.config.hosts = [
IPAddr.new("0.0.0.0/0"), # All IPv4 addresses.
IPAddr.new("::/0"), # All IPv6 addresses.
"localhost" # The localhost reserved domain.
]
In other environments, `Rails.application.config.hosts` is empty and no
Host header checks will be done. If you want to guard against header
attacks on production, you have to manually permit the allowed hosts
with:
Rails.application.config.hosts << "product.com"
The host of a request is checked against the hosts entries with the case
operator (#===), which lets hosts support entries of type RegExp,
Proc and IPAddr to name a few. Here is an example with a regexp.
# Allow requests from subdomains like `www.product.com` and
# `beta1.product.com`.
Rails.application.config.hosts << /.*\.product\.com/
A special case is supported that allows you to permit all sub-domains:
# Allow requests from subdomains like `www.product.com` and
# `beta1.product.com`.
Rails.application.config.hosts << ".product.com"
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This first started with moving type method inside
`ActionDispatch::Journey::Nodes::Symbol`.
`AD::Journey::Nodes::Symbol#type` was generated dynamically with an
`each` block. While this is OK for classes like `AD::Journey::Nodes::Slash`
or `AD::Journey::Nodes::Dot` which don't have further implementation, all
other classes containing more logic have this method defined in their class
body. This patch does the same in this case.
On code review process @kamipo suggested to fully expand over
metaprogramming for Slash and Dot classes, a topic on which I agree with him.
|
| |
|
|
|
|
|
| |
The variable `route` was only allocated to hold an object that was
immediately returned. This patch removes that variable.
|
|\
| |
| | |
Log exceptions atomically
|
| | |
|
| |
| |
| |
| |
| |
| | |
When distributed over multiple logger calls the lines can become
intermixed with other log statements. Combining them into a single
logger call makes sure they always get logged together.
|
|/
|
|
|
|
|
|
|
| |
The error can be reproduced with
require "bundler/setup"
require "action_controller"
AbstractController::ActionNotFound
|
|
|
|
|
| |
Raises an ArgumentError when multiple root routes are defined in the
same context instead of assigning nil names to subsequent roots.
|
|\
| |
| |
| | |
:only and :except are now chained for routing resource(s)
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Allow chaining the :only and :except options for routing resource(s).
Previously, the following yielded routes for both show and destroy:
resource :account, :only => [:show, :destroy], :except => :destroy
This now yields only the show action. This chaining can be useful for
passing optional :except options to code that makes use of the :only
option (e.g. for a gem with its own routing methods).
|
| |
| |
| |
| | |
`Journey::Router::RoutingError` is no longer used since db06d128262b49c8b02e153cf95eb46f4eff364b.
|
| |
| |
| |
| | |
[Gannon McGibbon + Josh Cheek]
|
| |
| |
| |
| |
| | |
Reset Capybara sessions if `take_failed_screenshot` raise exception
in system test `after_teardown`.
|
|\ \
| | |
| | | |
ActionController::API *does* support cookies, sessions
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
ActionController::Metal provides session support by delegating `session to the request (`"@_request"`)
https://github.com/rails/rails/blob/a3dcba42e2422eb9c2e77011a39ce72dc934b420/actionpack/lib/action_controller/metal.rb#L149
Though the ActionController::Cookies modules isn't included, it's really a convenience for providing a first class `cookies` object.
*all* ActionController::Metal subclasses support setting cookies via the `session` object.
|
|/ /
| |
| |
| | |
or they would be listed in `action_methods`
|
| |
| |
| |
| |
| |
| |
| |
| | |
There is no controller instance when using a redirect route or a
mounted rack application so pass the request object as the context
when resolving dynamic CSP sources in this scenario.
Fixes #34200.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Previously if a dynamic source returned a symbol such as :self it
would be converted to a string implicity, e.g:
policy.default_src -> { :self }
would generate the header:
Content-Security-Policy: default-src self
and now it generates:
Content-Security-Policy: default-src 'self'
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
this method (#34210)
* Fix `ActionController::Parameters#each_value`
`each_value` should yield with "value" of the params instead of "value" as an array.
Related to #33979
* Add changelog entry about `ActionController::Parameters#each_value`.
Follow up #33979
|
| | |
|