Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | ActionView now has its own logger | Rafael Mendonça França | 2012-01-18 | 3 | -2/+6 |
| | |||||
* | Refactor FormBuilder arguments and default config | Carlos Antonio da Silva | 2012-01-18 | 1 | -10/+7 |
| | | | | | | | | | | * Do not reopen AV::Base to define default form builder Inside the load hook we are already in AV::Base context. * Do not pass the given block to the form builder The block is evaluated in fields_for context using capture, with the builder as argument. This means we do not need to give the block to the FormBuilder itself. | ||||
* | Merge pull request #4509 from rafaelfranca/form_tag-refactor | José Valim | 2012-01-17 | 2 | -6/+5 |
|\ | | | | | Refactor form_for and form_tag | ||||
| * | No need to call html_safe since concat two SaffeBuffers always results in a ↵ | Rafael Mendonça França | 2012-01-17 | 1 | -1/+1 |
| | | | | | | | | SafeBuffer | ||||
| * | Use block syntax to avoid code duplication | Rafael Mendonça França | 2012-01-17 | 1 | -3/+3 |
| | | |||||
| * | No need to create a SafeBuffer since form_tag_html always rerturn a SafeBuffer | Rafael Mendonça França | 2012-01-17 | 1 | -2/+1 |
| | | |||||
* | | Merge pull request #4510 from carlosantoniodasilva/av-content-tag-for | José Valim | 2012-01-17 | 1 | -15/+10 |
|\ \ | | | | | | | ActionView content_tag_for refactoring and improvements | ||||
| * | | Fix errors when running entire suite due to class name collision | Carlos Antonio da Silva | 2012-01-18 | 1 | -2/+2 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | The Post class is created everywhere in the test suite, and due to that when applying the Array() logic to refactor content_tag_for, some other change to the Post class was breaking record tag tests. The solution is to rename the class to not collide with others already defined in the test suite. | ||||
| * | | Refactor content tag to not detect options Hash always | Carlos Antonio da Silva | 2012-01-18 | 1 | -7/+6 |
| | | | | | | | | | | | | | | | Only check for options and prefix arguments order once when running content_tag_for with a collection. | ||||
| * | | Do not mutate options hash | Carlos Antonio da Silva | 2012-01-18 | 1 | -2/+2 |
| | | | |||||
| * | | Remove capture. | Tim Cooper | 2012-01-18 | 1 | -1/+1 |
| | | | |||||
| * | | Always treat the object passed to content_tag_for as an array. | Tim Cooper | 2012-01-18 | 1 | -7/+3 |
| |/ | |||||
* / | Silent Sprockets logger when config.assets.logger is set to false | Guillermo Iguaran | 2012-01-17 | 1 | -1/+4 |
|/ | |||||
* | Merge pull request #4488 from rafaelfranca/av-refactor | Xavier Noria | 2012-01-17 | 28 | -436/+684 |
|\ | | | | | ActionView::Helpers::FormHelper refactoring | ||||
| * | Extract input_checked? to a module | Rafael Mendonça França | 2012-01-17 | 4 | -9/+24 |
| | | |||||
| * | Do not need of ActionView::Helpers scope since we are inside | Rafael Mendonça França | 2012-01-17 | 3 | -21/+21 |
| | | | | | | | | ActionView::Helpers | ||||
| * | Remove unused code | Rafael Mendonça França | 2012-01-17 | 1 | -39/+0 |
| | | |||||
| * | Do not need each here anymore | Rafael Mendonça França | 2012-01-17 | 1 | -3/+1 |
| | | |||||
| * | Extract DatetimeSelect | Rafael Mendonça França | 2012-01-17 | 4 | -54/+11 |
| | | |||||
| * | Extract TimeSelect | Rafael Mendonça França | 2012-01-17 | 5 | -7/+16 |
| | | |||||
| * | Extract DateSelect | Rafael Mendonça França | 2012-01-17 | 4 | -6/+63 |
| | | |||||
| * | Cleanup | Rafael Mendonça França | 2012-01-17 | 1 | -72/+1 |
| | | |||||
| * | Extract TimeZoneSelect | Rafael Mendonça França | 2012-01-17 | 3 | -34/+22 |
| | | |||||
| * | Extract GroupedCollectionSelect | Rafael Mendonça França | 2012-01-17 | 3 | -24/+43 |
| | | |||||
| * | Extract CollectionSelect | Rafael Mendonça França | 2012-01-17 | 5 | -51/+64 |
| | | |||||
| * | Extract Select | Rafael Mendonça França | 2012-01-17 | 3 | -18/+59 |
| | | |||||
| * | Remove unused code | Rafael Mendonça França | 2012-01-17 | 1 | -31/+0 |
| | | |||||
| * | Extract RangeField | Rafael Mendonça França | 2012-01-17 | 3 | -11/+10 |
| | | |||||
| * | Extract NumberField | Rafael Mendonça França | 2012-01-17 | 3 | -1/+21 |
| | | |||||
| * | Extract EmailField | Rafael Mendonça França | 2012-01-17 | 3 | -1/+10 |
| | | |||||
| * | Extract UrlField | Rafael Mendonça França | 2012-01-17 | 3 | -1/+10 |
| | | |||||
| * | Extract TelField | Rafael Mendonça França | 2012-01-17 | 3 | -1/+10 |
| | | |||||
| * | Extract SearchField | Rafael Mendonça França | 2012-01-17 | 3 | -14/+26 |
| | | |||||
| * | Remove code duplication between CheckBox ans RadioButton | Rafael Mendonça França | 2012-01-17 | 3 | -19/+14 |
| | | |||||
| * | Extract RadioButton | Rafael Mendonça França | 2012-01-17 | 5 | -25/+41 |
| | | |||||
| * | Extract CheckBox | Rafael Mendonça França | 2012-01-17 | 3 | -40/+62 |
| | | |||||
| * | Extract TextArea | Rafael Mendonça França | 2012-01-17 | 3 | -13/+22 |
| | | |||||
| * | Extract FileField | Rafael Mendonça França | 2012-01-17 | 4 | -3/+16 |
| | | |||||
| * | Extract HiddenField | Rafael Mendonça França | 2012-01-17 | 3 | -1/+14 |
| | | |||||
| * | Extract PasswordField | Rafael Mendonça França | 2012-01-17 | 4 | -5/+24 |
| | | |||||
| * | Rename classes | Rafael Mendonça França | 2012-01-17 | 5 | -8/+8 |
| | | |||||
| * | Extract duplicated code to a class | Rafael Mendonça França | 2012-01-17 | 4 | -186/+116 |
| | | |||||
| * | Extract TextFieldTag | Rafael Mendonça França | 2012-01-17 | 3 | -2/+117 |
| | | |||||
| * | Extract LabelTag | Rafael Mendonça França | 2012-01-17 | 3 | -54/+156 |
| | | |||||
* | | Merge pull request #4497 from carlosantoniodasilva/action-controller-refactor | José Valim | 2012-01-17 | 8 | -67/+20 |
|\ \ | | | | | | | Action controller refactor - remove Compatibility module | ||||
| * | | Bring back rendering templates that start with / in nested structures | Carlos Antonio da Silva | 2012-01-17 | 1 | -0/+1 |
| | | | |||||
| * | | Move protected instance variables definition, kill compatibility module | Carlos Antonio da Silva | 2012-01-17 | 2 | -15/+5 |
| | | | |||||
| * | | Remove deprecated default_charset= from AC::Base | Carlos Antonio da Silva | 2012-01-17 | 2 | -5/+2 |
| | | | | | | | | | | | | | | | This should be set globally as a configuration, using `config.action_dispatch.default_charset` instead | ||||
| * | | Move render_to_body logic to return a spaced string to AC::Rendering | Carlos Antonio da Silva | 2012-01-17 | 4 | -7/+5 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This seems to be required only when calling render :partial with an empty collection from a controller. This call happens to return no content, letting the response body empty, which means to Rails that it should go on and try to find a template to render based on the current action name, thus failing hard. Although tests keep all green, we need to check a better way to fix this. | ||||
| * | | Remove method missing handling when action is not found, use action missing ↵ | Carlos Antonio da Silva | 2012-01-17 | 1 | -8/+0 |
| | | | | | | | | | | | | | | | | | | | | | instead Do not create a method_missing method to handle not found actions, use the action_missing method provided by Rails instead. |