aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/lib
Commit message (Collapse)AuthorAgeFilesLines
* Fixed bug by switching to Loofah fragment instead of document.Timm2014-06-161-2/+2
|
* Changed css_select to not count on multiple selectors. Fixed bug in ↵Timm2014-06-161-8/+10
| | | | determine_root_from where @selected was an Array. Changed assert_select_encoded to use a fragment instead of a document.
* Added a proper substitution context class. Changed ArgumentFilter to be a ↵Timm2014-06-161-34/+47
| | | | selector. It is now called HTMLSelector.
* Fixed nested assert_select bug. Trying to create a full document for a ↵Timm2014-06-161-1/+1
| | | | nested call that already had a document.
* Added implementation for substitution values via Nokogiri's custom pseudo ↵Timm2014-06-161-5/+35
| | | | classes.
* Readded some documentation about substitution values.Timm2014-06-161-2/+12
|
* Updated documentation to remove mention of HTML::Selector and clarify what ↵Timm2014-06-151-21/+9
| | | | is expected of a selector now.
* Readded html_document method since it is used integration tests.Timm2014-06-151-1/+5
|
* Changed filter_matches to return a new NodeSet instead of Array.Timm2014-06-151-1/+2
|
* Initialized @css_selector_is_second_argument in determine_root_from.Timm2014-06-151-0/+1
|
* Changed early return for filter_matches as well as reassigning matches. ↵Timm2014-06-151-6/+6
| | | | Meddled with initialize in ArgumentFilter.
* Removed redundant comments from assert_select.Timm2014-06-151-3/+1
| | | | Cleaned up a comment.
* Added assert_size_match! with the assertions for assert_select.Timm2014-06-151-14/+18
|
* Changed some documentation for css_select.Timm2014-06-151-1/+1
|
* Replaced fragment calls with document, since we assume the responses are ↵Timm2014-06-151-9/+8
| | | | complete documents.
* Added filter_matches to reduce line count in assert_select.Timm2014-06-151-24/+19
|
* Renamed Selector to ArgumentFilter. Put code from HTMLSelector to ↵Timm2014-06-151-59/+39
| | | | ArgumentFilter.
* Removed the custom selected proc. It's no longer needed.Timm2014-06-151-10/+8
|
* Updated selector to not have reponse_from_page.Timm2014-06-151-5/+6
|
* Changed css_select and pulled out response_from_page from Selector.Timm2014-06-151-23/+17
|
* Changed comparison from HTML::Node to Nokogiri::XML::Node in ↵Timm2014-06-151-1/+1
| | | | assert_select_encoded.
* Removed more redundant lines. Removed fix_content block that circumvented a ↵Timm2014-06-151-7/+1
| | | | bug in html-scanner.
* Removed more lines of code in assert_select.Timm2014-06-151-7/+6
|
* Simplified the first delete_if loop in assert_select to use Loofah's text ↵Timm2014-06-151-14/+13
| | | | method.
* Removed argument and root variable in assert_select proc.Timm2014-06-151-4/+2
|
* Changed name to selector. And a bunch of other things.Timm2014-06-151-60/+51
|
* The first attempt at abstracting argument parsing from selection methods.Timm2014-06-151-81/+114
|
* Removed tag.rb since it has been deprecated.Timm2014-06-152-137/+0
|
* Corrected documentation bug.Timm2014-06-151-10/+57
|
* Added Loofah as a dependency in actionview.gemspec.Timm2014-06-111-9/+9
| | | | | | Implemented ActionView: FullSanitizer, LinkSanitizer and WhiteListSanitizer in sanitizers.rb. Deprecated protocol_separator and bad_tags. Added new tests in sanitizers_test.rb and reimplemented assert_dom_equal with Loofah.
* Handle client disconnect during live streamingMatthew Draper2014-06-082-13/+95
| | | | .. even when the producer is blocked for a write.
* adds some details to the rationale of converted_arrays [ci skip]Xavier Noria2014-06-071-0/+4
|
* Revert "Convert StrongParameters cache to a hash. This fixes an unbounded"Xavier Noria2014-06-071-6/+6
| | | | | | | | | | | | | | | | | | | | We cannot cache keys because arrays are mutable. We rather want to cache the arrays. This behaviour is tailor-made for the usage pattern strongs params is designed for. In a forthcoming commit I am going to add a test that covers why we need to cache by value. Every strong params instance has a live span of a request, the cache goes away with the object. Since strong params have such a concrete intention, it would be interesting to see if there are actually any real-world use cases that are an actual leak, one that practically may matter. I am not convinced that the theoretical leak has any practical consequences, but if it can be shown there are, then I believe we should either get rid of the cache (which is an optimization), or else wipe it in the mutating API. This reverts commit e63be2769c039e4e9ada523a8497ce3206cc8a9b.
* [ci skip] Fix capitalizationAkshay Vishnoi2014-06-072-3/+3
|
* remove another wasteful AS::SafeBuffer allocationAaron Patterson2014-06-061-1/+1
|
* eliminate wasteful AS::SafeBuffer allocationAaron Patterson2014-06-061-1/+1
|
* Use a frozen Set instance for CGI_VARIABLES.Nathaniel Bibler2014-06-051-8/+21
| | | Also expand the CGI_VARIABLE name listing to multiple lines for cleaner diffs and legibility.
* Avoid misuse of underscore argumentCorey Ward2014-06-051-2/+2
| | | Per convention, underscore-only argument names should be used for unused parameters.
* Merge branch 'master' of github.com:rails/railsAaron Patterson2014-06-044-36/+14
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * 'master' of github.com:rails/rails: For our build, stick with mail 2.5.x for now Correct result, previously showing wrong result Collapse PG default extractoin of most types to single regex Change wording of explanation about precision & scale of decimal numbers [ci skip] Cleaned up duplicated CHANGELOG entry [ci skip] reuse available belongs_to? method Convert StrongParameters cache to a hash. This fixes an unbounded memory leak demonstrated on @tenderlove's latest blog post: Partially revert deprecation of *_filter Pluralize params Add default_i18n_subject to the guides Fix regression on eager loading association based on SQL query rather than existing column. Relax mail gem constraint from ~> 2.5.4 to ~> 2.5, >= 2.5.4 Keep column defaults in type cast form Return a null column when no column exists for an attribute Refactor XML serializer to not depend on `serialized_attributes` Test the serialized types of virtual columns in XML implement ActiveRecord::Base#pretty_print + changelog Remove duplicated HashWithIndifferentAccess#with_indifferent_access.
| * Merge pull request #15498 from zenspider/fix_memory_leakGuillermo Iguaran2014-06-031-6/+6
| |\ | | | | | | Convert StrongParameters cache to a hash. This fixes an unbounded memory leak
| | * Convert StrongParameters cache to a hash. This fixes an unboundedRyan Davis2014-06-031-6/+6
| | | | | | | | | | | | | | | | | | memory leak demonstrated on @tenderlove's latest blog post: http://tenderlovemaking.com/2014/06/02/yagni-methods-are-killing-me.html
| * | Partially revert deprecation of *_filterRafael Mendonça França2014-06-031-27/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We are going to deprecate only on Rails 5 to make easier plugin maintainers support different Rails versions. Right now we are only discouraging their usage. This reverts commit 6c5f43bab8206747a8591435b2aa0ff7051ad3de. Conflicts: actionpack/CHANGELOG.md
| * | Merge pull request #15349 from tgxworld/remove_duplicated_method_callRafael Mendonça França2014-06-032-3/+2
| |\ \ | | | | | | | | Remove duplicated HashWithIndifferentAccess#with_indifferent_access.
| | * | Remove duplicated HashWithIndifferentAccess#with_indifferent_access.Guo Xiang Tan2014-05-262-3/+2
| | | |
* | | | push splitting "to" up the callstackAaron Patterson2014-06-031-15/+20
|/ / /
* | | Routes specifying 'to:' must be a string that contains a "#" or a rackAaron Patterson2014-06-031-3/+21
| | | | | | | | | | | | | | | application. Use of a symbol should be replaced with `action: symbol`. Use of a string without a "#" should be replaced with `controller: string`.
* | | push some options munging to an alternate constructorAaron Patterson2014-06-031-13/+19
| | |
* | | move options_constraints tests next to each otherAaron Patterson2014-06-031-2/+2
| | |
* | | only do is_a checks on `formatted` onceAaron Patterson2014-06-031-9/+5
| | |
* | | push options_constraints processing upAaron Patterson2014-06-031-22/+24
| | | | | | | | | | | | | | | this lets us reduce is_a checks on the options_constraints and push "callable constraints" verification to the right place.
generated by cgit v1.2.3 (git 2.25.1) at 2024-08-16 04:55:41 +0000