aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/lib
Commit message (Collapse)AuthorAgeFilesLines
* PERF: Hash[] + map is faster than this silly inject, and var[1..-1] is ↵Santiago Pastorino2010-10-031-3/+3
| | | | faster than var.sub('@', '')
* Rename _assigns to view_assigns in AV::TCDavid Chelimsky2010-10-031-9/+21
| | | | | | | | | - also add tests - also deprecate _assigns [#5751 state:resolved] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* Fixing search_field to remove object attribute from options hash [#5730 ↵Aditya Sanghi2010-10-021-1/+1
| | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* Revert "Perf: refactor _assign method to avoid inject and defining unneeded ↵José Valim2010-10-021-1/+5
| | | | | | | | local var." _assigns must return a hash. This reverts commit e66c1cee86aba1c81152f3d0872313e65cec85a9.
* removing AS::Testing::Default in favor of just undefing default_testAaron Patterson2010-10-011-2/+1
|
* Revert "removing crazy finalizer code until there is proof that we need it"José Valim2010-09-301-0/+11
| | | | This reverts commit a40e3c1a9604ab3737ad2465c8f6a6db0fe0cc78.
* Properly reload routes defined in class definitionPiotr Sarnacki2010-09-301-0/+1
| | | | | | | | | | | | | | | | | Sometimes it's easier to define routes inside Engine or Application class definition (e.g. one file applications). The problem with such case is that if there is a plugin that has config/routes.rb file, it will trigger routes reload on application. Since routes definition for application is not in config/routes.rb file routes_reloader will fail to reload application's routes properly. With this commit you can pass routes definition as a block to routes method, which will allow to properly reload it: class MyApp::Application < Rails::Application routes do resources :users end end
* Allow mounting engines at '/'Piotr Sarnacki2010-09-301-1/+1
| | | | | Without that commit script_name always become '/', which results in paths like //posts/1 instead of /posts/1
* Use .find here as it is simpler and faster.José Valim2010-09-301-1/+1
|
* avoid creating a block if possibleAaron Patterson2010-09-291-2/+2
|
* fixing regexp warningsAaron Patterson2010-09-291-1/+1
|
* tag value can be false, so nil? check is necessaryAaron Patterson2010-09-291-1/+1
|
* another case of extra nil? checkNeeraj Singh2010-09-301-1/+1
|
* no need to check for nil?Neeraj Singh2010-09-301-2/+2
|
* no need to check for nil?Neeraj Singh2010-09-301-1/+1
|
* no need of nil checkNeeraj Singh2010-09-301-1/+1
|
* removing crazy finalizer code until there is proof that we need itAaron Patterson2010-09-291-9/+0
|
* removing useless codeAaron Patterson2010-09-291-1/+0
|
* dry up method checking in the request objectAaron Patterson2010-09-291-10/+9
|
* reduce function calls on ArrayAaron Patterson2010-09-291-3/+2
|
* removing more lolinjectAaron Patterson2010-09-291-8/+7
|
* removing lollerjectAaron Patterson2010-09-291-1/+1
|
* oops, missed a uniqAaron Patterson2010-09-291-1/+1
|
* dry up action_methodsAaron Patterson2010-09-291-4/+4
|
* Merge remote branch 'miloops/warnings'José Valim2010-09-292-7/+3
|\
| * We can't assign @view_context_class here, define super() in test instead if ↵Emilio Tagua2010-09-291-1/+1
| | | | | | | | we want to avoid warnings.
| * _ is not a valid scheme name character, \w includes it and also is redundant ↵Emilio Tagua2010-09-291-1/+1
| | | | | | | | | | | | with \d. 'The scheme name consists of a letter followed by any combination of letters, digits, and the plus ("+"), period ("."), or hyphen ("-") characters; and is terminated by a colon (":").'
| * Remove redundant conditional.Emilio Tagua2010-09-291-5/+1
| |
| * Don't try to interpolate string if there's no interpolation point at all.Emilio Tagua2010-09-291-1/+1
| |
| * Initialize @view_context_class and cache view_context_class value.Emilio Tagua2010-09-291-1/+1
| |
* | no need to call e.classAaron Patterson2010-09-291-1/+1
| |
* | Fix a small typo (ht: masterkain)José Valim2010-09-291-1/+1
|/
* Ensure that named routes do not overwrite previously defined routes.José Valim2010-09-291-10/+13
|
* Fix an error on 1.8.7.José Valim2010-09-291-1/+1
|
* @_etag is not used anywhere.José Valim2010-09-291-2/+0
|
* Avoid (@_var ||= nil) pattern by using initialize methods and ensuring ↵José Valim2010-09-299-33/+41
| | | | everyone calls super as expected.
* Merge remote branch 'miloops/warnings'José Valim2010-09-2917-23/+39
|\
| * Define @_layout if it is not defined.Emilio Tagua2010-09-281-0/+1
| |
| * Initialize @path.Emilio Tagua2010-09-281-0/+1
| |
| * Remove more warnings on AP.Emilio Tagua2010-09-282-3/+4
| |
| * Remove more warnings: no need to define attr_accessor if already exists. ↵Emilio Tagua2010-09-281-3/+5
| | | | | | | | Initialize ivar.
| * Use redefine_method instead define_method, it may be already defined.Emilio Tagua2010-09-281-1/+1
| |
| * Remove method if exists, avoid calling Array#first so many times.Emilio Tagua2010-09-281-3/+5
| |
| * Remove more warnings on variables.Emilio Tagua2010-09-281-0/+1
| |
| * Initialize @compiled_at if it is not.Emilio Tagua2010-09-281-0/+1
| |
| * Remove warings from rescues: don't define more than once debug_hash method ↵Emilio Tagua2010-09-281-2/+2
| | | | | | | | and ask if @response if defined.
| * Remove remaining warnings on _trace by adding parenthesis to gsub arguments.Emilio Tagua2010-09-281-3/+3
| |
| * Use parenthesis to avoid ambiguous first argument warning.Emilio Tagua2010-09-281-1/+1
| |
| * Ask if the instance variable is defined before asking for it, avoid *many* ↵Emilio Tagua2010-09-281-1/+5
| | | | | | | | warnings.
| * Avoid more uninitialized variable warnings.Emilio Tagua2010-09-282-2/+3
| |
generated by cgit v1.2.3 (git 2.25.1) at 2024-10-31 16:00:25 +0000