aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/lib
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #8497 from acapilleri/conditional_cacheRafael Mendonça França2012-12-141-12/+24
|\ | | | | | | Removed :if / :unless conditions to fragment cache in favour of *cache_i...
| * Removed :if and :unless from fragment cache option in favour ofAngelo capilleri2012-12-141-12/+24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | cache_if(condition, option, &block) and cache_unless(condition, option, &block). In the PR #8371 was introduced conditional options :if and :unless in the cache method. Example: <%= cache @model, if: some_condition(@model) do %> ... <%end%> This is a good feature but *cache_if* and and *cache_unless* are more concise and close to the standard of rails view helpers (ex: link_to_if and link_to_unless). Example: <%= cache_if condition, @model do %> ... <%end%>
* | Clear url helper methods when routes are reloadedAndrew White2012-12-141-0/+6
| | | | | | | | | | Remove all the old url helper methods when clear! is called on the route set because it's possible that some routes have been removed.
* | Revert "Clear url helpers when reloading routes"Andrew White2012-12-141-1/+0
| | | | | | | | | | | | | | | | | | | | This doesn't actually remove old url helper methods as they are defined in a different module. This reverts commit 96bcef947bf713b7d9fc88f26dff69f568111262. Conflicts: actionpack/CHANGELOG.md
* | Add missing require.Rafael Mendonça França2012-12-133-0/+4
| | | | | | | | | | I was trying to use those files without Rails and that require was missing.
* | Merge pull request #8499 from schneems/schneems/html-route-inspectorSteve Klabnik2012-12-131-7/+24
|\ \ | | | | | | Output routes in :html format
| * | Output routes in :html formatschneems2012-12-121-7/+24
| |/ | | | | | | | | | | By formatting routes for different media (txt/html) we can apply optimizations based on the format. We can include meta-data in the HTML to allow a rich experience while rendering and viewing the routes. This PR shows route helpers as they are used with the `_path` extension, it also has a javascript toggle on the top to switch to `_url`. This way the developer can see the exact named route helper they can use instead of having to modify a base. This is one example of an optimization that could be applied. Eventually we can link out to guides for the different columns to better explain what helper, HTTP Verb, Path, and Controller#action indicate. We could even add a route search box that could allow developers to input a given route and see all of the routes that match it. These are stand alone features and should be delivered separately.
* | Bring back helpers_path attr accessorCarlos Antonio da Silva2012-12-131-1/+1
| | | | | | | | | | This is apparently used by the railtie to setup the app helpers paths correctly between initializers. I'll need to check it further.
* | Refactor helpers code in Action Pack a bitCarlos Antonio da Silva2012-12-133-8/+6
|/ | | | | | | | * Avoid calling class_eval when not needed * Remove helpers_path attr accessor, it's defined as a class attribute a few lines later * Avoid creating extra arrays when finding helpers, use flat_map and sort! * Remove not required refer variable when redirecting :back
* Remove deprecation message from Action PackCarlos Antonio da Silva2012-12-111-1/+1
| | | | | Related to the deprecation of Time.utc_time in favor of Time.utc, in 48583f8bf74d1cefefea3cd6591bd546a9eaff6c.
* Remove not used variable warnings from AM and ACCarlos Antonio da Silva2012-12-111-1/+1
|
* Fix rewinding in ActionDispatch::Request#raw_postMatt Venables2012-12-111-2/+3
| | | | | | | | | If env['RAW_POST_DATA'] is nil, #raw_post will attempt to set it to the result of #body (which will return env['rack.input'] if env['RAW_POST_DATA'] is nil). #raw_post will then attempt to rewind the result of another call to #body. Since env['RAW_POST_DATA'] has already been set, the result of #body is not env['rack.input'] anymore. This causes env['rack.input'] to never be rewound.
* Match the controller and path names defensively.Hiro Asari2012-12-101-1/+1
| | | | Use '\A' instead of '^', and make the alteration shorter.
* Merge pull request #8468 from schneems/schneems/rack-index-pageSantiago Pastorino2012-12-101-1/+1
|\ | | | | Use Rails to Render Default Index Page
| * Use Rails to Render Default Index Pageschneems2012-12-101-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is an alternative implementation to #7771 thanks to the advice of @spastorino Rails is a dynamic framework that serves a static index.html by default. One of my first questions ever on IRC was solved by simply deleting my public/index.html file. This file is a source of confusion when starting as it over-rides any set "root" in the routes yet it itself is not listed in the routes. By making the page dynamic by default we can eliminate this confusion. This PR moves the static index page to an internal controller/route/view similar to `rails/info`. When someone starts a rails server, if no root is defined, this route will take over and the "dynamic" index page from rails/welcome_controller will be rendered. These routes are only added in development. If a developer defines a root in their routes, it automatically takes precedence over this route and will be rendered, with no deleting of files required. In addition to removing this source of confusion for new devs, we can now use Rails view helpers to build and render this page. While not the primary intent, the added value of "dogfooding" should not be under-estimated. The prior PR #7771 had push-back since it introduced developer facing files. This PR solves all of the same problems, but does not have any new developer facing files (it actually removes one). cc/ @wsouto, @dickeyxxx, @tyre, @ryanb, @josevalim, @maxim, @subdigital, @steveklabnik ATP Railties and Actionpack.
* | Merge pull request #8476 from sheerun/fix/multipart-getRafael Mendonça França2012-12-101-1/+5
|\ \ | |/ |/| Prevent raising EOFError on multipart GET request.
| * Prevent raising EOFError on multipart GET request.Adam Stankiewicz2012-12-101-1/+5
| | | | | | | | | | | | | | | | | | | | Such request can happen on Internet Explorer. When we redirect after multipart form submission, the request type is changed to GET, but Content-Type is preserved as multipart. GET request cannot have multipart body and that caused Rails to fail. It's similar fix to Rack's one: https://github.com/chneukirchen/rack/blob/8025a4ae9477d1e6231344c2b7d795aa9b3717b6/lib/rack/request.rb#L224
* | Revert "API reader should look elsewhere for helper instructions"Vijay Dev2012-12-091-24/+0
| | | | | | | | | | | | | | | | | | This reverts commit ba2d867b2961b5ef72aad353c2d647b04654cbe3. Reason: https://github.com/lifo/docrails/commit/ba2d867b2961b5ef72aad353c2d647b04654cbe3#commitcomment-2276670 [ci skip]
* | Merge branch 'master' of github.com:lifo/docrailsVijay Dev2012-12-082-2/+40
|\ \
| * | API reader should look elsewhere for helper instructionsThiago Pinto2012-12-061-0/+24
| | |
| * | complementary options guidelines for f.file_field and file_field_tagThiago Pinto2012-12-062-0/+8
| | |
| * | adding example for f.file_inputThiago Pinto2012-12-061-0/+3
| | |
| * | adding example for f.file_inputThiago Pinto2012-12-061-0/+3
| | |
| * | correct bad jquery syntaxThiago Pinto2012-12-061-2/+2
| | |
* | | use `_action` instead of `_filter` callbacksFrancesco Rodriguez2012-12-072-8/+8
| | |
* | | update documentation and code to use _action callbacksFrancesco Rodriguez2012-12-072-7/+7
| | |
* | | fix prepend_before_filter documentation [ci skip]Francesco Rodriguez2012-12-071-3/+3
| | |
* | | Rename all action callbacks from *_filter to *_actionDavid Heinemeier Hansson2012-12-071-64/+86
| |/ |/|
* | Revert "Invert precedence of content in ActionDispatch::Static"Andrew White2012-12-071-11/+7
| | | | | | | | This reverts commit c59734f756b79c39486c45273d2cc5d42cd0c864.
* | Invert precedence of content in ActionDispatch::StaticAndrew White2012-12-061-7/+11
| | | | | | | | | | | | | | | | | | | | This commit inverts the precedence in ActionDispatch::Static so that dynamic content will be served before static content. This is so that precompiled assets do not inadvertently get included when running in development mode - it should have no effect in production where static files are usually handled by the web server. Closes #6421
* | Merge pull request #8371 from freegenie/5396-conditional-fragment-cachingRafael Mendonça França2012-12-051-1/+13
|\ \ | | | | | | | | | | | | Allow fragment cache to accept :if and :unless options. Closes #5396
| * | Allow fragment cache to accept :if and :unless optionsFabrizio Regini2012-12-051-1/+13
| | | | | | | | | | | | [Stephen Ausman + Fabrizio Regini]
* | | Merge pull request #8412 from ↵Rafael Mendonça França2012-12-051-18/+14
|\ \ \ | |/ / |/| | | | | | | | JoeyButler/action_dispatch_routing_mapper_refactoring Extract method refactoring.
| * | Extract method refactoring in ActionDispatch::Routing::SingletonResource.Joey Butler2012-12-051-18/+14
| | |
* | | Merge pull request #8404 from freegenie/filter_redirectsAndrew White2012-12-054-1/+40
|\ \ \
| * | | Adding filter capability to ActionController logsFabrizio Regini2012-12-054-1/+40
| | |/ | |/|
* / | Replace comments' non-breaking spaces with spacesclaudiob2012-12-042-3/+3
|/ / | | | | | | | | | | | | | | | | | | Sometimes, on Mac OS X, programmers accidentally press Option+Space rather than just Space and don’t see the difference. The problem is that Option+Space writes a non-breaking space (0XA0) rather than a normal space (0x20). This commit removes all the non-breaking spaces inadvertently introduced in the comments of the code.
* | Merge branch 'master' of github.com:lifo/docrailsVijay Dev2012-12-0422-283/+232
|\ \ | | | | | | | | | | | | Conflicts: guides/source/migrations.md
| * | copy edits [ci skip]Vijay Dev2012-12-044-27/+18
| | |
| * | Fix a typo in ActionController::CachingJean Boussier2012-12-031-2/+1
| | |
| * | Remove nodoc from FlashHash #[]= [ci skip]Pablo Torres2012-12-011-1/+1
| | |
| * | Cleans and removes 'Examples' tag [ci skip]Alvaro Pereyra2012-12-012-4/+0
| | |
| * | Cleans and removes useless 'Examples' tag [ci skip]Alvaro Pereyra2012-12-016-62/+44
| | |
| * | Add documentation to AssetTagHelper#image_alt [ci skip]Florent Guilleux2012-12-011-0/+3
| | |
| * | Fixes wrong typo on FormHelper [ci skip]Alvaro Pereyra2012-12-011-1/+1
| | |
| * | Cleans documentation from Helpers [ci skip]Alvaro Pereyra2012-12-015-121/+98
| | |
| * | Revert "Remove trailing whitespaces"Florent Guilleux2012-12-012-2/+2
| | | | | | | | | | | | This reverts commit 90c887fa7d0c454b7533e208daefc342dea4d5f3.
| * | Remove trailing whitespacesFlorent Guilleux2012-12-012-2/+2
| | |
| * | Improves documentation of Capture helper [ci skip]Alvaro Pereyra2012-12-012-14/+13
| | |
| * | Removes :nodoc: tag on AtomFeedHelper [ci skip]Alvaro Pereyra2012-12-011-3/+3
| | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-09 09:35:41 +0000