Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Cache some more things to improve partial perf | Yehuda Katz | 2009-08-09 | 2 | -5/+9 |
| | |||||
* | Went from 25% slower partials (vs. 2.3) to 10% faster. More to come. | Yehuda Katz | 2009-08-09 | 2 | -5/+9 |
| | |||||
* | Clean up partial object some more; replace passing around a block to a ↵ | Yehuda Katz | 2009-08-09 | 1 | -35/+39 |
| | | | | single block ivar | ||||
* | Clean up initializer and some of the internals of PartialRenderer | Yehuda Katz | 2009-08-09 | 2 | -49/+45 |
| | |||||
* | Ruby 1.9 compat: can't implicitly set instance var using block arg | Jeremy Kemper | 2009-08-08 | 1 | -2/+2 |
| | |||||
* | Merge branch 'patches' | Michael Koziarski | 2009-08-09 | 1 | -1/+1 |
|\ | |||||
| * | Don't call additional methods on builders passed to the atom_feed helper. | Michael Koziarski | 2009-08-09 | 1 | -1/+1 |
| | | | | | | | | | | | | Additionally, actually test that the atom_feed helper works with :xml as an option. [#1836 state:committed] | ||||
* | | Add :redirect to the testable RJS statements [#2612 state:resolved] | Jon Wood | 2009-08-09 | 1 | -3/+10 |
| | | | | | | | | | | | | | | Example : assert_select_rjs :redirect, root_path Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | | Fix HTTP basic authentication for long credentials [#2572 state:resolved] | Jan Schwenzien | 2009-08-09 | 1 | -1/+1 |
|/ | | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | Update truncate documentation / examples to more clearly demonstrate its ↵ | Steve St. Martin | 2009-08-08 | 1 | -8/+10 |
| | | | | | | | | actual behavior [#3016 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | Allow content_tag options to take an array [#1741 state:resolved] ↵ | rizwanreza | 2009-08-08 | 1 | -9/+7 |
| | | | | | | | | | | [rizwanreza, Nick Quaranto] Example: content_tag('p', "limelight", :class => ["song", "play"]) # => <p class="song play">limelight</p> Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | Allow radio buttons to work with booleans. | José Valim | 2009-08-08 | 1 | -2/+2 |
| | | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | Add :include_blank option for select_tag [#1987 status:resolved] | rizwanreza | 2009-08-08 | 1 | -0/+7 |
| | | | | | Signed-off-by: José Valim <jose.valim@gmail.com> Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | Polymorphic routes generates collection URL from model class [#1089 ↵ | Niklas Holmgren | 2009-08-08 | 1 | -0/+7 |
| | | | | | | | state:resolved] Signed-off-by: Dan Pickett <dpickett@enlightsolutions.com> Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | Merge commit 'jose/responder' | Yehuda Katz | 2009-08-08 | 3 | -26/+26 |
|\ | |||||
| * | Renamed ActionController::Renderer to ActionController::Responder and ↵ | José Valim | 2009-08-08 | 3 | -26/+26 |
| | | | | | | | | ActionController::MimeResponds::Responder to ActionController::MimeResponds::Collector. | ||||
* | | Fixes "Cached fragment hit" written to log even if fragment is not cached ↵ | Yehuda Katz | 2009-08-08 | 1 | -2/+2 |
|/ | | | | (Erik Andrejko) [#2917 state:resolved] | ||||
* | First pass at making partial rendering an Object. More cleanup to come. | Yehuda Katz | 2009-08-08 | 4 | -73/+93 |
| | |||||
* | remove duplicate call to stringify_keys [#2587 status:resolved] | Steve St. Martin | 2009-08-08 | 1 | -1/+1 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Fix number_to_precision rounding error [#2071 state:resolved] | wmoxam | 2009-08-08 | 1 | -1/+1 |
| | | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | Ruby 1.9.2: implicit argument passing of super from method defined by ↵ | Jeremy Kemper | 2009-08-07 | 1 | -3/+1 |
| | | | | define_method() is not supported | ||||
* | Rename find_by_parts and find_by_parts? to find and exists? | Yehuda Katz | 2009-08-07 | 9 | -15/+15 |
| | |||||
* | Renamed presenter to renderer, added some documentation and defined its API. | José Valim | 2009-08-07 | 13 | -229/+268 |
| | |||||
* | Encapsulate respond_with behavior in a presenter. | José Valim | 2009-08-07 | 1 | -190/+165 |
| | |||||
* | Add destroyed? to ActiveRecord, include tests for polymorphic urls for ↵ | José Valim | 2009-08-07 | 1 | -0/+31 |
| | | | | destroyed objects and refactor mime responds tests and documentation. | ||||
* | Add nagivational behavior to respond_with. | José Valim | 2009-08-07 | 3 | -61/+124 |
| | |||||
* | Merge branch 'master' of git://github.com/rails/rails into old | José Valim | 2009-08-07 | 4 | -14/+23 |
|\ | |||||
| * | Get all ActionController partial rendering to use ActionView's partial code. ↵ | Yehuda Katz | 2009-08-07 | 4 | -14/+23 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Consequences: * It is not possible to always pre-determine the layout before going to ActionView. This was *already* broken for render :partial => @object, :layout => true. This is now handled by overriding render_to_body in layouts.rb and manually injecting the partial's response. This needs to be done in ActionController since ActionController knows enough to get _layout_for_option. There is probably a better abstraction here. * As a result, all partial rendering can correctly restrict their layouts to the mime type of the rendered partial. This could have previously caused a bug in some edge cases. * If other layout-like options are added, they might need to add special code for the case of render :partial. We should try to think of an alternate solution, if possible, but this works for the cases we know of now. | ||||
* | | Merge branch 'master' of git://github.com/rails/rails into old | José Valim | 2009-08-07 | 47 | -393/+250 |
|\| | |||||
| * | Whitespace | Yehuda Katz | 2009-08-07 | 1 | -7/+7 |
| | | |||||
| * | Continue reworking the partial path. | Yehuda Katz | 2009-08-07 | 2 | -47/+22 |
| | | | | | | | | * TODO: Review ActionController calling render_template for certain partials. Might we be able to save logic by always delegating to AV's render_partial? | ||||
| * | Modify various partial methods to carry along the block that can be passed ↵ | Yehuda Katz | 2009-08-07 | 3 | -44/+54 |
| | | | | | | | | | | | | | | | | | | | | in with render * _render_single_template, which renders a template without layout * _render_partial_unknown_type, which renders a partial of unknown type (the entry method for most partial rendering; supports strings, objects, and collections) * _render_partial_object, which renders a partial for a single object. * extracted _render_partial_path so it can be used to render the spacer without going through the public render :partial | ||||
| * | Some more AV work: | Yehuda Katz | 2009-08-07 | 2 | -26/+25 |
| | | | | | | | | | | | | | | | | * rename _render_partial to _render_partial_unknown_type to reflect that for this call, we don't know the type. * Merge _render_partial_with_block and _render_partial_with_layout to _render_partial * TODO: Check to see if any more logic can be shared * TODO: See about streamlining block path so we can get rid of @_proc_for_layout * Remove @exempt_from_layout as it is no longer needed | ||||
| * | Replace _render_template_with_layout with _render_template since the layout ↵ | Yehuda Katz | 2009-08-07 | 3 | -13/+17 |
| | | | | | | | | is optional | ||||
| * | Some more AV refactoring: | Yehuda Katz | 2009-08-07 | 2 | -15/+6 |
| | | | | | | | | | | * remove no longer used _array_like_objects * _render_content_with_layout renamed to _render_content since layout it optional * remove check for optional layout before _render_content | ||||
| * | Start cleaning up partial path | Yehuda Katz | 2009-08-07 | 4 | -12/+20 |
| | | |||||
| * | This is handled by the resolver now | Yehuda Katz | 2009-08-07 | 1 | -24/+5 |
| | | |||||
| * | Clean up render @object a bit more. | Yehuda Katz | 2009-08-07 | 2 | -21/+19 |
| | | |||||
| * | Improve a path in _render_partial | Yehuda Katz | 2009-08-06 | 2 | -24/+27 |
| | | |||||
| * | Remove file that doesn't seem to be used anymore | Yehuda Katz | 2009-08-06 | 1 | -84/+0 |
| | | |||||
| * | Move AbstractController to a top-level component | Yehuda Katz | 2009-08-06 | 12 | -20/+18 |
| | | |||||
| * | ActionController::Metal#to_rack converted to #to_a to match normal rack ↵ | Yehuda Katz | 2009-08-06 | 2 | -3/+3 |
| | | | | | | | | convention | ||||
| * | Update _render_options to reflect the fact that they're public | Yehuda Katz | 2009-08-06 | 1 | -6/+6 |
| | | |||||
| * | Rename /base to /metal and make base.rb and metal.rb top-level to reflect ↵ | Yehuda Katz | 2009-08-06 | 26 | -36/+36 |
| | | | | | | | | their module locations | ||||
| * | rename ActionController::Http to ActionController::Metal at Josh's suggestion | Yehuda Katz | 2009-08-06 | 4 | -6/+6 |
| | | |||||
| * | Replace _action_view with view_context to reflect that it is public and that ↵ | Yehuda Katz | 2009-08-06 | 4 | -9/+8 |
| | | | | | | | | it does not need to be an ActionView instance | ||||
| * | replace _render_*_from_controller with render_* as they are intended to be ↵ | Yehuda Katz | 2009-08-06 | 4 | -8/+8 |
| | | | | | | | | public | ||||
| * | Make sure javascript_include_tag/stylesheet_link_tag does not append ".js" ↵ | Matthew Rudy Jacobs | 2009-08-05 | 1 | -10/+14 |
| | | | | | | | | | | | | or ".css" onto external urls [#1664 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
| * | Remove legacy processing and content_length | Yehuda Katz | 2009-08-02 | 1 | -40/+10 |
| | | | | | | | | | | | | | | | | | | | | | | * convert_content_type! is handled by assign_default_content_type_and_charset! * set_content_length! should be handled by the endpoint server. Otherwise each middleware that modifies the body has to do the expensive work of recalculating content_length. * convert_language! appears to be legacy. There are no tests for this * convert_cookies! should be handled by the new HeaderHash in Rack * Use an integer for .status's internal representation to avoid needing to do String manipulation just to find out the status | ||||
| * | Update cache_control to be a Hash of options that is used to build the header. | Yehuda Katz | 2009-08-02 | 4 | -26/+25 |
| | | | | | | | | * Significantly simplifies setting and modifying cache control in other areas |