Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | | | | Fix #9168 Initialize NullCookieJar with all options needed for KeyGenerator | Andrey Chernih | 2013-02-08 | 2 | -5/+9 | |
|/ / / | ||||||
* | | | ruby constant syntax is not supported as routing `:controller` option. | Yves Senn | 2013-02-06 | 1 | -0/+6 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The current implementation only works correctly if you supply the `:controller` with directory notation (eg. `:controller => 'admin/posts'`). The ruby constant notation (eg. `:controller => 'Admin::Posts`) leads to unexpected problems with `url_for`. This patch prints a warning for every non supported `:controller` option. I also added documentation how to work with namespaced controllers. The warning links to that documentation in the rails guide. | |||||
* | | | partials inside directory work with `assert_template` | Yves Senn | 2013-02-04 | 2 | -2/+3 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | previously when a partial was placed inside a directory (eg. '/dir/_partial'), `assert_template` did not replace the '_' prefix when looking through rendered tempaltes, which resulted in an error. I modified it to replace both, the leading '_' and the last '_' after a '/'. | |||||
* | | | descriptive `assert_template` error when partial wasn't rendered | Yves Senn | 2013-02-04 | 2 | -0/+7 | |
| |/ |/| | | | | | | | | | | | When `assert_template` is used with the :locals option, and the partial was not rendered, a method_missing error was raised. This changes first checks, if the partial actually was rendered and raises a descriptive error. | |||||
* | | Missing require hash/keys | Akira Matsuda | 2013-02-01 | 2 | -0/+3 | |
| | | ||||||
* | | Missing or unneeded require extract_options | Akira Matsuda | 2013-02-01 | 8 | -1/+8 | |
| | | ||||||
* | | Use \A in Regexps | Egor Homakov | 2013-02-01 | 1 | -1/+1 | |
| | | | | | | | | | | So, if there is redirect_to params[:q] i can send ?q=javascript:asdf()%0A/localpath Or something more nasty, so please use \A | |||||
* | | remove dead code | Aaron Patterson | 2013-01-30 | 1 | -4/+1 | |
| | | ||||||
* | | change parameter name for positional args | Aaron Patterson | 2013-01-30 | 1 | -2/+1 | |
| | | ||||||
* | | nodoc the helper classes, cache stuff for optimized helper | Aaron Patterson | 2013-01-30 | 1 | -13/+17 | |
| | | ||||||
* | | cache path parts in the instance | Aaron Patterson | 2013-01-30 | 1 | -2/+3 | |
| | | ||||||
* | | stop evaling a string every time | Aaron Patterson | 2013-01-30 | 1 | -4/+4 | |
| | | ||||||
* | | moving helper classes outside the private block | Aaron Patterson | 2013-01-30 | 1 | -90/+88 | |
| | | ||||||
* | | pushing specialization down to the optimized class | Aaron Patterson | 2013-01-30 | 1 | -23/+25 | |
| | | ||||||
* | | use polymorphism to remove conditional | Aaron Patterson | 2013-01-30 | 1 | -35/+27 | |
| | | ||||||
* | | move conditionals to instance | Aaron Patterson | 2013-01-30 | 1 | -6/+16 | |
| | | ||||||
* | | pull stuff out of the caller and hide in the instance | Aaron Patterson | 2013-01-30 | 1 | -4/+3 | |
| | | ||||||
* | | moving more stuff on to the instance | Aaron Patterson | 2013-01-30 | 1 | -18/+18 | |
| | | ||||||
* | | move optimize_helper? to the helper instance | Aaron Patterson | 2013-01-30 | 1 | -9/+12 | |
| | | ||||||
* | | moving more stuff to the instance | Aaron Patterson | 2013-01-30 | 1 | -6/+6 | |
| | | ||||||
* | | moving some stuff to the initializer | Aaron Patterson | 2013-01-30 | 1 | -14/+38 | |
| | | ||||||
* | | moved more evald code | Aaron Patterson | 2013-01-30 | 1 | -8/+7 | |
| | | ||||||
* | | factored out some of the dynamic code | Aaron Patterson | 2013-01-30 | 1 | -19/+31 | |
| | | ||||||
* | | Fix `content_tag_for` with array html option. | Semyon Perepelitsa | 2013-01-31 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It would embed array as string instead of joining it like `content_tag` does: content_tag(:td, class: ["foo", "bar"]){} #=> '<td class="foo bar"></td>' Before: content_tag_for(:td, item, class: ["foo", "bar"]){} #=> '<td class="item ["foo", "bar"]" id="item_1"></td>' After: content_tag_for(:td, item, class: ["foo", "bar"]){} #=> '<td class="item foo bar" id="item_1"></td>' | |||||
* | | Add 'X-UA-Compatible' => 'chrome=1' to default headers | Guillermo Iguaran | 2013-01-29 | 1 | -1/+2 | |
| | | ||||||
* | | Remove BestStandardsSupport middleware | Guillermo Iguaran | 2013-01-29 | 3 | -32/+0 | |
| | | ||||||
* | | Merge pull request #9096 from tricknotes/fix-code-comment | Rafael Mendonça França | 2013-01-28 | 1 | -4/+4 | |
|\ \ | | | | | | | Fix code comment | |||||
| * | | Fix JavaScript syntax in code comment [ci skip] | Ryunosuke SATO | 2013-01-29 | 1 | -4/+4 | |
| | | | ||||||
* | | | Make current_url? work with a HEAD method | Michiel Sikkes | 2013-01-28 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | | | ActionDispatch::Head was removed in favor of Rack::Head. But Rack::Head does not convert GET requests to HEAD requests so we need to do checking for HEAD requests ourselves. | |||||
* | | | Remove caching_allowed? from ActionController::Caching | Michiel Sikkes | 2013-01-28 | 1 | -4/+0 | |
|/ / | | | | | | | | | Where is this used? No other code references to this method and it isn't being tested anywhere. No tests fail when commented out. | |||||
* | | Merge pull request #9032 from firmhouse/head-breaks-csrf | Santiago Pastorino | 2013-01-28 | 1 | -2/+2 | |
|\ \ | | | | | | | Make HEAD work / convert to GET once more | |||||
| * | | Added request.head? to forgery protection code | Michiel Sikkes | 2013-01-22 | 1 | -2/+2 | |
| | | | ||||||
* | | | Use Encoding::UTF_8 constant :do_not_litter: | Akira Matsuda | 2013-01-28 | 4 | -5/+5 | |
| | | | ||||||
* | | | Use already defined Encoding constants rather than creating one-trip Strings | Akira Matsuda | 2013-01-28 | 2 | -2/+2 | |
| | | | ||||||
* | | | add fetch to CookieJar | Aaron Patterson | 2013-01-27 | 1 | -0/+4 | |
| | | | ||||||
* | | | Merge remote-tracking branch 'docrails/master' | Xavier Noria | 2013-01-26 | 6 | -4/+98 | |
|\ \ \ | | | | | | | | | | | | | | | | | | | | | Conflicts: actionpack/lib/action_view/helpers/form_options_helper.rb guides/code/getting_started/app/controllers/comments_controller.rb | |||||
| * | | | generic pass before merging docrails | Xavier Noria | 2013-01-26 | 4 | -422/+62 | |
| | | | | ||||||
| * | | | :scissors: "raise" duplication | Akira Matsuda | 2013-01-26 | 1 | -2/+1 | |
| | | | | ||||||
| * | | | Review #translate docs [ci skip] | Carlos Antonio da Silva | 2013-01-20 | 1 | -8/+7 | |
| | | | | ||||||
| * | | | Add documentation for abstract controller #translate and #localize method. | Jens Bissinger | 2013-01-20 | 1 | -0/+10 | |
| | | | | ||||||
| * | | | Add documentation to ActionDispatch::Response | Matthew Stopa | 2013-01-20 | 1 | -0/+7 | |
| | | | | ||||||
| * | | | fix broken examples format in image_tag helper [ci skip] | Francesco Rodriguez | 2013-01-18 | 1 | -0/+2 | |
| | | | | ||||||
| * | | | repeating documentation for option form helpers | Thiago Pinto | 2013-01-17 | 1 | -0/+286 | |
| | | | | ||||||
| * | | | repeating documentation for date and time form helpers | Thiago Pinto | 2013-01-17 | 1 | -0/+148 | |
| | | | | ||||||
| * | | | Fix typo introduced in 0004ca3a | Carlos Antonio da Silva | 2013-01-16 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | [ci skip] | |||||
| * | | | More documentation for ActionDispatch::Response | Matthew Stopa | 2013-01-16 | 1 | -1/+3 | |
| | | | | | | | | | | | | | | | | [ci skip] | |||||
| * | | | Document ActionDispatch::Response#body method | Matthew Stopa | 2013-01-16 | 1 | -0/+1 | |
| | | | | ||||||
* | | | | Add keys/values methods to TestSession | Carlos Antonio da Silva | 2013-01-25 | 1 | -0/+8 | |
| | | | | | | | | | | | | | | | | Bring back the same API we have with Request::Session. | |||||
* | | | | Integrate Action Pack with Rack 1.5 | Carlos Antonio da Silva | 2013-01-25 | 3 | -4/+22 | |
| | | | | | | | | | | | | | | | | | | | | | | | | All ActionPack and Railties tests are passing. Closes #8891. [Carlos Antonio da Silva + Santiago Pastorino] | |||||
* | | | | use the helpers list rather than getting the methods from the module | Aaron Patterson | 2013-01-24 | 1 | -1/+1 | |
| | | | |