aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/lib
Commit message (Collapse)AuthorAgeFilesLines
* Rename route_wrapper partial layout to tableCarlos Antonio da Silva2013-01-062-1/+1
| | | | | | It is used by the table formatter only, and it's already inside a routes directory that namespaces it properly, so calling it just "table" seems simpler.
* Move table routes formatter class to the inspector and rename itCarlos Antonio da Silva2013-01-063-19/+19
| | | | | | | It feels more consistent to have this class called "HtmlTableFormatter", and to have it here with the routes inspector and console formatter, since it's used for both routing error exceptions and the rails info page.
* Merge pull request #8777 from goshakkk/delegate-classAndrew White2013-01-062-2/+2
|\ | | | | Delegate to :class rather than 'self.class'
| * delegate to :class rather than 'self.class'Gosha Arinich2013-01-062-2/+2
| |
* | Refactor the logic that checks whether or not to emit the hidden id fieldCarlos Antonio da Silva2013-01-061-7/+6
| | | | | | | | | | By checking for object.persisted? first, we avoid the hash lookups for new objects.
* | Move the hidden :id field logic to where it belongs toCarlos Antonio da Silva2013-01-061-6/+9
| | | | | | | | | | | | | | | | When dealing with nested forms, Rails automatically generates a hidden field with the id value of the current object being generated by fields_for. This logic was inside the method that's available from the template object, but we just need it when really dealing with nested attributes, so moving the code to here makes more sense.
* | Eliminate the usage of parent_builder option from form_forCarlos Antonio da Silva2013-01-061-19/+15
| | | | | | | | Just use it internally from fields_for until we come up with a better solution.
* | Do not call fields_for from form_for, to avoid instantiating two buildersCarlos Antonio da Silva2013-01-061-5/+5
| |
* | Refactor to not call path.ast twiceCarlos Antonio da Silva2013-01-061-2/+3
| |
* | refactor Route#ast to use or-equals and block, instead of return with a condGosha Arinich2013-01-061-5/+4
| |
* | Remove unnecessary begin..rescue..end, use only rescueAkira Matsuda2013-01-062-13/+9
|/
* Fix documentation to content_tag_for [ci skip]Rafael Mendonça França2013-01-051-2/+2
|
* Merge pull request #8766 from jcoglan/session_token_docsAndrew White2013-01-051-7/+4
|\ | | | | | | | | Remove suggestion that Procs can be used as session secrets. [ci skip]
| * Remove suggestion that Procs can be used as session secrets.James Coglan2013-01-051-7/+4
| |
* | Remove warning, remove not used variable, and make methods privateCarlos Antonio da Silva2013-01-051-3/+5
|/ | | | Warning: "shadowing outer local variable - routes".
* Close container div tag in routing error pageCarlos Antonio da Silva2013-01-051-9/+11
|
* Move style to head to make routes page valid html5Carlos Antonio da Silva2013-01-052-4/+6
|
* display mountable engine routes on RoutingError.Yves Senn2013-01-052-8/+23
|
* split formatting concerns from RoutesInspectorYves Senn2013-01-051-20/+42
|
* Wrong copy and paste :bomb:Rafael Mendonça França2013-01-051-1/+1
| | | | [ci skip]
* Add documentation to raise_on_unpermitted_parameters optionRafael Mendonça França2013-01-051-2/+17
| | | | [ci skip]
* Rename the configuration to raise_on_unpermitted_parametersRafael Mendonça França2013-01-052-11/+13
| | | | Also changed the exception to UnpermittedParameters
* Ensure that raise_on_unexpected_params configuration will workRafael Mendonça França2013-01-051-9/+7
|
* Merge pull request #8752 from thomasfedb/masterRafael Mendonça França2013-01-052-6/+31
|\ | | | | Exception on unexpected params when enabled.
| * Allow developers to enable raising of exception when unexpected params are ↵Thomas Drake-Brockman2013-01-052-6/+31
| | | | | | | | provided.
* | Allow use of durations for ActionDispatch::SSL configurationAndrew White2013-01-041-1/+1
| |
* | Remove unnecessary `ERB::Util::h`Ryunosuke SATO2013-01-057-17/+17
| | | | | | | | It is automatically applied when strings is unsafe for html.
* | Suppress warning about IO#lines in Ruby 2.0Ryunosuke SATO2013-01-041-1/+1
|/ | | | actionpack/lib/action_dispatch/middleware/exception_wrapper.rb:99: IO#lines is deprecated; use #each_line instead
* Merge pull request #8723 from goshakkk/refactor-error-pageGuillermo Iguaran2013-01-033-5/+27
|\ | | | | Move error page js into script tag
| * move error page js into script tagGosha Arinich2013-01-043-5/+27
| |
* | Add documentation to ActionDispatch::Http::UploadedFile#headersRafael Mendonça França2013-01-031-0/+1
| | | | | | | | [ci skip]
* | Remove a useless TODO commentRobin Dupret2013-01-031-1/+0
| |
* | Merge pull request #8705 from amparo-luna/change_update_attributes_to_updateGuillermo Iguaran2013-01-034-8/+8
|\ \ | |/ |/| Rename update_attributes method to update
| * Change docs to use update instead of update_attributesAmparo Luna + Guillermo Iguaran2013-01-034-8/+8
| |
* | Merge pull request #8713 from goshakkk/better-error-pageGuillermo Iguaran2013-01-032-12/+10
|\ \ | | | | | | Fix env toggling, improve error page styling
| * | fix env toggling, improve error page stylingGosha Arinich2013-01-032-12/+10
| | |
* | | Fix typo on form_tag_helper.rbPaulo Luis Franchini Casaretto2013-01-031-1/+1
| | | | | | | | | | | | The inline documentantion had a typo that was somewhat confusing.
* | | Merge pull request #8715 from goshakkk/refactor-mapperCarlos Antonio da Silva2013-01-031-9/+4
|\ \ \ | | | | | | | | Refactor Routing::Mapper#matches?
| * | | refactor Routing::MapperGosha Arinich2013-01-031-9/+4
| |/ /
* | | Explain the possible precautionsAndre Arko2013-01-021-3/+4
| | |
* | | Restore original remote_ip algorithm.Andre Arko2013-01-021-53/+112
|/ / | | | | | | | | | | | | | | | | | | | | Proxy servers add X-Forwarded-For headers, resulting in a list of IPs. We remove trusted IP values, and then take the last given value, assuming that it is the most likely to be the correct, unfaked value. See [1] for a very thorough discussion of why that is the best option we have at the moment. [1]: http://blog.gingerlime.com/2012/rails-ip-spoofing-vulnerabilities-and-protection/ Fixes #7979
* | Merge pull request #8697 from goshakkk/undupRafael Mendonça França2013-01-021-5/+3
|\ \ | | | | | | Remove another unnecessary dup
| * | remove another unnecessary dupGosha Arinich2013-01-021-5/+3
| | |
* | | Merge pull request #8701 from senny/8700_double_slash_with_trailing_slashRafael Mendonça França2013-01-021-1/+5
|\ \ \ | | | | | | | | do not append a second slash when using `trailing_slash: true`
| * | | do not append a second slash when usingYves Senn2013-01-021-1/+5
| |/ /
* | | Fixing closing </p>Guillermo Iguaran2013-01-021-1/+1
| | |
* | | Fix a number of validation/style errors:Sam Ruby2013-01-022-8/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * <pre> is not allowed to be nested inside of <p> elements in HTML * Indentation of </p> doesn't match corresponding <p> * <p> element not explicitly closed * One more </div> than <div> In each case, the template was fixed to match how a HTML5 parser would "see" the resulting page.
* | | take into account multipart when calculating tag attributesAaron Patterson2013-01-021-4/+7
| | |
* | | ask the form builder for form tag attributesAaron Patterson2013-01-021-2/+3
| | |
* | | do not mutate the options hash (when we do not need to)Aaron Patterson2013-01-021-2/+2
|/ /