aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/lib
Commit message (Collapse)AuthorAgeFilesLines
* remove useless status setAaron Patterson2015-08-261-2/+0
| | | | | | Now that `Controller#status=` just delegates to the response object, we don't need to set the response on the controller and the response. We can just set it in one place.
* remove useless conditionalAaron Patterson2015-08-261-1/+1
| | | | we always have a response object, so there is no reason to test it
* remove ivars from the "protected" listAaron Patterson2015-08-261-1/+1
| | | | these ivars don't exist anymore, so we can remove them from the list
* use the content_type method on the request objectAaron Patterson2015-08-261-1/+1
| | | | | since the controller always has a request on it, we can just ask the request for the content type.
* ask the response for the statusAaron Patterson2015-08-261-3/+2
| | | | | | The controller instance always has an instance of a response object. We should store the status code on the response object so that it's only store in one place.
* remove useless conditionalAaron Patterson2015-08-261-1/+1
| | | | | We always have a response object in controller instances, so we can remove this conditional
* remove useless conditionalAaron Patterson2015-08-261-1/+1
| | | | | controller instances always have a response object, so we don't need to test to see if there is one, just always call to_a on the response.
* provide a request and response to all controllersAaron Patterson2015-08-255-35/+37
| | | | | | | | | | Controllers should always have a request and response when responding. Since we make this The Rule(tm), then controllers don't need to be somewhere in limbo between "asking a response object for a rack response" or "I, myself contain a rack response". This duality leads to conditionals spread through the codebase that we can delete: * https://github.com/rails/rails/blob/85a78d9358aa728298cd020cdc842b55c16f9549/actionpack/lib/action_controller/metal.rb#L221-L223
* :snip: whitespaceAaron Patterson2015-08-251-2/+2
|
* move response allocation to the class levelAaron Patterson2015-08-252-8/+22
| | | | | | we don't need an instance to figure out what type of response to allocate. Later we'll pull this up the stack and pass the response object down
* adding a direct dispatch method to controller classesAaron Patterson2015-08-252-1/+11
| | | | This saves a lambda and request allocation on each request.
* always dispatch to controllers the same wayAaron Patterson2015-08-253-7/+26
| | | | | controllers should always go through the `action` class method so that their middleware is respected.
* always return a controller class from the `controller_class` methodAaron Patterson2015-08-252-9/+14
| | | | | now the caller can just treat it like a regular controller even though it will return a 404
* Remove unused requiresMarcin Olichwirowicz2015-08-251-2/+0
| | | | They are already required in `actionpack/lib/action_dispatch.rb` (L25-L26)
* Make `assert_index` privateMarcin Olichwirowicz2015-08-251-3/+1
| | | | | This `protected` keyword looks like some leftover, since we are not using explicit receiver, this should go under `private`
* remove unused require ‘set’NehaGautam2015-08-251-1/+0
|
* Remove unused block argumentsAnshul Sharma2015-08-251-1/+1
|
* Remove unused block argumentsamitkumarsuroliya2015-08-251-1/+1
|
* remove more direct `env` mutationsAaron Patterson2015-08-241-1/+3
|
* remove another `@env` accessAaron Patterson2015-08-241-1/+1
|
* remove more direct access to `env`Aaron Patterson2015-08-242-3/+4
|
* fewer calls to `env`Aaron Patterson2015-08-241-2/+2
| | | | We don't want to directly access the env hash
* stop using `@env` in the GET / POST methodsAaron Patterson2015-08-242-4/+11
| | | | | I want to implement this with something besides `@env` in the future, so lets stop directly referencing it.
* rm useless methodAaron Patterson2015-08-241-4/+0
| | | | superclass already has this method, so remove this one
* pull up dispatcher allocationAaron Patterson2015-08-242-5/+1
| | | | | the dispatcher class isn't configurable anymore, so pull up allocation to the method that needs it.
* directly ask the request for the controller classAaron Patterson2015-08-241-6/+1
| | | | | | Now that we don't have subclasses depending on this method (they augment the request class instead of the dispatch class) we can remove this method and directly ask the request object for the controller class
* remove useless ivarAaron Patterson2015-08-241-2/+1
|
* remove setter for the dispatcher classAaron Patterson2015-08-241-2/+2
| | | | we don't need it anymore. We always use the same dispatcher in tests.
* use a custom request class to determine the controller classAaron Patterson2015-08-241-2/+7
| | | | | | controller class resolution has been moved to the request object, so we should override that method instead of relying on the RouteSet to generate the controller class.
* Merge pull request #21339 from deepj/unused-block-argumentsCarlos Antonio da Silva2015-08-242-3/+3
|\ | | | | Remove unused block arguments
| * Remove unused block argumentsdeepj2015-08-232-3/+3
| |
* | use methods on the request object instead of accessing envAaron Patterson2015-08-231-7/+7
| |
* | use `Request#path_info` instead of direct ENV accessAaron Patterson2015-08-231-1/+1
| | | | | | | | | | we already have a request, so we should use the methods on the request to access the path info information
* | remove env access from debug_exceptionsAaron Patterson2015-08-231-10/+9
| | | | | | | | Creates fewer request objects and helps to abstract away from internals
* | remove more `env` accessAaron Patterson2015-08-231-11/+19
| |
* | remove more env accessAaron Patterson2015-08-231-3/+3
| |
* | remove more env accessAaron Patterson2015-08-231-4/+6
| |
* | convert more `@env` access to get / set headerAaron Patterson2015-08-232-12/+14
| |
* | remove usage of `@env`Aaron Patterson2015-08-231-3/+5
| | | | | | | | | | try to remove dependencies on `@env` so we can have more flexible internals
* | Another place to use a request object in NullSessionHash Ronak Jangir2015-08-231-3/+3
|/ | | | May be missed in 5fe141638f1243ac6ae187ae14aa398b4c1875a2 commit Also fixes the broken build
* use a request object in the session middlewareAaron Patterson2015-08-225-46/+50
| | | | | This commit allows us to use one request object rather than allocating multiple request objects to deal with the session.
* move more `@env` access to method callsAaron Patterson2015-08-221-16/+16
| | | | | We're going to implement storing env values differently in the future, so let's disconnect these methods from the instance variables
* move ORIGINAL_SCRIPT_NAME to the metaprogrammed methodsAaron Patterson2015-08-221-4/+1
|
* metaprogram the HTTP_X_REQUEST_ID methodAaron Patterson2015-08-221-6/+1
| | | | we're already doing this with a bunch of other header data.
* use `body_stream` instead of getting the env value ourselvesAaron Patterson2015-08-221-1/+1
| | | | we have a method that knows how to get rack.input, so lets use that.
* convert `@env` use to get / set headerAaron Patterson2015-08-221-16/+16
| | | | | | We need to abstract the internals of the request object away from this instance variable so that the values for `@env` can be calculated in a different way.
* use get / set header to avoid depending on the `env` ivarAaron Patterson2015-08-221-11/+14
|
* Fix Railties test failure for asset routeseileencodes2015-08-221-1/+5
| | | | | | | | | Since none of the action pack tests failed without this conditional it didn't seem necessary. This fixes the build because it correctly returns a 404 instead of a 500 for the asset routes test. Test that was failing was in the `assets_test.rb` file and was the test named `test_assets_routes_are_not_drawn_when_compilation_is_disabled`.
* Refactor to remove controller class from route to requesteileencodes2015-08-222-40/+20
| | | | | | | | | | This refactoring moves the controller class name that was on the route set to the request. The purpose of this refactoring is for changes we need to move controller tests to integration tests, mainly being able to access the controller on the request instead of having to go through the router. [Eileen M. Uchitelle & Aaron Patterson]
* set cached values in the env hashAaron Patterson2015-08-211-6/+9
|
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-05 03:25:25 +0000