| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
as the last element of the array
|
| |
|
|
|
|
|
|
|
|
|
| |
If a request has unknown format (eg. /foo.bar), the renderer
fallbacks to default format.
This patch reverts Rails 3.2 behavior after c2267db commit.
Fixes issue #9654.
|
| |
|
| |
|
|\
| |
| | |
change array of array to hash
|
| | |
|
|/ |
|
|
|
|
| |
It'd be a nice convention to mark the unused variables like this, now that Ruby 2 will issue no warnings for such vars being unused.
|
|\
| |
| | |
Exceptions raised when using ActionController::Live cause server crash
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Any exceptions that occured at the view or controller level for a
controller using ActionController::Live would cause the server to either
hang with an open socket indefinitely, or immediately crash (depending
on whether the server was launched with rails s or directly). Changed
the behavior of exceptions to act the same as streaming templates for
html requests, and allow for an on_error callback if needed.
|
|\ \
| | |
| | |
| | |
| | | |
Added documentation to the FormBuilder class
Closes #10115
|
| | |
| | |
| | |
| | |
| | | |
clarify issue #10115. Also made the field_helpers an explicit list of
methods.
|
|\ \ \
| | | |
| | | | |
Mark unused block parameters.
|
| |/ / |
|
|/ / |
|
|\ \
| | |
| | | |
Refactoring some reused code into a method (inside of the routes mapper)
|
| | |
| | |
| | |
| | | |
mapper) and adding a constant for all the possible scopes.
|
| | | |
|
| | | |
|
|\ \ \
| | | |
| | | | |
Optimize generated ERB to reduce method calls
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
before:
');@output_buffer.append= ( content_icon row[:content] );@output_buffer.safe_concat('
');@output_buffer.safe_concat(' ');@output_buffer.append= ( spinner_img );@output_buffer.safe_concat('
');@output_buffer.safe_concat(' </td>
<td class="content">
');@output_buffer.append= ( content_link row[:content] );@output_buffer.safe_concat('
');@output_buffer.safe_concat(' </td>
<td class="message">
');
after:
';@output_buffer.append=( content_icon row[:content] );@output_buffer.safe_append='
';@output_buffer.append=( spinner_img );@output_buffer.safe_append='
</td>
<td class="content">
';@output_buffer.append=( content_link row[:content] );@output_buffer.safe_append='
</td>
<td class="message">
';
|
| | | | |
|
| |/ /
|/| |
| | |
| | |
| | |
| | |
| | |
| | | |
If a file field tag is passed the multiple option, it is turned into an
array field (appending "[]"), but if the file field is passed an
explicit name as an option, leave the name alone (do not append "[]").
Fixes #9830
|
| | |
| | |
| | |
| | |
| | |
| | | |
There's no need to use Hash#merge with a new hash just for setting the
href option to pass it through. Since we're always dealing with a new
html_options hash, we're free to just set the value instead.
|
| | | |
|
|\ \ \
| | | |
| | | | |
Add block support for the mail_to helper
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
routing bugfixes when matching multiple paths
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Closes #9913.
We need to expand the match shorthand syntax for every path.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This problem was introduced with:
https://github.com/rails/rails/commit/d03aa104e069be4e301efa8cefb90a2a785a7bff
|
| |/ / /
|/| | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Closes #10071
`#normalize_path!` depends on the options so we need to call
`#normalize_options!` first to make sure everything is set correctly.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Add changelog entry
Delete changelog
|
|\ \ \ \
| | | | |
| | | | | |
Rename DummyKeyGenerator -> LegacyKeyGenerator
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
|/ / / / |
|
| | | | |
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
Cookie-base session store auto-upgrade
|
| | | | |
| | | | |
| | | | |
| | | | | |
Automatically configure cookie-based sessions to use the best cookie jar given the app's config
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Revert grep to select since they are not the same
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
A previous commit swapped out a call to select for a call to grep in
time_zone_options_for_select. This behavior actually causes the
regexp priority option to stop working.
ActiveSupport::TimeZone overrides the =~ operator which is what the
select block was using previously. Enumerable#grep
checks pattern === element and in this case that would be /US/ ===
ActiveSupport::TimeZone which does not work because
ActiveSupport::TimeZone does not supply an implicit converting to_str
method, only an explicit to_s method.
It would be impossible to provide a to_str method that behaves
identically to the =~ method provided on ActiveSupport::TimeZone
so the only option is to revert back to using select with =~.
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
remove unused variable and assignment
|
| | | | | | | |
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
remove unused match variables in selector
|
| |/ / / / / / |
|
|/ / / / / / |
|