aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/lib/action_view
Commit message (Collapse)AuthorAgeFilesLines
...
* | Merge pull request #4509 from rafaelfranca/form_tag-refactorJosé Valim2012-01-172-6/+5
|\ \ | | | | | | Refactor form_for and form_tag
| * | No need to call html_safe since concat two SaffeBuffers always results in a ↵Rafael Mendonça França2012-01-171-1/+1
| | | | | | | | | | | | SafeBuffer
| * | Use block syntax to avoid code duplicationRafael Mendonça França2012-01-171-3/+3
| | |
| * | No need to create a SafeBuffer since form_tag_html always rerturn a SafeBufferRafael Mendonça França2012-01-171-2/+1
| | |
* | | Fix errors when running entire suite due to class name collisionCarlos Antonio da Silva2012-01-181-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | The Post class is created everywhere in the test suite, and due to that when applying the Array() logic to refactor content_tag_for, some other change to the Post class was breaking record tag tests. The solution is to rename the class to not collide with others already defined in the test suite.
* | | Refactor content tag to not detect options Hash alwaysCarlos Antonio da Silva2012-01-181-7/+6
| | | | | | | | | | | | | | | Only check for options and prefix arguments order once when running content_tag_for with a collection.
* | | Do not mutate options hashCarlos Antonio da Silva2012-01-181-2/+2
| | |
* | | Remove capture.Tim Cooper2012-01-181-1/+1
| | |
* | | Always treat the object passed to content_tag_for as an array.Tim Cooper2012-01-181-7/+3
|/ /
* | Merge pull request #4488 from rafaelfranca/av-refactorXavier Noria2012-01-1728-436/+684
|\ \ | | | | | | ActionView::Helpers::FormHelper refactoring
| * | Extract input_checked? to a moduleRafael Mendonça França2012-01-174-9/+24
| | |
| * | Do not need of ActionView::Helpers scope since we are insideRafael Mendonça França2012-01-173-21/+21
| | | | | | | | | | | | ActionView::Helpers
| * | Remove unused codeRafael Mendonça França2012-01-171-39/+0
| | |
| * | Do not need each here anymoreRafael Mendonça França2012-01-171-3/+1
| | |
| * | Extract DatetimeSelectRafael Mendonça França2012-01-174-54/+11
| | |
| * | Extract TimeSelectRafael Mendonça França2012-01-175-7/+16
| | |
| * | Extract DateSelectRafael Mendonça França2012-01-174-6/+63
| | |
| * | CleanupRafael Mendonça França2012-01-171-72/+1
| | |
| * | Extract TimeZoneSelectRafael Mendonça França2012-01-173-34/+22
| | |
| * | Extract GroupedCollectionSelectRafael Mendonça França2012-01-173-24/+43
| | |
| * | Extract CollectionSelectRafael Mendonça França2012-01-175-51/+64
| | |
| * | Extract SelectRafael Mendonça França2012-01-173-18/+59
| | |
| * | Remove unused codeRafael Mendonça França2012-01-171-31/+0
| | |
| * | Extract RangeFieldRafael Mendonça França2012-01-173-11/+10
| | |
| * | Extract NumberFieldRafael Mendonça França2012-01-173-1/+21
| | |
| * | Extract EmailFieldRafael Mendonça França2012-01-173-1/+10
| | |
| * | Extract UrlFieldRafael Mendonça França2012-01-173-1/+10
| | |
| * | Extract TelFieldRafael Mendonça França2012-01-173-1/+10
| | |
| * | Extract SearchFieldRafael Mendonça França2012-01-173-14/+26
| | |
| * | Remove code duplication between CheckBox ans RadioButtonRafael Mendonça França2012-01-173-19/+14
| | |
| * | Extract RadioButtonRafael Mendonça França2012-01-175-25/+41
| | |
| * | Extract CheckBoxRafael Mendonça França2012-01-173-40/+62
| | |
| * | Extract TextAreaRafael Mendonça França2012-01-173-13/+22
| | |
| * | Extract FileFieldRafael Mendonça França2012-01-174-3/+16
| | |
| * | Extract HiddenFieldRafael Mendonça França2012-01-173-1/+14
| | |
| * | Extract PasswordFieldRafael Mendonça França2012-01-174-5/+24
| | |
| * | Rename classesRafael Mendonça França2012-01-175-8/+8
| | |
| * | Extract duplicated code to a classRafael Mendonça França2012-01-174-186/+116
| | |
| * | Extract TextFieldTagRafael Mendonça França2012-01-173-2/+117
| | |
| * | Extract LabelTagRafael Mendonça França2012-01-173-54/+156
| | |
* | | Bring back rendering templates that start with / in nested structuresCarlos Antonio da Silva2012-01-171-0/+1
| | |
* | | Move render_to_body logic to return a spaced string to AC::RenderingCarlos Antonio da Silva2012-01-171-2/+0
|/ / | | | | | | | | | | | | | | | | | | | | This seems to be required only when calling render :partial with an empty collection from a controller. This call happens to return no content, letting the response body empty, which means to Rails that it should go on and try to find a template to render based on the current action name, thus failing hard. Although tests keep all green, we need to check a better way to fix this.
* | remove unused private methodsSergey Nartimov2012-01-131-16/+0
| |
* | use Rack::Utils.escape_pathSergey Nartimov2012-01-131-1/+1
| |
* | Merge pull request #4434 from carlosantoniodasilva/action-view-refactorJosé Valim2012-01-134-34/+41
|\ \ | | | | | | Action view refactor
| * | Refactor url_for helper to check for nil in the case statement onlyCarlos Antonio da Silva2012-01-121-8/+8
| | |
| * | Delegate data tag option to tag option for escapingCarlos Antonio da Silva2012-01-121-5/+6
| | |
| * | Remove value argument from boolean optionCarlos Antonio da Silva2012-01-121-2/+2
| | |
| * | Return faster when no option is givenCarlos Antonio da Silva2012-01-121-12/+11
| | |
| * | Refactor and improve readabilityCarlos Antonio da Silva2012-01-121-8/+7
| | |